Re: [AppDB] Problem with xinha, compile_update_string() and query_parameters()

2006-07-03 Thread Tony Lambregts
Chris Morgan wrote: Here is a patch that does all instances and removes compile_update_string() as well. Chris This is great. -- Tony Lambregts

Re: [AppDB] Problem with xinha, compile_update_string() and query_parameters()

2006-07-03 Thread Chris Morgan
Here is a patch that does all instances and removes compile_update_string() as well. Chris On Monday 03 July 2006 10:52 pm, Tony Lambregts wrote: > Chris Morgan wrote: > > We'll want to remove ALL uses of compile_update_string() and > > compile_insert_string(). I'll take care of this since th

Re: [AppDB] Problem with xinha, compile_update_string() and query_parameters()

2006-07-03 Thread Tony Lambregts
Chris Morgan wrote: We'll want to remove ALL uses of compile_update_string() and compile_insert_string(). I'll take care of this since there are 9 or 10 other instances of it. Yes we will have to I did some experimenting and any field that has a & in it will bomb out not just xinha fields

Re: Workaround a GNOME bug when it doesn't respect window's full screen state

2006-07-03 Thread Dmitry Timoshkov
"Joseph Garvin" <[EMAIL PROTECTED]> wrote: this patch makes GNOME dock disappear when a window enters full screen state. But GNOME top panel still remains on top, don't know yet how to workaround it. Shouldn't a bug be submitted with Gnome instead? Makes sense as a Crossover patch but not as

Re: [AppDB] Problem with xinha, compile_update_string() and query_parameters()

2006-07-03 Thread Chris Morgan
We'll want to remove ALL uses of compile_update_string() and compile_insert_string(). I'll take care of this since there are 9 or 10 other instances of it. Chris On Sunday 02 July 2006 5:08 pm, Tony Lambregts wrote: > Chris Morgan wrote: > > Is this the case when inserting data from a xinha e

Re: wine-1.0 goal: fix all reported msi and ole bugs?

2006-07-03 Thread Dan Kegel
On 6/22/06, James Hawkins <[EMAIL PROTECTED]> wrote: On 6/22/06, Dan Kegel <[EMAIL PROTECTED]> wrote: > I just looked, and there aren't *that* many msi and ole bugs > reported in bugzilla. > > Would it be unreasonable to set a goal of having > all msi and ole bugs fixed for wine-1.0 ? Just to cl

Re: devenum: Cleanup the formatting of register_clsids to match 4-space indention of the rest of the file

2006-07-03 Thread James Hawkins
On 7/3/06, James Hawkins <[EMAIL PROTECTED]> wrote: Changelog: * Cleanup the formatting of register_clsids to match 4-space indention of the rest of the file. * Initialize hkeys to avoid calling RegCloseKey on an uninitialized value. Ignore this patch, it doesn't even compile :-\ -- James Ha

Re: Have to install mozilla by hand to use builtin iexplore?

2006-07-03 Thread Dan Kegel
On 7/3/06, Brian Vincent <[EMAIL PROTECTED]> wrote: > Isn't wine supposed to install mozilla by itself, or something? Based on this patch: http://www.winehq.org/pipermail/wine-patches/attachments/20060630/e66603b1/0d89f0ee8b53f7c54a07bd81c5b7f2ea56f64eeb.diff I'd say your registry hadn't been p

Re: Have to install mozilla by hand to use builtin iexplore?

2006-07-03 Thread Brian Vincent
On 7/3/06, Dan Kegel <[EMAIL PROTECTED]> wrote: Isn't wine supposed to install mozilla by itself, or something? Based on this patch: http://www.winehq.org/pipermail/wine-patches/attachments/20060630/e66603b1/0d89f0ee8b53f7c54a07bd81c5b7f2ea56f64eeb.diff I'd say your registry hadn't been proper

Have to install mozilla by hand to use builtin iexplore?

2006-07-03 Thread Dan Kegel
I saw the iexplore patches go in on wine-cvs, so I refreshed my source tree just now with git and tried rm -rf ~/.wine iexplore http://google.com but I got Could not load Mozilla. HTML rendering will be disabled. To get it to work, I had to manually do wget http://ftp-mozilla.netscape.com/pub/

Re: Strange behavior in debugging of bug #5245, looking for comments

2006-07-03 Thread Louis Lenders
Alex Villací­s Lasso palosanto.com> writes: > > Robert Shearman wrote: > > Alex Villací­s Lasso wrote: > > > >> Last weekend, I was trying to trace down bug #5245 (Run-Time error > >> '6' overflow in terragen). With current CVS, the bug manifests itself > >> with an "Overflow" dialog when star

Re: Strange behavior in debugging of bug #5245, looking for comments

2006-07-03 Thread Alex Villací­s Lasso
Robert Shearman wrote: Alex Villací­s Lasso wrote: Last weekend, I was trying to trace down bug #5245 (Run-Time error '6' overflow in terragen). With current CVS, the bug manifests itself with an "Overflow" dialog when starting up Terragen. However, this bug does *not* go away with a native o

Re: Strange behavior in debugging of bug #5245, looking for comments

2006-07-03 Thread Robert Shearman
Alex Villací­s Lasso wrote: Last weekend, I was trying to trace down bug #5245 (Run-Time error '6' overflow in terragen). With current CVS, the bug manifests itself with an "Overflow" dialog when starting up Terragen. However, this bug does *not* go away with a native oleaut32.dll (taken from

Re: msiexec: msiexec also supports options using a hyphen [RESEND]

2006-07-03 Thread James Hawkins
On 7/3/06, James Hawkins <[EMAIL PROTECTED]> wrote: Hi, Is there anything wrong with this patch? I'll answer my own question :) The version I'm replacing used msi_strprefix and msi_strequal which ignore case, and I've replaced those with direct comparisons to chars, but only the lowercase.

Strange behavior in debugging of bug #5245, looking for comments

2006-07-03 Thread Alex Villací­s Lasso
Last weekend, I was trying to trace down bug #5245 (Run-Time error '6' overflow in terragen). With current CVS, the bug manifests itself with an "Overflow" dialog when starting up Terragen. However, this bug does *not* go away with a native oleaut32.dll (taken from win98), so this does not seem

Re: Workaround a GNOME bug when it doesn't respect window's full screen state

2006-07-03 Thread Joseph Garvin
Dmitry Timoshkov wrote: > Hello, > > this patch makes GNOME dock disappear when a window enters full screen state. > But GNOME top panel still remains on top, don't know yet how to workaround it. > Shouldn't a bug be submitted with Gnome instead? Makes sense as a Crossover patch but not as a win

Re: [Bug 5594] Unhandled page fault at startup with the game "Oddworld, Abe's Exoddus"

2006-07-03 Thread Dejan Velimirovic
> I should not need 'no-cd' because the "Play" CD is in my PC. It doesn't matter, if wine don't support it's protection method it will not work without no-cd. pgpsIrjg3aH8E.pgp Description: PGP signature

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-07-03 Thread Kuba Ober
> >PS: PLEASE PLEASE PLEASE ADD YOU COMMENTS BELOW THIS LINE NOT ABOVE. IT'S > >IMPOSSIBLE TO READ. > > By default microsoft outlook, hotmail, all add their replies above the > previous message. It's the way 90% of the email I see works. Just because billions of flies eat sh*t every day, so should

Re: mapi32: Write-strings warnings fix

2006-07-03 Thread Andrew Talbot
I shall constify subject and body. BTW, the initialisation of address in MAPISendMail() is also a write-strings violation. But it appears that it is redirected before any use. So I shall remove its initialisation, too. Thanks, -- Andy.

Re: [Bug 5592] Fifa06 Demo closes directly after starting

2006-07-03 Thread Dejan Velimirovic
Are you using real windows drive, instead of virtual windows drive by any chance? It's not recommended to do that. pgpXxLV86qxa1.pgp Description: PGP signature

Re: mapi32: Write-strings warnings fix

2006-07-03 Thread Alexandre Julliard
Andrew Talbot <[EMAIL PROTECTED]> writes: > Alexandre Julliard wrote: > >> These are not part of a Win32 API structure, there's no reason they >> can't be made const. >> > Great. I shall submit a patch to declare all the string elements of > Wine's MapiMessage type as LPCSTR. No, MapiMessage is

Re: mapi32: Write-strings warnings fix

2006-07-03 Thread Andrew Talbot
Alexandre Julliard wrote: > Andrew Talbot <[EMAIL PROTECTED]> writes: > >> @@ -113,8 +114,8 @@ >> } >> if (message->nFileCount) FIXME("Ignoring attachments\n"); >> >> -subject = message->lpszSubject ? message->lpszSubject : ""; >> -body = message->lpszNoteText ? message->lpszN

Re: Slow EULA display patch

2006-07-03 Thread Troy Rollo
On Saturday 01 July 2006 15:59, Krzysztof Foltman wrote: > Well, *great* to see that solved in the Wine core, but I still think I > have a bug in RichEdit, because the original (native) riched20 works > fast, despite the bug you just fixed. All that means is that the native rich edit control doesn

Re: [Bug 5592] New: Fifa06 Demo closes directly after starting

2006-07-03 Thread Dejan Velimirovic
Does it output something in terminal? I think it's caused by some copyprotection. pgpkS5q7a2x8Z.pgp Description: PGP signature

Re: Semantics, shaders, and fixups

2006-07-03 Thread Ivan Gyurdiev
H. Verbeet wrote: On 03/07/06, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: That's not particularly important. Well, it breaks color fixups :-) ...color fixups will go in their own function that does this differently for 8 vs 9 BOOL vshader_input_is_color( IWineD3DVertexShader* iface, unsi

Re: Semantics, shaders, and fixups

2006-07-03 Thread H. Verbeet
On 03/07/06, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: That's not particularly important. Well, it breaks color fixups :-) Something that has texcoord semantics doesn't necessarily have to contain texture coordinates, but it should contain something that has the same semantics. > But perhaps if

Re: Win64 patch 1/5 (configure)

2006-07-03 Thread Alexandre Julliard
"Ge van Geldorp" <[EMAIL PROTECTED]> writes: > The standard load address for 64-bit PE executables is the same as for > 32-bit, 0x40. This is also the standard load address for 64-bit ELF > executables. If the Wine loader is not relocated, it won't be able to load > the majority of PE executab

Re: Semantics, shaders, and fixups

2006-07-03 Thread Ivan Gyurdiev
H. Verbeet wrote: On 03/07/06, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: > Well, it is wrong. How is it wrong? In one case you have a semantic, and you use that to load up the correct register (query shader, shader gives you the index to load). In the other case you preinitialize the semantics wi

Re: Semantics, shaders, and fixups

2006-07-03 Thread H. Verbeet
On 03/07/06, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: > Well, it is wrong. How is it wrong? In one case you have a semantic, and you use that to load up the correct register (query shader, shader gives you the index to load). In the other case you preinitialize the semantics with the declaration

Re: Semantics, shaders, and fixups

2006-07-03 Thread Ivan Gyurdiev
H. Verbeet wrote: On 03/07/06, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: >>> and I just made it work today, >>> by storing a fake semantic for d3d8 shaders. By the way, I am still keeping that fake semantic around - it is useful - it allows me to have a single code path for loading arrays, instea

Re: Semantics, shaders, and fixups

2006-07-03 Thread H. Verbeet
On 03/07/06, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: >>> and I just made it work today, >>> by storing a fake semantic for d3d8 shaders. By the way, I am still keeping that fake semantic around - it is useful - it allows me to have a single code path for loading arrays, instead of the two we cur

Re: Semantics, shaders, and fixups

2006-07-03 Thread H. Verbeet
On 03/07/06, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: So, are the names in the D3DVSD_REGISTER enumeration meaningless? From the shader's point of view, yes. Why is D3DVSDE_POSITION called that way? IIRC the names somehow correspond to the way inputs are mapped for fixed function, but I'm not

RE: Win64 patch 1/5 (configure)

2006-07-03 Thread Ge van Geldorp
> From: Alexandre Julliard [mailto:[EMAIL PROTECTED] > > > Changelog: > > Ge van Geldorp <[EMAIL PROTECTED]> > > - Allow relocation on x86_64 > > Is that really needed for Win64? And if so, shouldn't it use > a more appropriate address? The standard load address for 64-bit PE executables

Re: Semantics, shaders, and fixups

2006-07-03 Thread Ivan Gyurdiev
and I just made it work today, by storing a fake semantic for d3d8 shaders. By the way, I am still keeping that fake semantic around - it is useful - it allows me to have a single code path for loading arrays, instead of the two we currently have, which is a mess..

Re: Semantics, shaders, and fixups

2006-07-03 Thread Ivan Gyurdiev
H. Verbeet wrote: On 03/07/06, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: Demo #2: Many Per Pixel Lights, http://www.zanir.szm.sk/dx/017_Many_Per_Pixel_Lights.zip This is a d3d8 demo. The shader inputs are not marked with a semantic - the declaration data is mapped 1:1 to the shader inputs, so a s

Re: Semantics, shaders, and fixups

2006-07-03 Thread H. Verbeet
On 03/07/06, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: Demo #2: Many Per Pixel Lights, http://www.zanir.szm.sk/dx/017_Many_Per_Pixel_Lights.zip This is a d3d8 demo. The shader inputs are not marked with a semantic - the declaration data is mapped 1:1 to the shader inputs, so a specific register nu

Re: [setupapi] fix return values and GUID string in SetupDiOpenClassRegKeyExW

2006-07-03 Thread Damjan Jovanovic
--- Joris Huizer <[EMAIL PROTECTED]> wrote: > Damjan Jovanovic wrote: > > +guidStringWithBraces[0] = (WCHAR) '{'; > > +CopyMemory(&guidStringWithBraces[1], > lpGuidString, > > +(MAX_GUID_STRING_LEN - 3)*sizeof(WCHAR)); > > +guidStringWithBraces[MAX_GUID_STRING_LEN - 2] > = (W

Re: Slow EULA display patch

2006-07-03 Thread Alexandre Julliard
Daniel Steven Hipschman <[EMAIL PROTECTED]> writes: > ChangeLog: > * Sped up GetTextExtentExPointW by adding a new freetype GDI font function > WineEngGetTextExtentExPoint and a new DC function pGetTextExtentExPoint. Looks good, but you should remove the non-Ex entry points in freetype.c and th

Re: Win64 patch 1/5 (configure)

2006-07-03 Thread Alexandre Julliard
Ge van Geldorp <[EMAIL PROTECTED]> writes: > Changelog: > Ge van Geldorp <[EMAIL PROTECTED]> > - Allow relocation on x86_64 Is that really needed for Win64? And if so, shouldn't it use a more appropriate address? -- Alexandre Julliard [EMAIL PROTECTED]

Re: mapi32: Write-strings warnings fix

2006-07-03 Thread Alexandre Julliard
Andrew Talbot <[EMAIL PROTECTED]> writes: > @@ -113,8 +114,8 @@ > } > if (message->nFileCount) FIXME("Ignoring attachments\n"); > > -subject = message->lpszSubject ? message->lpszSubject : ""; > -body = message->lpszNoteText ? message->lpszNoteText : ""; > +subject = messag

Semantics, shaders, and fixups

2006-07-03 Thread Ivan Gyurdiev
Hi, Here's another problem with shaders. Vertex shader input is marked up with tags that hint at the data usage - semantics. For the fixed pipeline, those tags must be 100% correct, because they tell the pipeline how to interpret the data - is that the position stream, or the color stream, or

Re: Link or rename wcmd.exe to cmd.exe?

2006-07-03 Thread James Hawkins
On 7/3/06, Chris <[EMAIL PROTECTED]> wrote: On Monday 03 July 2006 01:46, you wrote: > What's wrong with wineconsole? wineconsole by itself doesn't seem to do anything, and using --help didn't work (and there seems to be no man page). Running 'wineconsole wcmd.exe' started a command prompt in th

Re: Link or rename wcmd.exe to cmd.exe?

2006-07-03 Thread Chris
On Monday 03 July 2006 01:46, you wrote: > What's wrong with wineconsole? wineconsole by itself doesn't seem to do anything, and using --help didn't work (and there seems to be no man page). Running 'wineconsole wcmd.exe' started a command prompt in the activating terminal just like wcmd.exe no

Re: Link or rename wcmd.exe to cmd.exe?

2006-07-03 Thread James Hawkins
On 7/3/06, Chris <[EMAIL PROTECTED]> wrote: On Sunday 02 July 2006 23:58, you wrote: > The case I care about most is: > in cron, or ssh'ing in without X forwarding, use wcmd.exe to run a batch > file. > > We need to be able to support both cases. How about leaving wcmd.exe alone (or renaming it

Re: [setupapi] fix return values and GUID string in SetupDiOpenClassRegKeyExW

2006-07-03 Thread Joris Huizer
Damjan Jovanovic wrote: +guidStringWithBraces[0] = (WCHAR) '{'; +CopyMemory(&guidStringWithBraces[1], lpGuidString, +(MAX_GUID_STRING_LEN - 3)*sizeof(WCHAR)); +guidStringWithBraces[MAX_GUID_STRING_LEN - 2] = (WCHAR) '}'; +guidStringWithBraces[MAX_GUID_STRING_LEN - 1] = 0;

Re: RESEND: enhmetafile: Read and write support for little-endian EMFs on big-endian machines

2006-07-03 Thread Phil Krylov
Hi, Is anything wrong with that patch? On 25/06/06, Phil Krylov <[EMAIL PROTECTED]> wrote: Hi, This version has no ugly macros and adds read support. Diffed against current CVS. ChangeLog: enhmetafile: Read and write support for little-endian EMFs on big-endian machines. -- Ph.

Re: Link or rename wcmd.exe to cmd.exe?

2006-07-03 Thread Chris
On Sunday 02 July 2006 23:58, you wrote: > The case I care about most is: > in cron, or ssh'ing in without X forwarding, use wcmd.exe to run a batch > file. > > We need to be able to support both cases. How about leaving wcmd.exe alone (or renaming it to winecmd.exe), and wait on making cmd.exe u

Re: Link or rename wcmd.exe to cmd.exe?

2006-07-03 Thread Dan Kegel
[wcmd needs to start a window.] Have you ever seen this be a problem in the real world? Yes. Start Progman, or some ther "shell" application, without an xterm (eg. through your WM or by running wine progman.exe &), then attempt to execute wcmd.exe (a standard operation I'd think, if you want to