Re: Slow EULA display patch

Daniel Steven Hipschman wrote: This patch fixes the slow EULA loading problem in http://bugs.winehq.org/show_bug.cgi?id=5516 Well, *great* to see that solved in the Wine core, but I still think I have a bug in RichEdit, because the original (native) riched20 works fast, despite the bug you j

Re: riched20: corrected EM_GETLINE and wrong hWnd patches (combined into one)

On 6/30/06, James Hawkins <[EMAIL PROTECTED]> wrote: On 6/30/06, Krzysztof Foltman <[EMAIL PROTECTED]> wrote: > > So, the current plan is to: > - See if the "new Thomas patch" gets accepted during the nearest 2 weeks > - If yes, rewrite the 1.0 fix and it send separately - it's totally > incompat

Re: riched20: corrected EM_GETLINE and wrong hWnd patches (combined into one)

On 6/30/06, Krzysztof Foltman <[EMAIL PROTECTED]> wrote: So, the current plan is to: - See if the "new Thomas patch" gets accepted during the nearest 2 weeks - If yes, rewrite the 1.0 fix and it send separately - it's totally incompatible with that patch - If not, resubmit the EM_GETLINE stuff,

Link or rename wcmd.exe to cmd.exe?

I'd like to restart this old thread which brings up the point that there are applications that hard-code cmd.exe and (sometimes intentionally) ignore COMSPEC. One example is Perl, which has the following comment in win32/win32.c:

Re: riched20: corrected EM_GETLINE and wrong hWnd patches (combined into one)

James Hawkins wrote: this problem. The previous version you sent in did have his name, which is perfectly legit, but this version doesn't. You can either add his name as well as yours to the changelog, or ask him to resend the tests separately. So, the current plan is to: - See if the "new T

Re: riched20: corrected EM_GETLINE and wrong hWnd patches (combined into one)

On 6/30/06, Krzysztof Foltman <[EMAIL PROTECTED]> wrote: James Hawkins wrote: > I've just looked at this patch and the previous patch Thomas sent in, > and saying that this is roughly based on his patch is putting it > lightly. > missing feature, but either way, he deserves credit for the code

Re: riched20: corrected EM_GETLINE and wrong hWnd patches (combined into one)

James Hawkins wrote: I've just looked at this patch and the previous patch Thomas sent in, and saying that this is roughly based on his patch is putting it lightly. The EM_GETLINE code is completely changed (I haven't even seen his "new" implementation - http://www.winehq.org/pipermail/wine-

Re: [TOOLS] Re: Gecko installer

Jeremy Newman wrote: This is now live at: http://source.winehq.org/winegecko.php On Sun, 2006-06-25 at 11:40 +0200, Jonathan Ernst wrote: Le samedi 24 juin 2006 à 20:06 +0200, Jacek Caban a écrit : Hi, [...] - We need php script redirecting to SourceForge similar to one t

Re: [PATCH 10/11] server: add calls to get/set menu item info

On 30/06/06, Thomas Kho <[EMAIL PROTECTED]> wrote: I'm not 100% clear what the problem is. My interpretation of your first email was that there was a necessary distinction in type between user/gdi handles as stored in the server, but now my understanding is that you're concerned gdi objects in ME

Re: riched20: corrected EM_GETLINE and wrong hWnd patches (combined into one)

On 6/30/06, Krzysztof Foltman <[EMAIL PROTECTED]> wrote: ChangeLog: * EM_GETLINE support (roughly based on code by Thomas Kho, although there are important changes, for example, it works correctly in RichEdit 1.0 emulation mode) (bug #4305) * Workaround for wrong window handles (bug# 4452)

Re: winspool.drv: Write-strings warnings fix

Andrew Talbot wrote: > Changelog: > winspool.drv: Write-strings warnings fix. The touched parts should call the UNICODE-Functions instead of the ANSI-Functions. That's on my ToDo-List, but after the Port-Functions are fixed. Many tests for the affected Functions also needs to come before the

Re: [PATCH 10/11] server: add calls to get/set menu item info

On 6/30/06, Robert Shearman <[EMAIL PROTECTED]> wrote: Thomas Kho wrote: > On 6/30/06, Robert Shearman <[EMAIL PROTECTED]> wrote: > >> Thomas, can you regenerate this patch using "void *" for bmpitem (or >> perhaps add a new gdi_handle_t type)? > > > I'll add the gdi_handle_t type and resubmit t

Re: mapi32: Replace CRITICAL_SECTION by RTL_CRITICAL_SECTION.

Hervé Poussineau wrote: Replace CRITICAL_SECTION by RTL_CRITICAL_SECTION, according to prototype of RtlEnterCriticalSection and others. It would be better to fix the file to use the kernel32 critical section functions instead of the ntdll ones. -- Rob Shearman

Re: [PATCH 10/11] server: add calls to get/set menu item info

Thomas Kho wrote: On 6/30/06, Robert Shearman <[EMAIL PROTECTED]> wrote: Thomas, can you regenerate this patch using "void *" for bmpitem (or perhaps add a new gdi_handle_t type)? I'll add the gdi_handle_t type and resubmit two patches (I caught another use in the menu struct). As others

Re: [PATCH 10/11] server: add calls to get/set menu item info

On 6/30/06, Robert Shearman <[EMAIL PROTECTED]> wrote: Thomas, can you regenerate this patch using "void *" for bmpitem (or perhaps add a new gdi_handle_t type)? I'll add the gdi_handle_t type and resubmit two patches (I caught another use in the menu struct). Tommy

Re: [AppDb] [Resend] prefix all GPC variables

There are several issues that I've found so far in this patch. It appears that you used a search and replace. You'll need to go through EVERY line of the patch and undo the changes to things like sql queries and others where the changes don't make sense. At some point we can discuss altering t

Re: [AppDb] appsubmit fix

Yeah, lets pass the parameters into this function so we can move it around and reuse it without needing a global. Chris On Friday 30 June 2006 7:24 am, Jonathan Ernst wrote: > Le jeudi 29 juin 2006 à 12:19 -0400, Chris Morgan a écrit : > > Can we pass the parameters we need into the function in

Re: Call for volunteer: dwarf2 testing

Eric Pouech wrote: As you may have seen, there's now some support for the dwarf2 debug format (instead of stabs) in the Wine tree I'd like to get some feedback on the overall feedback on how it behaves. To do so, you need to reconfigure Wine with something like CFLAGS="$CFLAGS -gdwarf-2" ./confi

Re: Wine 0.9.16 and ddraw issues

On Fri, Jun 30, 2006 at 05:11:24PM +0200, Alexander Nicolaysen Sørnes wrote: > ... > fixme:d3d:IWineD3DStateBlockImpl_Release Releasing primary stateblock > ... > fixme:d3d:IWineD3DStateBlockImpl_Release Releasing primary stateblock this are also the last words of Planescape Torment when startin

Wine 0.9.16 and ddraw issues

Greetings, I maintain several ddraw apps in the Application Database. While most of the problems introduced by Wine 0.9.16 have been fixed, some still remain. Command & Conquer and C&C: Red Alert When exiting the game, a messagebox displays: 'Unregonized Direct Draw result code: 1' A demo of R

Re: [PATCH 10/11] server: add calls to get/set menu item info

"Robert Shearman" <[EMAIL PROTECTED]> wrote: You can pass HBITMAPs between processes on Windows, although you are correct in saying that they aren't user handles. Of course, passing bitmap handles between processes on Wine won't work yet. Feng Yuan's book claims that while GDI handles are ker

Re: Debugging string comparison problem

> I think the bug is here. Using SysAllocString instead of > SysAllocStringLen I get: > > VarBstrCmp returns 1 > CompareStringW returns 2 Using SysAllocString, I get that the length of each string is 0. So yeah, they'd be equal. So, I'm back to where I started: in Windows, these are different c

Re: Debugging string comparison problem

Juan Lang wrote: You missed the two collation_table lookups. You're right, I did miss that. Note that on Windows using CompareString on L"\0001\0002" and L"\0002\0001" gives a result of CSTR_EQUAL, so I don't think the bug is in the collation tables. Really? For which locale

Re: Debugging string comparison problem

> You missed the two collation_table lookups. You're right, I did miss that. > Note that on Windows using CompareString on L"\0001\0002" and > L"\0002\0001" gives a result of CSTR_EQUAL, so I don't think the bug is > in the collation tables. Really? For which locale, and which version of Wind

Re: [PATCH 10/11] server: add calls to get/set menu item info

On 30/06/06, Robert Shearman <[EMAIL PROTECTED]> wrote: You can pass HBITMAPs between processes on Windows, Is there anything special you need to do to it for that to work? It doesn't seem to work very well for me, and any documentation I can find basically says that while GDI handles are unique

Using firefox with ietab extension

Hi, anybody tried this already? I wanted to use Firefox 1.5.4 together with the ietab extension for some specific sites (Outlook Web Access). I don't want to install the Mozilla ActiveX plugin but instead us our internal stuff, but wasn't able yet to get this going. Installation of firefox and

Re: wine autorun utility

On 6/30/06, William Knop <[EMAIL PROTECTED]> wrote: Parsing a windows inf hardly belongs anywhere but wine. Actually, Troy makes that point rather well in an earlier mail: This is not true. The existing action-on-CD-insertion programs provided by the desktop environment try to detect the co

Re: DDRAW: Releasing attached surfaces

On Thu, Jun 29, 2006 at 04:43:04PM +0200, Krzysztof Benkowski wrote: > --- surface.c 26 Jun 2006 12:15:20 - 1.6 > +++ surface.c 29 Jun 2006 14:09:59 - > @@ -377,7 +377,7 @@ IDirectDrawSurfaceImpl_Release(IDirectDr > while( (surf = This->next_complex) ) > { >

Re: [AppDb] appsubmit fix

Le jeudi 29 juin 2006 à 12:19 -0400, Chris Morgan a écrit : > Can we pass the parameters we need into the function instead of using a > global? I don't think it is better. If we just pass it it'll make a copy of the array. We could also use &$aClean but I don't see why it would be better too.

Re: advapi32: Implement RegisterServiceCtrlHandleExW.

Andrey Turkin wrote: Robert Shearman wrote: @@ -603,10 +608,18 @@ static BOOL service_handle_control(HANDL TRACE("received control %ld\n", dwControl); -if (service_accepts_control(service, dwControl) && service->handler) +if (service_accepts_control(service, dwControl))

Re: advapi32: Implement RegisterServiceCtrlHandleExW.

Robert Shearman wrote: > --- ... > @@ -603,10 +608,18 @@ static BOOL service_handle_control(HANDL > > TRACE("received control %ld\n", dwControl); > > -if (service_accepts_control(service, dwControl) && service->handler) > +if (service_accepts_control(service, dwControl)) >

Re: [PATCH 10/11] server: add calls to get/set menu item info

H. Verbeet wrote: On 29/06/06, Thomas Kho <[EMAIL PROTECTED]> wrote: [EMAIL PROTECTED](get_menu_item_info) +user_handle_t handle; +unsigned int pos; [EMAIL PROTECTED] +unsigned int required_size; + +unsigned int type; +unsigned int state; +unsigned int id; +use

Re: [Tools/Wine.inf] Set Internet Explorer version

Vitaliy Margolen wrote: Thursday, June 29, 2006, 6:28:11 PM, Olaf Leidinger wrote: On Thu, 29 Jun 2006 10:56:12 -0700 "James Hawkins" <[EMAIL PROTECTED]> wrote: On 6/28/06, Maarten Lankhorst <[EMAIL PROTECTED]> wrote: Should we require that people install Internet Explorer

Re: DDRAW: Releasing attached surfaces

Hi, > That's weird, now it works without the "fix" and even Tiberian Sun > starts where previously it hung. > I must have wrongly assumed that the bug was related to surface > implementation code... > But i'm still curious what might be the cause. Will check that out later. > Sorry for bothering th

Re: wine autorun utility

Forgive my lazyness and my bad english, but IMHO most of discussion resembles MS Corporation behaviour by trying to decide what is good for a user, and what is not. Hey, just let the user or his admin to decide this. IMO there should be just one checkbox in winecfg that rules autorunability.

Re: wine autorun utility

On 6/30/06, William Knop <[EMAIL PROTECTED]> wrote: Parsing a windows inf hardly belongs anywhere but wine. Actually, Troy makes that point rather well in an earlier mail: This is not true. The existing action-on-CD-insertion programs provided by the desktop environment try to detect the cont