wine and serial port - again

2006-06-27 Thread Pavel Troller
Hi! From time to time, complaints can be heard about functionality of the serial port implementation in wine. Just now I have one of examples of the serial communication problem. There is a very simple program, called ft or softjump, intended to dump or modify some particular addresses of an EE

Re: [Dlls/Cryptnet] Implement a stub cryptnet

2006-06-27 Thread Dmitry Timoshkov
+ case DLL_PROCESS_ATTACH: + ghInst = NULL; + break; You meant to make it 'ghInst = hinstDLL;', right? I'd suggest to get rid of ghInst altogether until there is a real need for it. And please add a DisableThreadLibraryCalls( hinstDLL ); call. -- Dmitry.

Re: [Dlls/Cryptnet] Implement a stub cryptnet

2006-06-27 Thread Dmitry Timoshkov
"Maarten Lankhorst" <[EMAIL PROTECTED]> wrote: +static HINSTANCE ghInst = NULL; + +BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) +{ + TRACE("(0x%p, %ld, %p)\n", hinstDLL, fdwReason, lpvReserved); + + switch (fdwReason) { + case DLL_WINE_PREATTACH: +

Re: mswsock.dll: TranmitFile - new way [1/2]

2006-06-27 Thread Juan Lang
Hi Lukazs, I'm afraid this still isn't ready for inclusion: diff -u -r1.3 Makefile.in --- dlls/mswsock/Makefile.in9 May 2005 14:42:33 - 1.3 +++ dlls/mswsock/Makefile.in27 Jun 2006 23:13:09 - @@ -4,13 +4,16 @@ VPATH = @srcdir@ MODULE= mswsock.dll IMPORTLIB = libmsws

Re: Wine developers?

2006-06-27 Thread Troy Rollo
On Wednesday 28 June 2006 02:11, Mike Hearn wrote: > On Mon, 26 Jun 2006 08:27:10 +1000, Troy Rollo wrote: > > On Friday 23 June 2006 22:50, Mike Hearn wrote: > >> careful, none of us are lawyers here. > > > > That's not entirely true. > > We have IP lawyers on wine-devel? Can you say who? I'm a n

Re: Wine, Darwine, CodeWeavers-- Intel MacOS X

2006-06-27 Thread Mike Hearn
On 6/27/06, Steven Edwards <[EMAIL PROTECTED]> wrote: I don't think they are wrong about feeling that the site just seems to totally ignore OS X. I guess the FreeBSD and Solaris guys feel the same way reading over recent discussions. Alexandre does not treat patches from anyone as a second class

Re: [AppDB] Make screen shots safe from SQL injection

2006-06-27 Thread Tony Lambregts
Chris Morgan wrote: As we've discussed before I'd rather we did a single full pass of manual testing than several full passes. It saves us time in that we don't have to test the same things repeatedly like we would have to do when making changes to things like classes that are used all over the

Re: Wine, Darwine, CodeWeavers-- Intel MacOS X

2006-06-27 Thread Steven Edwards
Hi Mike, On 6/27/06, Mike Hearn <[EMAIL PROTECTED]> wrote: I think your email was OK, but wine-devel gets a constant stream of Mac users/developers telling us how many Mac users want Wine, how they would be a big benefit to the project, how Apple-land is a land of milk and honey etc ... whereas

Re: msvcrt/tests: Don't leave files on the disk

2006-06-27 Thread Ivan Leo Puoti
Andreas Mohr wrote: Hi, On Tue, Jun 27, 2006 at 04:05:14PM +0100, [EMAIL PROTECTED] wrote: ChangeLog: Don't leave files on the user's hdd Don't you think that a rm -rf / would be more efficient? ;) Unfortunately the tests are for windows, but I guess format c: would do too :-D Ivan.

Re: winbase.h: Add a few casts

2006-06-27 Thread Andrew Talbot
Alexandre Julliard wrote: > Andrew Talbot <[EMAIL PROTECTED]> writes: > >> Changelog: >> winelib: Add a few casts. > > Why do you need them? > Sorry. I confess that I was looking around with Splint, saw that the difference between the returned types of some string functions differed from th

Re: [AppDb] [Resend] errorpage -> show_error_page

2006-06-27 Thread Chris Morgan
Can we put a module prefix on this function so it is easier to locate in the tree? I'm not sure what but it seems like we should try to prefix something that matches the file the function is in. Chris On Monday 26 June 2006 6:18 pm, Jonathan Ernst wrote: > Changelog: > - rename errorpage fun

Re: [AppDB] Make screen shots safe from SQL injection

2006-06-27 Thread Chris Morgan
> > As we've discussed before I'd rather we did a single full pass of manual > > testing than several full passes. It saves us time in that we don't have > > to test the same things repeatedly like we would have to do when making > > changes to things like classes that are used all over the code.

Re: [AppDb] automatic variable cleanup

2006-06-27 Thread Chris Morgan
Wow, thats a pretty neat idea. A few comments. We should do something to the values in $_REQUEST so they can't be used after this function is called. We should error if there are variables that don't fit the format we expect. We can't have anything getting past this filter by default or we'll

Re: Wine developers?

2006-06-27 Thread Mike Hearn
On Mon, 26 Jun 2006 08:27:10 +1000, Troy Rollo wrote: > On Friday 23 June 2006 22:50, Mike Hearn wrote: >> A very specific legal interpretation that would require the >> company behind Thinstall to want to hurt the Wine project be careful, >> none of us are lawyers here. > > That's not entire

Re: Wine, Darwine, CodeWeavers-- Intel MacOS X

2006-06-27 Thread Mike Hearn
On Mon, 26 Jun 2006 04:08:30 -0400, William Knop wrote: > Oh... Sorry about that. I suppose I did come off a bit critical. I think your email was OK, but wine-devel gets a constant stream of Mac users/developers telling us how many Mac users want Wine, how they would be a big benefit to the projec

wineconsole not working (but wine worked for console app)

2006-06-27 Thread Dee Ayy
Dear Wine Developers,I tried to post this anonymously, but it wanted me to create an account:In reply, some what confirmation of http://bugs.winehq.org/show_bug.cgi?id=5082 My comments:While reading the man page for wine, searching for how to run a Win32 exe which needs a native dll, I noticed the

Build on kubuntu 6.06,amd_64 works

2006-06-27 Thread Amaury
Hi, Sorry if I'm ask a stupid question, but I'm a newbie to Linux, trying to learn... I've been trying to install wine through the package manager but it said it was not possible (error message: "Depends: wine-dev but it is not installable"). I kind of knew it cos i'm running under Ubuntu 6.06-LT

New dlls/ddraw/device.c warnings

2006-06-27 Thread Gerald Pfeifer
After the recent sets of changes, I found that GCC 3.4 issues the following warnings (on FreeBSD 5.4. I checked and depending on how a compiler implements assert(), the warnings are valid, insofar as the compiler doesn't have a way to automatically determine that all code paths are covered: de

Debugging string comparison problem

2006-06-27 Thread Juan Lang
I'm trying to figure out why CompareStringA returns CSTR_EQUAL for the strings "\1" and "\2". (See bug 5469, and the todo_wine test case in dlls/kernel/tests/locale.c) CompareStringA does the usual thing, calls MultiByteToWideChar and calls CompareStringW. So CompareStringW is comparing L"\00

Re: msvcrt/tests: Don't leave files on the disk

2006-06-27 Thread Andreas Mohr
Hi, On Tue, Jun 27, 2006 at 04:05:14PM +0100, [EMAIL PROTECTED] wrote: > ChangeLog: Don't leave files on the user's hdd Don't you think that a rm -rf / would be more efficient? ;) (one code line only) Andreas P.S.: Kids, don't try this at home!

Re: [AppDB] Make screen shots safe from SQL injection

2006-06-27 Thread Tony Lambregts
Chris Morgan wrote: On Monday 26 June 2006 11:38 pm, Tony Lambregts wrote: Chris Morgan wrote: Yes, having quotes around limit values breaks sql queries. I'll incorporate this into the injection change patch. I'm curious as to why the rest of the patch is the same though. It will conflict wh

Re: keyboard keypress codepath

2006-06-27 Thread Dmitry Timoshkov
"Saulius Menkevicius" <[EMAIL PROTECTED]> wrote: Now the problem is that I use Lithuanian keyboard layout on my gnome desktop and it doesn't properly "translate" some of the non-latin letters (like 'ąčęėįųū'). When I press one of those MS Word shows 'a/A' instead of 'ą/Ą', 'c/C' instead of 'č/Č'

Re: wined3d: Regression in DX8 SDK samples with VBO patch

2006-06-27 Thread Stefan Dösinger
Am Dienstag 27 Juni 2006 04:08 schrieb Jason Green: > http://source.winehq.org/git/?p=wine.git;a=commit;h=2122026713baa3180931816 >07db79d7577f728e9 > > This patch breaks most of the DirectX 8 SDK Direct3D samples > (Billboard, ClipMirror, Cull, etc.). It seems like most of the > samples that use

Re: WINED3D: Fix compilation (VBO constants)

2006-06-27 Thread H. Verbeet
On 27/06/06, Stefan Dösinger <[EMAIL PROTECTED]> wrote: Am Dienstag 27 Juni 2006 00:32 schrieb H. Verbeet: > This makes wined3d use the VBO constants as defined in > include/wine/wined3d_gl.h Just asking, how do you check for those constant? As the code I sent compiled fine here(with mesa) the wa

Re: wrc: allow quotes around resource ID

2006-06-27 Thread Alexandre Julliard
Juan Lang <[EMAIL PROTECTED]> writes: > Fixes bug 786. > > ChangeLog: allow quotes around resource ID I don't think that's the right fix, Windows doesn't handle this as a string, it simply passes the name through including quotes and all. -- Alexandre Julliard [EMAIL PROTECTED]

Re: riched20: hWnd validity test in window procedure

2006-06-27 Thread Alexandre Julliard
Krzysztof Foltman <[EMAIL PROTECTED]> writes: > ChangeLog: > * Added hWnd validity check to work around buggy apps (bug# 4452) > > This patch is based on Phil Krylov's one, with two differences: it > checks the handle even before trying to call GetWindowLong, and it > checks for invalid window ha

Re: winbase.h: Add a few casts

2006-06-27 Thread Alexandre Julliard
Andrew Talbot <[EMAIL PROTECTED]> writes: > Changelog: > winelib: Add a few casts. Why do you need them? -- Alexandre Julliard [EMAIL PROTECTED]

Re: WINED3D: Fix compilation (VBO constants)

2006-06-27 Thread James Hawkins
On 6/27/06, Stefan Dösinger <[EMAIL PROTECTED]> wrote: Am Dienstag 27 Juni 2006 00:32 schrieb H. Verbeet: > This makes wined3d use the VBO constants as defined in > include/wine/wined3d_gl.h Just asking, how do you check for those constant? As the code I sent compiled fine here(with mesa) the wa

Re: wined3d: Regression in DX8 SDK samples with VBO patch

2006-06-27 Thread Stefan Dösinger
Am Dienstag 27 Juni 2006 04:08 schrieb Jason Green: > http://source.winehq.org/git/?p=wine.git;a=commit;h=2122026713baa3180931816 >07db79d7577f728e9 > > This patch breaks most of the DirectX 8 SDK Direct3D samples > (Billboard, ClipMirror, Cull, etc.). It seems like most of the > samples that use

Re: [AppDb] html cleanup

2006-06-27 Thread Jonathan Ernst
Le mardi 27 juin 2006 à 01:51 -0400, Chris Morgan a écrit : > What is the justification for making this change? I can't find anything on > w3.org that suggests that these values should be lowercase and the > documentation seems to suggest that for the 'type' attribute the values > should all be

Re: WINED3D: Fix compilation (VBO constants)

2006-06-27 Thread Stefan Dösinger
Am Dienstag 27 Juni 2006 00:32 schrieb H. Verbeet: > This makes wined3d use the VBO constants as defined in > include/wine/wined3d_gl.h Just asking, how do you check for those constant? As the code I sent compiled fine here(with mesa) the way I used is to look at the diff if some changes are miss

Re: Patch: winex11drv create_cursor Loading 32bit rgba cursor image

2006-06-27 Thread Louis Lenders
Mike Hearn plan99.net> writes: > > Heya Pauli, > > A review is enclosed. To submit a patch please send it to > the wine-patches list, where it'll enter Alexandres queue for review. > > Firstly I'm kind of surprised this doesn't require the XCursor extension. > Handling the case of a solid alph