Re: WM_GETICON patch

2006-06-10 Thread Chris
I updated the patch a little more to handle WM_QUERYDRAGICON as well (something else that was complained about with GeoShell), since it's dealt with similarly to WM_GETICON (lparam is unused and an HICON is returned in the result). An odd effect now is that apps are showing one of GeoShell's ar

Re: getuname: add stub implementation [try 4]

2006-06-10 Thread Dmitry Timoshkov
"Vitaly Lipatov" <[EMAIL PROTECTED]> wrote: > Just curious, what application besides charmap.exe uses getuname.dll? You are right, I guess it was charmap.exe Is it unuseful dll? If nobody else besides charmap.exe uses that dll then yes, it's not useful for Wine at this point. Since interfaces

Re: Icmp* functions in iphlpapi.dll

2006-06-10 Thread Dmitry Timoshkov
"Simon Kissane" <[EMAIL PROTECTED]> wrote: In Win2000, the ICMP functions exist in icmp.dll In WinXP, they are still there, but they have also been duplicated into iphlpapi.dll How would one go about adding them to iphlpapi? Does one just duplicate all the code in the second DLL, or is there a

Re: Icmp* functions in iphlpapi.dll

2006-06-10 Thread Carl Fongheiser
On 6/10/06, Simon Kissane <[EMAIL PROTECTED]> wrote: Suppose one was to add code to iphlpapi's LibMain which didLoadLibrary & GetProcAddress to get the addresses of the functions inicmp.dll, and then the iphlpapi implementations just called theicmp.dll implementations? (I'm assuming doing a static

WM_GETICON patch

2006-06-10 Thread Chris
Here's a patch I'm trying to make to implement the WM_GETICON message, which programs like GeoShell (a Win32 taskbar replacement) would use to get a taskbar icon for the running processes. I'm not quite sure if it's proper or not, though. Originally GeoShell would show no icon on the taskbar and

Broken FC5 packages - stay clear.

2006-06-10 Thread Vitaliy Margolen
It seems that FC5 packager created a broken Wine distribution. Instead of being 1-3 packages it's 15 (from what user told me on #winehq. And it doesn't work at all: "Application tried to create a window, but no driver could be loaded." Which tells me it's compiled without X headers. I didn't even

msi: sql parsing

2006-06-10 Thread Joris Huizer
Hello, As somebody asked me whether I could try to use MSN Beta 8, I decided to give it a try; The installer quits at some point, caused by an unhandled SQL command "ALTER TABLE `Registry` HOLD" I decided to have a look at this, but I'm not familiar with msi, and my SQL knowledge isn't very bi

Icmp* functions in iphlpapi.dll

2006-06-10 Thread Simon Kissane
Hi In Win2000, the ICMP functions exist in icmp.dll In WinXP, they are still there, but they have also been duplicated into iphlpapi.dll How would one go about adding them to iphlpapi? Does one just duplicate all the code in the second DLL, or is there a way to have some function implemented onc

Re: awwww

2006-06-10 Thread Mike McCormack
Dan Kegel wrote: I forgot to mention: I also consider any installer bug a high priority bug. Installers Should Just Work. Agreed, as the installer blocks any other testing that can be done on an application. That's the reason Jeremy has had CodeWeavers employees working on OLE32 and MSI f

Re: user[3/5]: handle special cases for SPI_SETDESKWALLPAPER

2006-06-10 Thread Andrew Ziem
Thank you for catching that. I missed the part = {'\0'}; Andrey Turkin wrote: I cannot see where emptyW initialized. Andrew Ziem wrote: The special cases remove the wallpaper or set it to default. Previously, these cases were ignored, so Wine would crash. +if (NULL ==

Re: user[3/5]: handle special cases for SPI_SETDESKWALLPAPER

2006-06-10 Thread Andrey Turkin
I cannot see where emptyW initialized. Andrew Ziem wrote: The special cases remove the wallpaper or set it to default. Previously, these cases were ignored, so Wine would crash. +if (NULL == pvParam || SETWALLPAPER_DEFAULT == pvParam) +{ +static const WCHAR empt

Re: user[2/5]: implement A version of SPI_GETDESKWALLPAPER

2006-06-10 Thread Andrey Turkin
Andrew Ziem wrote: Previously, SPI_GETDESKWALLPAPER was handled by default: in the switch, so the function (an A- function) would return a W string. 5e4b86d689c899fc896d2870efaca9c335f01da0 diff --git a/dlls/user/syspara

Re: Recording with "Lexia" (mci "open new")

2006-06-10 Thread Eric Pouech
Peter Åstrand wrote: 1) I believe the mciwave.c patch below makes sense in any case, right? Without it freed memory is used. I don't see why ? wmw->openParms.lpstrElementName and filename is a pointer to the same memory, due to this statement in WAVE_mciOpen: memcpy(&wmw->openPar

Re: winmm: Add support for "open new" commands.

2006-06-10 Thread Eric Pouech
Peter Åstrand wrote: ChangeLog: winmm: Add support for "open new" commands. looks globally good, except that you don't enforce that you got a correct device name ie I'm not sure that 'open new type waveaudio' works (without the alias) A+

Re: awwww

2006-06-10 Thread Jaap Stolk
On 6/10/06, Vitaliy Margolen <[EMAIL PROTECTED]> wrote: How about some newer copy protection systems that Wine could support I was wondering about that. I'm trying to run autocad 2004. (It's more an example to debug wine, I don't really need it) When run, it generates a temporary DLL, which in

Re: DDraw: New ddraw lib

2006-06-10 Thread Jesse Allen
On 6/10/06, Stefan Dösinger <[EMAIL PROTECTED]> wrote: Am Samstag, 10. Juni 2006 01:40 schrieb Jesse Allen: > On 6/9/06, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > > Hi, > > > > > I just want to state, the patch is very helpful when you can't use > > > DGA. I just ran a test with Starcraft in m

Re: appdb security

2006-06-10 Thread EA Durbin
Tobias Burnus wrote: Why don't you use mysql_escape_string(...)? http://de.php.net/manual/en/function.mysql-escape-string.php Why not just use PEAR::DB as recommended in the book "Essential PHP Security", as it handles multiple SQL interfaces and escapes the data automatically for you, app

riched20 bug 4452 fix still not merged?

2006-06-10 Thread Dan Kegel
Hi Matt, can you add http://bugs.winehq.org/show_bug.cgi?id=4452 to your list of riched20 bugs to look at? This one even has a fix, but for some reason the fix hasn't been merged yet. Thanks, Dan

Re: notepad patches (search/replace, etc)

2006-06-10 Thread Marcus Meissner
On Sat, Jun 10, 2006 at 09:52:50AM -0600, Vitaliy Margolen wrote: > Friday, June 9, 2006, 11:49:44 AM, Anoni Moose wrote: > > Let's try again... I apologize for the bad indentation. It's indented fine > > in > > emacs, which I use; however, when I use "diff -u file1 file2", it gives me > > the >

Re: getuname: add stub implementation [try 4]

2006-06-10 Thread Vitaly Lipatov
В сообщении от 10 июня 2006 19:25 Dmitry Timoshkov написал(a): > "Vitaly Lipatov" <[EMAIL PROTECTED]> wrote: > > Add WINE_PREATTACH and correct numer of params for GetUName > > Try4: Export functions by name (@), fix warning in FIXME > > > > Changelog > > add minimal implementation for getuname dll

Re: netapi32: Improve NetUserGetInfo function

2006-06-10 Thread Joris Huizer
Simon Kissane wrote: netapi32: Improve NetUserGetInfo function * Implemented support for all levels documented by MSDN * Corrected error codes for nonexistent levels * Now works with empty string as server name I have also attached a C program (which can be compiled with MINGW), which tests the

Re: notepad patches (search/replace, etc)

2006-06-10 Thread Vitaliy Margolen
Friday, June 9, 2006, 11:49:44 AM, Anoni Moose wrote: > Let's try again... I apologize for the bad indentation. It's indented fine in > emacs, which I use; however, when I use "diff -u file1 file2", it gives me the > entire file as a patch. Therefore, I must use "diff -uwB". Emacs must be > screwi

Re: getuname: add stub implementation [try 4]

2006-06-10 Thread Dmitry Timoshkov
"Vitaly Lipatov" <[EMAIL PROTECTED]> wrote: Add WINE_PREATTACH and correct numer of params for GetUName Try4: Export functions by name (@), fix warning in FIXME Changelog add minimal implementation for getuname dll and GetUName function Just curious, what application besides charmap.exe uses

Re: notepad patches (search/replace, etc)

2006-06-10 Thread Anoni Moose
Let's try again... I apologize for the bad indentation. It's indented fine in emacs, which I use; however, when I use "diff -u file1 file2", it gives me the entire file as a patch. Therefore, I must use "diff -uwB". Emacs must be screwing it up... ChangeLog:* programs/notepad/main.c, programs/notep

Re: awwww

2006-06-10 Thread Dan Kegel
On 6/10/06, Dan Kegel <[EMAIL PROTECTED]> wrote: If you want to see the bugs I consider high priority, have a look at http://wiki.winehq.org/DanKegel My top five app list is ... I forgot to mention: I also consider any installer bug a high priority bug. Installers Should Just Work. - Dan

kernel32.VerSetConditionMask present

2006-06-10 Thread Vitaly Lipatov
VerSetConditionMask function is introduced in kernel32 science Windows 2000. Some broken applications check VerSetConditionMask present via GetProcAddress for check version of running Windows. What is the preferable method to disable export VerSetConditionMask from kernel32 when we have win98 ver

Re: awwww

2006-06-10 Thread Dan Kegel
On 6/9/06, James Hawkins <[EMAIL PROTECTED]> wrote: > If you is didn't understand, lots of bugs & problems that you > raise are not as critical as you think they are. I don't really agree, but assuming that were true, this is an open source project. You work on things you want to work on, fix b

Re: svrapi: add stub implementation [try 2]

2006-06-10 Thread Robert Shearman
Vitaly Lipatov wrote: +1 stub NetAccessAdd +2 stub NetAccessCheck +3 stub NetAccessDel +4 stub NetAccessEnum +5 stub NetAccessGetInfo +6 stub NetAccessGetUserPerms +7 stub NetAccessSetInfo +8 stub NetConnectionEnum +9 stub NetFileClose2 +10 stub NetFileEnum +11 stub NetSecurityGetInfo +12 stub N

Re: DDraw: New ddraw lib

2006-06-10 Thread Stefan Dösinger
Am Samstag, 10. Juni 2006 01:40 schrieb Jesse Allen: > On 6/9/06, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > > Hi, > > > > > I just want to state, the patch is very helpful when you can't use > > > DGA. I just ran a test with Starcraft in multiplayer last night. Using > > > OpenGL is noticibly fa

Re: WineD3D: Fog fixes

2006-06-10 Thread H. Verbeet
On 09/06/06, Jesse Allen <[EMAIL PROTECTED]> wrote: This patch doesn't work with the latest fglrx saying missing symbol for glFogCoordf. Mesa is ok though. Indeed, the patch should add the proper definitions to wined3d_gl.h and use GL_EXTCALL().