Re: regedit: Refresh also refresh registry keys in listview

2006-06-08 Thread James Hawkins
On 6/8/06, Anoni Moose <[EMAIL PROTECTED]> wrote: These patches allow for refreshing of registry keys in listview, when Refresh menu item is selected. Changelog: * programs/regedit/framewnd.c, programs/regedit/treeview.c: regedit: Uncomment RefreshListView() call, comment TVM_SELECTITEM

Re: edit: Fix crashing, bugs

2006-06-08 Thread James Hawkins
On 6/8/06, Anoni Moose <[EMAIL PROTECTED]> wrote: This patch fix an unhandled page fault with MS notepad and Wine Notepad when loading/editing large files, and some other bugs shown in the Changelog: * dlls/user/edit.c: user: Fixed unhandled page-fault when text length exceeded buffer si

Re: str*casecmpW functions

2006-06-08 Thread Vitaliy Margolen
Thursday, June 8, 2006, 6:57:36 PM, Anoni Moose wrote: > This patch adds some functions for comparison of WCHAR strings, while > ignoring case. Changelog: >     * libs/unicode/string.c: >     unicode: Added strcasecmpW, strncasecmpW functions. BTW what's wrong with strncmpiW? Vitaliy Margolen

Re: server: use getopt

2006-06-08 Thread Mike McCormack
Anoni Moose wrote: This patch let's the server code use getopt to parse arguments. +while ((optchr = getopt(argc, argv, "d:fhk:p:vw")) != -1 && + optind < argc) { /* 'Tis possible we might have a variable declaration... */ + +switch (optchr) { + case 'd'

Re: wcmd: some features/bug fixes

2006-06-08 Thread Mike McCormack
Anoni Moose wrote: * programs/wcmd/builtins.c, programs/wcmd/wcmdmain.c, programs/wcmd/wcmd.h: wcmd: Clear terminal screen using escape code. -Fix infinite file-read loop with TYPE command. -TITLE command use terminal escape code. -Added FREEDISK comm

Re: str*casecmpW functions

2006-06-08 Thread Mike McCormack
Anoni Moose wrote: * libs/unicode/string.c: unicode: Added strcasecmpW, strncasecmpW functions. You've added a dependency on user32.tolowerW, which cannot be linked from all the places that unicode.h is used. Mike

Re: notepad: settings saving code

2006-06-08 Thread Mike McCormack
Anoni Moose wrote: The following files allow saving and loading of notepad's settings to the registry. No patch needed... new files. Changelog: Always send a patch, and make sure to create it from your wine/ directory so that the full path of the file that you're modifying is specified. T

Re: notepad patches (search/replace, etc)

2006-06-08 Thread Vitaliy Margolen
Thursday, June 8, 2006, 6:40:33 PM, Anoni Moose wrote: > This is my first patch to an open source project... if anyone has any > comments/suggestions, please tell me. :) > These patches add full search, search next, replace, and goto line > functionality to notepad. Too bad I missed the 0.9.15 r

Re: xlldrv/keyboard.c: Report of typos

2006-06-08 Thread Joseph Garvin
Andrew Talbot wrote: > I guess, for now, if I want to edit a file that contains high-order > characters, I will need to change the encoding setting of the editor to one > that can accommodate the full character set. > > Thanks, > > -- Andy. > > > Why not submit a bug for Kate? It should detect

Re: appdb security

2006-06-08 Thread EA Durbin
Is there a reason why we don't do the if(empty()) check inside of makeSafe()? as in put the if(empty()) inside of the function itself, or pass if( empty (makeSafe( $_REQUEST['appId'] ) ) ) when we assign it? the reason I didn't put it in the makeSafe function was because we were testing to s

Re: appdb security

2006-06-08 Thread EA Durbin
It will be a large undertaking, but I'll help change this across the board. I'm going out of town for the next 2 days and won't be near my computer, but I can start on it when I get back. From: Chris Morgan <[EMAIL PROTECTED]> To: wine-devel@winehq.org, EA Durbin <[EMAIL PROTECTED]> Subject

Re: xlldrv/keyboard.c: Report of typos

2006-06-08 Thread Andrew Talbot
James Hawkins wrote: > Can you give us some examples of possible typos? I think people will > be more inclined to look into the problem if they see a definite > problem pointed out. > I have worked out what is happening. Assuming the newsgroup system can render the characters properly, in Vim, a

Re: wined3d: GLSL Patch feedback requested

2006-06-08 Thread Ivan Gyurdiev
+ * If a program for the given combination does not exist, create one, and store + * that data in both shader objects so we can delete all of the programs later. + * If it creates a program, it will link the given objects, too. Is this comment still relevant? - Fix relative addressing (it was

Re: xlldrv/keyboard.c: Report of typos

2006-06-08 Thread James Hawkins
On 6/8/06, Andrew Talbot <[EMAIL PROTECTED]> wrote: I believe there are numerous typos in this file. Starting at line 310, there seem to be several missing double quotes; they break compilation if -Wwrite-strings is specified. I was going to assume the missing quotes to be the only factor and fix

xlldrv/keyboard.c: Report of typos

2006-06-08 Thread Andrew Talbot
I believe there are numerous typos in this file. Starting at line 310, there seem to be several missing double quotes; they break compilation if -Wwrite-strings is specified. I was going to assume the missing quotes to be the only factor and fix things myself. But as there are some non-printing cha

Re: appdb security

2006-06-08 Thread Chris Morgan
Alright. I'm sold on having to check all user input. We should make this input checking change across the board if you are up for it. $clean = array(); //array of filtered user input + +$clean['catId'] = makeSafe( $_REQUEST['catId'] ); function admin_menu() { -if(isset($_REQUEST['catId'

Re: Recording with "Lexia" (mci "open new")

2006-06-08 Thread Peter Åstrand
1) I believe the mciwave.c patch below makes sense in any case, right? Without it freed memory is used. I don't see why ? wmw->openParms.lpstrElementName and filename is a pointer to the same memory, due to this statement in WAVE_mciOpen: memcpy(&wmw->openParms, lpOpenParms, sizeof(M

Re: Prospects of an OpenAL audio driver...

2006-06-08 Thread Eric Pouech
Nick Burns wrote: Date: Tue, 06 Jun 2006 22:36:26 +0200 Nick Burns wrote: OpenAL 1.1 supports recording... (1.0 does not have recording so that is a problem yes) -- My driver handles this atm -- it checks for recording capabilities and supports accordingly half or full duplex ? Unknown

Re: Recording with "Lexia" (mci "open new")

2006-06-08 Thread Eric Pouech
1) I believe the mciwave.c patch below makes sense in any case, right? Without it freed memory is used. I don't see why ? 2) Any ideas why "open new" works, even though MCIERR_MISSING_DEVICE_NAME is returned? because "open new alias capture" should create a new mci session of name

Re: Feedback requested for Mac OSX x86 stack patch

2006-06-08 Thread Nick Burns
From: Robert Shearman <[EMAIL PROTECTED]> Subject: Re: Feedback requested for Mac OSX x86 stack patch Date: Thu, 08 Jun 2006 10:29:11 +0100 Nick Burns wrote: I tried using winapi_check, winapi_test, winapi_... They all seemed to give me some odd perl errors (missing defs/funcs in config.pm tha

Re: Feedback requested for Mac OSX x86 stack patch -- #2

2006-06-08 Thread Nick Burns
From: Robert Shearman <[EMAIL PROTECTED]> Subject: Re: Feedback requested for Mac OSX x86 stack patch -- #2 Date: Thu, 08 Jun 2006 10:36:31 +0100 Nick Burns wrote: diff -u -p -r1.114 ChangeLog --- ChangeLog 24 May 2006 18:09:06 - 1.114 +++ ChangeLog 8 Jun 2006 07:06:10 - @@ -1,

Re: Feedback requested on an OpenAL audio driver patch -- #2

2006-06-08 Thread Nick Burns
Got ya will remove that when I send to the wine patch list From: "James Hawkins" <[EMAIL PROTECTED]> Subject: Re: Feedback requested on an OpenAL audio driver patch -- #2 Date: Thu, 8 Jun 2006 10:03:19 -0700 On 6/8/06, Nick Burns <[EMAIL PROTECTED]> wrote: Ok I fixed up my OpenAL driver as pe

Re: wined3d: GLSL Patch feedback requested

2006-06-08 Thread Nick Burns
That looks very impressive (good progress). I would have to look at the actual GLSL produced by this. The actual translation points look good. From: "Jason Green" <[EMAIL PROTECTED]> Date: Thu, 8 Jun 2006 11:54:04 -0400 By the way, here's a comparison screenshot of Civ4 from before my hard dri

Re: appdb security

2006-06-08 Thread EA Durbin
I always use the method of filtering user input as described at the php security consortium. It makes it easier to track tainted user input vs filtered input. If all filtered variables are put in an array it makes it easier to ensure you're using the non tainted variable. http://phpsec.org/pro

Re: Feedback requested on an OpenAL audio driver patch -- #2

2006-06-08 Thread James Hawkins
On 6/8/06, Nick Burns <[EMAIL PROTECTED]> wrote: Ok I fixed up my OpenAL driver as per the suggestions (thanks much) I am not sure how to use or test pkg-config (does that exist on Mac OSX?) The differences with the OpenAL driver patch... 1. It has a perty ChangeLog diff You're not supposed t

Re: setupapi.dll: partially implement SetupDiGetClassDevsExA

2006-06-08 Thread Mike McCormack
Peter Beutner wrote: I thought they started auditing their code and removing any "dirty" parts? And according to their website this process is nearly done. Unfortunately, the fallout of their audit process has been that many trusted developers left the project. For me, the main problem is

Re: setupapi.dll: partially implement SetupDiGetClassDevsExA

2006-06-08 Thread Dmitry Timoshkov
"Peter Beutner" <[EMAIL PROTECTED]> wrote: Don't be suprised if your patch isn't accepted. ReactOS is considered a dirty reverse engineering project by many, and Alexandre has rejected patches using their code before. I thought they started auditing their code and removing any "dirty" parts?

Re: appdb security

2006-06-08 Thread Jonathan Ernst
Le jeudi 08 juin 2006 à 11:42 -0400, Chris Morgan a écrit : > Can you come up with a non-destructive working example for the appdb > website(appdb.winehq.org)? ;-) > > I ask because I thought we went through this some time ago but I agree that > what you say looks like an open issue. > > Chris

Re: setupapi.dll: partially implement SetupDiGetClassDevsExA

2006-06-08 Thread Peter Beutner
Mike McCormack wrote: Christian Gmeiner wrote: Partially implement SetupDiGetClassDevsExA. This patch bases on reactos setupapi.dll. Don't be suprised if your patch isn't accepted. ReactOS is considered a dirty reverse engineering project by many, and Alexandre has rejected patches using th

Re: Linux noob

2006-06-08 Thread Molle Bestefich
Kuba Ober wrote: Molle Bestefich wrote: > Kuba Ober wrote: > > > I'm annoyed that .wine is inaccessible through KDE and Gnome apps. > > > > It is accessible all right. You just don't know how to get there. > > Please insert relevant context when quoting. You're obviously > misrepresenting what I

Re: appdb security

2006-06-08 Thread Christoph Frick
On Thu, Jun 08, 2006 at 11:42:09AM -0400, Chris Morgan wrote: > Can you come up with a non-destructive working example for the appdb > website(appdb.winehq.org)? ;-) no ;P > I ask because I thought we went through this some time ago but I agree > that what you say looks like an open issue. if

Re: wined3d: GLSL Patch feedback requested

2006-06-08 Thread Jason Green
By the way, here's a comparison screenshot of Civ4 from before my hard drive failed, and this is without having texturing on pixel shaders entirely working. Using GLSL (working completely for vertex shaders 2.0, at least the instructions that Civilization 4 used): http://cmhousing.net/wine/civ4_

Re: appdb security

2006-06-08 Thread Chris Morgan
Can you come up with a non-destructive working example for the appdb website(appdb.winehq.org)? ;-) I ask because I thought we went through this some time ago but I agree that what you say looks like an open issue. Chris On Thursday 08 June 2006 11:35 am, Christoph Frick wrote: > On Thu, Jun

wined3d: GLSL Patch feedback requested

2006-06-08 Thread Jason Green
The current cumulative patch is located here: http://cmhousing.net/wine/glsl_cumul.diff (This includes the recently submitted "Split constant loading out of drawPrim()" patch, which hasn't been applied to git yet) Before submitting, I plan to fix the following things: - Fix relative addressing

Re: appdb security

2006-06-08 Thread Christoph Frick
On Thu, Jun 08, 2006 at 11:25:08AM -0400, Chris Morgan wrote: > $sQuery = "Select versionId from appVersion where > appId='"$_REQUEST['appId']."';"; > > Who's '' around $_REQUEST should prevent the string from being interpreted as > anything but a single value passed as the value of appId. wit

Re: Linux noob

2006-06-08 Thread Kuba Ober
On Thursday 08 June 2006 09:02, Molle Bestefich wrote: > Kuba Ober wrote: > > > I'm annoyed that .wine is inaccessible through KDE and Gnome apps. > > > > It is accessible all right. You just don't know how to get there. > > Please insert relevant context when quoting. You're obviously > misrepres

Recording with "Lexia" (mci "open new")

2006-06-08 Thread Peter Åstrand
Hi, I've patched Wine to make recordings work in "Lexia" (http://www.lexia.just.nu/, currently down). When I started out, recordings didn't work, and I was getting traces like: trace:mci:mciSendStringW (L"open new type waveaudio alias capture", 0x7db2ebc8, 128, (nil)) fixme:mci:mciSendString

Re: setupapi.dll: partially implement SetupDiGetClassDevsExA

2006-06-08 Thread Mike McCormack
Christian Gmeiner wrote: Partially implement SetupDiGetClassDevsExA. This patch bases on reactos setupapi.dll. Don't be suprised if your patch isn't accepted. ReactOS is considered a dirty reverse engineering project by many, and Alexandre has rejected patches using their code before. The

Re: [MAPI32 2/3] interface IProfAdmin & its 12 methods, function MAPIAdminProfiles implemented

2006-06-08 Thread Alexandre Julliard
[EMAIL PROTECTED] writes: > +/** > + * IProfAdmin_GetLastError > + * > + * PARAMS > + * hResult [I] HRESULT data type containing the error value > + * generated in the previous method ca

Re: configure: Fix test for ability to link with ICU libraries.

2006-06-08 Thread Alexandre Julliard
Scott Bambrough <[EMAIL PROTECTED]> writes: > @@ -603,8 +603,8 @@ if test "$ac_cv_header_unicode_ubidi_h" > then > saved_libs="$LIBS" > ICU_LIB_DIR="${ICU_LIB_DIR-/usr/lib}" > -ICUUC_LIB="${ICUUC_LIB-$ICU_LIB_DIR/libsicuuc.a}" > -ICUDATA_LIB="${ICUDATA_LIB-$ICU_LIB_DIR/libsicud

Re: Linux noob

2006-06-08 Thread Molle Bestefich
Kuba Ober wrote: > I'm annoyed that .wine is inaccessible through KDE and Gnome apps. It is accessible all right. You just don't know how to get there. Please insert relevant context when quoting. You're obviously misrepresenting what I said, turning it into something completely else, and the

Re: Feedback requested for Mac OSX x86 stack patch -- #2

2006-06-08 Thread Robert Shearman
Nick Burns wrote: diff -u -p -r1.114 ChangeLog --- ChangeLog 24 May 2006 18:09:06 - 1.114 +++ ChangeLog 8 Jun 2006 07:06:10 - @@ -1,3 +1,8 @@ +2006-06-08 Nick Burns <[EMAIL PROTECTED]> + + * include/windef.h: + If on Mac OSX (x86) use force_align_arg_pointer to fix

Re: Feedback requested for Mac OSX x86 stack patch

2006-06-08 Thread Robert Shearman
Nick Burns wrote: I tried using winapi_check, winapi_test, winapi_... They all seemed to give me some odd perl errors (missing defs/funcs in config.pm that WERE there and were also in setup.pm) So... I stupidly went thru and made the relevant files work by copying and pasting the functions and

Feedback requested for Mac OSX x86 stack patch -- #2

2006-06-08 Thread Nick Burns
Ok I have fixed up my Mac OSX stack patch a bit as per the feedback -- thanks much This only patches windef.h There still needs to be some solution for msvcrt AND any other api entry points that are not denoted with __stdcall or __cdecl or WINAPI or WINAPIV This means that Morrowwind (use

Feedback requested on an OpenAL audio driver patch -- #2

2006-06-08 Thread Nick Burns
Ok I fixed up my OpenAL driver as per the suggestions (thanks much) I am not sure how to use or test pkg-config (does that exist on Mac OSX?) The differences with the OpenAL driver patch... 1. It has a perty ChangeLog diff 2. configure.ac now checks for AL/al.h (which is where OpenAL should be)