Re: Feedback requested on an OpenAL audio driver patch

2006-06-07 Thread Marcus Meissner
On Wed, Jun 07, 2006 at 09:36:35PM -0700, Nick Burns wrote: > >From: Leon Freitag <[EMAIL PROTECTED]> > >Date: Wed, 7 Jun 2006 12:09:36 +0200 > > > >P.S. Isn't it better to use pkg-config to check where the libs are located > >anyway? > >Leon > > Is there an example of this? Yes, see the libxml2

Re: Feedback requested for Mac OSX x86 stack patch

2006-06-07 Thread Nick Burns
From: Alexandre Julliard <[EMAIL PROTECTED]> Date: Tue, 06 Jun 2006 12:14:47 +0200 "Nick Burns" <[EMAIL PROTECTED]> writes: > I was concerned about msvcrt not using the __stdcall/WINAPI for its > functions (why is this?). Most msvcrt functions use the cdecl calling convention, not stdcall. Ok

Re: Feedback requested for Mac OSX x86 stack patch

2006-06-07 Thread Nick Burns
From: Alexandre Julliard <[EMAIL PROTECTED]> Date: Wed, 07 Jun 2006 11:40:42 +0200 "Nick Burns" <[EMAIL PROTECTED]> writes: > What about overriding __cdecl and __stdcall? > Are there any internal functions that use those that should not? > That would get around the APIENTRY/WINAPI/CALLBACK probl

Re: Feedback requested on an OpenAL audio driver patch

2006-06-07 Thread Nick Burns
From: Leon Freitag <[EMAIL PROTECTED]> Date: Wed, 7 Jun 2006 12:07:32 +0200 > AC_CHECK_HEADERS(\ >+ OpenAL/al.h \ >+ al/al.h \ >AudioUnit/AudioUnit.h \ >CoreAudio/CoreAudio.h \ >IOKit/IOKitLib.h \ Your patch checks for OpenAL headers only in these places. However my distro (Sus

Re: Feedback requested on an OpenAL audio driver patch

2006-06-07 Thread Nick Burns
From: Leon Freitag <[EMAIL PROTECTED]> Date: Wed, 7 Jun 2006 12:09:36 +0200 P.S. Isn't it better to use pkg-config to check where the libs are located anyway? Leon Is there an example of this? - Nick

Re: Feedback requested on an OpenAL audio driver patch

2006-06-07 Thread Nick Burns
From: Leon Freitag <[EMAIL PROTECTED]> Date: Wed, 7 Jun 2006 15:54:49 +0200 My first impressions: 1) Doesn't compile here: audio.c: In function ‘OpenAL_WaveClose’: audio.c:636: error: void value not ignored as it ought to be because alcCloseDevice() is declared here as void (my openal versi

Re: Feedback requested on an OpenAL audio driver patch

2006-06-07 Thread Nick Burns
From: Robert Reif <[EMAIL PROTECTED]> Date: Wed, 07 Jun 2006 20:55:58 -0400 Nick Burns wrote: It seemed to work well for GTA3, Tribes2 and FlatOut(requires a binary patch to run) (dsound) -- and for SndRec32 (win/wout) (Games and ...App... tested under Mac OSX x86 -- Mac Book Pro) How do t

Re: [KERNEL 1/2] changed test for function FindFirstFileA to find dosdevices

2006-06-07 Thread Vitaliy Margolen
Wednesday, June 7, 2006, 9:03:43 AM, Konstantin Petrov wrote: > changed test for function FindFirstFileA to find dosdevices. > As function FindFirstFile must accept such paths as > "c:\\windows\\win.ini" > "c:\\NUL", > "c:\\COM1", > "c:\\LPT1", > "c:\\LPT9", > "c:\\COM9", > "c:\\CON", > "c:\\AUX"

Re: Feedback requested on an OpenAL audio driver patch

2006-06-07 Thread Robert Reif
Nick Burns wrote: It seemed to work well for GTA3, Tribes2 and FlatOut(requires a binary patch to run) (dsound) -- and for SndRec32 (win/wout) (Games and ...App... tested under Mac OSX x86 -- Mac Book Pro) How do the winmm and dsound regression tests work when run in the interactive mode?

Re: Yet another round of redundand NULL checks before HeapFree (found by Smatch).

2006-06-07 Thread Michael Stefaniuc
Please disregard this patch as a false positive crept in. Michael Stefaniuc wrote: > hopefully this should be the last round of redundand NULL checks before > HeapFree removals. I know, famous last words. But this time i have > extended the redundant_null_check.pl Smatch script to find all non-nul

Re: shell32: Write-strings warning fix

2006-06-07 Thread Andrew Talbot
Andrew Talbot wrote: > Robert Shearman wrote: >> Sorry, this is wrong. If InsertMenuItemA writes to the string then it >> will be corrupted and will display the wrong thing for further uses in >> the process. > > A MENUITEMINFOA's dwTypeData is currently declared as writeable (LPSTR); > what it i

Re: shell32: Write-strings warning fix

2006-06-07 Thread Andrew Talbot
Robert Shearman wrote: > Sorry, this is wrong. If InsertMenuItemA writes to the string then it > will be corrupted and will display the wrong thing for further uses in > the process. A MENUITEMINFOA's dwTypeData is currently declared as writeable (LPSTR); what it is initialised from will not affec

Re: Linux noob

2006-06-07 Thread Andreas Mohr
On Wed, Jun 07, 2006 at 11:17:12AM -0400, Kuba Ober wrote: > I'm sure Gnome has something similar, but I don't use it so I didn't bother > looking the key up. > > I.e. no big deal. > > Cheers, Kuba Andreas Mohr

re: lstrlen(A/W) patch

2006-06-07 Thread Dan Kegel
Clinton wrote: Does the Richedit control return an error, or clear itself when passed EM_SETTEXTEX with lParam = NULL? On Windows, it returns 1 and clears itself. Unless the ST_SELECTION flag is set, in which case it returns 0, and actually replaces the text with nothing. My patch to wine resu

Re: shell32: Write-strings warning fix

2006-06-07 Thread Robert Shearman
Andrew Talbot wrote: Changelog: shell32: Write-strings warning fix. diff -urN a/dlls/shell32/shlview.c b/dlls/shell32/shlview.c --- a/dlls/shell32/shlview.c2006-05-23 17:24:50.0 +0100 +++ b/dlls/shell32/shlview.c2006-06-07 19:37:41.0 +0100 @@ -779,7 +779,9 @@ */ stat

Re: Linux noob

2006-06-07 Thread Kuba Ober
> I'm annoyed that .wine is inaccessible through KDE and Gnome apps. It is accessible all right. You just don't know how to get there. > Not through the file manager, but often in various applications. nope. Unless you're talking about some very broken applications that I didn't come across yet

Re: lstrlen(A/W) patch

2006-06-07 Thread Clinton Stimpson
Mike McCormack wrote: Clinton Stimpson wrote: Oh, used internally, ok (I thought it was public and that the wine debugger said Paf 5.2 called that lstrlenW directly). The public version is defined in dlls/kernel/string.c, and has an exception handler as required by Win32. So here's anothe

Re: Feedback requested on an OpenAL audio driver patch

2006-06-07 Thread Leon Freitag
P.S. Isn't it better to use pkg-config to check where the libs are located anyway? Leon pgpbKZ8HlkpCr.pgp Description: PGP signature

Re: Feedback requested on an OpenAL audio driver patch

2006-06-07 Thread Leon Freitag
My first impressions: 1) Doesn't compile here: audio.c: In function ‘OpenAL_WaveClose’: audio.c:636: error: void value not ignored as it ought to be because alcCloseDevice() is declared here as void (my openal version is 1.0.20051129) 2) It'd be better to convert ALC errors from FIXMEs to ERRs.

Re: Feedback requested on an OpenAL audio driver patch

2006-06-07 Thread Leon Freitag
> AC_CHECK_HEADERS(\ >+ OpenAL/al.h \ >+ al/al.h \ > AudioUnit/AudioUnit.h \ > CoreAudio/CoreAudio.h \ > IOKit/IOKitLib.h \ Your patch checks for OpenAL headers only in these places. However my distro (Suse 10.1) puts openal headers to AL/ instead of al/ and so configu

Re: [uxtheme/tests] Add initial tests (Second try)

2006-06-07 Thread Paul Vriens
On Wed, 2006-06-07 at 08:44 +0200, Paul Vriens wrote: > Hi, > > I've added the framework and some initial (simple) tests. No > functionality tests (yet), only parameter and return-value checking. > > This one also 'fixes' the tests for Wine when theming is enabled. > > Changelog > Added framew

Re: Hal and functions in setupapi

2006-06-07 Thread Mike McCormack
Damjan Jovanovic wrote: That's not anything close to how SETUPAPI works on Windows. Download devinst.c from ReactOS's SETUPAPI and have a look. No, please don't do that, you'll risk having your patches rejected. Implement it in the way that is right for Wine. The only interfaces you need t

Re: libunicode: Add some more code page tables that are available for download from ftp.unicode.org, most notably the table for the us-ascii encoding, which is quite common.

2006-06-07 Thread Alexandre Julliard
Robert Shearman <[EMAIL PROTECTED]> writes: > libs/unicode/Makefile.in |3 > libs/unicode/c_1361.c| 5138 > ++ > libs/unicode/c_2.c | 3587 > libs/unicode/c_20127.c | 683 ++ > libs/unicode/cpmap.pl

Re: [Wine] Re: Linux noob

2006-06-07 Thread Peter Beutner
Molle Bestefich wrote: Peter Beutner wrote: Because it is the defacto standard to store settings under ~/.. Only for stuff that's thought to be generally uninteresting. well, speaking of system.reg, user.reg and dosdevices/, I think they are "generally uninteresting". And if you mangle with t

Re: Hal and functions in setupapi

2006-06-07 Thread Damjan Jovanovic
--- Christian Gmeiner <[EMAIL PROTECTED]> wrote: > Hi all... > > at the momemt i am reading into functions to get > some informations about > e.g. cdrom drives. At the moment > i am loking into SetupDiGetClassDevsW to support > GUID_DEVINTERFACE_CDROM and > later USB devices. > My overall goal

Re: winecfg: Avoid unnecessary casts

2006-06-07 Thread Detlef Riekenberg
Am Mittwoch, den 07.06.2006, 16:45 +0900 schrieb Dmitry Timoshkov: > -psh.u3.ppsp = (LPCPROPSHEETPAGEW) & psp; > +psh.u3.ppsp = psp; Where is the "&" ? -- By By ... ... Detlef

Re: Feedback requested for Mac OSX x86 stack patch

2006-06-07 Thread Alexandre Julliard
"Nick Burns" <[EMAIL PROTECTED]> writes: > What about overriding __cdecl and __stdcall? > Are there any internal functions that use those that should not? > That would get around the APIENTRY/WINAPI/CALLBACK problem with OpenGL That's probably the easiest, yes. It may well cover too many function

Re: How are we doing?

2006-06-07 Thread Kai Blin
* Molle Bestefich <[EMAIL PROTECTED]> [05/06/06, 15:21:08]: I'm not going to try and answer all of these questions, but this one I think I can answer. > Honestly, I think that you just don't like me and that's why you > comprehend everything I write in an extremely prejudicious, negative > manner

Re: [WINED3D 2/3] Fix missing light recording

2006-06-07 Thread Michael Stefaniuc
Ivan Gyurdiev wrote: > >> >From nobody Mon Sep 17 00:00:00 2001 >> > > Please delete this line in case the patch is corrupt.. missed it The patch is not corrupted as it starts only with the '---' line. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Networ