Re: Feedback requested for Mac OSX x86 stack patch

2006-06-05 Thread Nick Burns
Thanks for the feedback... I look forward to windows apps not dieing a horrible death on Mac OSX I was concerned about msvcrt not using the __stdcall/WINAPI for its functions (why is this?). I am guessing the d3d8/d3d9 redefinitions should be removed? Where can I find a list of (or affect th

Re: oleaut32 [1/2]: Copy BYREF args directly if they have the same variant type [RESEND]

2006-06-05 Thread Dan Kegel
On 6/5/06, James Hawkins <[EMAIL PROTECTED]> wrote: There are two or three files that are generated, and until we compile them ourselves, we should keep them in git, because we need some of the files to compile the tests. Oh, right. Anyway, lzexpand/tests/lzexpand_main.c is an example of a gol

Re: oleaut32 [1/2]: Copy BYREF args directly if they have the same variant type [RESEND]

2006-06-05 Thread James Hawkins
On 6/5/06, Dan Kegel <[EMAIL PROTECTED]> wrote: On 6/5/06, James Hawkins <[EMAIL PROTECTED]> wrote: > The test would require us to have an idl file compiled by widl. I bet that'd be ok, at least until our idl compiler shapes up. How big is the output file? Maybe you could even embed it inside t

Re: oleaut32 [1/2]: Copy BYREF args directly if they have the same variant type [RESEND]

2006-06-05 Thread Dan Kegel
On 6/5/06, James Hawkins <[EMAIL PROTECTED]> wrote: The test would require us to have an idl file compiled by widl. I bet that'd be ok, at least until our idl compiler shapes up. How big is the output file? Maybe you could even embed it inside the .c file if it's not too huge.

Re: oleaut32 [1/2]: Copy BYREF args directly if they have the same variant type [RESEND]

2006-06-05 Thread James Hawkins
On 6/5/06, Dan Kegel <[EMAIL PROTECTED]> wrote: James wrote: > Is there anything wrong with this patch? Well, it doesn't have a conformance test... The test would require us to have an idl file compiled by widl. The attached file is a part of the initial type marshalling tests written by Rob

re: oleaut32 [1/2]: Copy BYREF args directly if they have the same variant type [RESEND]

2006-06-05 Thread Dan Kegel
James wrote: Is there anything wrong with this patch? Well, it doesn't have a conformance test... - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

[Fwd: Re: msi patch submission - cond.y]

2006-06-05 Thread Dominic Wise
I may be wrong, but I feel it might be useful for a naive outsider to enter this discussion, even if it does mean I get burnt to a crisp. I'm neither a Wine nor a parser developer (though I do have a few years C/++ experience) and fully accept that I may be flamed to a tiny cinder for my comments,

Re: msi patch submission - cond.y

2006-06-05 Thread EA Durbin
looked up 'tilde' and MSI on Google, it looks as though COND_I* actually relates to strings, as it seems that the tilde means 'case insensitive', but I wonder if it has been inadvertently used on integer comparisons by some installers]. Coming from perl, I though the tilde was part of a regex a

Re: msi patch submission - cond.y

2006-06-05 Thread Dominic Wise
I may be wrong, but I feel it might be useful for a naive outsider to enter this discussion, even if it does mean I get burnt to a crisp. I'm neither a Wine nor a parser developer (though I do have 14 years C/++ experience) and fully accept that I may be flamed to a tiny cinder for my comments, but

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread Joseph Garvin
EA Durbin wrote: > Okay what am i misunderstanding?, explain it to me as its imperative I > learn, and I'd love to learn. > > %u is an unsigned integer which is 0 to +32,767. > > > %i is a signed integer –32,767 to +32,767. > > If the sequence number is always going to be a positive number why > sh

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread Neil Skrypuch
On Monday, June 05, 2006 12:58, EA Durbin wrote: > Okay what am i misunderstanding?, explain it to me as its imperative I > learn, and I'd love to learn. > > %u is an unsigned integer which is 0 to +32,767. > > > %i is a signed integer –32,767 to +32,767. > > If the sequence number is always going

winedbg - setting breakpoint

2006-06-05 Thread Stephen Clark
Hello List, I am trying to get classic Myst to run again under wine. How do I set a breakpoint in it when it run by winevdm. Thanks, Steve -- "They that give up essential liberty to obtain temporary safety, deserve neither liberty nor safety." (Ben Franklin) "The course of history shows

Re: GetDIBits() with a bitmap that is selected in a device context

2006-06-05 Thread Michael Kaufmann
I have submitted new tests to wine-patches. @Dmitry: One of your bitmap tests triggers an assertion on Windows 9x. Look here: http://test.winehq.org/data/200605161000/ Regards, Michael Dmitry Timoshkov wrote: The application "Fritz 5.32" calls GetDIBits() with a bitmap that is still selected

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread Jonathan Ernst
Le lundi 05 juin 2006 à 14:01 -0500, EA Durbin a écrit : > > > >Vitaliy. > > > >PS: PLEASE PLEASE PLEASE ADD YOU COMMENTS BELOW THIS LINE NOT ABOVE. IT'S > >IMPOSSIBLE TO READ. > > > > > By default microsoft outlook, hotmail, all add their replies above the > previous message. It's the way 90% o

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread EA Durbin
Can you 100% guarantee that documentation is correct? And that there are no broken apps that will try to pass negative number? Vitaliy. Okay, i guess I see your point, but if the broken app passes a negative number its not going to work correctly anyway, as it will read from the wrong Disk

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread Vitaliy Margolen
Monday, June 5, 2006, 1:01:10 PM, EA Durbin wrote: >>Both of those depend on the type and not on what it "should be". >>And the type is INT it's a "signed int". > Why must it be a signed int, the comparison is always a positive number > which is an unsigned int. So if we always pass a positive nu

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread Detlef Riekenberg
Am Montag, den 05.06.2006, 14:01 -0500 schrieb EA Durbin: > >And the type is INT it's a "signed int". > Why must it be a signed int, Welcome to the World of Microsoft. Another Example from MS: A Function is declared to return a BOOL and documented to return '0', '1' or '2' We are Compatible,

Re: Feedback requested for Mac OSX x86 stack patch

2006-06-05 Thread Alexandre Julliard
"Nick Burns" <[EMAIL PROTECTED]> writes: > (notes are at the top of the patch) > > I would like some feedback on my stack fix patch > > I do not know how it interacts with linux -- no access to a linux box > This has been confirmed to fix numerous app issues (due to stack alignment) > > I am start

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread EA Durbin
Vitaliy. PS: PLEASE PLEASE PLEASE ADD YOU COMMENTS BELOW THIS LINE NOT ABOVE. IT'S IMPOSSIBLE TO READ. By default microsoft outlook, hotmail, all add their replies above the previous message. It's the way 90% of the email I see works. Both of those depend on the type and not on what i

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread Vitaliy Margolen
Monday, June 5, 2006, 11:02:38 AM, EA Durbin wrote: > As Robert Shearman stated, why give it a 4 byte value when it's using a 2 > byte value. > The sequence should never be a negative number, where am I mistaken on this? Both of those depend on the type and not on what it "should be". And the typ

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread EA Durbin
I'm not flaming, I'm trying to get assitance with the problem and sharing my findings with other developers. I openly admit im a novice C hacker, and could use some help which I thought was what the wine-devel mailing list was used for, as its for developers. As Robert Shearman stated, why giv

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread EA Durbin
Okay what am i misunderstanding?, explain it to me as its imperative I learn, and I'd love to learn. %u is an unsigned integer which is 0 to +32,767. %i is a signed integer –32,767 to +32,767. If the sequence number is always going to be a positive number why should we allot it the extra 32,

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread Robert Shearman
Mike McCormack wrote: EA Durbin wrote: It doesn't use %d currently. It uses %i. And its not to print. It uses this value in the SQL statement. The LastSequence value of the Media table is NEVER negative as i pointed out in the MSDN link. It must always be zero or larger and this is handled

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread Mike McCormack
EA Durbin wrote: It doesn't use %d currently. It uses %i. And its not to print. It uses this value in the SQL statement. The LastSequence value of the Media table is NEVER negative as i pointed out in the MSDN link. It must always be zero or larger and this is handled by passing %u. Unfortun

Re: Wine VM86 exception handling bug?

2006-06-05 Thread Andrey Turkin
I used nasm and hiew. There is no point in adding additional tools dependencies. Anyway the test codes wouldn't be changed somehow often. And anyway I'm already submitted patch :) Detlef Riekenberg wrote: Am Montag, den 05.06.2006, 11:58 +0100 schrieb Mike Hearn: On 6/5/06, Robert Shearman <[E

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread Vitaliy Margolen
Why would you add all your findings and "test cases" into the Wine's test suite? Until then you should stop flaming list. With all the energy you spent writing these e-mails BACKWARDS as I might add. And you outright IGNORED my suggestions on the IRC chat room. So until you show us some code tha

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread EA Durbin
It doesn't use %d currently. It uses %i. And its not to print. It uses this value in the SQL statement. The LastSequence value of the Media table is NEVER negative as i pointed out in the MSDN link. It must always be zero or larger and this is handled by passing %u. The SELECT * FROM `Media` W

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread Mike McCormack
EA Durbin wrote: I did in fact write a test, which does prove this. Hans has a copy of it, and i think i sent it to wine-devel too. I haven't seen any patch for the Wine regression test suite as yet, and that is what I have been asking you to write. As for files.c, the query in ready_media

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread EA Durbin
My analysis has not changed it still remains the same to this day. Case, america's army installer is working backward, not going through the media in the correct order. Upon troubleshooting this I found that this is due to the query returning the wrong results for LastSequence. I don't have

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread Mike McCormack
EA Durbin wrote: obviously my patch wasn't "wrong" as you so put it, as this is the same thing as the one I submitted. I just phrased the definition of it wrong assuming the conditional statements were used by SQL. Your patch caused the regression tests to fail, and Hans' did not. err:msi:m

re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread EA Durbin
obviously my patch wasn't "wrong" as you so put it, as this is the same thing as the one I submitted. I just phrased the definition of it wrong assuming the conditional statements were used by SQL. From: "Dan Kegel" <[EMAIL PROTECTED]> To: wine-devel , "Hans Leidekker" <[EMAIL PROTECTED]> CC

re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread Dan Kegel
Hans wrote: [http://www.winehq.org/pipermail/wine-cvs/2006-June/023395.html] Fix some copy/paste bugs in the implementation of condition operators. Congratulations on getting your patch into cvs! How far does this go towards fixing America's Army (http://bugs.winehq.org/show_bug.cgi?id=5139)

Re: Wine VM86 exception handling bug?

2006-06-05 Thread Detlef Riekenberg
Am Montag, den 05.06.2006, 11:58 +0100 schrieb Mike Hearn: > On 6/5/06, Robert Shearman <[EMAIL PROTECTED]> wrote: > > It depends whether it's in a convenient form. For a 100-byte COM file, > > it is probably already in its most convenient form. > > If, like Rob, you are an i386 ninja master who w

Re: To or or not :-)

2006-06-05 Thread Stephen Clark
Molle Bestefich wrote: isn't it rather insane to require specific editor settings just to be able to *view* the code? It's a necessity for some editors. The TAB setting can be embedded in ASCII files, there are various magic comments that will cause vim and emacs to switch to a readable

Re: msi patch submission - cond.y

2006-06-05 Thread EA Durbin
Then what are the conditional statements in cond.y used for? Though they may not be SQL errors, if IGE and ILEmeans IS Greater than or equal to, or Is Less than or Equal to then it's still and error, even if it doesn't pertain to SQL. Do these not mean IS Greater than or equal to, or Is Less t

Re: msi patch submission - cond.y

2006-06-05 Thread Hans Leidekker
On Monday 05 June 2006 15:33, EA Durbin wrote: > Is IGE not is greater than or equal to, and shouldn't the sign for that be > >= rather than <=, or does IGE mean something else, perfect example of > were comments should be, after all the function should be written perfectly I don't think that's e

Re: msi patch submission - cond.y

2006-06-05 Thread Mike McCormack
EA Durbin wrote: fixed various SQL errors in COND_GetOperator() and compare_int() Unfortunately cond.y has nothing to do with SQL. Mike

Re: To or or not :-)

2006-06-05 Thread Molle Bestefich
Robert Shearman wrote: Perhaps you could post your coding style rants on a blog somewhere, Yeah, sorry. It was a joke on the K&R discussion - hence the smiley in the subject ;-).

Re: To or or not :-)

2006-06-05 Thread Robert Shearman
Molle Bestefich wrote: isn't it rather insane to require specific editor settings just to be able to *view* the code? It's a necessity for some editors. The TAB setting can be embedded in ASCII files, there are various magic comments that will cause vim and emacs to switch to a readable tabs

Re: msi patch submission - cond.y

2006-06-05 Thread EA Durbin
Is IGE not is greater than or equal to, and shouldn't the sign for that be >= rather than <=, or does IGE mean something else, perfect example of were comments should be, after all the function should be written perfectly so it can be interpreted without any comments in the code. After all H

Re: How are we doing?

2006-06-05 Thread Molle Bestefich
Dmitry Timoshkov wrote: I'd suggest to return and carefully reread the whole paragraph I've quoted and replied to. It has nothing to do with a constructive talk about commenting the code, instead it's full of insults and hits. It has everything to do with a constructive talk about comments. I

To or or not :-)

2006-06-05 Thread Molle Bestefich
isn't it rather insane to require specific editor settings just to be able to *view* the code? It's a necessity for some editors. The TAB setting can be embedded in ASCII files, there are various magic comments that will cause vim and emacs to switch to a readable tabs setting. What is insane

Re: rpcrt4: Introduce a new function, safe_multiply, which will raise an exception if a multiply overflows a 4-byte integer.

2006-06-05 Thread Robert Shearman
Alexandre Julliard wrote: Robert Shearman <[EMAIL PROTECTED]> writes: +unsigned char overflow; +#if defined(__i386__) && defined (__GNUC__) +__asm__( +"mull %3\n\t" +"seto %%cl" +: "=a" (ret), "=c" (overflow) /* outputs: eax, cl */ +:

Re: rpcrt4: Introduce a new function, safe_multiply, which will raise an exception if a multiply overflows a 4-byte integer.

2006-06-05 Thread Alexandre Julliard
Robert Shearman <[EMAIL PROTECTED]> writes: > +unsigned char overflow; > +#if defined(__i386__) && defined (__GNUC__) > +__asm__( > +"mull %3\n\t" > +"seto %%cl" > +: "=a" (ret), "=c" (overflow) /* outputs: eax, cl */ > +: "%a" (a), "rm" (b)

Re: Wine VM86 exception handling bug?

2006-06-05 Thread Andrey Turkin
I believe it is better to store binaries as arrays and use temporary files than drop many small .com binaries all over the code tree (for now I have 3 test programs about 30 bytes each). It is possible to comment/disassemble test cases instruction by instruction, if needed. Also, not everyone

Re: userenv: Add a stub implementation of userenv.dll

2006-06-05 Thread Detlef Riekenberg
Am Montag, den 05.06.2006, 19:42 +0900 schrieb Mike McCormack: > > For mingw, this is in "include/userenv.h" > > Right. It's in include/userenv.h in the platform SDK too, however Wine > still doesn't have that header, > and I don't feel motivated to add it right yet... I know such Situations

Re: Wine VM86 exception handling bug?

2006-06-05 Thread Mike Hearn
On 6/5/06, Robert Shearman <[EMAIL PROTECTED]> wrote: It depends whether it's in a convenient form. For a 100-byte COM file, it is probably already in its most convenient form. If, like Rob, you are an i386 ninja master who wields a disassembler as most of us wield a knife and fork then yes may

Re: Wine VM86 exception handling bug?

2006-06-05 Thread Robert Shearman
Mike McCormack wrote: Mike Hearn wrote: Sure it might be small, but it's still a binary no matter how we store it. It's not more useful as an array than as a true binary file on disk. Why obfuscate and expand it by embedding it into a text file? An LGPL'ed binary is a bit of a contradictio

Re: userenv: Add a stub implementation of userenv.dll

2006-06-05 Thread Mike McCormack
Detlef Riekenberg wrote: For mingw, this is in "include/userenv.h" Right. It's in include/userenv.h in the platform SDK too, however Wine still doesn't have that header, and I don't feel motivated to add it right yet... Mike

Re: userenv: Add a stub implementation of userenv.dll

2006-06-05 Thread Detlef Riekenberg
Am Montag, den 05.06.2006, 14:01 +0900 schrieb Mike McCormack: > +++ b/dlls/userenv/userenv_main.c > +typedef struct _PROFILEINFOA { ... > +} PROFILEINFOA, *LPPROFILEINFOA; For mingw, this is in "include/userenv.h" -- By By ... ... Detlef

Re: msi patch submission - cond.y

2006-06-05 Thread Mike McCormack
EA Durbin wrote: fixed various SQL errors in COND_GetOperator() and compare_int() IMO, both of your patches are incorrect. I'm waiting for your test case. Mike

Re: Wine VM86 exception handling bug?

2006-06-05 Thread Mike McCormack
Mike Hearn wrote: Sure it might be small, but it's still a binary no matter how we store it. It's not more useful as an array than as a true binary file on disk. Why obfuscate and expand it by embedding it into a text file? An LGPL'ed binary is a bit of a contradiction, isn't it? Mike

Re: Wine VM86 exception handling bug?

2006-06-05 Thread Mike Hearn
On 6/5/06, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > I'd rather we got out of the habit of doing this seeing as I think git can > deal with binaries better than cvs can. There is no point in storing the binaries in the *source* tree, besides tiny .com file which shows the bug shouldn't take

Re: acad 2004 license file bug

2006-06-05 Thread Jaap Stolk
On 6/5/06, Dan Kegel <[EMAIL PROTECTED]> wrote: Don't use winetools, please. As you noticed, it does bad things to your ~/.wine. Ok. removed winetools and build a new ~/.wine/ > (can wine fake internet explorer, >so i don't need to install the real thing?) Yes. Here's what I do: # Fake IE