Re: FW: RE: My 1.0 wish list

2006-06-03 Thread James Hawkins
On 6/3/06, Tom Booker <[EMAIL PROTECTED]> wrote: hopefully nobody flames me but i just tied all these bugs together thru bug 5350.. they block it now.. maybe i should just make them all dupes instead? plz dont flame me im just trying to help I don't think that was a good idea. It's possib

Re: FW: RE: My 1.0 wish list

2006-06-03 Thread Tom Booker
hopefully nobody flames me but i just tied all these bugs together thru bug 5350..  they block it now.. maybe i should just make them all dupes instead?   plz dont flame me  im just trying to help   Tom  On 6/3/06, EA Durbin <[EMAIL PROTECTED]> wrote: I have compiled a list of applications that are

Re: My 1.0 wish list

2006-06-03 Thread Tom Booker
On 6/3/06, EA Durbin <[EMAIL PROTECTED]> wrote: I just tested the latest Kidspiration install. The self extracting .exeextracts the Trial.exe file into windows/temp, and then complains about not having a program associated with Kid's Trial.exe. After traversing into the.wine/drive_c/windows/temp fo

Re: FW: RE: My 1.0 wish list

2006-06-03 Thread Mike McCormack
EA Durbin wrote: proven this with code and resulting logs. This problem affects a multitude of applications in wine. If your not willing to work on it then either someone else can, or it can remain broken. I told you from the start that I don't have time to work on this now. I've told you a

Re: wined3d: Another GLSL shader status update

2006-06-03 Thread Phil Costin
To clarify - It doesn't matter that you're changing the version of the future software pixel shader support capability but the vertex shader change is problematic because apps may see the 3.0 VS capability and supply a 3.0 shader to a 1.4 capable GL implementation. Phil Phil Costin wrote: > Hi

Re: wined3d: Another GLSL shader status update

2006-06-03 Thread Phil Costin
Hi Jason, Can you just clarify for my why you are changing the D3DVS_VERSION() and D3DPS_VERSION() to 3.0 for SHADER_ARB in the caps section of directx.c? SHADER_ARB refers to ARB_vertex_program and ARB_fragment_program which do not support features greater than VS 1.1 and PS 1.4 respectively. Th

Re: DirectX blitter bug

2006-06-03 Thread Alexander Nicolaysen Sørnes
Søndag 04 juni 2006 02:13, skrev Mike Hearn: > Lords of Magic works perfectly EXCEPT that rendering is corrupted when it > is using DirectX "fast blitting"; they provide a software emulated > workaround for some truly ancient cards (Matrox Mystique anyone?) and the > game works well in this mode. B

DirectX blitter bug

2006-06-03 Thread Mike Hearn
Lords of Magic works perfectly EXCEPT that rendering is corrupted when it is using DirectX "fast blitting"; they provide a software emulated workaround for some truly ancient cards (Matrox Mystique anyone?) and the game works well in this mode. But it should work properly in DirectX accelerated mod

Re: To K&R or not

2006-06-03 Thread Peter Beutner
James Hawkins schrieb: On 6/3/06, Stephen Clark <[EMAIL PROTECTED]> wrote: > >"Tabs are not forbidden but discouraged. A tab is defined as 8 >characters and the usual amount of indentation is 4 characters." > > A tab is not defined as 8 spaces - it is defined as go to the next TAB STOP! The tab

Re: mapi32: Write-strings warnings fix

2006-06-03 Thread Andrew Talbot
Hans Leidekker wrote: > [...] How about this patch? > > -char *address = "", *to = NULL, *cc = NULL, *bcc = NULL, *subject, > *body; > +char *to = NULL, *cc = NULL, *bcc = NULL; > +const char *subject, *body, *address = ""; > > -Hans Because of the testing: if (!message) retur

Re: Shell integration idea

2006-06-03 Thread Mike Hearn
On 6/3/06, Mikołaj Zalewski <[EMAIL PROTECTED]> wrote: OK, I won't insist on aggregation :). As for apartments I've thought that something like that: HRESULT res=CoInitializeEx(NULL, COINIT_MULTITHREADED); /* working with objects with ThreadingModel Both */ if (SUCCEEDED(res)) CoUninitialize();

Re: Shell integration idea

2006-06-03 Thread Mikołaj Zalewski
The number of developers that understand COM aggregation and all the baroque rules that make it up is very, very low. A simple ops struct of function pointers as used in the wineserver or kernel would be fine here ... COM adds an awful lot of complexity that really isn't needed at all (eg you mu

Re: mapi32: Write-strings warnings fix

2006-06-03 Thread Andrew Talbot
Hans Leidekker wrote: > > I see no warnings with -Wwrite-strings and -Wcast-qual. > > -Hans Hans, Yes, you are right. Of course, the values are being taken from the SDK elements, not being assigned to them, so the local variable can and should be constified. -- Andy.

Re: Prospects of an OpenAL audio driver...

2006-06-03 Thread Nick Burns
On Fri, 02 Jun 2006 02:08:04 -0700, Nick Burns wrote: Are there any problems with using OpenAL for such a purpose? Probably not, it depends on the exact level of abstraction OpenAL gives. But it begs the question - why? thanks -mike The reason for using OpenAL is for platforms that dont h

Re: mapi32: Write-strings warnings fix

2006-06-03 Thread Hans Leidekker
On Saturday 03 June 2006 22:06, Andrew Talbot wrote: > The problem is that the SDK defines the strings as non-const, so making > subject and body const char * would cause a qual-cast violation. I see no warnings with -Wwrite-strings and -Wcast-qual. -Hans

Re: mapi32: Write-strings warnings fix

2006-06-03 Thread Andrew Talbot
Actually, sorry, my earlier statement was rubbish. But the point of the Write-strings warning is to flag the discarding of a qualifer. Thus char *s = "string"; /* bad */ discards the effective const factor of the string constant. So I can't assign const char * values to char * variables. --

Re: mapi32: Write-strings warnings fix

2006-06-03 Thread Andrew Talbot
Option 2 is the way to go. -- A.

Re: mapi32: Write-strings warnings fix

2006-06-03 Thread Andrew Talbot
Hans Leidekker wrote: > That won't do either because these pointers are dereferenced a few lines > further down. How about this patch? > > -char *address = "", *to = NULL, *cc = NULL, *bcc = NULL, *subject, > *body; > +char *to = NULL, *cc = NULL, *bcc = NULL; > +const char *subject,

Re: mapi32: Write-strings warnings fix

2006-06-03 Thread Hans Leidekker
On Saturday 03 June 2006 21:26, Andrew Talbot wrote: > subject = message->lpszSubject; > body = message->lpszNoteText; That won't do either because these pointers are dereferenced a few lines further down. How about this patch? -char *address = "", *to = NULL, *cc = NULL, *bcc = NUL

Re: To K&R or not

2006-06-03 Thread James Hawkins
On 6/3/06, Stephen Clark <[EMAIL PROTECTED]> wrote: > >"Tabs are not forbidden but discouraged. A tab is defined as 8 >characters and the usual amount of indentation is 4 characters." > > A tab is not defined as 8 spaces - it is defined as go to the next TAB STOP! The tab stop could be every 8 s

Re: mapi32: Write-strings warnings fix

2006-06-03 Thread Andrew Talbot
Peter Oberndorfer wrote: > On Saturday 03 June 2006 16:33, Andrew Talbot wrote: >> Changelog: >> mapi32: Write-strings warnings fix. >> >> diff -urN a/dlls/mapi32/sendmail.c b/dlls/mapi32/sendmail.c >> --- a/dlls/mapi32/sendmail.c 2006-05-23 17:24:40.0 +0100 >> +++ b/dlls/mapi32/sendm

Re: Added initial version of Wine OleView

2006-06-03 Thread Vitaliy Margolen
Saturday, June 3, 2006, 11:36:45 AM, Piotr Caban wrote: Please change FSF's address to the new one. Vitaliy Margolen

Re: Wine VM86 exception handling bug?

2006-06-03 Thread Mike Hearn
On Fri, 02 Jun 2006 08:01:55 -0700, Dan Kegel wrote: > You can embed a trivial DOS executable as data in the .c file I'd rather we got out of the habit of doing this seeing as I think git can deal with binaries better than cvs can. thanks -mike

Re: FW: RE: My 1.0 wish list

2006-06-03 Thread Hans Leidekker
On Saturday 03 June 2006 18:45, EA Durbin wrote: > That can't be used for a test case, for a test case I, or most likely > someone elsewho has the ability and the time has to write code under > dlls/msi/tests/db.c and make a program in windows to re-illustrate this > bug. Do you know SQL? Could y

wined3d: Another GLSL shader status update

2006-06-03 Thread Jason Green
Well, I've fixed the speed issues with using GLSL (it's now just as fast as ARB shaders for the ones that actually work correctly) and gotten a few other things to work correctly. However, I'm still having issues with certain pixel/vertex shader combinations. Ohsix caught on that it may have to

Re: Prospects of an OpenAL audio driver...

2006-06-03 Thread Mike Hearn
On Fri, 02 Jun 2006 02:08:04 -0700, Nick Burns wrote: > Are there any problems with using OpenAL for such a purpose? Probably not, it depends on the exact level of abstraction OpenAL gives. But it begs the question - why? thanks -mike

Re: ntdll: a simple implementation of cross-process NtAllocateVirtualMemory

2006-06-03 Thread Mike Hearn
On Sat, 03 Jun 2006 09:43:04 +0200, Alexandre Julliard wrote: > If it's a solution that can be expanded later on to cover the other > cases, yes, but not if it's a dead-end. When this was discussed before the idea of bringing back the service thread was raised. I still think we should do this, ass

Re: MSI query tests

2006-06-03 Thread Mike Hearn
On Thu, 01 Jun 2006 21:51:20 -0500, EA Durbin wrote: > I don't know how I would run this on windows. You don't have to, you just need to run it against a native MSI. As to how to convert your findings into a test case, I guess that may be trickier. There is some fundamental behavior here that is

Re: Added initial version of Wine OleView

2006-06-03 Thread James Hawkins
On 6/3/06, Piotr Caban <[EMAIL PROTECTED]> wrote: + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA The address has changed, and we recently did a sweep of the code base changing to the new address, so we'd like to keep the old address out. * Foundation, Inc., 51

Re: Shell integration idea

2006-06-03 Thread Mike Hearn
On Fri, 02 Jun 2006 20:16:25 +0200, Mikolaj Zalewski wrote: > Of course when we use COM aggregation instead of a factory pattern we > will have all the interfaces visible under one CLSID so we will be able > to construct a IWineTrash directly with the main object hidden behind > the scene. Argh

Re: How are we doing?

2006-06-03 Thread Mike Hearn
On Sat, 03 Jun 2006 12:03:21 +1000, Jeff Latimer wrote: > We seem to have a policy of not accepting comments in exisiting code. We do? I seem to recall having comment patches accepted before. Albiet a long time ago. > If I add comments to existing code that clear up a mystery I have found > th

Re: How are we doing?

2006-06-03 Thread Mike Hearn
On Fri, 02 Jun 2006 08:03:46 -0500, Jeremy White wrote: > And I think I would agree that the Wine server is commented > about right; it is, imho, a beautiful piece of code. +1 to that. I reckon I didn't really grok in that deep-down-in-your-soul way what "good coding style" is until I took time t

Re: How are we doing?

2006-06-03 Thread Mike Hearn
On Fri, 02 Jun 2006 12:33:03 +0100, Robert Shearman wrote: > The lack of comments in your email is more horrifying. Haha :) Maybe we should have a new janitorial task "comment code", or maybe Alexandre should reject patches that don't have enough comments? The problem I think is that because MSD

Re: ntdll: a simple implementation of cross-process NtAllocateVirtualMemory

2006-06-03 Thread Robert Shearman
Alexandre Julliard wrote: "Dan Kegel" <[EMAIL PROTECTED]> writes: On 6/2/06, Alexandre Julliard <[EMAIL PROTECTED]> wrote: The problem here is that you don't control at what point you interrupt the process, so you can't do anything in it except system calls, and that won't be enough.

Re: FW: RE: My 1.0 wish list

2006-06-03 Thread EA Durbin
That can't be used for a test case, for a test case I, or most likely someone elsewho has the ability and the time has to write code under dlls/msi/tests/db.c and make a program in windows to re-illustrate this bug. From: "Jason Green" <[EMAIL PROTECTED]> To: "EA Durbin" <[EMAIL PROTECTED]>

Re: To K&R or not

2006-06-03 Thread Peter Beutner
James Hawkins schrieb: We do have a consensus about tabs vs. spaces. To quote the page I sent you in the last message: "Tabs are not forbidden but discouraged. A tab is defined as 8 characters and the usual amount of indentation is 4 characters." More and more this is being followed, but we wo

Re: To K&R or not

2006-06-03 Thread James Hawkins
On 6/3/06, Peter Beutner <[EMAIL PROTECTED]> wrote: The question is in how far that really works in reality. Even when leaving such (imho) minor things like K&R or not, spaces after if or not,etc aside. Just look at the tabs vs. space issue: I don't really have a problem with both of them but mi

Re: FW: RE: My 1.0 wish list

2006-06-03 Thread Jason Green
On 6/3/06, EA Durbin <[EMAIL PROTECTED]> wrote: This problem in MSI spans a multitude of bugs. ATI demo(Rendering With Natural Light ) - bug # 4712? I noticed yesterday that just about every ATI Demo had similar installer problems. Just try a few from here if you need some quick test cases:

Re: FW: RE: My 1.0 wish list

2006-06-03 Thread EA Durbin
I have compiled a list of applications that are affected by the bug in which the query in ready_media_for_file() in MSI returns the wrong results, it returns LastSequence less than the file->Sequence being passed. Here is a detailed analysis of the multiple types of errors this bugs causes.

Re: DAZ Studio

2006-06-03 Thread Vitaliy Margolen
Saturday, June 3, 2006, 6:14:14 AM, Andrew Neil Ramage wrote: > After running winecfg and setting winver for DAZStudio.exe to XP, I get > the following. > [EMAIL PROTECTED]:~/Download/Windows> wine > /home/andrew/.wine/drive_c/Program\ Files/DAZ/Studio/DAZStudio.exe > fixme:imm:ImmReleaseContext

Re: mapi32: Write-strings warnings fix

2006-06-03 Thread Peter Oberndorfer
On Saturday 03 June 2006 16:33, Andrew Talbot wrote: > Changelog: > mapi32: Write-strings warnings fix. > > diff -urN a/dlls/mapi32/sendmail.c b/dlls/mapi32/sendmail.c > --- a/dlls/mapi32/sendmail.c 2006-05-23 17:24:40.0 +0100 > +++ b/dlls/mapi32/sendmail.c 2006-06-03 14:44:21.00

RE: My 1.0 wish list

2006-06-03 Thread EA Durbin
I just tested the latest Kidspiration install. The self extracting .exe extracts the Trial.exe file into windows/temp, and then complains about not having a program associated with Kid's Trial.exe. After traversing into the .wine/drive_c/windows/temp folder and typing Wine Kid's Trial.exe the p

Re: DAZ Studio

2006-06-03 Thread Andrew Neil Ramage
When I run the command, I get a Crash Detected dialog with the following text: DAZStudio.exe caused an EXCEPTION_ACCESS_VIOLATION in module at 0073:42A66FF5 Andrew When the dragons grow too mighty To slay with pen or sword I grow weary of the battle And the storm I walk toward Madrigal by

Re: DAZ Studio

2006-06-03 Thread Jeff Latimer
Andrew, so far the uniscribe part looks like pretty much like I would expect. What is the problem you are experiencing? Jeff Andrew Neil Ramage wrote: After running winecfg and setting winver for DAZStudio.exe to XP, I get the following. [EMAIL PROTECTED]:~/Download/Windows> wine /home/an

Re: Built-in iexplore

2006-06-03 Thread Jonathan Ernst
Le vendredi 02 juin 2006 à 13:42 -0700, Brandon a écrit : > Daniel Skorka wrote: > > Oleksii Krykun <[EMAIL PROTECTED]> wrote: > > > $ wine iexplore > > > fixme:shdocvw:IEWinMain "" 1 > > > fixme:ole:CoResumeClassObjects stub > > > Could not load Mozilla. HTML rendering will be disabled. > > ^^

Re: Re: Re: Wine 1.0 Tasks

2006-06-03 Thread fenix
bint3LPh75nyW.bin Description: undefined

Re: How are we doing?

2006-06-03 Thread Jeff Latimer
Matt Finnicum wrote: Also, sometimes it's not obvious why a function is called. A comment like "Call funcResetStatusVariables because the above code triggers a redraw which can break them" would save a new developer twenty minutes of "But why update them THERE?! Does my code have to do that?".

Re: [Darwine] Quartz driver

2006-06-03 Thread anarkhos
At 10:48 PM +0200 5/31/06, Emmanuel Maillard wrote: >Hi all, > >Quartz driver is up to date on Darwine CVS. Ah, so you managed to get bitmaps working. I attempted it, but was getting confused with the undocumented setbitmap behavior in WINE (the bitmaps were being loaded correctly, but weren't b

DAZ Studio

2006-06-03 Thread Andrew Neil Ramage
After running winecfg and setting winver for DAZStudio.exe to XP, I get the following. [EMAIL PROTECTED]:~/Download/Windows> wine /home/andrew/.wine/drive_c/Program\ Files/DAZ/Studio/DAZStudio.exe fixme:imm:ImmReleaseContext (0x10020, 0x403cde30): stub fixme:imm:ImmReleaseContext (0xa00a2, 0x4

Re: To K&R or not

2006-06-03 Thread Peter Beutner
James Hawkins schrieb: On 6/2/06, Aneurin Price <[EMAIL PROTECTED]> wrote: How about setting a standard that will be used in the repository, and providing the indent commands to set it that way, then indenting *every file* in the repository to that standard. Then every developer can use indent

Re: How are we doing?

2006-06-03 Thread Alexandre Julliard
Peter Beutner <[EMAIL PROTECTED]> writes: >> BTW Alexandre, can we preserve references to bug numbers in patch comments? > Indeed that would be nice. I'm not opposed to having bug number in the comments, but it has to be in addition to a proper explanation; the log must be understandable on its o

Re: How are we doing?

2006-06-03 Thread Peter Beutner
Vitaliy Margolen schrieb: Friday, June 2, 2006, 6:27:18 AM, EA Durbin wrote: There is precious little "Why" in the comments of a lot of projects - Why does this function exist, why would I call it, why does it return what it does, etc. BS comments like those within the function don't help, ob

Re: ntdll: a simple implementation of cross-process NtAllocateVirtualMemory

2006-06-03 Thread Alexandre Julliard
"Dan Kegel" <[EMAIL PROTECTED]> writes: > How 'bout we also implement remote thread creation, and create > a temporary service thread to service a remote memory allocation request? > That would give the thread context you say is required. Yes that's a possibility, we need support for creating rem

Re: ntdll: a simple implementation of cross-process NtAllocateVirtualMemory

2006-06-03 Thread Alexandre Julliard
"Dan Kegel" <[EMAIL PROTECTED]> writes: > Are you willing to accept a patch which makes some common use > cases work well, but does not address others? If it's a solution that can be expanded later on to cover the other cases, yes, but not if it's a dead-end. -- Alexandre Julliard [EMAIL PROTEC

Re: How are we doing?

2006-06-03 Thread n0dalus
On 6/3/06, Vitaliy Margolen <[EMAIL PROTECTED]> wrote: I don't see any problems here. If anyone needs to know _why_ some function does X - they should look on msdn. Also it would really help look at the patch itself that _does_ explain what the patch is for. And might even link to the bug #. I