Re: Dinput8: DirectInput8Create rewrite

2006-05-14 Thread Jesse Allen
On 5/14/06, Roderick Colenbrander <[EMAIL PROTECTED]> wrote: Hi, This patch lets DirectInput8Create work similar to the native version which according to MSDN uses CoCreateInstance to create a dinput8 object. This rewrite should fix the dll count related issues. This patch needs linking again

Re: Moving menus to wineserver

2006-05-14 Thread Dimi Paun
On Sun, 2006-05-14 at 18:33 -0700, Dan Kegel wrote: > Hmm. Ulrich (Weigand, I presume) hasn't been active on the > wine list lately, so I'm cc'ing him on this... No, my bad, it's Ulrich Czekalla. -- Dimi Paun <[EMAIL PROTECTED]> Lattica, Inc.

Re: Moving menus to wineserver

2006-05-14 Thread Dan Kegel
On 5/14/06, Dimi Paun <[EMAIL PROTECTED]> wrote: > [ http://bugs.winehq.org/show_bug.cgi?id=5231 ] > This seems to be part of Dimi Paun's TODO list. It wasn't on my TODO, I was just keeping track of the task. Alexandre told me that Urlich had a patch about 2 years ago (at WineConf 2004), and he

Re: Moving menus to wineserver

2006-05-14 Thread Dimi Paun
On Sun, 2006-05-14 at 15:02 -0700, Dan Kegel wrote: > This seems to be part of Dimi Paun's TODO list. > Dimi, were you about to do this? If not, am I on the right track > here? It wasn't on my TODO, I was just keeping track of the task. Alexandre told me that Urlich had a patch about 2 years ago

Moving menus to wineserver

2006-05-14 Thread Dan Kegel
wineserver currently tracks a lot of info about windows (those things on the screen, not the operating system). It turns out (see http://bugs.winehq.org/show_bug.cgi?id=5231 ) that it probably needs to do the same thing for menus and menuitems to make the win32 apis GetMenuItemCount and GetMenuIte

Re: Still missing glyph

2006-05-14 Thread Huw Davies
On Sun, May 14, 2006 at 11:16:29PM +0200, Uwe Bonnes wrote: > even with a recent fontforge, I get "Missing glyph for": > LD_LIBRARY_PATH="../libs/unicode:$LD_LIBRARY_PATH" ../tools/sfnt2fnt > small_fonts.ttf 11 1253 96 128 5 > Missing glyph for char 0385 > ... > > Is this expected behaviour? Yes.

Still missing glyph

2006-05-14 Thread Uwe Bonnes
Hallo, even with a recent fontforge, I get "Missing glyph for": fontforge -script ../fonts/genttf.ff small_fonts.sfd small_fonts.ttf Copyright (c) 2000-2006 by George Williams. Executable based on sources from 19:18 13-Apr-2006. ../tools/widl/widl -I. -I. -I../include -I../include-h -H amstr

Re: Valgrind warning cleanup...

2006-05-14 Thread Dan Kegel
On 5/14/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > + memset( ldtent, 0, sizeof(*ldtent) ); /* Keep valgrind happy */ I'd never do anything like that (i.e. doing something where you have to put a comment besides that it's there to please lint, valgrind or what else code checkers ther

Re: widl: Added an option to set importlib search path.

2006-05-14 Thread Detlef Riekenberg
Hi Jacek: +" -L path Set importlib searcg dir to path (multiple -L Small typo in tools/widl/widl.c: "search" -- By By ... ... Detlef

Re: Valgrind warning cleanup...

2006-05-14 Thread leslie . polzer
On Sat, May 13, 2006 at 01:36:54PM -0700, Dan Kegel wrote: > There's another valgrind warning that is much more understandable, and > I'm sending an obvious fix for it to wine-patches. (My first patch > missed one instance, so I'm resending.) I'd appreciate it if you could > check that one, too. -

Re: gdi: Add WineGL driver interface and wrapper functions

2006-05-14 Thread Tomas Carnecky
... and here the patch diff --git a/dlls/gdi/driver.c b/dlls/gdi/driver.c index 9f40a8d..012d882 100644 --- a/dlls/gdi/driver.c +++ b/dlls/gdi/driver.c @@ -194,6 +194,33 @@ #define GET_FUNC(name) driver->funcs.p## GET_FUNC(StrokePath); GET_FUNC(SwapBuffers); GET_FUNC(Wide

Re: Quiet valgrind warnings in init_current_teb

2006-05-14 Thread Alexandre Julliard
"Mike Hearn" <[EMAIL PROTECTED]> writes: > ent is initialized here OK, it's correctly pointing to an LDT_ENTRY > struct on the stack. Valgrind is (presumably) complaining about > ent->HighWord.Bits.Granularity being tested before being assigned, but > that's wrong and is either a mistake in: > > a

Re: possible MCI deadlock

2006-05-14 Thread Eric Pouech
Damjan Jovanovic wrote: I've been looking at bug 3930 (http://bugs.winehq.org/show_bug.cgi?id=3930), where Heroes of might and magic basically hangs on a black screen when sound is enabled (and works when sound is disabled). It happens on all wine versions, the winedbg session below is from wine

Re: Quiet valgrind warnings in init_current_teb

2006-05-14 Thread Mike Hearn
On 5/14/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: Of course it is testing "ent" by accessing a member of it, thus dereferencing it. ent is initialized here OK, it's correctly pointing to an LDT_ENTRY struct on the stack. Valgrind is (presumably) complaining about ent->HighWord.Bits.Granu

Re: Quiet valgrind warnings in init_current_teb

2006-05-14 Thread leslie . polzer
On Sat, May 13, 2006 at 11:11:50PM +0100, Mike Hearn wrote: > if ((ent->HighWord.Bits.Granularity = (limit >= 0x10))) > > but unless I'm reading it wrong this is not testing ent before > initialization at all, it's testing limit, assigning to ent, then > testing the result of that assignment .

Re: comctl32[1/8]: header: don't check lpItem for NULL in GetItemT

2006-05-14 Thread MikoĊ‚aj Zalewski
You will need to split this patch into two. Checking for NULL has nothing to do with callback. Also I'm not sure why are you removing NULL check? Any explanations, tests? This patch is already split into eight parts - I hope thay are small enough. That's true the first patch doesn't have mu

Re: Valgrind warning cleanup...

2006-05-14 Thread Vassilis Virvilis
Dan Kegel wrote: On 5/13/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: I know this kind of errors from working on GNU Parted with Valgrind, and my policy is to leave the code alone when I can't spot why it should be wrong. I strongly advise against doing otherwise. I'll buy that. That

Re: Quiet valgrind warnings in init_current_teb

2006-05-14 Thread Eric Pouech
Mike Hearn wrote: Hmm, are you sure this isn't a bug in Valgrind itself? The code it's warning on is this: inline static void wine_ldt_set_limit( LDT_ENTRY *ent, unsigned int limit ) { if ((ent->HighWord.Bits.Granularity = (limit >= 0x10))) limit >>= 12; ent->LimitLow = (WORD)limit;