Re: Patch to limit testing results in AppDB

2006-01-25 Thread Chris Morgan
Oooh a new appdb hacker. Welcome :-) > // Show the Test results for a application version > function ShowVersionsTestingTable($iVersionId, $iCurrentTest, $link) > { The maximum number of versions to show should be a parameter to this function. > -$hResult = query_appdb("

Re: DINPUT: Enforce single mouse acquire

2006-01-25 Thread Dmitry Timoshkov
On Wed, 2006-01-25 at 19:11 -0500, Alex Villací­s Lasso wrote: > > But if you disallow nested acquires the check for This being NULL in > > the hook proc should not be needed, right? > > > > > Good point. But it doesn't hurt either. This might be changed into an > assertion, since that is what

Re: DINPUT: Enforce single mouse acquire

2006-01-25 Thread Alex Villací­s Lasso
Dmitry Timoshkov wrote: On Wed, 2006-01-25 at 18:19 -0500, Alex Villací­s Lasso wrote: The easiest way out of this (the one the patch implements) is to disallow nested acquires. It is a little more complicated if DirectInput actually requires support for nested acquires (why? I have only o

Re: DINPUT: Enforce single mouse acquire

2006-01-25 Thread Dmitry Timoshkov
On Wed, 2006-01-25 at 18:19 -0500, Alex Villací­s Lasso wrote: > The easiest way out of this (the one the patch implements) is to > disallow nested acquires. It is a little more complicated if DirectInput > actually requires support for nested acquires (why? I have only one > mouse...) But if

Re: DINPUT: Enforce single mouse acquire

2006-01-25 Thread Alex Villací­s Lasso
Dmitry Timoshkov wrote: On Wed, 2006-01-25 at 17:55 -0500, Alex Villací­s Lasso wrote: The problem is that if (This == NULL), then This->hook cannot be evaluated (for CallNextHookEx) without generating a segmentation fault. This is the very situation the patch is trying to prevent. S

Re: DINPUT: Enforce single mouse acquire

2006-01-25 Thread Dmitry Timoshkov
On Wed, 2006-01-25 at 17:55 -0500, Alex Villací­s Lasso wrote: > The problem is that if (This == NULL), then This->hook cannot be > evaluated (for CallNextHookEx) without generating a segmentation fault. > This is the very situation the patch is trying to prevent. Sorry for not spotting it earl

Re: DINPUT: Enforce single mouse acquire

2006-01-25 Thread Alex Villací­s Lasso
Dmitry Timoshkov wrote: On Wed, 2006-01-25 at 17:32 -0500, Alex Villací­s Lasso wrote: +if (This == NULL) { +ERR("mouse hook called with no current lock!\n"); +return 0; +} + if (code != HC_ACTION) return CallNextHookEx( This->hook, code, wparam, lparam );

Re: DINPUT: Enforce single mouse acquire

2006-01-25 Thread Dmitry Timoshkov
On Wed, 2006-01-25 at 17:32 -0500, Alex Villací­s Lasso wrote: > +if (This == NULL) { > +ERR("mouse hook called with no current lock!\n"); > +return 0; > +} > + > if (code != HC_ACTION) return CallNextHookEx( This->hook, code, wparam, lparam ); You need to call CallNe

Re: wine and jack => segfault? / wine and OSS not working

2006-01-25 Thread Eric Pouech
Joachim Förster wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Eric Pouech wrote: can you post a +winmm,+oss,+wave trace ? A trace of wine using OSS-output driver and oss2jack: that's because oss2jack doesn't provide a proper mixer interface does the attached patch help ? A+ -- Eric

Re: user: fix DrawTextExA/W on empty strings.

2006-01-25 Thread Dimi Paun
From: "Paul Vriens" <[EMAIL PROTECTED]> > But there's an if in between: > > if (count == -1) count = strlenW(str); Yeap, missed that one. Which proves that the code should be improved, since it managed to confuse 2 people already ;) -- Dimi Paun <[EMAIL PROTECTED]> Lattica, Inc.

Re: user: fix DrawTextExA/W on empty strings.

2006-01-25 Thread Paul Vriens
On Wed, 2006-01-25 at 14:03 -0500, Dimi Paun wrote: > From: "Rein Klazes" <[EMAIL PROTECTED]> > > Wrong, look again. > > You must be kidding. Care to explain how 'stmt' > can ever be executed in: > > ... >if (A || B) return; >if (B) stmt; > ... > But there's an if in between: if (count

Re: HW address w/o connection in iphlpapi

2006-01-25 Thread Michael Ost
On Wed, 2006-01-25 at 11:13 -0800, Juan Lang wrote: > I'm not the decider here, really. Alexandre is. While I'd like to see my > recent patch get in because it removes a lot of unnecessary junk from > ifenum.c and improves the situation for most people, it's not the end of > the story. Wine's po

Re: HW address w/o connection in iphlpapi

2006-01-25 Thread Juan Lang
> The function does seem to be provided by libc. And so the diff must be > in the implementations of that. Is there any precedent in Wine of making > a runtime decision based on the c library? Probably, but see below.. > Would you be OK with a patch that uses if_indextoname() only in the > specia

Re: HW address w/o connection in iphlpapi

2006-01-25 Thread Michael Ost
On Wed, 2006-01-25 at 10:42 -0800, Juan Lang wrote: > > > Although I don't like the idea of predefined limits :) I'll probably > > > > Me neither, which is why I used that prominent macro > > MOST_INTERFACES_IMAGINABLE. Can you even imagine a system with 50 (or > > 100?) ethernet interfaces? How

Re: user: fix DrawTextExA/W on empty strings.

2006-01-25 Thread Dimi Paun
From: "Rein Klazes" <[EMAIL PROTECTED]> > Wrong, look again. You must be kidding. Care to explain how 'stmt' can ever be executed in: ... if (A || B) return; if (B) stmt; ... -- Dimi Paun <[EMAIL PROTECTED]> Lattica, Inc.

Re: user: fix DrawTextExA/W on empty strings.

2006-01-25 Thread Rein Klazes
On Wed, 25 Jan 2006 07:49:57 -0800 (PST), you wrote: >Hi Rein, > >-if (!str) return 0; >+if (!str || count == 0) return 0; > if (count == -1) count = strlenW(str); >-if (count == 0) return 0; >+if (count == 0) { >+if( flags & DT_CALCRECT) { >+rect->right = r

Re: HW address w/o connection in iphlpapi

2006-01-25 Thread Juan Lang
> > Although I don't like the idea of predefined limits :) I'll probably > > Me neither, which is why I used that prominent macro > MOST_INTERFACES_IMAGINABLE. Can you even imagine a system with 50 (or > 100?) ethernet interfaces? How about an application that needs more than > 256K (showing my a

Re: HW address w/o connection in iphlpapi

2006-01-25 Thread Michael Ost
On Tue, 2006-01-24 at 21:44 -0800, Juan Lang wrote: > > Right. if_nameindex does not return eth0 if I boot up without an > > ethernet connection. Maybe this is a system dependent thing? > > I am running on a RH8 based system. > > Or a libc thing? I'm running on FC2. > > > The if_nameindex code l

commdlg patch

2006-01-25 Thread Turkin, Andrey
Hi! Here is quick&dirty (TM :) patch (against wine-0.9.6) that changes explorer-like Open/Save file dialogs to be more 3.11-like dialog/Windows compatible: 1) set view window control id to 1121 2) set inner list window control id to 1 instead of 2000 (anyone know why 2000 was chosen?) This

Re: Problems with references to drive Z: in registry's User Shell Folders

2006-01-25 Thread Michael Jung
On Wednesday 25 January 2006 17:36, Alexandre Julliard wrote: > Maybe what we should do is to always have the paths point into the c: > drive, and then play with symlinks at the Unix level to redirect > things to $HOME. This way it would keep working even if the drive > config is changed after the

Re: wine and jack => segfault? / wine and OSS not working

2006-01-25 Thread Joachim Förster
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Eric Pouech wrote: > can you post a +winmm,+oss,+wave trace ? A trace of wine using OSS-output driver and oss2jack: trace:winmm:DllMain 0x7ec3 0x1 0x1 trace:winmm:WINMM_CreateIData Initialized IData (0x7eca68c0) trace:winmm:MMDRV_Init () trace:wi

Re: Fwd: Re: Fwd: MBR was destroyed

2006-01-25 Thread Kuba Ober
> >> I was part of the disk group when my MBR was overwritten because I'd > >> been doing some work on the > >> drives and don't like sudo. Isn't it still a bug in wine that the MBR > >> was overwritten in the first > >> place, even if I'm in the disks group or running as root? If sudo is too much

Re: Problems with references to drive Z: in registry's User Shell Folders

2006-01-25 Thread Juan Lang
> Maybe what we should do is to always have the paths point into the c: > drive, and then play with symlinks at the Unix level to redirect > things to $HOME. This way it would keep working even if the drive > config is changed after the initial setup. I like this suggestion, though I'm hoping some

Re: Problems with references to drive Z: in registry's User Shell Folders

2006-01-25 Thread Alexandre Julliard
Juan Lang <[EMAIL PROTECTED]> writes: > I'm of the opinion that all this fancy CSIDL_PERSONAL mapping doesn't > belong in shell32, even though I put it there. shell32 should default to > creating paths that are part of the profiles directory if nothing else > exists, since the shell won't work wi

Re: Global hooks problems (WH_MOUSE_LL)

2006-01-25 Thread Dmitry Timoshkov
On Tue, 2006-01-24 at 23:50 -0700, Vitaliy Margolen wrote: > Attached is the small program to test part of this. Fixing problems (1) & > (2) made it work. But it still not enough for the game (for some reason). Vitaliy, could you transform hook_test.c to an appropriate Wine test suite while leav

Re: Problems with references to drive Z: in registry's User Shell Folders

2006-01-25 Thread Michael Jung
Hey Juan, On Wednesday 25 January 2006 17:03, you wrote: > > I'm proposing to add two more environment variables: %PERSONAL%, > > which would be expanded to the DOS path corresponding to $HOME if > > this exists, or to %USERPROFILE%\\My Documents if not (with "My > > Documents" resource based, of

Re: Problems with references to drive Z: in registry's User Shell Folders

2006-01-25 Thread Juan Lang
> when shell32.dll is registered during wineprefixcreate, it puts a > lot of paths based on Z:\ in HKLM/HKCU > Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\User > Shell Folders. This is due to resolving CIDL_PERSONAL to the DOS > path corresponding to $HOME. > > If people remove the Z:

Re: user: fix DrawTextExA/W on empty strings.

2006-01-25 Thread Juan Lang
Hi Rein, -if (!str) return 0; +if (!str || count == 0) return 0; if (count == -1) count = strlenW(str); -if (count == 0) return 0; +if (count == 0) { +if( flags & DT_CALCRECT) { +rect->right = rect->left; +rect->bottom = rect->top; +} +

Re: Can't compile with vc7: oleauto.h(229) : error C2719: 'function-parameter': formal parameter with __declspec(align('8')) won't be aligned

2006-01-25 Thread Alexandre Julliard
Dan Kegel <[EMAIL PROTECTED]> writes: > A UCLA student trying to compile wine conformance tests on Windows > ran into this: > >> [Compiling wine tests with VC7 or >> the server 2003 sdk gets] this error when compiling. >> >> ..\..\..\include\oleauto.h(229) : error C2719: 'function-parameter': >> f

Re: user32: make menu tests pass on Win 9x/ME -- RESENT

2006-01-25 Thread Alexandre Julliard
Rein Klazes <[EMAIL PROTECTED]> writes: > Changelog: > dlls/user : menu.c > dlls/user/tests : menu.c > > - make menu tests pass on Win9x/ME; > - rename the macro IS_STRING_ITEM to IS_STRING_ITEM_ONLY, which better > reflects what it is doing: absence of other item type flags. Yo

Re: CVS build error

2006-01-25 Thread Huw D M Davies
On Wed, Jan 25, 2006 at 02:37:09PM +0100, Peter Åstrand wrote: > > I can't build the CVS version anymore, I get: > > gcc -g -O2 -o widl client.o hash.o header.o proxy.o server.o typegen.o > typelib.o utils.o widl.o write_msft.o parser.tab.o lex.yy.o -L../../libs > -lwpp -lwine_port -lfl > ../..

CVS build error

2006-01-25 Thread Peter Åstrand
I can't build the CVS version anymore, I get: gcc -g -O2 -o widl client.o hash.o header.o proxy.o server.o typegen.o typelib.o utils.o widl.o write_msft.o parser.tab.o lex.yy.o -L../../libs -lwpp -lwine_port -lfl ../../libs/libwpp.a(lex.yy.o)(.text+0x624): In function `_yy_dummy_uses_of_stati

Re: d3d8: CreateDevice should try the parent if the current window fails

2006-01-25 Thread Jan Zerebecki
On Tue, Jan 24, 2006 at 08:36:15PM +0100, H. Verbeet wrote: > On 24/01/06, Jan Zerebecki <[EMAIL PROTECTED]> wrote: > > Changelog: > > d3d8: CreateDevice should try the parent if the current window fails > > because it doesn't have the property __wine_x11_whole_window . > > Fixes bug #4341 . > Does

RE: Global hooks problems (WH_MOUSE_LL)

2006-01-25 Thread Rolf Kalbermatter
Vitaliy Margolen [EMAIL PROTECTED] wrote: > So my question is to anyone who knows. What is the proper way > to deliver > these messages to global hooks that are in a different thread/process? Just an observation I did in a Windows program running under WinXP. Not sure if this is related somehow

Re: wine and jack => segfault? / wine and OSS not working

2006-01-25 Thread Francois Gouget
On Mon, 23 Jan 2006, Joachim Förster wrote: [...] some days ago I sent some mails to the wine-users list. My problem: the JACK output driver of wine does not work => wine segfaults; and the OSS output driver does not work, too. Windows Media Player (used for testing) says, it cannot find the audi

Problems with references to drive Z: in registry's User Shell Folders

2006-01-25 Thread Michael Jung
Hi, when shell32.dll is registered during wineprefixcreate, it puts a lot of paths based on Z:\ in HKLM/HKCU Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\User Shell Folders. This is due to resolving CIDL_PERSONAL to the DOS path corresponding to $HOME. If people remove the Z: drive