Re: advpack: Implement ExtractFiles

2006-01-10 Thread Mike McCormack
James Hawkins wrote: What is the policy about attaching changes to tests that pass because of a patch sent in? Should I also diff the tests? There's a higher level policy of "all changes should be atomic", which requires Wine to be in a working state before and after each change, so yes, y

Re: PATCH/RFC: defer OLE apartment window creation

2006-01-10 Thread Robert Shearman
Marcus Meissner wrote: On Wed, Dec 21, 2005 at 02:55:14AM +, Robert Shearman wrote: Marcus Meissner wrote: @@ -257,6 +254,15 @@ return apt; } +void make_apartment_window(APARTMENT *apt) { +if (apt->win) return; +if (!(apt->model & COINIT_APARTMENTTHREADED)) +ret

Regression caused by "ntdll: Check file size when mapping image sections to avoid SIGBUS errors."

2006-01-10 Thread Troy Rollo
On Wed, 4 Jan 2006 08:21, Alexandre Julliard wrote: > Module: wine > Branch: refs/heads/master > Commit: 67f2a36ce3725a52b79ed618964244cc96ae ... > status = STATUS_INVALID_IMAGE_FORMAT; /* generic error */ > +if (header_size > st.st_size) goto error; > if (map_file_into_view( vi

Re: ntdll/tests: Load test on win95 again

2006-01-10 Thread Vitaliy Margolen
Tuesday, January 10, 2006, 4:00:51 PM, Detlef Riekenberg wrote: > Am Dienstag, den 10.01.2006, 20:14 +0100 schrieb Alexandre Julliard: >> > - ntdll/tests: Load test on win95 again >> > (kernel32,CreateWaitableTimerA not present) >> >> A better fix would be to avoid the call completely, the ntdll

RFC: implementation of driver functionality in msacm

2006-01-10 Thread Alex Villací­s Lasso
This patch is the preliminary result of some work I have been doing in order to add missing functionality to builtin msacm32.dll. I am submitting this to wine-devel rather than wine-patches, and in one big patch rather than several because I would like comments on some choices I made while addi

Need help to fix a failing test

2006-01-10 Thread Kai Blin
Hi folks, As far as I can see, secur32 tests are failing on all windows platforms right now. (http://test.winehq.org/data/200601101000/) Now, this seems to be due to the following: main.c:475: Test failed: cbMaxToken for NTLM is 1904, not 12000. I'm pretty sure that I got the 12000 from my win2k

Re: ntdll/tests: Load test on win95 again

2006-01-10 Thread Detlef Riekenberg
Am Dienstag, den 10.01.2006, 20:14 +0100 schrieb Alexandre Julliard: > > - ntdll/tests: Load test on win95 again > > (kernel32,CreateWaitableTimerA not present) > > A better fix would be to avoid the call completely, the ntdll tests > shouldn't need to use kernel32 functions. I asked the Autho

Mozilla ActiveX Control -- Browser not in a valid state

2006-01-10 Thread Phil Lodwick
Hi, I have a Borland C++ Builder app that is a simple FORM with a TCppWebBrowser and a button. I have two callbacks, one when the form is created, and one when the user pushes the button. Both callbacks just navigate to google. __fastcall TForm1::TForm1(TCompone

Re: RESEND: winecfg: Added "Use PRIMARY selection" option

2006-01-10 Thread Alexandre Julliard
Phil Krylov <[EMAIL PROTECTED]> writes: > Initially I did it that way, but: > > 1) The X11 option page is named "Graphics", and clipboard is not > graphics ;) DXGrab is not really graphics either... maybe the page should be named "windowing" or something along those lines. > 2) There's no free

Re: RFC: implementation of driver functionality in msacm (RESEND)

2006-01-10 Thread Alex Villací­s Lasso
Eric Pouech wrote: Alex Villací­s Lasso wrote: Eric Pouech wrote: * Implementation of broadcasts to notification windows on driver add/remove, enabling/disabling, and priority changes - MSDN seems to state that differed notification is actually a counter, not a simple boolean (whereas e

Re: RESEND: winecfg: Added "Use PRIMARY selection" option

2006-01-10 Thread Phil Krylov
On Tue, 10 Jan 2006 20:23:20 +0100 Alexandre Julliard <[EMAIL PROTECTED]> wrote: > Phil Krylov <[EMAIL PROTECTED]> writes: > > > ChangeLog: > > > > Added support for "Use PRIMARY selection" clipboard option. > > I don't think we want a new property sheet page for that, it should go > with the ot

Re: WineDbg: Implemented harware assisted breakpoints.

2006-01-10 Thread Eric Pouech
Eric Pouech wrote: one can now set a hardware breakpoint in winedbg (it will not insert an INT 3 command in the code, but rather use the x86 debug registers). handy for debugging trashed code for example all the syntaxic forms of the 'break' command can be used for this new hbreak command. (o

Re: RFC: implementation of driver functionality in msacm (RESEND)

2006-01-10 Thread Alex Villací­s Lasso
Eric Pouech wrote: * Implementation of broadcasts to notification windows on driver add/remove, enabling/disabling, and priority changes - MSDN seems to state that differed notification is actually a counter, not a simple boolean (whereas enable/disable is a boolean) I have just read the MS

Re: RFC: implementation of driver functionality in msacm (RESEND)

2006-01-10 Thread Eric Pouech
Alex Villací­s Lasso wrote: (resent because previous attempt never appeared in wine-devel) This patch is the preliminary result of some work I have been doing in order to add missing functionality to builtin msacm32.dll. I am submitting this to wine-devel rather than wine-patches, and in one b

Re: Starter projects for new Wine contributors?

2006-01-10 Thread Detlef Riekenberg
Am Montag, den 09.01.2006, 21:02 -0500 schrieb Al Tobey: > > I'm looking for suggestions for starter projects for > > new contributors that would take something like a week to do, > > and wouldn't require much knowledge of Wine ahead of time. > Tests! Another way is: Fixing Tests, that currently

Re: Please read: Wine(HQ) needs a reorganization (AppDB, Bugzilla, etc.)

2006-01-10 Thread Lionel Ulmer
On Mon, Jan 09, 2006 at 08:42:06PM -0800, Scott Ritchie wrote: > Forums are absolutely a good idea. (...) > The reason is the same reason I post to these forums - they're > far more usable, well-sorted, and accessable than a mailing list. The problem is that (AFAIK) most if not all Wine developper

Re: static COM VTables?

2006-01-10 Thread Robert Shearman
Stefan Dösinger wrote: Hello, I just read the "constify data" todo, and I thought it would be good to make the VTables in my ddraw implementation const. The old ddraw implementation also declares them static. Is there any advantage in it? My C book just says that they can only be referenced

Re: Winelib debugging with eclipse in fc4

2006-01-10 Thread Michael Ost
On Sat, 2006-01-07 at 18:04 +0100, Eric Pouech wrote: > you could (not tested) alternatively: > - set winegdb --gdb as the name for executing gdb > - not reset the AeDebug key > - set the executable to be the real exec (+ .so extension if run from > the build tree) > that should work also > you wo

static COM VTables?

2006-01-10 Thread Stefan Dösinger
Hello, I just read the "constify data" todo, and I thought it would be good to make the VTables in my ddraw implementation const. The old ddraw implementation also declares them static. Is there any advantage in it? My C book just says that they can only be referenced from the local module, whi

Re: RESEND: winecfg: Added "Use PRIMARY selection" option

2006-01-10 Thread Alexandre Julliard
Phil Krylov <[EMAIL PROTECTED]> writes: > ChangeLog: > > Added support for "Use PRIMARY selection" clipboard option. I don't think we want a new property sheet page for that, it should go with the other X11 options. -- Alexandre Julliard [EMAIL PROTECTED]

Re: ntdll/tests: Load test on win95 again

2006-01-10 Thread Alexandre Julliard
Detlef Riekenberg <[EMAIL PROTECTED]> writes: > Changelog: > > - ntdll/tests: Load test on win95 again > (kernel32,CreateWaitableTimerA not present) A better fix would be to avoid the call completely, the ntdll tests shouldn't need to use kernel32 functions. -- Alexandre Julliard [EMAIL PROTEC

RFC: implementation of driver functionality in msacm (RESEND)

2006-01-10 Thread Alex Villací­s Lasso
(resent because previous attempt never appeared in wine-devel) This patch is the preliminary result of some work I have been doing in order to add missing functionality to builtin msacm32.dll. I am submitting this to wine-devel rather than wine-patches, and in one big patch rather than several

Re: Loader Optimization

2006-01-10 Thread Alexandre Julliard
Robert Shearman <[EMAIL PROTECTED]> writes: > What sort of tests do you want? I don't think I'll be able to come up > with anything that can be put into the Wine test framework. Agreed, it's probably not possible to put that in the test framework since it will need native dlls. All we really need

Re: Loader Optimization

2006-01-10 Thread Robert Shearman
Alexandre Julliard wrote: Robert Shearman <[EMAIL PROTECTED]> writes: ChangeLog: Optimize for the case where a DLL with no path is requested and it is already loaded. This change is correct since RtlDosSearchPath_U did not change the path being looked at - if libname contains no path then f

test exploit for WMF / SETABORTPROC vulnerability

2006-01-10 Thread Marcus Meissner
Hi, If someone needs an exploit for the WMF / SETABORTPROC vulnerability that works under WINE (<0.9.5) to verify fixed packages, feel free to mail me offline. Ciao, Marcus

Re: Please read: Wine(HQ) needs a reorganization (AppDB, Bugzilla, etc.)

2006-01-10 Thread n0dalus
On 1/10/06, Molle Bestefich <[EMAIL PROTECTED]> wrote: > > > Unfortunately it uses SQLite, which may not be able to effectively > > handle the huge needs of wine's bug tracking. It says they will try > > implement support for other sql servers in later versions, but > > currently it doesn't. > > Bu

Re: daily winetest generation

2006-01-10 Thread Paul Millar
On Monday 09 Jan 2006 21:50, Rolf Kalbermatter wrote: > Paul Millar wrote: > > The problem above (at the beginning of this year) was with a > > missing GUID in the compiler, which is now fixed. > > Could you tell me what GUID it was. Certainly, it was IID_IHttpNegotiate2, as defined by: DEFINE_GU

Re: Please read: Wine(HQ) needs a reorganization (AppDB, Bugzilla, etc.)

2006-01-10 Thread n0dalus
On 1/10/06, Molle Bestefich <[EMAIL PROTECTED]> wrote: > > Switch to Trac, for example. It will import your Bugzilla bugs in a > snap and you're ready to go. User friendly and much simpler and much > more consistent than Bugzilla. > http://projects.edgewall.com/trac/ > Trac looks interesting, bu

Re: COMCTL32: Invalidate the entire progress bar any time it changes.

2006-01-10 Thread Dmitry Timoshkov
"Mike McCormack" <[EMAIL PROTECTED]> wrote: This is an old patch, but the code that is in comctl32 now is wrong. This fixes it, and there's no known regressions. Unfortunately there's no way to fix this "efficiently". Mike ChangeLog: Invalidate the entire progress bar any time it changes.

Re: Loader Optimization

2006-01-10 Thread Alexandre Julliard
Robert Shearman <[EMAIL PROTECTED]> writes: > ChangeLog: > Optimize for the case where a DLL with no path is requested and it is > already loaded. This change is correct since RtlDosSearchPath_U did not > change the path being looked at - if libname contains no path then > file_part will be the sa

Loader Optimization Benchmarks

2006-01-10 Thread Robert Shearman
Hi, I thought it would be good to post some benchmarks for the patch I just sent to wine-patches: http://www.winehq.org/pipermail/wine-patches/2006-January/023323.html I tested the loader code using the following in both cases: int i; DWORD dwTicksAfter; DWORD dwTicksBefore = GetTickC

Re: JDK

2006-01-10 Thread Robert Shearman
Uwe Bonnes wrote: "Robert" == Robert Shearman <[EMAIL PROTECTED]> writes: Robert> Curro Amores wrote: >> I get this error when trying to install j2se with wine, i think is >> PE 0x004d-00522000 Deferred rpcrt4 PE 0x0068-0086c000 >> Deferred msi PE 0x65f0-6

Re: JDK

2006-01-10 Thread Uwe Bonnes
> "Robert" == Robert Shearman <[EMAIL PROTECTED]> writes: Robert> Curro Amores wrote: >> I get this error when trying to install j2se with wine, i think is >> PE 0x004d-00522000 Deferred rpcrt4 PE 0x0068-0086c000 >> Deferred msi PE 0x65f0-65fc2000 Deferred ole32

Re: JDK

2006-01-10 Thread Paul Vriens
> Curro Amores wrote: > >> I get this error when trying to install j2se with wine, i think is has >> something to do with windows installer, but ihave installed >> InstMSIA.exe manually with wine ( i dont get any error or see any >> installation box with "wine InstMSI.exe"). >> >> Has somebody trie

Re: JDK

2006-01-10 Thread Robert Shearman
Curro Amores wrote: I get this error when trying to install j2se with wine, i think is has something to do with windows installer, but ihave installed InstMSIA.exe manually with wine ( i dont get any error or see any installation box with "wine InstMSI.exe"). Has somebody tried to install JA

(no subject)

2006-01-10 Thread Curro Amores
I get this error when trying to install j2se with wine, i think is has something to do with windows installer, but ihave installed InstMSIA.exe manually with wine ( i dont get any error or see any installation box with "wine InstMSI.exe"). Has somebody tried to install JAva with wine? This is