Re: On creating 16bit windows convert null instances to current process

2005-12-31 Thread Joseph Garvin
Mike McCormack wrote: Typing too fast on IRC, probably ;) Dmitry is correct, it should be GlobalUnlock16(hTask). Mike Hmm, but then there are page faults. I'll have to take a closer look at task.c to see what's going on...

Re: On creating 16bit windows convert null instances to current process

2005-12-31 Thread Mike McCormack
Joseph Garvin wrote: Dmitry Timoshkov wrote: And GlobalUnlock(tdb) is not right at all, you want GlobalUnlock16(hTask). Mike walked me through the patch, I'm not sure what his reasoning was on unlocking tdb versus hTask. Typing too fast on IRC, probably ;) Dmitry is correct, it should be

re: ole db conformance tests

2005-12-31 Thread Dan Kegel
About three years ago, I wrote in http://www.winehq.org/hypermail/wine-devel/2003/01/0208.html : > Say, how close are these kinds of things to being able to run under wine? > http://msdn.microsoft.com/library/en-us/oledb/htm/testtoolsov.asp The MDAC SDK, downloadable from http://msdn.microsoft.co

Re: On creating 16bit windows convert null instances to current process

2005-12-31 Thread Joseph Garvin
Dmitry Timoshkov wrote: And GlobalUnlock(tdb) is not right at all, you want GlobalUnlock16(hTask). I resent it a second later with the 'x' fix. That does look more correct, but strangely the patch as is works. If I make your change the application I'm trying to fix gives this: err:heap:

re: What operating systems will Winelib run on non-x86 systems?

2005-12-31 Thread Dan Kegel
Hi Wei Li, last year, you asked in http://www.winehq.org/hypermail/wine-users/2004/06/0086.html > I could not find the info regarding what operating systems > (such as AIX 5L > v5.2, HP-UX 11i, Solaris Release Level > 9) will Winelib run on non-x86 > machines. I'll really > appreciate it if someo

Re: WININET: lpvStatusInfo in INTERNET_STATUS_NAME_RESOLVED, INTERNET_STATUS_CONNECTING_TO_SERVER, and INTERNET_STATUS_CONNECTED_TO_SERVER should be strings, not sockaddr_in.

2005-12-31 Thread Robert Shearman
Jacek Caban wrote: +/* FIXME: inet_ntoa is not thread safe. */ +szaddr = WININET_strdup_AtoW(inet_ntoa(lpwhs->socketAddress.sin_addr)); INTERNET_SendCallback(&lpwhr->hdr, lpwhr->hdr.dwContext, INTERNET_STATUS_NAME_RESOLVED, - &(lpwhs

Re: Finding patches in wine-cvs mailing list for regression tests using CVS dates

2005-12-31 Thread Daniel Calviño Sánchez
2005/12/31, Marcus Meissner <[EMAIL PROTECTED]>: > > Thanks a lot, this is the patch I was looking for. I'm going to fill a > > bug report now. > > Its already fixed in current CVS... I have just seen the fix. I tested with an updated CVS and it works fine again. Thanks for the help, and sorry fo

Re: Finding patches in wine-cvs mailing list for regression tests using CVS dates

2005-12-31 Thread Marcus Meissner
On Sat, Dec 31, 2005 at 03:48:16PM +0100, Daniel Calviño Sánchez wrote: > 2005/12/31, Marcus Meissner <[EMAIL PROTECTED]>: > > There is a CVS commit that has: > > revision 1.24 > > date: 2005-12-21 21:29:03 +0100; author: julliard; state: Exp; > > lines: +2 -0 > > Marcus

Re: [Darwine] Re: Preliminary CD-Rom support on MacOS X #2

2005-12-31 Thread emmanuel maillard
Thanks, i will take a look at git. Emmanuel Le 31 déc. 05 à 13:38, Pierre d'Herbemont a écrit : emmanuel maillard wrote: On 30 déc. 05, at 13:08, Robert Shearman wrote: I appreciate you splitting up your patches for easier review, but patches are meant to be independent atomic changes tha

Re: Finding patches in wine-cvs mailing list for regression tests using CVS dates

2005-12-31 Thread James Hawkins
On 12/31/05, Daniel Calviño Sánchez <[EMAIL PROTECTED]> wrote: > > But, where can the information about CVS commits be seen? Perhaps I > sound somewhat silly... but I can't find it. > I mean, I know where I can see the changes made to a specific file. > But I don't know where can I see a list with

Re: Finding patches in wine-cvs mailing list for regression tests using CVS dates

2005-12-31 Thread Daniel Calviño Sánchez
2005/12/31, Marcus Meissner <[EMAIL PROTECTED]>: > There is a CVS commit that has: > revision 1.24 > date: 2005-12-21 21:29:03 +0100; author: julliard; state: Exp; > lines: +2 -0 > Marcus Meissner <[EMAIL PROTECTED]> > msvcrt: Implemented wctime(), wasctime(). >

Re: [Darwine] Re: Preliminary CD-Rom support on MacOS X #2

2005-12-31 Thread Pierre d'Herbemont
emmanuel maillard wrote: On 30 déc. 05, at 13:08, Robert Shearman wrote: I appreciate you splitting up your patches for easier review, but patches are meant to be independent atomic changes that improve the code. However, if Alexandre applied this patch alone then Wine wouldn't compile an

Finding patches in wine-cvs mailing list for regression tests using CVS dates

2005-12-31 Thread Daniel CalviñoSánchez
Hello. First of all, I'm not sure if this message should be posted here, so sorry if it isn't the correct place. I found a regression and made some test to find the patch that caused the problem. I followed the "How to do regression testing using CVS" section in Wine documentation http://winehq.or

Re: Finding patches in wine-cvs mailing list for regression tests using CVS dates

2005-12-31 Thread Marcus Meissner
On Sat, Dec 31, 2005 at 01:45:04PM +0100, Daniel Calviño Sánchez wrote: > Hello. First of all, I'm not sure if this message should be posted > here, so sorry if it isn't the correct place. > > I found a regression and made some test to find the patch that caused > the problem. I followed the "How

Finding patches in wine-cvs mailing list for regression tests using CVS dates

2005-12-31 Thread Daniel Calviño Sánchez
Hello. First of all, I'm not sure if this message should be posted here, so sorry if it isn't the correct place. I found a regression and made some test to find the patch that caused the problem. I followed the "How to do regression testing using CVS" section in Wine documentation http://winehq.or

Re: On creating 16bit windows convert null instances to current process

2005-12-31 Thread Dmitry Timoshkov
"Joseph Garvin" <[EMAIL PROTECTED]> wrote: +/* Correct if instance is null now, because later we won't + be able to tell the difference between a 16-bit NULL and + a 32-bit NULL */ + +if (!instance) +{ +HTASK16 hTask = GetCurrentTask(); +TDB *tdb = Globa

Re: OLEAUT32: Use the FAILED macro to check for failure of interface methods.

2005-12-31 Thread Robert Shearman
Marcus Meissner wrote: On Sat, Dec 31, 2005 at 11:12:33AM +0900, Mike McCormack wrote: Robert Shearman wrote: These changes are wrong. IStream_Read can return S_FALSE, which means that the call was successful, but didn't do what was intended. From MSDN: S_FALSE The data cannot be r

Re: OLEAUT32: Use the FAILED macro to check for failure of interface methods.

2005-12-31 Thread Marcus Meissner
On Sat, Dec 31, 2005 at 11:12:33AM +0900, Mike McCormack wrote: > > Robert Shearman wrote: > > >These changes are wrong. IStream_Read can return S_FALSE, which means > >that the call was successful, but didn't do what was intended. From MSDN: > > > >S_FALSE > > The data cannot be read from the