Re: New trying to debug missing menubar

2005-12-27 Thread Joseph Garvin
So I've worked on this some more but I'm still stuck =) The +menu log shows a couple CreateMenu calls that I can immediately dismiss -- they're for the system menu (the one you get when you click the upper left box in the title bar). Using +win, there's a call to CreateWindowEx that passes a v

Re: SPARC assembly won't compile, problems with NT headers

2005-12-27 Thread Troy Rollo
On Fri, 23 Dec 2005 19:18, Alexandre Julliard wrote: > Troy Rollo <[EMAIL PROTECTED]> writes: > > This will work if (and only if) the value of SizeOfImage is unimportant > > for Winelib executables. Of course in that case there is probably some > > merit in setting it to zero anyway since at least

Re: URLMON: Removed not used code.

2005-12-27 Thread Jacek Caban
Troy Rollo wrote: Merely removing unused code does not give you any copyright in the file. On related matters, neither does fixing trivial bugs - there must be some substantial additional expression introduced to a file in order to give rise to a copyright claim. "Substantial" in this case mea

Re: URLMON: Removed not used code.

2005-12-27 Thread Troy Rollo
On Wed, 28 Dec 2005 03:45, Jacek Caban wrote: > @@ -3,6 +3,7 @@ > * > * Copyright 1999 Ulrich Czekalla for Corel Corporation > * Copyright 2002 Huw D M Davies for CodeWeavers > + * Copyright 2005 Jacek Caban for CodeWeavers > * > * This library is free software; you can redistribute it an

Re: exception.o - Undefined reference to NtCurrentTeb in CVS?

2005-12-27 Thread Evil
Robert Shearman wrote: > > Are you compiling with -O2? If not, then that is the reason why the > error is occuring for you, but not others (but still needs to be fixed). > You hit the nail on the head, Robert. I removed -O2 from my flags while troubleshooting a problem with a different project (f

Re: unixfs: Implemented WinXP style pidl-format

2005-12-27 Thread Michael Jung
Could you please ignore this patch. I'm experiencing some problems with it. I'll send a new version soon. On Tuesday 27 December 2005 16:44, Michael Jung wrote: > Changelog: > Store filenames in CP_ACP and WCHAR in the SHITEMIDs > Removed some wine_todo's for tests that now succeed >

Re: Patch for Bug 4159

2005-12-27 Thread Howard Selover III
Hello Ulrich, I debated where to place the fix since this is not a public documented function. At least I could not find documentation for the function. I decided to go with the location and type of return previously presented by the function. If the author/maintainer desires the other approac

Re: exception.o - Undefined reference to NtCurrentTeb in CVS?

2005-12-27 Thread Robert Shearman
Evil wrote: I commented out the three references to NtCurrentTeb in dlls/ntdll/tests/exception.c and WINE now compiles, installs, and runs fine. There's no CVS history for that file beyond the (current) 1.1 version, so I'm guessing an include or something has been missing ever since it was firs

Re: exception.o - Undefined reference to NtCurrentTeb in CVS?

2005-12-27 Thread Evil
I commented out the three references to NtCurrentTeb in dlls/ntdll/tests/exception.c and WINE now compiles, installs, and runs fine. There's no CVS history for that file beyond the (current) 1.1 version, so I'm guessing an include or something has been missing ever since it was first added on the

Re: Patch for Bug 4159

2005-12-27 Thread Ulrich Czekalla
I don't think this should fail if size equals 0. This function is also used by StgStreamImpl_Read and it shouldn't fail if it reads 0 bytes. I think a better place to fix it is in the SmallBlocksToBigBlocks() loop. /Ulrich On Mon, Dec 26, 2005 at 09:26:58AM -0500, Howard Selover III wrote: > Cha

[Bug 3095] ID Collisions in menus

2005-12-27 Thread Ann & Jason Edmeades
Hiya, I've found my changes for this other bug, which also relates to the menu code are wrong, and am trying to work out how to identify how windows does it. The problem is that there is a menu item with the same id as a popup menu. In all the tests for all the calling functions, windows will re