Re: PATCH: GlobalAddAtomA check for invalid ptr

2005-08-14 Thread Marcus Meissner
On Sun, Aug 14, 2005 at 10:27:20PM +0200, Felix Nawothnig wrote: > Marcus Meissner wrote: > >>Yes, but please don't use the IsBad* functions, use a proper exception > >>handler. > >Next try, is this what you imagined. > > The reason for using an exception handler is thread safety - to achieve > t

Re: WINEALSA: comment on unexpected shrinking of mmap-buffer (resend)

2005-08-14 Thread Robert Reif
Alex Villací­s Lasso wrote: Alex Villací­s Lasso wrote: The good news: the patch sort of works (in my setup, at least, with Fedora Core 4). All the games I have (Japanese RPGs) now have smooth sound, unless the CPU load is too high. The bad news: the patch does nothing to make the dsound te

Re: AppDB - set default comments mode to threaded for new users

2005-08-14 Thread Tony Lambregts
Chris Morgan wrote: Chris Morgan <[EMAIL PROTECTED]> include/user.php Set default comments mode to threaded for new users Index: include/user.php === RCS file: /opt/cvs-commit/appdb/include/user.php,v retrieving revision 1.46 diff

Re: MSHMTL: Added QueryStatus implementation

2005-08-14 Thread Saulius Krasuckas
* On Sun, 14 Aug 2005, Jacek Caban wrote: > * Saulius Krasuckas wrote: > > > > Is something like this OK? I have "borrowed" boolean variable > > expect_SetActiveObject_active. > > Yes, it looks good. Does that mean by a chance it can to wine-patches? :-)

Wine book

2005-08-14 Thread Christian Britz
Hi, some days ago someone wrote a mail to this list regarding a book that he or she is writing about wine. Unfortunately I lost this mail, could the person please contact me privately? Regards, Christian

Re: PATCH: GlobalAddAtomA check for invalid ptr

2005-08-14 Thread Felix Nawothnig
Marcus Meissner wrote: Yes, but please don't use the IsBad* functions, use a proper exception handler. Next try, is this what you imagined. The reason for using an exception handler is thread safety - to achieve that you have to put it around the ATOM_AddAtomA call. Felix

Re: MSHMTL: Added QueryStatus implementation

2005-08-14 Thread Jacek Caban
Saulius Krasuckas wrote: * On Sun, 14 Aug 2005, Jacek Caban wrote: I'm not sure if it is a correct fix. Although it avoids crashes, much less functionality of QueryStatus is tested. Before your patch all possible commands were tested. This is true only for nt family windows. :-P On

Re: World of Warcraft

2005-08-14 Thread Jacob Emcken
Hi, [EMAIL PROTECTED] wrote: It's me again. The latest WoW patch (1.5.1) broke stuff again, and now I'm unable to click on anything outside of menu items in game. The issue seems to be related to camera angle, as I am able to click on items/people when I have my camera positioned just right

Re: MSHMTL: Added QueryStatus implementation

2005-08-14 Thread Saulius Krasuckas
* On Sun, 14 Aug 2005, Saulius Krasuckas wrote: > * On Sun, 14 Aug 2005, Jacek Caban wrote: > > > > Presently if you want to make this test not to crash, you may disable > > IOleCommand tests if UIActivate fails. Is something like this OK? I have "borrowed" boolean variable expect_SetActiveObj

Re: MSHMTL: Added QueryStatus implementation

2005-08-14 Thread Saulius Krasuckas
* On Sun, 14 Aug 2005, Jacek Caban wrote: > > I'm not sure if it is a correct fix. Although it avoids crashes, > much less functionality of QueryStatus is tested. Before > your patch all possible commands were tested. This is true only for nt family windows. :-P On 9x test function exits on an

Re: Regression in DVD Shrink

2005-08-14 Thread Jonathan Ernst
Some more informations. Wine version: 20050725 The problem seems to be related with css encrypted discs. Scenarios: A: 1)put an unencrypted disc and mount it 2)run dvd shrink and open the disc => success B: 1)put a css encrypted disc and mount it 2)run dvd shrink and open the disc => failure C

Re: RichEdit flicker

2005-08-14 Thread Phil Krylov
On Sat, 13 Aug 2005 18:51:06 +0400 Phil Krylov <[EMAIL PROTECTED]> wrote: > > The paragraph structure should include not MEPF_REWRAP and MEPF_REPAINT > > flags, but indexes of rows from which to start re-wrapping and repainting > > (e.g. nStartRewrap and nStartRepaint). The wrapping routine should

Re: MSHMTL: Added QueryStatus implementation

2005-08-14 Thread Jacek Caban
Hello. Saulius Krasuckas wrote: * On Tue, 2 Aug 2005, Jacek Caban wrote: --- dlls/mshtml/tests/htmldoc.c 26 Jul 2005 10:31:23 - 1.5 +++ dlls/mshtml/tests/htmldoc.c 1 Aug 2005 22:33:37 - @@ -806,12 +806,76 @@ static void test_Persist() } } +static OLECMDF expect_cmds[OLECMD

Re: PATCH: GlobalAddAtomA check for invalid ptr

2005-08-14 Thread Marcus Meissner
On Thu, Aug 11, 2005 at 02:52:52PM +0200, Alexandre Julliard wrote: > Marcus Meissner <[EMAIL PROTECTED]> writes: > > > So ... now we can: > > > > - fix this program by contacting the developers etc... which is difficult. > > - fix WINE by adding a check. > > > > I can only fix WINE. > > Yes, but

Re: MSHMTL: Added QueryStatus implementation

2005-08-14 Thread Saulius Krasuckas
* On Sun, 14 Aug 2005, Saulius Krasuckas wrote: > * On Tue, 2 Aug 2005, Jacek Caban wrote: > > > > +hres = IOleCommandTarget_QueryStatus(cmdtrg, NULL, 0, NULL, NULL); > > +ok(hres == S_OK, "QueryStatus failed: %08lx\n", hres); > > + > > +hres = IOleCommandTarget_QuerySt

Re: MSHMTL: Added QueryStatus implementation

2005-08-14 Thread Saulius Krasuckas
* On Tue, 2 Aug 2005, Jacek Caban wrote: > > --- dlls/mshtml/tests/htmldoc.c 26 Jul 2005 10:31:23 - 1.5 > +++ dlls/mshtml/tests/htmldoc.c 1 Aug 2005 22:33:37 - > @@ -806,12 +806,76 @@ static void test_Persist() > } > } > > +static OLECMDF expect_cmds[OLECMDID_GETPRINTTEMPLATE+