AppDB - allow maintainers to process submitted screenshots and application versions

2005-08-02 Thread Chris Morgan
This patch should offload a little bit of the work involved in being an appdb admin by allowing maintainers and super maintainers to process screenshots submitted for applications they maintain or supermaintain, or to process submitted versions for applications they super maintain. Any comments on

Re: commctrl: rebar theming

2005-08-02 Thread Frank Richter
On 03.08.2005 00:38, Robert Shearman wrote: > You have added this field, but don't use it apart from in a commented > out line. It's used in theme_changed(). But the commented out line is a mistake. -f.r.

Re: commctrl: rebar theming

2005-08-02 Thread Frank Richter
On 03.08.2005 00:38, Robert Shearman wrote: > You have added this field, but don't use it apart from in a commented > out line. Hm, that's not how it's supposed to be. Gotta check again. -f.r.

Re: commctrl: rebar theming

2005-08-02 Thread Robert Shearman
Frank Richter wrote: @@ -184,6 +186,7 @@ HFONThFont; /* handle to the rebar's font */ SIZE imageSize; /* image size (image list) */ DWORDdwStyle; /* window style */ +DWORDorgStyle;/* original style (dwStyle may change) */ SIZE calcSize;

WRT: Links and Timeout

2005-08-02 Thread Detlef Riekenberg
Hi Francois and Paul. On the WRT-Page "http://www.astro.gla.ac.uk/users/paulm/WRT/wrt.php";, the link for "current status of Wine's conformance tests" is dead ("http://fgouget.free.fr/wine/tests-en.shtml";). Do you think, some Download-Links to "http://www.astro.gla.ac.uk/users/paulm/WRT/CrossBui

Re: test case demonstrating PeekMessage give up timeslices

2005-08-02 Thread Jeremy White
I dug into this a bit further. Felix, the extra 100 yields are coming from code I prompted, in ntdll/sync.c; if the return from an NtWait... is TIMEOUT, then we force a yield. (The thread that points to more info is here: http://www.winehq.org/hypermail/wine-devel/2005/01/0469.html) If I back tha

Re: DSOUND: prevent assertion in mixer.c

2005-08-02 Thread Alex Villací­s Lasso
Felix Nawothnig wrote: Since the error of "length not a multiple of block size" is nonfatal, Yes it is fatal. Errors mean that something which should not have happened did happen - and we're not talking about something the API is supposed to handle... there is wrong code in Wine, internal

Re: DSOUND: prevent assertion in mixer.c

2005-08-02 Thread Felix Nawothnig
Alex Villací­s Lasso wrote: I guess this is preluded by some "length not a multiple of block size" errors? I've been experiencing those errors with the same failed assertion in another game and came up with a similar patch but didn't submit since I think this just hides another bug as it should

Re: DSOUND: prevent assertion in mixer.c

2005-08-02 Thread Alex Villací­s Lasso
Felix Nawothnig wrote: Alex Villací­s Lasso wrote: wine-pthread: mixer.c:386: DSOUND_MixInBuffer: Assertion `adjusted_remainder >= 0' failed. wine: Unhandled exception (thread 000a), starting debugger... WineDbg starting on pid 0x8 I guess this is preluded by some "length not a multiple of

Re: Move Win16 relay messages to the relay16 channel

2005-08-02 Thread Alexandre Julliard
Uwe Bonnes <[EMAIL PROTECTED]> writes: > RelayFromInclude doesn't follow CreateProcess, if I understand things right... Not sure what you mean, it's in the registry so child processes will certainly use the same options. -- Alexandre Julliard [EMAIL PROTECTED]

Re: Move Win16 relay messages to the relay16 channel

2005-08-02 Thread Uwe Bonnes
> "Felix" == Felix Nawothnig <[EMAIL PROTECTED]> writes: Felix> Uwe Bonnes wrote: Felix> How about implementing magic values like %native% and %win16% for Felix> it then? "option-like" debug channels seem very unintuitive to Felix> me... Good idea! Go ahead with implementing

Re: Move Win16 relay messages to the relay16 channel

2005-08-02 Thread Felix Nawothnig
Uwe Bonnes wrote: Why? When you're debugging 16bit programs, sometimes you only want to see 16bit calls.:) Isn't your proposal similar to the recent "nrelay" proposal, where only calls from native code is logged, but not wine code calling other wine code? Why exactly do we need this (both nrel

Re: Move Win16 relay messages to the relay16 channel

2005-08-02 Thread Uwe Bonnes
> "Felix" == Felix Nawothnig <[EMAIL PROTECTED]> writes: Felix> Uwe Bonnes wrote: Why? >>> When you're debugging 16bit programs, sometimes you only want to see >>> 16bit calls.:) >> Isn't your proposal similar to the recent "nrelay" proposal, where >> only calls fr

Re: Move Win16 relay messages to the relay16 channel

2005-08-02 Thread Felix Nawothnig
Uwe Bonnes wrote: Why? When you're debugging 16bit programs, sometimes you only want to see 16bit calls.:) Isn't your proposal similar to the recent "nrelay" proposal, where only calls from native code is logged, but not wine code calling other wine code? Why exactly do we need this (both nre

Re: test case demonstrating PeekMessage give up timeslices

2005-08-02 Thread Alexandre Julliard
Felix Nawothnig <[EMAIL PROTECTED]> writes: > I meant that using shm generally would lower the cost of a server > request and doing that extra yield would no longer be necessary > (although we'd still have the other yield due to the request itself > unless the queue is put into shm). If you mean

Re: DSOUND: prevent assertion in mixer.c

2005-08-02 Thread Felix Nawothnig
Alex Villací­s Lasso wrote: wine-pthread: mixer.c:386: DSOUND_MixInBuffer: Assertion `adjusted_remainder >= 0' failed. wine: Unhandled exception (thread 000a), starting debugger... WineDbg starting on pid 0x8 I guess this is preluded by some "length not a multiple of block size" errors? I've

Re: test case demonstrating PeekMessage give up timeslices

2005-08-02 Thread Felix Nawothnig
I wrote: since a server call is much more expensive than a Windows system call. Would using shm fix that? No, you don't want to put the message queue in shared memory, that's not reliable. shm + kernel handles for synchronization then? Wait, putting the message queue into shm isn't what I wa

Re: test case demonstrating PeekMessage give up timeslices

2005-08-02 Thread Alexandre Julliard
Jeremy White <[EMAIL PROTECTED]> writes: > But I have to admit I'm bothered; you seem to be refusing > a patch that makes Wine more correct. > > PeekMessage() is more lightweight on Windows than it is on Wine, but > I can still write bad code that chokes the system by spin looping on > PeekMessage

Re: test case demonstrating PeekMessage give up timeslices

2005-08-02 Thread Felix Nawothnig
Alexandre Julliard wrote: since a server call is much more expensive than a Windows system call. Would using shm fix that? No, you don't want to put the message queue in shared memory, that's not reliable. shm + kernel handles for synchronization then? Felix

Re: Help debugging GLXUnsupportedPrivateRequest failure

2005-08-02 Thread Oliver Stieber
--- Alex Villací­s Lasso <[EMAIL PROTECTED]> wrote: It looks like you running mesa which should work, I've just sent in a patch that fixes a problem I' getting which is very similar to yours '[x11drv] backout d3d-stencil-support-os-2'. This may correct the problem you are having. > Joseph Garvi

Re: test case demonstrating PeekMessage give up timeslices

2005-08-02 Thread Jeremy White
Alexandre Julliard wrote: > Felix Nawothnig <[EMAIL PROTECTED]> writes: > > >>But then that "extra" NtYieldExecution should not depend on >>!PM_NOYIELD since PM_NOYIELD doesn't have any effect on Windows, right? > > > It has an effect for Win16 apps, they need to release the Win16 > lock. We co

Re: Help debugging GLXUnsupportedPrivateRequest failure

2005-08-02 Thread Alex Villací­s Lasso
Joseph Garvin wrote: I've had problems with Fedora not supporting random extensions that every other linux distro does since Core 2 that have never been fixed. I'm guessing they use some patchset that screws things up. If all else fails, try installing xorg manually from source. Oliver Stieb

Re: test case demonstrating PeekMessage give up timeslices

2005-08-02 Thread Alexandre Julliard
Felix Nawothnig <[EMAIL PROTECTED]> writes: > But then that "extra" NtYieldExecution should not depend on > !PM_NOYIELD since PM_NOYIELD doesn't have any effect on Windows, right? It has an effect for Win16 apps, they need to release the Win16 lock. We could add a yield in the PM_NOYIELD case, bu

Re: pf_vsnprintf implementatnion of 'I', 'I32' and 'I64' prefixes for type specifiers

2005-08-02 Thread David Laight
On Tue, Aug 02, 2005 at 10:35:59PM +0900, Mike McCormack wrote: > > It's a little more complicated than you think, after you start handling > all the width modifiers, various floating point formats, etc. Not to mention coding in the 'brokenness'! On windows: _snprintf(buff, 3, "ab" ) returns 2

Re: [wined3d] texture state sepeartion part3

2005-08-02 Thread Oliver Stieber
--- Jesse Allen <[EMAIL PROTECTED]> wrote: > On 8/2/05, Oliver Stieber <[EMAIL PROTECTED]> wrote: > > Hi, > > This patch moves the setting of states from device to basetexture, states > > that relate to the > > opengl texture object will only be updated when they are out of sync, this > > red

Re: test case demonstrating PeekMessage give up timeslices

2005-08-02 Thread Felix Nawothnig
Alexandre Julliard wrote: So, PeekMessage always yields execution (it shouldn't) with PM_NOYIELD specified it yields execution twice (although it shouldn't at all). PeekMessage is going to call the server and wait on the result, there's no way around it. The extra yield is to avoid hammering the

Re: test case demonstrating PeekMessage give up timeslices

2005-08-02 Thread Alexandre Julliard
Felix Nawothnig <[EMAIL PROTECTED]> writes: > (The numbers slightly differ between runs for obvious reasons but they > are close enough (with an error margin of +/- 10 we could maybe make > this a real testcase)) > > So, PeekMessage always yields execution (it shouldn't) with PM_NOYIELD > specifie

Re: test case demonstrating PeekMessage give up timeslices

2005-08-02 Thread Felix Nawothnig
I wrote: So, PeekMessage always yields execution (it shouldn't) with PM_NOYIELD specified it yields execution twice (although it shouldn't at all). Err, that should read "and without PM_NOYIELD specified". Felix

Re: test case demonstrating PeekMessage give up timeslices

2005-08-02 Thread Felix Nawothnig
Alexandre Julliard wrote: You can probably fix it by passing PM_NOYIELD in the PeekMessage calls. But if your app needs a lot of CPU, restructuring the code to avoid all the needless polling would give much better results, and probably improve the behavior on Windows too. That's just a workarou

Re: [wined3d] texture state sepeartion part3

2005-08-02 Thread Jesse Allen
On 8/2/05, Oliver Stieber <[EMAIL PROTECTED]> wrote: > Hi, > This patch moves the setting of states from device to basetexture, states > that relate to the > opengl texture object will only be updated when they are out of sync, this > reduces the number of > texture object state changes during

broken installers

2005-08-02 Thread Ivan Leo Puoti
Microsoft is giving out, free of charge and with free posting, visual studio 2005 beta 2. I received my copy today, I got a CD with visual studio 2005 team suite, a DVD with visual studio 2005 team foundation server, and a CD with sql server 2005 developer edition community technology preview.

Re: WLDAP32: tests for ldap_err2string{A,W} and LdapMapErrorToWin32 (#2)

2005-08-02 Thread Hans Leidekker
On Tuesday 2 August 2005 16:30, Alexandre Julliard wrote: > I don't see any point in testing the actual strings. Surely no code is > going to rely on the exact string contents. OK, fair enough. I had written it to get at the strings, but I agree it has limited value in detecting regressions. -H

Re: Remove Win16 CurrentDirectory hack

2005-08-02 Thread Alexandre Julliard
Richard Cohen <[EMAIL PROTECTED]> writes: > The Win32 CurrentDirectory is more likely to be correct, and this > fixes some Win16 installers. No it's not correct, the current directory needs to be per-task for Win16 apps. -- Alexandre Julliard [EMAIL PROTECTED]

Re: WLDAP32: tests for ldap_err2string{A,W} and LdapMapErrorToWin32 (#2)

2005-08-02 Thread Alexandre Julliard
Hans Leidekker <[EMAIL PROTECTED]> writes: > This patch restricts the ldap_err2string tests to a specific thread locale. > > -Hans > > Changelog > Tests for ldap_err2string{A,W} and LdapMapErrorToWin32. I don't see any point in testing the actual strings. Surely no code is going to rely on the

Re: getting the path to .wine

2005-08-02 Thread Alexandre Julliard
Ivan Leo Puoti <[EMAIL PROTECTED]> writes: > What's the best way/way usually used in wine to get the full path to .wine? wine_get_config_dir. -- Alexandre Julliard [EMAIL PROTECTED]

Re: test case demonstrating PeekMessage give up timeslices

2005-08-02 Thread Alexandre Julliard
Oliver Mössinger <[EMAIL PROTECTED]> writes: > Hi wine-devel, > > attached i have a test case whitch demonstates the differece between Windows > and wine. There is also a sample program 'TEST.CPP' attached. > > On Windows XP > - Start 'test.exe' from a dos-box... you see some FAST counting intege

Re: pf_vsnprintf implementatnion of 'I', 'I32' and 'I64' prefixes for type specifiers

2005-08-02 Thread Jonathan Wilson
> Feel free to go ahead and write one if you like :) One assumes ReactOS needs such a function, how do they do it? Would getting the ReactOS guys to re-licence as LGPL (if such a thing is even possible) their printf base code work? (is what they have even any use?) Just a thought :)

Re: Esound support

2005-08-02 Thread Tom Wickline
On 8/1/05, Peter Åstrand <[EMAIL PROTECTED]> wrote: > > Hi. This patch implements Esound sound support. See > http://bugs.winehq.com/show_bug.cgi?id=326 for details. Can it be applied? > > Index: ChangeLog > === > RCS file: /home/win

Re: pf_vsnprintf implementatnion of 'I', 'I32' and 'I64' prefixes for type specifiers

2005-08-02 Thread Mike McCormack
Jonathan Wilson wrote: Question: Why doesnt WINE just have a complete implementation of the core "printf" logic itself? It's a little more complicated than you think, after you start handling all the width modifiers, various floating point formats, etc. Feel free to go ahead and write one

getting the path to .wine

2005-08-02 Thread Ivan Leo Puoti
What's the best way/way usually used in wine to get the full path to .wine? Ivan.

Re: pf_vsnprintf implementatnion of 'I', 'I32' and 'I64' prefixes for type specifiers

2005-08-02 Thread Jonathan Wilson
Question: Why doesnt WINE just have a complete implementation of the core "printf" logic itself? With all the differences between "printf" as defined in ANSI C and as is present on the systems WINE runs on (i.e. linux, darwin, solaris, BSD etc) and "printf" as implemented by Microsoft in their

Re: MSXML3: initial implementation based on libxml2

2005-08-02 Thread Andreas Mohr
Hi, On Tue, Aug 02, 2005 at 05:39:48PM +0900, Mike McCormack wrote: > > This patch is a start on msxml3. More implementation to follow. Nice! I need that one... Andreas

Re: WLDAP32: tests for ldap_err2string{A,W} and LdapMapErrorToWin32

2005-08-02 Thread Hans Leidekker
On Tuesday 2 August 2005 06:52, Dmitry Timoshkov wrote: > > +static const char* WLDAP32_error[] = { > > +"Success", > > This test won't work on a not english locale once somebody adds > translations for another language. You either need to prevent > the test from running on locales different

Re: ownerdraw paint recursion in listbox

2005-08-02 Thread Alexander Yaworsky
Dmitry Timoshkov wrote: While browsing my old not answered e-mails I've found this one. Does the attached patch help? It restricts the control to draw outside of the item rect but not the whole control rect as it currently does. No, it does not help. trace.bz2 Description: Binary data