Re: Try 2:Implement IOCTL_SCSI_GET_INQUIRY_DATA

2005-07-27 Thread Dmitry Timoshkov
"Vitaliy Margolen" <[EMAIL PROTECTED]> wrote: > Check for HAVE_SG_IO_HDR_T_INTERFACE_ID instead of defined Linux > +static NTSTATUS GetInquiryData(int fd, PSCSI_ADAPTER_BUS_INFO BufferOut, > DWORD OutBufferSize) > +{ > +PSCSI_INQUIRY_DATA inquirydata = NULL; > +sg_io_hdr_t iocmd;

Re: Version

2005-07-27 Thread Marcus Meissner
On Wed, Jul 27, 2005 at 11:31:03AM +0200, jstrupeni wrote: > Hello, > I'm using a Novell Linux Desktop Version 9 and I don't know which > version of Wine I should install. The SUSE Linux 9.1 version. Ciao, Marcus

Re: Benchmark's on the Wiki

2005-07-27 Thread Tom Wickline
On 7/27/05, Paul Vriens <[EMAIL PROTECTED]> wrote: > Hi Tom, Hello Paul, > > maybe it's an idea to put the WinXP and Wine results next to each other, > to have some immediate idea of the differences. Okay, I'll try to do this by Saturday. > Maybe even add a diff column showing how well/bad we

Re: Another AppDB screenshot problem...

2005-07-27 Thread James Liggett
Hi Tony, Thanks so much for looking into this. Hope it gets fixed soon ;-) James On Wed, 2005-07-27 at 21:35 -0600, Tony Lambregts wrote: > James Liggett wrote: > > Hi, > > Tonight I tried to submit a shot for Palm Desktop 4.1 and it gave me > > this error: > > > > Unable to move screenshot from

Re: Another AppDB screenshot problem...

2005-07-27 Thread Tony Lambregts
James Liggett wrote: Hi, Tonight I tried to submit a shot for Palm Desktop 4.1 and it gave me this error: Unable to move screenshot from to data/screenshots/originals/781 What's going on? I can confirm this (I cannot upload a screenshot either) Chris and I are not sure what is going on here.

Re: patch for libs/wine/mmap.c making wine running on FreeBSD 5.x

2005-07-27 Thread Dmitry Timoshkov
"jean-marc DETREZ" <[EMAIL PROTECTED]> wrote: > @@ -207,6 +207,13 @@ void *wine_anon_mmap( void *start, size_ > #elif defined(__svr4__) || defined(__NetBSD__) || defined(__APPLE__) > if ( try_mmap_fixed( start, size, prot, flags, fdzero, 0 ) ) > return start; > +#elif define

Re: Implement IOCTL_SCSI_GET_INQUIRY_DATA

2005-07-27 Thread Dmitry Timoshkov
"Vitaliy Margolen" <[EMAIL PROTECTED]> wrote: > +static NTSTATUS GetInquiryData(int fd, PSCSI_ADAPTER_BUS_INFO BufferOut, > DWORD OutBufferSize) > +{ > +PSCSI_INQUIRY_DATA inquirydata = NULL; > +sg_io_hdr_t iocmd; > +UCHAR inquiry[INQ_CMD_LEN] = {INQUIRY, 0, 0, 0, INQ_REPLY_LEN, 0}; >

Re: [wined3d] support get vertexdeclaration with pnumelements set to zero

2005-07-27 Thread Mitchell Mebane
Oliver Stieber wrote: With the patch this time --- Oliver Stieber <[EMAIL PROTECTED]> wrote: Hi, This patch returns all elements when getDeclaration is called with pnumelements set to 0. This fixes bugs in Teeage mutant ninja turtles and The Increadibles.

Version

2005-07-27 Thread jstrupeni
Hello, I have a Novell Linux Desktop Version 9 and I don't know what version of Wine I should install. Thank you very much in advance. Juan

Version

2005-07-27 Thread jstrupeni
Hello, I'm using a Novell Linux Desktop Version 9 and I don't know which version of Wine I should install. Thank you very much in advance, Juan

Re: Benchmark's on the Wiki

2005-07-27 Thread Anssi Hannula
Tom Wickline wrote: Hello, I put the Benchmark results that I posted to wine-devel back in April on the Wiki. http://wiki.winehq.org/BenchMark I would appreciate any constitutive criticism to improve this page. I think it would be easier to read if the wine and xp results were side-to-side i

Re: wine/dlls/ntdll loadorder.c

2005-07-27 Thread Rein Klazes
On 27 Jul 2005 16:37:18 +0200, you wrote: > Rein Klazes <[EMAIL PROTECTED]> writes: > > > Girotel uses a 32 bit comm.dll located in the programs directory, which > > is also the current directory. After this change I need to add an dll > > override to load the program's comm.dll and not attempt t

Re: Benchmark's on the Wiki

2005-07-27 Thread Paul Vriens
On Wed, 2005-07-27 at 00:49, Tom Wickline wrote: > Hello, > > I put the Benchmark results that I posted to wine-devel back in April > on the Wiki. > http://wiki.winehq.org/BenchMark > > I would appreciate any constitutive criticism to improve this page. > > Tom > > > Hi Tom, maybe it's an id

Re: Fix Using DDraw to Access the Desktop

2005-07-27 Thread Lionel Ulmer
On Wed, Jul 27, 2005 at 04:33:29PM +0100, Robert Shearman wrote: > I'm pretty sure Windows NT doesn't allow you to have direct access to > the video memory so surely Windows must be doing it like this too? > How do you suggest to fix the problem? The only way I could think of would be to lock the

Re: [wined3d] support get vertexdeclaration with pnumelements set to zero

2005-07-27 Thread Oliver Stieber
With the patch this time --- Oliver Stieber <[EMAIL PROTECTED]> wrote: > Hi, > This patch returns all elements when getDeclaration is called with > pnumelements set to 0. This fixes bugs in Teeage mutant ninja turtles and The > Increadibles. > > > > > > _

Re: How to pass / convert file names?

2005-07-27 Thread Stefan Dösinger
> > This sounds interesting to me. I will be pleased to test your program > > with Nautilus (the Gnome equivalent to Konqueror). I will search for > > your submission on the ML archives, if you have a newer version please > > tell me how to get it. > > Compiled and works fine with KDE (didn't have

Re: bugs #3148 - Still in wine-20050725

2005-07-27 Thread Hiji
--- Andreas Mohr <[EMAIL PROTECTED]> wrote: > Hi, > > On Mon, Jul 25, 2005 at 02:31:58PM -0700, Hiji > wrote: > > Can anyone help out with this bug? It's still in > > existence in the July Wine release. > OK, I've added a comment. > > Andreas Mohr > Thanks for taking the time to look into thi

Re: hhctrl: Add the WebBrowser implementation

2005-07-27 Thread James Hawkins
On 7/27/05, James Hawkins <[EMAIL PROTECTED]> wrote: > Hey, > > This patch includes these changes: > * no more HH_* macros, no more hhctrl.h > * uses proper ref counting > * stores pointers instead of using ptr arithmetic > * IOleClientSiteImpl frees itself so there is no mem leak > * uses the ICO

Re: Theming & code duplication

2005-07-27 Thread Robert Shearman
Frank Richter wrote: Hi, somewhat recently I sent some code to wine-patches to add button theming; if you have glanced at it, despite utilizing subclassing, code was duplicated from the button code in user. In particular, the themed button does its own state management. The reason is that upon

Re: Fix Using DDraw to Access the Desktop

2005-07-27 Thread Robert Shearman
Alexandre Julliard wrote: Robert Shearman <[EMAIL PROTECTED]> writes: Previously, using ddraw to write to a small area of the desktop (or even none at all) would cause the screen to go black because the contents of the screen wasn't copied to the surface before the surface was copied back t

Re: Fix Using DDraw to Access the Desktop

2005-07-27 Thread Alexandre Julliard
Robert Shearman <[EMAIL PROTECTED]> writes: > Previously, using ddraw to write to a small area of the desktop (or > even none at all) would cause the screen to go black because the > contents of the screen wasn't copied to the surface before the surface > was copied back to the screen. This patch

Re: Const Function Parameters?

2005-07-27 Thread Felix Nawothnig
Andreas Mohr wrote: While I'm not too convinced in this case (1.5% improvement sounds like within statistic noise), it should be a good idea to mark things in Wine const whenever possible (objdump -x helps here), since it improves reliability Huh? He did stuff like... -void foo(int i) +void fo

Re: dlls/winmm/winealsa/midi.c: Bug in MIDI_CMD_BENDER fixed

2005-07-27 Thread Felix Nawothnig
Johannes Koch wrote: No, you don't. The bitwise shifting operator has a higher precedence than the bitwise or does. In case you didn't know... $ man 7 operator is your friend. :-) Felix

Re: wine/dlls/ntdll loadorder.c

2005-07-27 Thread Alexandre Julliard
Rein Klazes <[EMAIL PROTECTED]> writes: > Girotel uses a 32 bit comm.dll located in the programs directory, which > is also the current directory. After this change I need to add an dll > override to load the program's comm.dll and not attempt the built-in > comm.drv, which of course is not needed

Re: hhctrl: Add the WebBrowser implementation

2005-07-27 Thread Alexandre Julliard
"Dmitry Timoshkov" <[EMAIL PROTECTED]> writes: > Right, I think that const pointer is not what James had in mind, > but a const area pointed out by a pointer. No, the pointer is constant, not the object itself. That's the same ICOM_THIS_MULTI macro that's used at a gazillion other places. -- Al

Re: RICHED20: TODO list additions

2005-07-27 Thread Kuba Ober
On Friday 22 July 2005 11:41, Dmitry Timoshkov wrote: > "Phil Krylov" <[EMAIL PROTECTED]> wrote: > > Added some missing but useful items to the RichEdit TODO list. > > > > + * - full justification > > + * - hyphenation > > + * - tables > > What kind of hyphenation richedit needs? Would an automatic

Re: Reimplement EnumDateFormats, make it work for all available locales

2005-07-27 Thread Dmitry Timoshkov
"Paul Vriens" <[EMAIL PROTECTED]> wrote: -BOOL WINAPI EnumDateFormatsA( DATEFMT_ENUMPROCA lpDateFmtEnumProc, LCID Locale, DWORD dwFlags) +BOOL WINAPI EnumDateFormatsA(DATEFMT_ENUMPROCA proc, LCID lcid, DWORD flags) Why did you change the names ? I thought we sticked to the MSDN ones ? We st

Re: hhctrl: Add the WebBrowser implementation

2005-07-27 Thread Dmitry Timoshkov
"Alexandre Julliard" <[EMAIL PROTECTED]> wrote: > +#define ICOM_THIS_MULTI(impl,field,iface) impl* const This=(impl*)((char*)(iface) - offsetof(impl,field)) IMO using 'const' before the type looks more natural. Also adding 'const' to all type conversions wouldn't hurt: const impl* This = (con

Re: wine/dlls/ntdll loadorder.c

2005-07-27 Thread Rein Klazes
On Thu, 7 Jul 2005 13:26:11 -0500, you wrote: > ChangeSet ID: 18748 > CVSROOT: /opt/cvs-commit > Module name: wine > Changes by: [EMAIL PROTECTED] 2005/07/07 13:26:11 > > Modified files: > dlls/ntdll : loadorder.c > > Log message: > Use the same defaults for module

Re: Benchmark's on the Wiki

2005-07-27 Thread Oliver Stieber
--- Tom Wickline <[EMAIL PROTECTED]> wrote: > On 7/26/05, Mitchell Mebane <[EMAIL PROTECTED]> wrote: > > I'd be interested to see how 3DMark05 runs. Do Oliver's patches support it > > yet? > > Back in April 3DMark05 would install and load but there was a lack of > Pixel Shader 2.0 > support, s

Re: crypt32: Re: exception handling, part 2

2005-07-27 Thread Kuba Ober
> > > + tooBig[] = { 0x02, 0x84, 0x0f, 0xff, 0xff, 0xfc }; > > > + tooBig[] = { 0x02, 0x84, 0xff, 0xff, 0xff, 0xfc }; > > > | encode.c:313: Test failed: Expected CRYPT_E_ASN1_LARGE, got 80093106 > > > > That's CRYPT_E_ASN1_MEMORY, meaning out of memory. Weird, it must try to > > allocate this much

Theming & code duplication

2005-07-27 Thread Frank Richter
Hi, somewhat recently I sent some code to wine-patches to add button theming; if you have glanced at it, despite utilizing subclassing, code was duplicated from the button code in user. In particular, the themed button does its own state management. The reason is that upon state changes, the user3

Report request. Wine20050725 Configuration error

2005-07-27 Thread Ivan Lezhnev, Jr.
> configure: WARNING: GL/glx.h: present but cannot be compiled > configure: WARNING: GL/glx.h: check for missing prerequisite headers? > configure: WARNING: GL/glx.h: see the Autoconf documentation > configure: WARNING: GL/glx.h: section "Present But Cannot Be Compiled" > configure: WARNING

Re: Automatic ANSI<>Unicode message translation

2005-07-27 Thread Filip Navara
Troy Rollo wrote: On Wednesday 27 July 2005 18:40, Dmitry Timoshkov wrote: I also disassembled kernel32.dll to see how it populated CP_ACP (if I recall correctly it populated it from a registry key under either HKEY_CURRENT_CONFIG or HKEY_LOCAL_MACHINE, so perhaps a change in the r

Re: Reimplement EnumDateFormats, make it work for all available locales

2005-07-27 Thread Paul Vriens
> Hello, > > Changelog: > Dmitry Timoshkov <[EMAIL PROTECTED]> > - Reimplement EnumDateFormats, make it work for all available locales. > - Add a test for EnumDateFormats > ... > -BOOL WINAPI EnumDateFormatsA( DATEFMT_ENUMPROCA lpDateFmtEnumProc, LCID > Locale, DWORD dwFlags) > +BOOL W

Re: Add ShellExecute() conformance tests

2005-07-27 Thread Francois Gouget
Saulius Krasuckas wrote: [...] One test fails on my box: [...] | shlexec.c:275: Test failed: ShellExecute(null, "C:\windows\temp\\test_shortcut_shlexec.lnk", null, null) failed: rc=31 err=0 The thing is that it fails on my box too which is why I had it marked as todo when I submited the pat

Re: hhctrl: Add the WebBrowser implementation

2005-07-27 Thread Alexandre Julliard
"Dmitry Timoshkov" <[EMAIL PROTECTED]> writes: > "James Hawkins" <[EMAIL PROTECTED]> wrote: > > > +#define ICOM_THIS_MULTI(impl,field,iface) impl* const > > This=(impl*)((char*)(iface) - offsetof(impl,field)) > > IMO using 'const' before the type looks more natural. Also adding 'const' > to all

Re: Automatic ANSI<>Unicode message translation

2005-07-27 Thread Alexandre Julliard
Troy Rollo <[EMAIL PROTECTED]> writes: > On the other hand SendMessageA of any character to an A window procedure > (regardless of any DBCS rules that might apply) ought to pass the character > through immediately. > > This means that ideally, if the window is not a unicode window, then there

Re: Const Function Parameters?

2005-07-27 Thread Andreas Mohr
Hi, On Tue, Jul 26, 2005 at 11:08:12PM -0400, Michael Carlson wrote: > I agree, the compiler should realise the parameters aren't used as an > l-value in the function anywhere - but it apparently doesn't, or > marking the parameters const is having some other effect on the binary > - with gcc 4.0.

Re: Automatic ANSI<>Unicode message translation

2005-07-27 Thread Troy Rollo
On Wednesday 27 July 2005 19:22, Filip Navara wrote: > Actually it affects the CP_THREAD_ACP code page, but not CP_ACP. Interesting. I wasn't previously aware of this. It isn't used anywhere in Wine (it's returned, but nothing ever calls a routine with CP_THREAD_ACP). I suspect not a whole lot

Re: Automatic ANSI<>Unicode message translation

2005-07-27 Thread Troy Rollo
On Wednesday 27 July 2005 18:40, Dmitry Timoshkov wrote: >> > I also disassembled > > kernel32.dll to see how it populated CP_ACP (if I recall correctly it > > populated it from a registry key under either HKEY_CURRENT_CONFIG or > > HKEY_LOCAL_MACHINE, so perhaps a change in the registry could caus

Re: Const Function Parameters?

2005-07-27 Thread Michael Carlson
On 7/26/05, Troy Rollo <[EMAIL PROTECTED]> wrote: > On Wed, 27 Jul 2005 09:25, Felix Nawothnig wrote: > > There is no need to make anything except the pointers const - I don't > > think I've ever seen that in real world code. In theory this would give > > the compiler slightly more information... b

Re: Automatic ANSI<>Unicode message translation

2005-07-27 Thread Dmitry Timoshkov
"Troy Rollo" <[EMAIL PROTECTED]> wrote: > > Did you test specifically A->W conversion of the message data or something > > else? > > I tested the CP_ACP conversions and the GetACP call. Actually you didn't answer the question. GetACP() by itself shows nothing, only actual API tests could show so

Re: dlls/winmm/winealsa/midi.c: Bug in MIDI_CMD_BENDER fixed

2005-07-27 Thread Johannes Koch
No, you don't. The bitwise shifting operator has a higher precedence than the bitwise or does. You may test it with this programm: #include int main(int agrc, char** argv) { int iTest = 0x42 << 7 | 0x02; int iTest1 = (0x42 << 7) | 0x02; int iTest2 = 0x42 << (7 | 0x02); printf("iTest

Re: Automatic ANSI<>Unicode message translation

2005-07-27 Thread Troy Rollo
On Wednesday 27 July 2005 18:16, Dmitry Timoshkov wrote: > Did you test specifically A->W conversion of the message data or something > else? I tested the CP_ACP conversions and the GetACP call. I also disassembled kernel32.dll to see how it populated CP_ACP (if I recall correctly it populated

Re: hhctrl: Add the WebBrowser implementation

2005-07-27 Thread Dmitry Timoshkov
"James Hawkins" <[EMAIL PROTECTED]> wrote: > +#define ICOM_THIS_MULTI(impl,field,iface) impl* const > This=(impl*)((char*)(iface) - offsetof(impl,field)) IMO using 'const' before the type looks more natural. Also adding 'const' to all type conversions wouldn't hurt: const impl* This = (const im

Re: Automatic ANSI<>Unicode message translation

2005-07-27 Thread Dmitry Timoshkov
"Troy Rollo" <[EMAIL PROTECTED]> wrote: > Locale doesn't affect the A->W translation. I know that is counter-intuitive > and it surprised me when I found out (and verified) this. The system dialogs > where you can change these things tend to obscure this. Did you test specifically A->W conversi