Re: dlls/winmm/winealsa/midi.c: Bug in MIDI_CMD_BENDER fixed

2005-07-26 Thread Marcus Meissner
On Tue, Jul 26, 2005 at 11:52:55PM +0200, Johannes Koch wrote: > The pitch value was wrongly converted and has to be centered around zero. > > Changelog >Fixed pitch bending in the alsa midi driver. > > ? patch.diff > Index: dlls/winmm/winealsa/midi.c > ==

Re: Automatic ANSI<>Unicode message translation

2005-07-26 Thread Troy Rollo
On Wed, 27 Jul 2005 15:28, Dmitry Timoshkov wrote: > Take into account that threads can belong to different processes. Another > thing that we may want to take into account (that needs a test though) is > whether a thread locale affects the translation. Locale doesn't affect the A->W translation.

Re: Add ShellExecute() conformance tests

2005-07-26 Thread Marcelo Duarte
Saulius Krasuckas escreveu: * On Fri, 22 Jul 2005, Francois Gouget wrote: So the goal of this conformance test is to at least get things started and to test a few sticking points like putting quotes around the One test fails on my box: In my box it pass(1). | $ make -C dlls/shel

Re: Automatic ANSI<>Unicode message translation

2005-07-26 Thread Dmitry Timoshkov
"Troy Rollo" <[EMAIL PROTECTED]> wrote: > Locales don't affect the ANSI code page - that is determined either at boot > time or by the most recent call of the process to SetGlobalCP (NT only). I > could write a test for this, but I won't have time to do it until about a > week from now. Take i

Re: Automatic ANSI<>Unicode message translation

2005-07-26 Thread Troy Rollo
On Wed, 27 Jul 2005 13:20, Dmitry Timoshkov wrote: > "Troy Rollo" <[EMAIL PROTECTED]> wrote: > > This means that ideally, if the window is not a unicode window, then > > there should be no A->W->A translation. > > What is the source and target threads are running in different locales? > That's the

Re: Add ShellExecute() conformance tests

2005-07-26 Thread Saulius Krasuckas
* On Fri, 22 Jul 2005, Francois Gouget wrote: > > So the goal of this conformance test is to at least get things started > and to test a few sticking points like putting quotes around the One test fails on my box: | $ make -C dlls/shell32/tests/ test | make: Entering directory `/mnt/antras/usr

Re: Automatic ANSI<>Unicode message translation

2005-07-26 Thread Dmitry Timoshkov
"Troy Rollo" <[EMAIL PROTECTED]> wrote: > This means that ideally, if the window is not a unicode window, then there > should be no A->W->A translation. What is the source and target threads are running in different locales? That's the point in conversion to unicode for the interthread PostMessa

Re: Benchmark's on the Wiki

2005-07-26 Thread Tom Wickline
On 7/26/05, Mitchell Mebane <[EMAIL PROTECTED]> wrote: > I'd be interested to see how 3DMark05 runs. Do Oliver's patches support it > yet? Back in April 3DMark05 would install and load but there was a lack of Pixel Shader 2.0 support, so none of the test would run. http://www.futuremark.com/pro

Re: Benchmark's on the Wiki

2005-07-26 Thread Mitchell Mebane
Tom Wickline wrote: Hello, I put the Benchmark results that I posted to wine-devel back in April on the Wiki. http://wiki.winehq.org/BenchMark I would appreciate any constitutive criticism to improve this page. Tom . I'd be interested to see how 3DMark05 runs. Do Oliver's patches

Re: Const Function Parameters?

2005-07-26 Thread Troy Rollo
On Wed, 27 Jul 2005 09:25, Felix Nawothnig wrote: > There is no need to make anything except the pointers const - I don't > think I've ever seen that in real world code. In theory this would give > the compiler slightly more information... but if the optimizer is unable > to figure out that the par

Re: [wined3d] pbuffer support

2005-07-26 Thread Ivan Gyurdiev
> I expect this is caused by states not being in sync between the pbuffer and > old buffer, or > textures not being loaded properly... I've just sent in a patch that should > correct the latter. Re-tested HL2 today, pbuffer white screen regression is gone.

Re: Const Function Parameters?

2005-07-26 Thread Felix Nawothnig
Michael Carlson wrote: I've also found that marking a couple of parameters of that function const (that I believe should be marked const anyways), CPU usage in that function drops measurably with oprofile. As far as I know, parameters that aren't modified in a function should be marked const anyw

Re: How to pass / convert file names?

2005-07-26 Thread Christian Britz
Christian Britz wrote: > Stefan Dösinger wrote: >> I've also written a small C program which scans the registry and >> creates .desktop files for each mime type found. I've sent a first alpha >> version to this list late June. With these .desktop files in place you can >> just click on the fil

Benchmark's on the Wiki

2005-07-26 Thread Tom Wickline
Hello, I put the Benchmark results that I posted to wine-devel back in April on the Wiki. http://wiki.winehq.org/BenchMark I would appreciate any constitutive criticism to improve this page. Tom

Re: Automatic ANSI<>Unicode message translation

2005-07-26 Thread Troy Rollo
On Tue, 26 Jul 2005 17:31, Dmitry Timoshkov wrote: > > What about the character codes which can't be converted? > > A->W conversion doesn't have that problem That is not necessarily true. A DBCS lead byte without a valid trail byte will result in failure in an A->W conversion. In fact translatin

Const Function Parameters?

2005-07-26 Thread Michael Carlson
I've been doing some oprofille tests with wine running fce ultra, the 8-bit Nintendo emulator. I found that when running a rom for 60 seconds, more than 99% of the CPU utilization for winex11drv (which uses the most of all components of wine in this case) is in the same function : convert_888_to_08

Re: How to test a win16 application in our test-suite

2005-07-26 Thread Jakob Eriksson
Steven Edwards wrote: --- Paul Vriens <[EMAIL PROTECTED]> wrote: I'm busy fixing up version.dll, and I want to create some tests to read resources from win16 applications. I currently have a fixed .exe in my tests directory, but I'd like to create a 16bit .exe (or .dll) during the creation o

Re: cross-compiling for ARM

2005-07-26 Thread Steven Edwards
Hi John, --- John Connor <[EMAIL PROTECTED]> wrote: > Has anyone tried to cross-compile Wine for the ARM platform or is there > any documentation on how to do this? I have but its been a day or two. You need two trees and to first build the Wine tools for your host platform and something like th

cross-compiling for ARM

2005-07-26 Thread John Connor
Has anyone tried to cross-compile Wine for the ARM platform or is there any documentation on how to do this? This is an e-mail from General Dynamics Robotic Systems. It is for the intended recipient only and may contain confidential and

Re: How to pass / convert file names?

2005-07-26 Thread Christian Britz
Dear Stefan, Stefan Dösinger schrieb: > Try this script: > > #!/bin/bash > document=`winepath -l "$1"` > exec wine start.exe "$document" Marvellous! This is exactly the solution I need. :-) Maybe I should have been able to guess better what the "path" in winepath actually stands for... ;-) > I

Adding a new include file (softpub.h)

2005-07-26 Thread Paul Vriens
Hi, for a patch to wintrust_main.c I need to define a GUID (WINTRUST_ACTION_GENERIC_VERIFY_V2). This GUID is present in softpub.h. The include file is not included in Wine right now. What are the 'rules' to add a new include file? Is it ok that have only this GUID in there ? Cheers, Paul. P.S.

Re: commctrl: modularize progress drawing

2005-07-26 Thread Dimi Paun
From: "Felix Nawothnig" <[EMAIL PROTECTED]> > > It has become the norm lately to not have the ALLCAPS_ prefix > > for internal static functions, but rather have names_with_underscores > > to easily tell them apart from Win32 APIs. > > > > So for the above, I guess get_led_size() would be preferabl

Re: commctrl: modularize progress drawing

2005-07-26 Thread Felix Nawothnig
Dimi Paun wrote: It has become the norm lately to not have the ALLCAPS_ prefix for internal static functions, but rather have names_with_underscores to easily tell them apart from Win32 APIs. So for the above, I guess get_led_size() would be preferable. I thought the only half-official rule wo

Re: commctrl: modularize progress drawing

2005-07-26 Thread Dimi Paun
From: "Frank Richter" <[EMAIL PROTECTED]> > Frank Richter <[EMAIL PROTECTED]> > Split up the drawing code into a set of smaller functions and also moved > some common computations into helper functions. All that to facilitate > the implementation of the forthcoming theming support. > +static inl

Re: How to pass / convert file names?

2005-07-26 Thread Stefan Dösinger
> One solution would probably be to write a wrapper script that translates > the path name before it is passed to wine. One discussion board entry I > found indicates the CrossOver plugin does it that way. Try this script: #!/bin/bash document=`winepath -l "$1"` exec wine start.exe "$document" I

How to pass / convert file names?

2005-07-26 Thread Christian Britz
Hi, I discovered only recently a problem which is probably quite prevalent, but I could not find the answer on the web. Example: I want to configure Mozilla for opening .DOC files with the free Word Viewer that can be downloaded at http://www.microsoft.com. To do so I go to Edit -> Preferences ->

Re: [wintrust] Return TRUST_E_PROVIDER_UNKNOWN for WinVerifyTrust

2005-07-26 Thread Rein Klazes
On Mon, 25 Jul 2005 21:28:27 +0200, you wrote: > > Hi Rein, > > could you try the attached patch. It's a hack and we probably need an > implementation of softpub.h. I just want to make sure Girotel doesn't > use the same ActionID Yes that works. Here is the Girotel's output: | fixme:wintrust:Wi

Re: [wined3d] regression

2005-07-26 Thread Oliver Stieber
--- Raphael <[EMAIL PROTECTED]> wrote: > On Monday 25 July 2005 19:47, Robert Shearman wrote: > > Oliver Stieber wrote: > > >Following this patch > > > http://www.winehq.org/hypermail/wine-patches/2005/07/0575.html wined3d > > > SegV's every time the dll is loaded. > > > > One bug is that GetModu

Re: [wined3d] per app settings regression

2005-07-26 Thread Oliver Stieber
--- Raphael <[EMAIL PROTECTED]> wrote: > On Monday 25 July 2005 20:41, Oliver Stieber wrote: > > Hi, > > This patch corrects a regression issue in > > http://www.winehq.org/hypermail/wine-patches/2005/07/0575.html > > > > Hi > > You just sent the sme patch :) > Maybe you forgot to attach the go

Re: Automatic ANSI<>Unicode message translation

2005-07-26 Thread Dmitry Timoshkov
"Phil Krylov" <[EMAIL PROTECTED]> wrote: Oh sorry. For some reason I thought that HIWORD(wParam) is used for some other data. Here is a new patch, is it ok? Looks good to me, let's see if Alexandre likes it as well. -- Dmitry.

Re: wine installation for Debian

2005-07-26 Thread David Goodenough
Khe Siang Tan wrote: > Hi > > just wondering if someone could help mei am > running Debian operating systemand i am trying to > install/run WINE.i have typed the command $apt-get > install wine in root user. > > KHE:/home/zhe# apt-get install wine > Reading Package Lists... Done > Bu

Re: objsel: Add stubs for objsel.dll and objsel.h

2005-07-26 Thread Alexandre Julliard
Thomas Weidenmueller <[EMAIL PROTECTED]> writes: > Thomas Weidenmueller wrote: > > The attached archive contains a stubbed objsel.dll and it's public > > header file objsel.h > > Any comments why it got rejected? I'd appreciate if you could send a proper patch instead of a zip file. -- Alexand

Re: Automatic ANSI<>Unicode message translation

2005-07-26 Thread Phil Krylov
Hi Dmitry, On Tue, 26 Jul 2005 16:56:31 +0900 "Dmitry Timoshkov" <[EMAIL PROTECTED]> wrote: > The key word is "the whole" wparam. So, there is no need to truncate it > by using LOWORD. Oh sorry. For some reason I thought that HIWORD(wParam) is used for some other data. Here is a new patch, is it

Windows API

2005-07-26 Thread Bennie Kahler-Venter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Anyone saw the article in June's Dr. Dobb's Journal, July 95 titled "Finding Binary Clones with Opstrings & Function Digests: Part I" by Andrew Schulman http://www.undoc.com Although just the first article, It already shows promise from wine's perspec

Re: hhctrl: Add the WebBrowser implementation

2005-07-26 Thread Dmitry Timoshkov
"James Hawkins" <[EMAIL PROTECTED]> wrote: > +#define HH_Alloc(size) ((LPVOID)HeapAlloc(GetProcessHeap(), > HEAP_ZERO_MEMORY, size)) > + > +#define HH_Free(buffer) \ > +if (buffer) \ > +HeapFree(GetProcessHeap(), 0, (HLOCAL)buffer); Alot of work has been done to avoid tests for NULL

Re: Automatic ANSI<>Unicode message translation

2005-07-26 Thread Dmitry Timoshkov
"Phil Krylov" <[EMAIL PROTECTED]> wrote: > > One solution is to translate the whole wparam. > > How do you see it? Example: I do a > > PostMessageA(hwndAnsi, WM_CHAR, 0xF301, 0); > > map_wparam_AtoW takes the "\x01\xF3" string, translates it to Unicode via > CP_ACP (for CP1251, this would be p

Re: bugs #3148 - Still in wine-20050725

2005-07-26 Thread Andreas Mohr
Hi, On Mon, Jul 25, 2005 at 02:31:58PM -0700, Hiji wrote: > Can anyone help out with this bug? It's still in > existence in the July Wine release. OK, I've added a comment. Andreas Mohr

Re: Automatic ANSI<>Unicode message translation

2005-07-26 Thread Phil Krylov
On Tue, 26 Jul 2005 16:31:50 +0900 "Dmitry Timoshkov" <[EMAIL PROTECTED]> wrote: > "Phil Krylov" <[EMAIL PROTECTED]> wrote: > > > > This patch is not correct. All messages which potentially go through > > > wineserver > > > should be posted/sent via unicode. > > > > OK, then how you would sugge

Re: Automatic ANSI<>Unicode message translation

2005-07-26 Thread Dmitry Timoshkov
"Dmitry Timoshkov" <[EMAIL PROTECTED]> wrote: > > What about the character codes which can't be converted? > > A->W conversion doesn't have that problem, A->W translation either if Of course the last A->W should be read as W->A, i.e.: "W->A translation either if ..." -- Dmitry.

Another AppDB screenshot problem...

2005-07-26 Thread James Liggett
Hi, Tonight I tried to submit a shot for Palm Desktop 4.1 and it gave me this error: Unable to move screenshot from to data/screenshots/originals/781 What's going on? Thanks a lot, James Liggett

Re: Automatic ANSI<>Unicode message translation

2005-07-26 Thread Dmitry Timoshkov
"Phil Krylov" <[EMAIL PROTECTED]> wrote: > > This patch is not correct. All messages which potentially go through > > wineserver > > should be posted/sent via unicode. > > OK, then how you would suggest to solve the problem described in previous > messages of this thread? One solution is to tra

Re: Automatic ANSI<>Unicode message translation

2005-07-26 Thread Phil Krylov
On Tue, 26 Jul 2005 16:04:22 +0900 "Dmitry Timoshkov" <[EMAIL PROTECTED]> wrote: > This patch is not correct. All messages which potentially go through > wineserver > should be posted/sent via unicode. OK, then how you would suggest to solve the problem described in previous messages of this thr

Re: Automatic ANSI<>Unicode message translation

2005-07-26 Thread Dmitry Timoshkov
"Phil Krylov" <[EMAIL PROTECTED]> wrote: > Translate Unicode<->ANSI message wParams only when window type > (ANSI/Unicode) does not match message handling function postfix > (PeekMessageA/W etc.). This patch is not correct. All messages which potentially go through wineserver should be posted/sen