Re: PATCH: gcc4 alias fixes

2005-04-25 Thread Dan Kegel
Dimitrie O. Paun wrote: This is the patch I use for gcc4.0 here. I am not really sure why this aliasing was introduced, but it will not work this way anymore. I still don't understand why it doesn't work. It was introduced because using macros it not always acceptable. Some source uses these functi

How to deal with different struct sizes per OS

2005-04-25 Thread Paul Vriens
Hi, while dealing with the SYSTEM_PROCESS_INFORMATION struct in winternl.h I found that the struct has different sizes for NT/W2K/W2K3. How do we deal with this? Have a struct per OS and deal with it in the handling part (ntdll/nt.c in this case) for what *version* returns? Should the default one

Re: Bug 2904

2005-04-25 Thread Juan Lang
> Hey guys, can one of you have a look at bug 2904? Isn't this the same thing? http://www.winehq.org/hypermail/wine-devel/2005/04/0494.html Whether or not the patch Michael attached is the "real" fix, it should solve the immediate problem (the assert failure.) --Juan ___

Re: WoW, er Wine on Windows--Re: Still more fun?

2005-04-25 Thread Augustus Saunders
All, thanks for your responses. There's an important point that I forgot in my first email which explains what I hope to get from WINE. We don't just want to grab static screenshots, we ultimately want to do appsharing in Flash, almost like X Windows or terminal server type stuff, except over

Bug 2904

2005-04-25 Thread Dustin Navea
Hey guys, can one of you have a look at bug 2904? The reporter left a slightly barebones report, but I was able to find the patch that caused the problem, and posted all the relevant info I could find in my comments. Hopefully someone can write up a quick fix.. Thanks Dustin P.S. It's great to

Re: avicap32 patch

2005-04-25 Thread Maarten Lankhorst
Juan Lang wrote: Hi Maarten, You need to include "winnls.h" unconditionally, capGetDriverDescriptionW is always compiled with calls to MultiByteToWideChar. Oops, didn't see it, my fault -- fixed + sprintf(device, "/dev/video%i", devnum); Why not use snprintf(device, sizeof(device) ...) in

TrashCan - Day 4

2005-04-25 Thread Steven Edwards
Hi, This one is much better but still far from perfect. Trashing files to ~/.Trash now works and its cleanly put in to a new function. Alexandre wants to have the default behavior to be to use C:\Recycled so I am going to add a registry entry and a option to winecfg so that the user can enable F

Re: avicap32 patch

2005-04-25 Thread Juan Lang
Hi Maarten, > +#ifdef HAVE_LINUX_VIDEODEV_H > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include "winnls.h" > +#endif You need to include "winnls.h" unconditionally, capGetDriverDescriptionW is always compiled with calls to MultiByteT

Some fixes for filtergraph.c (#3)

2005-04-25 Thread Maarten Lankhorst
Added critical section around the mediacontrols, also added a release for the attached filters when the filtergraph gets released, so ref count leak has decreased.. I also submitted a patch to devenum to fix another release error, as a matter of fact: fixme:quartz:ReadThread 0x7d331c20 -> Frame

Re: Hierarchical namespace for tests

2005-04-25 Thread Alexandre Julliard
Paul Millar <[EMAIL PROTECTED]> writes: > Hopefully not a controversial one. I think it will prove useful to separate > the > different tests' namespace. This would allow identical filenames to appear > in different DLL tests directories without confusion (c.f. "generated.c" > currently). > >

Re: tools/widl

2005-04-25 Thread Alexandre Julliard
"Ge van Geldorp" <[EMAIL PROTECTED]> writes: > This is a big problem for me. Eric Kohl (not me) did a lot of work on WIDL > in the ReactOS tree, there's about 20 patches to follow after this one. If > this first patch is not acceptable and needs to be rewritten, it means I can > no longer simply p

Re: Privilege Checks For RegLoadKey, RegUnloadKey & RegSaveKey

2005-04-25 Thread Alexandre Julliard
Robert Shearman <[EMAIL PROTECTED]> writes: > Changelog: > - Fix access rights for RegOpenKeyEx and RegCreateKeyEx calls. > - Add privilege checks for RegLoadKey, RegUnloadKey & RegSaveKey calls. This breaks the crypt tests: ../../../tools/runtest -q -P wine -M advapi32.dll -T ../../.. -p advap

Re: Add strncpyW to unicode.h

2005-04-25 Thread James Hawkins
On 4/25/05, Jeff Latimer <[EMAIL PROTECTED]> wrote: > I have just been reading the lists and realise that strncpyW/strncpy is > bad news for some reason. Please consider this patch withdrawn. > > Wouldn't it be better to implement strncpyW as a wrapper for memcpy? > Given that all the other strin

RE: tools/widl

2005-04-25 Thread Ge van Geldorp
> From: Alexandre Julliard > > You should add some sort of get_fc_name() function instead of > duplicating a big switch like that every time you want to > print a name. This is a big problem for me. Eric Kohl (not me) did a lot of work on WIDL in the ReactOS tree, there's about 20 patches to fo

Re: tools/widl

2005-04-25 Thread Alexandre Julliard
Ge van Geldorp <[EMAIL PROTECTED]> writes: > +switch(var->type->type) > +{ > +case RPC_FC_BYTE: > +print_client("0x4e,/* FC_IN_PARAM_BASETYPE */\n"); > +print_client("0x%02x,/* FC_BYTE */\n", RPC_FC_BYT

Re: Add strncpyW to unicode.h

2005-04-25 Thread Jeff Latimer
I have just been reading the lists and realise that strncpyW/strncpy is bad news for some reason. Please consider this patch withdrawn. Wouldn't it be better to implement strncpyW as a wrapper for memcpy? Given that all the other string functions are implemeted with the (W) version, having s

Re: Installing Mozilla

2005-04-25 Thread Alex Woods
On Sun, Apr 24, 2005 at 08:00:37PM -0500, Dustin Navea wrote: > Was it the Mozilla installer that was crashing due to a bug in it's > ntmisc.c or the Mozilla app itself that was crashing? It was the Gecko Runtime Environment (GRE) part of the installer. -- Alex