Re: msvcrt: set mode bits in _fstati64

2004-12-04 Thread Juan Lang
--- Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > Apparently a returned info should be based on whether a file handle > resembles an ordinary disk based file, or pipe, or device, or something > else. But that's a target for a separate patch. Got it. How's this? --Juan _

Re: msvcrt: set mode bits in _fstati64

2004-12-04 Thread Dmitry Timoshkov
"Juan Lang" <[EMAIL PROTECTED]> wrote: > > What you probably need to consider is a type of a file passed in. > > Hm? Not sure what you mean here. Apparently a returned info should be based on whether a file handle resembles an ordinary disk based file, or pipe, or device, or something else. But

Re: msvcrt: set mode bits in _fstati64

2004-12-04 Thread Juan Lang
--- Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > Why do you take into account (FILE_ATTRIBUTE_HIDDEN | > FILE_ATTRIBUTE_SYSTEM) > at all? They have nothing to do with an ability to read/write files. You're right. I didn't do any tests, it was just my poor memory. > What you probably need to con

Re: Janitorial: WinMM conversion of 32 bit low level drivers to Unicode interface

2004-12-04 Thread Steven Edwards
--- Eric Pouech <[EMAIL PROTECTED]> wrote: > This patch is based on work by Filip Navara from ReactOS. > He did the Winmm part (+wave & midi mapper), I did the rest (+ 16 message > mapping) > A+ Eric I just want you to know you are my personal hero. Someday they will write songs about you that I

Re: Fix for winedbg; disassemble range was flawed

2004-12-04 Thread Jeremy White
This updated version prevents an infinite loop in the (currently impossible) case of a poorly specified disassembly range. Truth is, this functions interface is a bit awkward. Jeremy White wrote: Changelog: Properly respect a disassemble x,y command (prior behavior would do y-x instructions, n

Re: RFC: Use editline in winedbg

2004-12-04 Thread Jeremy White
Robert Shearman wrote: Jeremy White wrote: Hi folks, The attached patch dynamically detects and uses the BSD licensed editline library (a pretty close replacement for readline), if it's available. This gives winedbg command line recall. I think this should be available via Win32 calls without the

Re: msvcrt: set mode bits in _fstati64

2004-12-04 Thread Dmitry Timoshkov
"Juan Lang" <[EMAIL PROTECTED]> wrote: > + buf->st_mode = S_IFREG; > + if (!(hfi.dwFileAttributes & (FILE_ATTRIBUTE_HIDDEN | > FILE_ATTRIBUTE_SYSTEM))) > + { > +buf->st_mode |= S_IREAD; > +if (!(hfi.dwFileAttributes & FILE_ATTRIBUTE_READONLY)) > + buf->st_mode |= S_IWRITE; > + }

Re: COMCTL32: Minor corrections

2004-12-04 Thread Dmitry Timoshkov
"Filip Navara" <[EMAIL PROTECTED]> wrote: > >> - DrawEdge(NULL, &(infoPtr->rcDraw), EDGE_SUNKEN, BF_RECT | BF_ADJUST); > >> + /* subract the size of the edge drawn by DrawEdge */ > >> + InflateRect(&infoPtr->rcDraw, -2, -2); > > > > Please use GetSystemMetrics(SM_CXEDGE) and GetSystemMetrics(SM

Re: COMCTL32: Minor corrections

2004-12-04 Thread Filip Navara
Robert Shearman wrote: Filip Navara wrote: - /* use DrawEdge to adjust the size of rcEdge to get rcDraw */ memcpy((&infoPtr->rcDraw), (&infoPtr->rcClient), sizeof(infoPtr->rcDraw)); - DrawEdge(NULL, &(infoPtr->rcDraw), EDGE_SUNKEN, BF_RECT | BF_ADJUST); + /* subract the size of the edge draw

Re: RFC: Use editline in winedbg

2004-12-04 Thread Robert Shearman
Mike Hearn wrote: On Sat, 04 Dec 2004 17:17:28 -0600, Robert Shearman wrote: I think this should be available via Win32 calls without the licensing issues. See dlls/kernel/editline.c Yeah, maybe, though I'm not sure how easy it'd be to integrate readline with that stuff. I *really* *really

Re: COMCTL32: Minor corrections

2004-12-04 Thread Robert Shearman
Filip Navara wrote: Changelog: - Tooltip icons must be destroyed with DestroyIcon and not with DeleteObject. - Don't use DrawEdge with NULL device context, it's invalid call and sets last error. Index: lib/comctl32/datetime

Re: RFC: Use editline in winedbg

2004-12-04 Thread Mike Hearn
On Sat, 04 Dec 2004 17:17:28 -0600, Robert Shearman wrote: > I think this should be available via Win32 calls without the licensing > issues. See dlls/kernel/editline.c Yeah, maybe, though I'm not sure how easy it'd be to integrate readline with that stuff. I *really* *really* want this feature,

Re: RFC: Use editline in winedbg

2004-12-04 Thread Andreas Mohr
Hi, On Sat, Dec 04, 2004 at 04:54:14PM -0600, Jeremy White wrote: > Hi folks, > > The attached patch dynamically detects and uses the BSD licensed editline > library (a pretty close replacement for readline), if it's available. > This gives winedbg command line recall. Very nice, finally! Now wh

Re: RFC: Use editline in winedbg

2004-12-04 Thread Robert Shearman
Jeremy White wrote: Hi folks, The attached patch dynamically detects and uses the BSD licensed editline library (a pretty close replacement for readline), if it's available. This gives winedbg command line recall. I think this should be available via Win32 calls without the licensing issues. See

Re: implement DllCanUnloadNow for dmusic

2004-12-04 Thread Robert Shearman
James Hawkins wrote: On Sat, 04 Dec 2004 15:13:47 -0600, Robert Shearman <[EMAIL PROTECTED]> wrote: Ok, think about this sequence of events that should leave the DLL ref count at 0: 1. Create an IDirectMusicBufferImpl object. 1a. Calls LockModule. 1b. Calls QueryInterface which calls LockModule.

Re: implement DllCanUnloadNow for dmusic

2004-12-04 Thread James Hawkins
On Sat, 04 Dec 2004 15:13:47 -0600, Robert Shearman <[EMAIL PROTECTED]> wrote: > James Hawkins wrote: > > >Changelog > > * properly implement DllCanUnloadNow ref counting > > > > > > > > Sorry, still isn't correct. Please see my comments below. > > >

RFC: Use editline in winedbg

2004-12-04 Thread Jeremy White
Hi folks, The attached patch dynamically detects and uses the BSD licensed editline library (a pretty close replacement for readline), if it's available. This gives winedbg command line recall. This gets around readline's license requirements. I'm nervous because I wasn't sure if that was the only

Re: New Canadian keyboard layout

2004-12-04 Thread Jean-Michel Dault
Le sam 04/12/2004 à 12:59, Vincent Béron a écrit : > > The keyboard that the Government of Quebec uses is the CAN/CSA > > Z243.200-92, and is *not defined* in Wine. > If it is the one I think it is (AKA as Canadian multi-lingual, with the > "è" in place of the deadkey "`"), nobody I know except the

Re: implement DllCanUnloadNow for dmusic

2004-12-04 Thread Robert Shearman
James Hawkins wrote: Changelog * properly implement DllCanUnloadNow ref counting Sorry, still isn't correct. Please see my comments below. Index: dlls/dmusic/buffer.c ==

DInput has been broken for about 6 months now

2004-12-04 Thread Scott Ritchie
Well, one of my favorite games, Fallout 2, didn't work when I tried it. This is strange though, as it was working about 3 years ago. Looking through the AppDB page, http://appdb.winehq.org/appview.php?appId=194&versionId=319 - it looks like it's been broken since June. Specifically, here's the s

Re: Implemented CreateAsyncBindCtx

2004-12-04 Thread Mike Hearn
On Fri, 03 Dec 2004 23:01:36 -0500, Jacek Caban wrote: > +hres = IBindCtx_RegisterObjectParam(bctx, (LPOLESTR)BSCBHolder, > (IUnknown*)callback); > + > +*pbind = bctx; > + > +return S_OK; > } You don't do anything with hres here, is that intentional? Can RegisterObjectParam fail? th

Re: New Canadian keyboard layout

2004-12-04 Thread Vincent Béron
Le sam 04/12/2004 à 11:15, Jean-Michel Dault a écrit : > Le sam 04/12/2004 à 07:20, Dmitry Timoshkov a écrit : > > "Jean-Michel Dault" <[EMAIL PROTECTED]> wrote: > > > I'm doing a pilot project for the Quebec government, and we have one > > > major problem: they have a keyboard layout that's unsupp

Re: New Canadian keyboard layout

2004-12-04 Thread Jean-Michel Dault
Please use this new patch instead. There were a few mismatches in my previous patch, I tweaked it a bit, and now I get a perfect score of 127. trace:keyboard:X11DRV_KEYBOARD_DetectLayout Attempting to match against "Canadian CAN/CSA-Z243.200-92 keyboard layout" trace:keyboard:X11DRV_KEYBOARD_Dete

Re: New Canadian keyboard layout

2004-12-04 Thread Jean-Michel Dault
Le sam 04/12/2004 à 07:20, Dmitry Timoshkov a écrit : > "Jean-Michel Dault" <[EMAIL PROTECTED]> wrote: > > I'm doing a pilot project for the Quebec government, and we have one > > major problem: they have a keyboard layout that's unsupported by Wine, > > though it was commited to XFree about 3 year

Re: Making the Documentation into help files

2004-12-04 Thread Mike Hearn
On Sun, 28 Nov 2004 20:08:41 -0800, Scott Ritchie wrote: > So, how is this done? I presume there's a freedesktop.org standard for > these things, as both Gnome and KDE have them in the same way, but > currently we're not converting the documentation sgml files into these > help files. Nope there

Re: New Canadian keyboard layout

2004-12-04 Thread Dmitry Timoshkov
"Jean-Michel Dault" <[EMAIL PROTECTED]> wrote: > I'm doing a pilot project for the Quebec government, and we have one > major problem: they have a keyboard layout that's unsupported by Wine, > though it was commited to XFree about 3 years ago. What do you mean by "unsupported by Wine", is that ju

Re: Problem to draw a bitmap

2004-12-04 Thread Dmitry Timoshkov
"Vincent Béron" <[EMAIL PROTECTED]> wrote: > > > > /* Make the window visible on the screen */ > > > > ShowWindow (hwnd, nFunsterStil); > > > > Insert UpdateWindow(hwnd); here. > > > > > > PrintBmp(hwnd, "BOARD.bmp"); > > Still, it works on XP and not on Wine, so we should fix Wine. > It's pro

Re: Wine book

2004-12-04 Thread Christian Costa
Lionel Ulmer wrote: Just kidding. I remember Tom saying last year that native DirectX actually works under Wine. Maybe it's worth covering? Am I way off base? Well, native DInput somewhat works (for which I am pretty surprised, I would need to trace it to see what Win32 calls it uses) I got