Re: visual studio 6 not happy?

2004-12-01 Thread Dan Kegel
Jerry Geis wrote: I am trying to use wine 12-01-04 release with Visual Studio. I am getting the vcspawn error. Have you ever found a solution to that? [http://www.winehq.com/hypermail/wine-devel/2003/02/0335.html] Nope. I didn't look very hard, though. If not I am trying to use the command line nm

Re: <> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive

2004-12-01 Thread Mike McCormack
Robert van Herk wrote: Added functionality to browse for a UNIX folder. This is done by making two new funtions in dlls/shell32/brsfolder.c, namely wine_shell_browse_for_UNIX_directoryA wine_shell_browse_for_UNIX_directoryW These functions are exported in shlobj.h. How about creatin

Re: [OLE #3] Tests For COM Functions

2004-12-01 Thread Dmitry Timoshkov
"Dmitry Timoshkov" <[EMAIL PROTECTED]> wrote: > Under Win95 the tests don't run due to missing APIs CoResumeClassObjects > and CoInitializeEx. Win98 results: marshal.c test doesn't run either, but this time due to missing kernel32.OpenThread; moniker.c tests pass. -- Dmitry.

Re: [OLE #2] Provide Reference Implementation of DllCanUnloadNow

2004-12-01 Thread Robert Shearman
Dmitry Timoshkov wrote: "Robert Shearman" <[EMAIL PROTECTED]> wrote: Perhaps it would be better to prefix both a variable and lock/unlock interfaces with a module name, in this case "DEVENUM_" since they are global and externally visible. Do we still need to worry about that crap even tho

Re: [OLE #2] Provide Reference Implementation of DllCanUnloadNow

2004-12-01 Thread Dmitry Timoshkov
"Robert Shearman" <[EMAIL PROTECTED]> wrote: > >Perhaps it would be better to prefix both a variable and lock/unlock > >interfaces with a module name, in this case "DEVENUM_" since they are > >global and externally visible. > > > > > > Do we still need to worry about that crap even though we do

Re: [OLE #2] Provide Reference Implementation of DllCanUnloadNow

2004-12-01 Thread Robert Shearman
Dmitry Timoshkov wrote: "Robert Shearman" <[EMAIL PROTECTED]> wrote: -DWORD dll_ref = 0; +LONG cLocks; ... +/** + * Dll lifetime tracking declaration + */ +void LockModule() +{ +InterlockedIncrement(&cLocks); +} + +v

Re: attemp at implementing DllCanUnload now for dcompos

2004-12-01 Thread James Hawkins
On Wed, 01 Dec 2004 17:44:55 -0600, Robert Shearman <[EMAIL PROTECTED]> wrote: > James Hawkins wrote: > > > > >Hey all, > > > >It would really help me out if you could look over this patch and see > >if I've incorrectly implemented ref-counting and DllCanUnloadNow for > >dcompos. I used suggest

Re: Suggestions for fixing test?

2004-12-01 Thread Dmitry Timoshkov
"Jakob Eriksson" <[EMAIL PROTECTED]> wrote: > http://test.winehq.org/data/200412011000/xp_IDWASEMPTY/gdi32:metafile.txt > > > Any suggestions for fixing this? Run the tests from not a service? -- Dmitry.

Re: [OLE #3] Tests For COM Functions

2004-12-01 Thread Dmitry Timoshkov
"Robert Shearman" <[EMAIL PROTECTED]> wrote: > I have only tried these tests on WinXP SP2. Please report > if they fail on Win9x. In order compile the tests with Platform SDK I applied the attached patch. Under win2k SP4 I got: marshal.c:898: Test failed: CoGetClassObject should have returned

Re: [OLE #2] Provide Reference Implementation of DllCanUnloadNow

2004-12-01 Thread Dmitry Timoshkov
"Robert Shearman" <[EMAIL PROTECTED]> wrote: > -DWORD dll_ref = 0; > +LONG cLocks; ... > +/** > + * Dll lifetime tracking declaration > + */ > +void LockModule() > +{ > +InterlockedIncrement(&cLocks); > +} > + > +void UnlockMo

Re: <> Added shell32.dll functions to browse for unix directory;

2004-12-01 Thread Shachar Shemesh
Robert van Herk wrote: So yes, I could put it all in a structure on the stack and then pass it to the dlgproc, but it will only arrive there on WM_INITDIALOG. However, I will also need the structure when the other messages come in. So where do I save it then, if I cannot put it in a global var?

Re: attemp at implementing DllCanUnload now for dcompos

2004-12-01 Thread Robert Shearman
James Hawkins wrote: Hey all, It would really help me out if you could look over this patch and see if I've incorrectly implemented ref-counting and DllCanUnloadNow for dcompos. I used suggestions from Rob and a sample implementation written by him. The only concern I have is that I'm not sure if

Re: <> Added shell32.dll functions to browse for unix directory;

2004-12-01 Thread Robert van Herk
However I can definitely see your point here but since the functions are all internal to shell32 at this point and can accept any parameters you may like, I would consider it a cleaner solution to allocate a structure on the stack which contains such helper variables together with the pointer to

Re: Bugzilla in CVS

2004-12-01 Thread Dimitrie O. Paun
On Wed, Dec 01, 2004 at 04:51:35PM -0600, Jeremy Newman wrote: > http://cvs.winehq.org/cvsweb/bugzilla/ > > I have imported our buzilla into CVS for anyone to start submitting > patches on. If I remember correctly, it is a fairly straight branch of > version 2.17.4. All I modified was the template

Bugzilla in CVS

2004-12-01 Thread Jeremy Newman
http://cvs.winehq.org/cvsweb/bugzilla/ I have imported our buzilla into CVS for anyone to start submitting patches on. If I remember correctly, it is a fairly straight branch of version 2.17.4. All I modified was the templates in: /template/en/default/global Enjoy!

Re: <> Added shell32.dll functions to browse for unix directory;

2004-12-01 Thread Robert van Herk
Rolf Kalbermatter wrote: Robert van Herk wrote: I guess you are right, but the strange thing is that this was already the case in the original code. The hwnd of the tree view and the pointer to the browseinfo structure are copied into a global variable, so at least my code is not worse here :-)

Fwd: Re: Bug Busters

2004-12-01 Thread Peter Hartshorn
May I suggest that the times given are GMT and at least one days notice so everyone who wants to join in can, no matter where they are on the planet. On Wed, 1 Dec 2004 04:10 pm, James Hawkins wrote: > On Tue, 30 Nov 2004 23:58:59 -0500, Adam Babcock <[EMAIL PROTECTED]> wrote: > > James Hawkins w

RE: <> Added shell32.dll functions to browse for unix directory;

2004-12-01 Thread Rolf Kalbermatter
Robert van Herk wrote: > I guess you are right, but the strange thing is that this was already > the case in the original code. The hwnd of the tree view and the > pointer to the browseinfo structure are copied into a global variable, > so at least my code is not worse here :-). Well, existing c

Re: Resend [AppDB] show total number of maintainers and applications in the appMaintainers table

2004-12-01 Thread Jeremy Newman
This patch fails to apply to the tip. Update and resend. On Sun, 2004-11-21 at 09:50 -0700, Tony Lambregts wrote: > There was a bug in last one, use this instead. > > Change Log: Show the total number of maintainers and applications in the > appMaintainers table in the admin menu > > Files Cha

Re: systray rewrite part 2

2004-12-01 Thread Grant Williamson
Mike, does this help any? Please use the registry key HKEY_CURRENT_CONFIG\Software\Fonts\LogPixels to set the screen resolution and remove the "Resolution" entry in the config file fixme:crypt:CRYPT_VerifyImage (rsaenh.dll, 0x77e2a488): not verifying image fixme:crypt:CRYPT_LoadProvider Fai

attemp at implementing DllCanUnload now for dcompos

2004-12-01 Thread James Hawkins
Hey all, It would really help me out if you could look over this patch and see if I've incorrectly implemented ref-counting and DllCanUnloadNow for dcompos. I used suggestions from Rob and a sample implementation written by him. The only concern I have is that I'm not sure if all of these classe

Re: gdi/mfdrv BS_PATTERN brushes

2004-12-01 Thread Walt Ogburn
Hi Huw, You're right, it's a META_DIBCREATEPATERNBRUSH under XP at least. I think I understand this better now. I'll hold off on the patch and try to write some tests. I don't think there's any easy way to fix the problems in the current code without changing it to META_CREATEPATTERNBRUSH. Th

Re: Wine book

2004-12-01 Thread Lionel Ulmer
> 4.Installing Applications [35 pages] [...] > Using Native DirectX I was just wondering what would be convered by this particular topic. Lionel -- Lionel Ulmer - http://www.bbrox.org/

Re: Bug Busters

2004-12-01 Thread tony_lambregts
Mike Hearn wrote: On Wed, 01 Dec 2004 01:29:50 -0500, James Hawkins wrote: agree that programs should be freely available to anyone if the bug requires a program. Some of the bugs don't need them. I also agree that the older bugs should be fixed first. We might even find that a bunch of bugs we

Re: Winecfg -> browse for folder

2004-12-01 Thread Robert van Herk
Hi Mike, I have some questions about your comments: @@ -46,7 +48,8 @@ shpolicy.c \ shv_bg_cmenu.c \ shv_item_cmenu.c \ - systray.c + systray.c \ + unixTools.c s/unixTools.c/unix_tools.c/ for consistency What do you mean? Does s/x/y/ mean that I should change x into y? Also consistent ind

Re: <> Added shell32.dll functions to browse for unix directory;

2004-12-01 Thread Robert van Herk
Rolf Kalbermatter wrote: Robert van Herk wrote: -LPITEMIDLIST WINAPI SHBrowseForFolderA (LPBROWSEINFOA lpbi) +static INT_PTR BrowseW (LPBROWSEINFOW lpbi, DLGPROC dlgproc, enum browsemode aBrowseMode) +{ +INT_PTR ret; + +browseMode = aBrowseMode; ^^

Re: <> Added shell32.dll functions to browse for unix directory;

2004-12-01 Thread Rolf Kalbermatter
Robert van Herk wrote: >-LPITEMIDLIST WINAPI SHBrowseForFolderA (LPBROWSEINFOA lpbi) >+static INT_PTR BrowseW (LPBROWSEINFOW lpbi, DLGPROC dlgproc, enum browsemode >aBrowseMode) >+{ >+INT_PTR ret; >+ >+browseMode = aBrowseMode; ^^ I may miss something he

Re: Winecfg -> browse for folder

2004-12-01 Thread Robert van Herk
+static void prepNextFile(LP_UNIXTOOLS_DIRDATA dirdata) +{ + TRACE("hallo\n"); + Well, the patch clearly still needs a bit more work ;) Still, it looks like it's on the right track. Good going! Haha! I am glad there is still a "Hallo" in the code :-). Thanks for your advice Mike. I will ch

Re: Bug Busters

2004-12-01 Thread James Hawkins
On Wed, 01 Dec 2004 17:42:26 +, Mike Hearn <[EMAIL PROTECTED]> wrote: > On Wed, 2004-12-01 at 12:27 -0500, James Hawkins wrote: > > > So that the most potential developers will be able to join, let's have > > > the session this Friday Dec. 3, 7pm GMT. Is that a good time for > > I think Sunda

Re: Bug Busters

2004-12-01 Thread tony_lambregts
Robert van Herk wrote: Also, I am getting the strange feeling that the buglist is somewhat outdated :-). For example: almost all bugs are either NEW or UNCONFIRMED. Isn't that a bit odd? It's just that way right now. The way Bugzilla was designed there is supposed to be a default person for eac

Re: Winecfg -> browse for folder

2004-12-01 Thread Mike Hearn
On Wed, 2004-12-01 at 17:08 +0100, Robert van Herk wrote: > Anyways: I already implemented it (as you perhaps saw) using UNIX api > calls. I think I did OK, though I am not very experienced in neither C > programming or win32. Mike, perhaps you could take a look at my patch? Sure. Here you go.

Re: Bug Busters

2004-12-01 Thread Mike Hearn
On Wed, 2004-12-01 at 12:27 -0500, James Hawkins wrote: > > So that the most potential developers will be able to join, let's have > > the session this Friday Dec. 3, 7pm GMT. Is that a good time for I think Sunday would be a better day of the week. Friday/Saturday nights people tend to go out on

Re: Bug Busters

2004-12-01 Thread James Hawkins
On Wed, 1 Dec 2004 12:25:38 -0500, James Hawkins <[EMAIL PROTECTED]> wrote: > On Wed, 01 Dec 2004 17:04:49 +, Mike Hearn <[EMAIL PROTECTED]> wrote: > > > > On Wed, 2004-12-01 at 11:52 -0500, James Hawkins wrote: > > > What time is best for everyone? Also is once a week too much or not > > >

Re: Bug Busters

2004-12-01 Thread James Hawkins
On Wed, 01 Dec 2004 17:04:49 +, Mike Hearn <[EMAIL PROTECTED]> wrote: > On Wed, 2004-12-01 at 11:52 -0500, James Hawkins wrote: > > What time is best for everyone? Also is once a week too much or not > > enough? > > I think as long as both USians and Europeans can be awake at the same > time,

Re: which classes support aggregation?

2004-12-01 Thread Robert Shearman
James Hawkins wrote: IClassFactory->CreateInstance aggregation check: "The CreateInstance method of IClassFactory takes pUnkOuter as the second member. This parameter must be null unless the class supports aggregation, which many don't." Where can I find out which classes support aggregation?

Re: Bug Busters

2004-12-01 Thread Mike Hearn
On Wed, 2004-12-01 at 09:24 -0700, [EMAIL PROTECTED] wrote: > There is nothing wrong with fixing a bug for its own sake and any bug we fix > will ultimately improve wine and provide some insites into debugging > wine. Well, yes if you assume infinite manpower. We don't have that so I'd personally

Re: Bug Busters

2004-12-01 Thread James Hawkins
On Wed, 01 Dec 2004 14:54:59 +, Mike Hearn <[EMAIL PROTECTED]> wrote: > On Wed, 01 Dec 2004 01:29:50 -0500, James Hawkins wrote: > > Well, as long as it's at a time I can do without having redeye the next > day I'm happy to drop in and help with this. On choices of bugs: > > I think if this g

Re: implementing DllCanUnloadNow questions

2004-12-01 Thread Robert Shearman
James Hawkins wrote: On Tue, 30 Nov 2004 15:34:50 -0600, Robert Shearman <[EMAIL PROTECTED]> wrote: James Hawkins wrote: I would like to work on the DllCanUnloadNow janitorial task, but I was wondering if there are any patches or examples of dll's that correctly implement this so that I can

Re: Bug Busters

2004-12-01 Thread Mike Hearn
On Wed, 2004-12-01 at 11:52 -0500, James Hawkins wrote: > What time is best for everyone? Also is once a week too much or not > enough? I think as long as both USians and Europeans can be awake at the same time, it should be that sort of time. So evening GMT. Before saying "let's do it once a wee

Re: Wine book

2004-12-01 Thread Ira Krakow
Dimi, > > We need a discussion of how to use the std C++ lib. > Thanks. I'll add it to my list. Ira

Re: Bug Busters

2004-12-01 Thread Jakob Eriksson
Mike Hearn wrote: On Wed, 01 Dec 2004 01:29:50 -0500, James Hawkins wrote: agree that programs should be freely available to anyone if the bug requires a program. Some of the bugs don't need them. I also agree that the older bugs should be fixed first. We might even find that a bunch of bugs

Re: Bug Busters

2004-12-01 Thread tony_lambregts
Mike Hearn wrote: On Wed, 01 Dec 2004 01:29:50 -0500, James Hawkins wrote: agree that programs should be freely available to anyone if the bug requires a program. Some of the bugs don't need them. I also agree that the older bugs should be fixed first. We might even find that a bunch of bugs we

Re: Bug Busters

2004-12-01 Thread Robert van Herk
Joel Konkle-Parker wrote: James Hawkins wrote: I have a totally non-original idea for sessions called Bug Busters where, at a designated time, a group of wine developers would get together on #winehackers (or some other channel). We would pick a bug (or maybe more) from wine's bug tracker and work

Re: Winecfg -> browse for folder

2004-12-01 Thread Robert van Herk
Mike Hearn wrote: On Tue, 30 Nov 2004 22:08:26 +0100, Robert van Herk wrote: Oops, I guess this suggestion was a bit too late, since I commited my patch this afternoon... I wouldn't worry too much. I'm not sure a PIDL extension is a good idea anyway - it's probably the Microsoft way, but t

Re: Wine book

2004-12-01 Thread Dimitrie O. Paun
On Tue, Nov 30, 2004 at 05:42:31PM -0700, Brian Vincent wrote: > 13. Advanced Porting Techniques [25 pages] > C++ Problems We need a discussion of how to use the std C++ lib. -- Dimi.

<> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive

2004-12-01 Thread Robert van Herk
Hi, I had some problems with my mail server, so I send in this patch again. If the previous one did arrive, please ignore this e-mail. Changes: Added functionality to browse for a UNIX folder. This is done by making two new

<> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive

2004-12-01 Thread Robert van Herk
Changes: Added functionality to browse for a UNIX folder. This is done by making two new funtions in dlls/shell32/brsfolder.c, namely wine_shell_browse_for_UNIX_directoryA wine_shell_browse_for_UNIX_directoryW These functions are exported in shlobj.h. The original code that allowed ju

Suggestions for fixing test?

2004-12-01 Thread Jakob Eriksson
http://test.winehq.org/data/200412011000/xp_IDWASEMPTY/gdi32:metafile.txt Any suggestions for fixing this? regards, Jakob

Re: Bug Busters

2004-12-01 Thread Joel Konkle-Parker
James Hawkins wrote: I have a totally non-original idea for sessions called Bug Busters where, at a designated time, a group of wine developers would get together on #winehackers (or some other channel). We would pick a bug (or maybe more) from wine's bug tracker and work together to fix the bug(s)

Re: implementing DllCanUnloadNow questions

2004-12-01 Thread Mike Hearn
On Tue, 30 Nov 2004 18:33:20 -0500, James Hawkins wrote: > Is _Construct the same as _AddRef()? I'm thinking it's not. If it > isn't, I need to add a MSI_Construct to msi. What are the parameters > to the Construct function and what would usually go in the place of > the "..."? It's just the fu

Re: Bug Busters

2004-12-01 Thread Mike Hearn
On Wed, 01 Dec 2004 01:29:50 -0500, James Hawkins wrote: > agree that programs should be freely available to anyone if the bug > requires a program. Some of the bugs don't need them. I also agree > that the older bugs should be fixed first. We might even find that a > bunch of bugs we try to fi

Re: Wine book

2004-12-01 Thread Mike Hearn
On Tue, 30 Nov 2004 17:42:31 -0700, Brian Vincent wrote: > 3.Configuring Wine [35 pages] > Introduction to Winecfg Hah, optimist :)

Re: which classes support aggregation?

2004-12-01 Thread Mike Hearn
On Tue, 30 Nov 2004 18:36:37 -0500, James Hawkins wrote: > IClassFactory->CreateInstance aggregation check: > "The CreateInstance method of IClassFactory takes pUnkOuter as the > second member. This parameter must be null unless the class supports > aggregation, which many don't." > > Where can I

Re: systray rewrite part 2

2004-12-01 Thread Mike Hearn
On Tue, 30 Nov 2004 19:14:15 +0100, Grant Williamson wrote: > Mike, > ok the rewrite, applies & compiles cleanly on 20041019, however, > running SIP Phone-lite, it does not show on the systray, the older > patch did. > I am running gnome-2.8 on rhel4, what program do you want us to test > w

Re: Winecfg -> browse for folder

2004-12-01 Thread Mike Hearn
On Tue, 30 Nov 2004 22:08:26 +0100, Robert van Herk wrote: > Oops, I guess this suggestion was a bit too late, since I commited my > patch this afternoon... I wouldn't worry too much. I'm not sure a PIDL extension is a good idea anyway - it's probably the Microsoft way, but this is a Wine extensi

Re: Always create a suspended thread in CreateThread and resume it if CREATE_SUSPENDED flag is not set as Windows does

2004-12-01 Thread Robert Shearman
Dmitry Timoshkov wrote: Hello, there is at least one application which crashes in CreateThread due to a race between a creating thread and a newly created one. The problem is that the tid address passed to CreateThread resides in the memory block allocated with VirtualAlloc which gets freed once th

Re: Wine book

2004-12-01 Thread Shachar Shemesh
I'm not sure what I'm writing here is appropriate for actual "headings". It's just some points to keep in mind when writing the actual chapters. Brian Vincent wrote: [1] Chapter outlines: Title: "Wine: Running Windows Applications on Linux" [4] 1. Wine Introduction[15 pages] What is Wine? How C

Debian Packages Almost Ready

2004-12-01 Thread Scott Ritchie
Debian packages are almost done. I have them up for testing. Add the following to /etc/apt/sources.list deb http://tuzakey.com/~scott/ binary/ deb-src http://tuzakey.com/~scott/ source/ My friend's webserver can't handle the huge bandwidth permanent hosting of packages like this will require,