Small WinMM janitorial project

2004-11-30 Thread Steven Edwards
Hi, With this patch it is possible to use a few Windows sound drivers under ReactOS but I have only submitted patches for one small part of this because its going to require a bit of rework of the existing WinMM code. This should fix 2 of the existing W->A CrossCall issues # dlls/winmm/winmm.c: wi

Re: Bug Busters

2004-11-30 Thread James Hawkins
On Tue, 30 Nov 2004 23:23:46 -0700, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > James Hawkins wrote: > > > > On Tue, 30 Nov 2004 23:58:59 -0500, Adam Babcock <[EMAIL PROTECTED]> wrote: > > > >>James Hawkins wrote: > >> > >> > >> > >>>I have a totally non-original idea for sessions called Bug B

Re: Bug Busters

2004-11-30 Thread tony_lambregts
James Hawkins wrote: On Tue, 30 Nov 2004 23:58:59 -0500, Adam Babcock <[EMAIL PROTECTED]> wrote: James Hawkins wrote: I have a totally non-original idea for sessions called Bug Busters where, at a designated time, a group of wine developers would get together on #winehackers (or some other channel

Re: Bug Busters

2004-11-30 Thread James Hawkins
On Tue, 30 Nov 2004 23:58:59 -0500, Adam Babcock <[EMAIL PROTECTED]> wrote: > James Hawkins wrote: > > > > I have a totally non-original idea for sessions called Bug Busters > > where, at a designated time, a group of wine developers would get > > together on #winehackers (or some other channel).

Re: Bug Busters

2004-11-30 Thread Adam Babcock
James Hawkins wrote: I have a totally non-original idea for sessions called Bug Busters where, at a designated time, a group of wine developers would get together on #winehackers (or some other channel). We would pick a bug (or maybe more) from wine's bug tracker and work together to fix the bug(s)

Bug Busters

2004-11-30 Thread James Hawkins
I have a totally non-original idea for sessions called Bug Busters where, at a designated time, a group of wine developers would get together on #winehackers (or some other channel). We would pick a bug (or maybe more) from wine's bug tracker and work together to fix the bug(s). This would serve s

Re: Wine book : Ira Krakow introduction

2004-11-30 Thread Ira Krakow
Brian, thank you for all your hard work getting the ball rolling and for your kind words about me. I totally agree with you about Prentice Hall's professionalism and that they "get it". I want to introduce myself briefly to the group. I am an independent Windows (and DOS before that) database ap

Wine book

2004-11-30 Thread Brian Vincent
Just wanted to give everyone a heads up.. I followed up with Jeremy's email a few months ago about a publisher wanting to put together a book on Wine. Yep, I have no life and 400 pages can't be that hard to write. Well, we started the ball rolling and now it looks like it's going to happen. I s

Re: implementing DllCanUnloadNow questions

2004-11-30 Thread James Hawkins
On Tue, 30 Nov 2004 15:34:50 -0600, Robert Shearman <[EMAIL PROTECTED]> wrote: > James Hawkins wrote: > > >I would like to work on the DllCanUnloadNow janitorial task, but I was > >wondering if there are any patches or examples of dll's that correctly > >implement this so that I can do it right. >

which classes support aggregation?

2004-11-30 Thread James Hawkins
IClassFactory->CreateInstance aggregation check: "The CreateInstance method of IClassFactory takes pUnkOuter as the second member. This parameter must be null unless the class supports aggregation, which many don't." Where can I find out which classes support aggregation? -- James Hawkins

Re: implementing DllCanUnloadNow questions

2004-11-30 Thread Robert Shearman
James Hawkins wrote: I would like to work on the DllCanUnloadNow janitorial task, but I was wondering if there are any patches or examples of dll's that correctly implement this so that I can do it right. I don't know of any examples so far, but Mike Hearn and I will be tackling OLE soon, so th

Re: Debugging of Windows App

2004-11-30 Thread Eric Pouech
Bernard Gallet a écrit : I am trying to debug a Windows app on Wine. I have the source code, it is compiled with Visual Studio 2002. I have not yet been able to get Line/File info. It is my understanding that winedbg does not recognize pdb, however, I am unable to link without one! Can somebody

Re: Winecfg -> browse for folder

2004-11-30 Thread Robert van Herk
Steven Edwards wrote: Hi, --- Francois Gouget <[EMAIL PROTECTED]> wrote: If there's something preventing it, wouln't a Shell Namespace extension be the right solution? This would be ideal. You there is lots of example code for extending the namespace for CVS and SVN so adding support for a

Re: wine/dlls/shell32 tests/shellpath.c version.h - IE6 breakage

2004-11-30 Thread Juan Lang
--- Mike McCormack <[EMAIL PROTECTED]> wrote: > The following seemingly simple and harmless change caused a regression > in IE6. The toolbar icons are no longer displayed and the error message > below appears in the log. Interesting. My preference would have been to use Win2K's shell32 version,

implementing DllCanUnloadNow questions

2004-11-30 Thread James Hawkins
I sent this message a couple months ago, but I got no response so I'll try again. I would like to work on the DllCanUnloadNow janitorial task, but I was wondering if there are any patches or examples of dll's that correctly implement this so that I can do it right. Is LockServer(TRUE/FALSE) the s

Re: acmstream mem leak fix

2004-11-30 Thread Michael Günnewig
James Hawkins <[EMAIL PROTECTED]> writes: > Unless I'm mistaken, we don't want to free allocated memory only when > the call fails. Sorry, but you are wrong. When you always free the memory you will run into a segmentation fault when the application uses the returned stream. The problem is the s

Re: Winecfg -> browse for folder

2004-11-30 Thread Steven Edwards
Hi, --- Francois Gouget <[EMAIL PROTECTED]> wrote: > If there's something preventing it, wouln't a Shell Namespace > extension > be the right solution? This would be ideal. You there is lots of example code for extending the namespace for CVS and SVN so adding support for a Unix filesystem shoul

Re: systray rewrite part 2

2004-11-30 Thread Grant Williamson
Mike, ok the rewrite, applies & compiles cleanly on 20041019, however, running SIP Phone-lite, it does not show on the systray, the older patch did. I am running gnome-2.8 on rhel4, what program do you want us to test with it. Mike Hearn wrote: Clearly, I need to figure out a system for gen

Re: misc. crypt test mem leak fixes

2004-11-30 Thread James Hawkins
On Tue, 30 Nov 2004 21:35:31 +0800, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > "James Hawkins" <[EMAIL PROTECTED]> wrote: > > > Changelog > > * misc. crypt test mem leak fixes > > Apparently lines with LocalAlloc were added by mistake instead > of LocalFree. > > -- > Dmitry. > > wow...

Re: wine/dlls/shell32 tests/shellpath.c version.h - IE6 breakage

2004-11-30 Thread Robert Shearman
Dmitry Timoshkov wrote: "Andreas Mohr" <[EMAIL PROTECTED]> wrote: On Tue, Nov 30, 2004 at 02:24:37PM +0900, Mike McCormack wrote: The following seemingly simple and harmless change caused a regression in IE6. The toolbar icons are no longer displayed and the error message below appears i

Debugging of Windows App

2004-11-30 Thread Bernard Gallet
I am trying to debug a Windows app on Wine. I have the source code, it is compiled with Visual Studio 2002. I have not yet been able to get Line/File info. It is my understanding that winedbg does not recognize pdb, however, I am unable to link without one! Can somebody help? T IA, - Bernard GA

Re: wine/dlls/shell32 tests/shellpath.c version.h - IE6 breakage

2004-11-30 Thread Dmitry Timoshkov
"Andreas Mohr" <[EMAIL PROTECTED]> wrote: > On Tue, Nov 30, 2004 at 02:24:37PM +0900, Mike McCormack wrote: > > > > The following seemingly simple and harmless change caused a regression > > in IE6. The toolbar icons are no longer displayed and the error message > > below appears in the log. >

Re: wine/dlls/shell32 tests/shellpath.c version.h - IE6 breakage

2004-11-30 Thread Andreas Mohr
Hi, On Tue, Nov 30, 2004 at 02:24:37PM +0900, Mike McCormack wrote: > > The following seemingly simple and harmless change caused a regression > in IE6. The toolbar icons are no longer displayed and the error message > below appears in the log. > > err:imagelist:ImageList_LoadImageW Error loa

Re: Winecfg -> browse for folder

2004-11-30 Thread Francois Gouget
On Sat, 27 Nov 2004, Robert van Herk wrote: [...] Internally though, the SHBrowseForFolder dialog (dlls/shell32/brsfolder.c) uses pidls, which, as far as I know, are a specific win32 thing for identifying paths uniqually. Thus, if I'd make an extra flag in the dialog, I would have to extent pidl

Re: wine/dlls/shell32 tests/shellpath.c version.h - IE6 breakage

2004-11-30 Thread Stefan Dösinger
> Am Dienstag, 30. November 2004 06:24 schrieb Mike McCormack: > > The following seemingly simple and harmless change caused a regression > > in IE6. The toolbar icons are no longer displayed and the error message > > below appears in the log. > > I can confirm the symptom. I'll test if reversing

Re: Problem with file dialog

2004-11-30 Thread Stefan Dösinger
Hello, > Changelog: > Store the new style before redrawing and repositioning the control. This patch fixes the problem! Thanks, Stefan

Re: wine/dlls/shell32 tests/shellpath.c version.h - IE6 breakage

2004-11-30 Thread Stefan Dösinger
Am Dienstag, 30. November 2004 06:24 schrieb Mike McCormack: > The following seemingly simple and harmless change caused a regression > in IE6. The toolbar icons are no longer displayed and the error message > below appears in the log. I can confirm the symptom. I'll test if reversing the patch he

Re: Porting SmartWin a Windows API GUI library...

2004-11-30 Thread Dimitrie O. Paun
On Tue, Nov 30, 2004 at 02:06:01PM +0100, Thomas Hansen wrote: > Comments sombody...? I think its a good idea, but before you can consider a WineLib port, you need a MinGW port under Windows. So does it build with the MinGW toolchain? Do you have MinGW Makefiles? If yes, I can take a look, the por

Re: misc. crypt test mem leak fixes

2004-11-30 Thread Dmitry Timoshkov
"James Hawkins" <[EMAIL PROTECTED]> wrote: > Changelog > * misc. crypt test mem leak fixes Apparently lines with LocalAlloc were added by mistake instead of LocalFree. -- Dmitry.

Porting SmartWin a Windows API GUI library...

2004-11-30 Thread Thomas Hansen
I'm the admin of http://smartwin.sourceforge.net and I've been thinking that if this library (SmartWin) could be ported to WineLib that would be really awesome... I would definitely take it right into the CVS (unless it breaks everything) and I'd make it a definitely focus trying to keep the compat

Re: gdi/mfdrv BS_PATTERN brushes

2004-11-30 Thread Huw D M Davies
On Mon, Nov 29, 2004 at 09:16:49PM -0800, Walt Ogburn wrote: > > This fixes the problem that Emanuele Gisi reported last month in the Aloha > problem. With this patch BS_PATTERN brushes get created correctly and > don't cause a locking problem. > > Changelog: > Fix creation of BS_PATTERN brushes i

Re: icmstream mem leak fix

2004-11-30 Thread Mike McCormack
James Hawkins wrote: I just want to make sure I've got this. Do we want to release even if the call to QueryInterface suceeds? The old code sets ref=0, then just free's the memory. My method would set ref=1, then call Release() which decrements ref and free's memory. If QueryInterface succeeds,

Re: icmstream mem leak fix

2004-11-30 Thread James Hawkins
On Tue, 30 Nov 2004 16:32:59 +0900, Mike McCormack <[EMAIL PROTECTED]> wrote: > > > James Hawkins wrote: > > > Ignoring the change that I made, what is wrong with the current code? > > I kindof figured that pstream was tied into ppv, but I wanted to make > > sure. If that is the case, then my a