Re: Wine User Guide Improvements

2004-10-26 Thread Brian Vincent
On Tue, 26 Oct 2004 15:55:45 -0700, Scott Ritchie <[EMAIL PROTECTED]> wrote: > I agree with your plan to condense the guide down. I would still keep > some parts of the Getting Wine chapter and put it at the end of the > introduction, or possibly at the beginning of configuring wine. I agree > ab

Re: rsaenh

2004-10-26 Thread Juan Lang
Hi Michael, that was quick! Okay, more feedback: 1. English note: destruct_handle_table really should be destroy_handle_table. I know, "destructor" came into common use, but the verb is to destroy. Same with destruct_key, destruct_hash, etc. 2. A CSP isn't allocating a "real" handle, it's sort

Re: Re-implement MSVCRT *printf

2004-10-26 Thread Mike McCormack
Aneurin Price wrote: Comments, anyone? Looks like you've put quite a bit of effort into that. I think it's a worthwhile effort, however, please consider: * using a style more consistent with the rest of the Wine codebase * not abusing the preprocessor in printf.h, * not writing C code in the head

Re: [dx9-12] Major change to design

2004-10-26 Thread Alexandre Julliard
"Ann and Jason Edmeades" <[EMAIL PROTECTED]> writes: > In this case (very pseudo code!) > > D3D9 SetStreamSource (idx, d3d9_vb): >Call WineD3D SetStreamSource(idx, d3d9_vb->wined3d_vb) > > WineD3D SetStreamSource: >In an array store the new vb and addref, and release the old one. > > If I

Re: Gradient Color for Caption Bar

2004-10-26 Thread Dmitry Timoshkov
"William Poetra Yoga H" <[EMAIL PROTECTED]> wrote: > This patch is for filling the caption bar (a.k.a. title bar) with gradient > colors, like in Win98/WinME/Win2K/WinXP. > > I've modified nonclient.c too heavily (work on other parts of it), so this > patch may generate offsets or things like tha

RE: Wine User Guide Improvements

2004-10-26 Thread Scott Ritchie
Brian, I agree with your plan to condense the guide down. I would still keep some parts of the Getting Wine chapter and put it at the end of the introduction, or possibly at the beginning of configuring wine. I agree about changing it to be mostly a reference to the relevant parts of WineHQ. Wo

Re: GetTimeZoneInformation return value fix

2004-10-26 Thread Alexandre Julliard
Rein Klazes <[EMAIL PROTECTED]> writes: > - reordered some code from the existing helper _GetTimeZoneBias > to make it more general useful (and changed the helper names to > TIME_xyz). > - Make GetTimeZoneInformation return the correct zone id > constants. > -

RE: [dx9-12] Major change to design

2004-10-26 Thread Ann and Jason Edmeades
>Looks much better yes, thanks. Thanks! >There's still something strange here: >> +/* Not recording... */ >> +if (oldSrc != NULL) { >> +IWineD3DVertexBuffer_Release(oldSrc); >> +IUnknown_Release((IUnknown *)((IWineD3DVertexBufferImpl *)oldSrc)->resource.parent); /* Relea

rsaenh

2004-10-26 Thread Michael Jung
Hello, this is an updated version of the rsaenh implementation from yesterday. Updates: 1.) Broke long lines to not exceed a length of 100 characters. 2.) Substituted tabs with spaces. 3.) Removed magic constants. 4.) Rsaenh now uses MD4, MD5 and SHA from advapi32. 5.) Regression tests should wo

Re: [dx9-12] Major change to desgin

2004-10-26 Thread Alexandre Julliard
"Ann and Jason Edmeades" <[EMAIL PROTECTED]> writes: > I think this patch should keep you happy (It doesn't do any of the > IWineUserDevice stuff as the code isn't ready for it, but does the dual ref > count + adds Set/Get Stream source). Let me know if you have problems with > it. Looks much bet

Re: WSCEnumProtocols

2004-10-26 Thread Alexandre Julliard
Hans Leidekker <[EMAIL PROTECTED]> writes: > On Tuesday 26 October 2004 02:51, Alexandre Julliard wrote: >> You cannot cast a WSAPROTOCOL_INFOA* to a WSAPROTOCOL_INFOW*, the >> structures don't have the same size. > > Not generally no, but here I can because the size difference comes > from the la

Re: rsaenh

2004-10-26 Thread Hans Leidekker
On Tuesday 26 October 2004 17:20, Michael Jung wrote: > There is also a DES implementation in dlls/advapi32/crypt_des.c. However, this > one is not exported by advapi32.dll. I could copy the code over to The DES code is used internally to produce LanManager password hashes. I doubt if you could

Re: shell32: shellpath tests failing greatly

2004-10-26 Thread Juan Lang
Hi Rolf, try reregistering shell32; those entries are supposed to be created by wine.inf when it registers it. --Juan __ Do you Yahoo!? Read only the mail you want - Yahoo! Mail SpamGuard. http://promotions.yahoo.com/new_mail

shell32: shellpath tests failing greatly

2004-10-26 Thread Rolf Kalbermatter
The recently added tests for shellpath are failing almost completely on my system as it is missing the according registry entries. Not sure how one is supposed to get those registry entries properly. Maybe there is an install script? Although the current documentation talks about an utility wineins

FW: GetEnvironmentVariableW regression?

2004-10-26 Thread Rolf Kalbermatter
I suddenly happen to get an error when starting up any application in Wine after having upgraded to current CVS yesterday night from a version a few days ago. The error message is about: "Warning: The specified Windows directory L"c:\\windows" is not accessible" and the same applies for the system

Re: WineHQ: Assorted spelling fixes

2004-10-26 Thread Walt Ogburn
s/concensus/consensus On Tue, 26 Oct 2004, Filip Navara wrote: > Francois Gouget wrote: > > >Index: wwn/wn20041015_244.xml > >=== > >RCS file: /var/cvs/lostwages/wwn/wn20041015_244.xml,v > >retrieving revision 1.1 > >diff -u -r1.1 w

Re: WineHQ: Assorted spelling fixes

2004-10-26 Thread Filip Navara
Francois Gouget wrote: Index: wwn/wn20041015_244.xml === RCS file: /var/cvs/lostwages/wwn/wn20041015_244.xml,v retrieving revision 1.1 diff -u -r1.1 wn20041015_244.xml --- wwn/wn20041015_244.xml 15 Oct 2004 03:59:52 - 1.1 +++ wwn/w

Re: rsaenh

2004-10-26 Thread Kuba Ober
On wtorek 26 paƅdziernik 2004 11:52 am, Juan Lang wrote: > Michael wrote: > > There is also a DES implementation in dlls/advapi32/crypt_des.c. > > However, this one is not exported by advapi32.dll. I could copy the > > code over to dlls/rsaenh, but this would mean unnecessary code > > duplication.

Re: rsaenh

2004-10-26 Thread Juan Lang
Michael wrote: > There is also a DES implementation in dlls/advapi32/crypt_des.c. > However, this one is not exported by advapi32.dll. I could copy the > code over to dlls/rsaenh, but this would mean unnecessary code > duplication. How are such cases handled in wine typically? They are typically h

Re: Re: Problems downloading the RedHat Packages.

2004-10-26 Thread gslink
I downloaded the Oct. Package from Heanet and got garbage. This isn't surprising if it is not there.

Re: rsaenh

2004-10-26 Thread Michael Jung
On Tuesday 26 October 2004 16:56, Juan Lang wrote: > Michael wrote: > > > 1. MD4, MD5, and SHA1 are now implemented in wine's > > > advapi32. Please use these instead of OpenSSL's. > > > > Yes, that makes sense. Would it be possible to move > > the SHA1, MD4 and MD5 related code to some other > >

Wine for Solaris 2.8 assembler problems

2004-10-26 Thread Doug
I am trying to compile Wine for Solaris to get MCS working for mono. However there are problems getting Wine to work on Solaris 2.8. When first compiling wine, I was thought the errors were caused by using the assembler for Solaris so I changed the as (assembler) to the GNU version. Now I get t

Re: rsaenh

2004-10-26 Thread Dimitrie O. Paun
On Tue, Oct 26, 2004 at 10:13:59AM +0200, Michael Jung wrote: > > Finally, some stylistic nits: > > 4. Please break long lines. > Is there a rule for the maximum line lenght in wine? Would 128 characters be > ok? There's no maximum just don't make them too long. 128 is a bit much, <100 is better

Re: rsaenh

2004-10-26 Thread Michael Jung
Hello Juan, thanks for your comments! > 1. MD4, MD5, and SHA1 are now implemented in wine's > advapi32. Please use these instead of OpenSSL's. Yes, that makes sense. Would it be possible to move the SHA1, MD4 and MD5 related code to some other directory in the wine tree and link to it staticall

Re: WSCEnumProtocols

2004-10-26 Thread Hans Leidekker
On Tuesday 26 October 2004 02:51, Alexandre Julliard wrote: > > +INT WINAPI WSAEnumProtocolsA( LPINT lpiProtocols, LPWSAPROTOCOL_INFOA lpBuffer, > > LPDWORD lpdwLength ) > > +{ > > + return WINSOCK_EnumProtocols( lpiProtocols, (WSAPROTOCOL_INFOW *)lpBuffer, > > lpdwLength, FALSE ); > > +} > >