I have compiled crypt and run the tests with no failures.
This latest patch removes all changes to the pointer arithmetic.
On Tue, 03 Aug 2004 07:55:51 +0300, Shachar Shemesh
<[EMAIL PROTECTED]> wrote:
> James Hawkins wrote:
>
> >>- strcpy(keyname + strlen(KEYSTR), pProvName);
> >>
>
James Hawkins wrote:
- strcpy(keyname + strlen(KEYSTR), pProvName);
I changed that line to strcatW(keyname, pProvName). That makes a lot
more sense Mike, thanks for the tip.
I'm wasn't exactly sure on this one so it would be great if you could
help me on this one. When using poin
"James Hawkins" <[EMAIL PROTECTED]> wrote:
> ptr = keyname + strlenW(keyname);
>
> I guess it holds true here as well because keyname is a pointer and
> we're adding ot it. If that is the case, the included patch fixes the
> two things mentioned.
You have to look for other similar, not mentione
On Tue, Aug 03, 2004 at 03:17:27AM +0200, Filip Navara wrote:
> I did another test. I intserted a code into the ListView window
> procedure to print a message every time the internal dwStyle member
> doesn't match the one returned by GetWindowLong with GWL_STYLE. To my
> little surprise they wer
Dimitrie O. Paun wrote:
[snip]
The problem is that WM_STYLECHANGED is sometimes sent, sometimes not,
and it seems so much easier to just update it every time we come in
so we can be sure we're using the latest value, as we should. It's
redundant, I agree, but it's neglijable in terms of performance
Dimitrie O. Paun wrote:
On Tue, Aug 03, 2004 at 01:42:28AM +0200, Filip Navara wrote:
Unfortunetly I can't explain it, because I don't understand it
myself. I
In which case I must object to the patch :( It seems we're just hiding
a problem in a very convoluted way, don't you think?
Well, I agre
On Tue, Aug 03, 2004 at 01:42:28AM +0200, Filip Navara wrote:
> Unfortunetly I can't explain it, because I don't understand it myself. I
In which case I must object to the patch :( It seems we're just hiding
a problem in a very convoluted way, don't you think?
> have inserted debug messages on
Dimitrie O. Paun wrote:
Can you please explain why updating it is a problem? Yes, we may be
doing more work than needed, but at most it should be a no-op.
In fact, we used to call 'GetWindowLongW(hwnd, GWL_STYLE)' every
time we needed to get to the dwStyle, so updating it in there
should be OK.
On Sat, Jul 31, 2004 at 05:52:21AM +0200, Filip Navara wrote:
> Tobias Burnus wrote:
> [snip]
>
> Can you try the attached patch please?
>
> Changelog:
> - Don't update infoPtr->dwStyle in LISTVIEW_WindoProc. It's already
> handled in LISTVIEW_StyleChanged and LISTVIEW_Create processing.
>
>
James Hawkins wrote:
I'm wasn't exactly sure on this one so it would be great if you could
help me on this one. When using pointer arithmetic, do the operations
such as --, ++... increment or decrement by the size of the pointer
type?
Yes, if you have a char (1byte) pointer and you ++, you'll ge
Michael Jung <[EMAIL PROTECTED]> writes:
> If the CSP's CPAcquireContext function fails, which is quite common (e.g.
> because the user specified key container does not exist), the "temp" variable
> is still free'd twice.
Yes, the free needs to be moved inside the if, sorry about that.
> I'm a
Tobias Burnus wrote:
The patch improves the situation a lot! Even Save List works now!
Thanks!
Great!
[snip]
Now, I click on the scrollbar to scroll to the rightmost columns;
while the header is correct, the list itself contains the FIRST
columns not the columns which belong to the column headers
"Dmitry Timoshkov" <[EMAIL PROTECTED]> writes:
> "Alexandre Julliard" <[EMAIL PROTECTED]> wrote:
>> I think it would
>> be better to try to take loadorder into account, though I admit it's
>> not trivial to do.
>
> Any idea how to do it without breaking DLL separation?
A possibility would be to u
> - strcpy(keyname + strlen(KEYSTR), pProvName);
I changed that line to strcatW(keyname, pProvName). That makes a lot
more sense Mike, thanks for the tip.
I'm wasn't exactly sure on this one so it would be great if you could
help me on this one. When using pointer arithmetic, do the
Jeroen Janssen wrote:
I think writing (COM) tests is a great idea.
I have 'hit' a few bumps in the road of wine & COM in the past few weeks
and I would appreciate it if I can help with writing (specific)
testscenarios.
It would be great to have a small 'com test framework' & sample code to
base
Duane Clark wrote:
Howdy,
Debugging a problem I am having in COM (mentioned a few weeks ago), I
think I know what the problem is but not where. So I figured some COM
test would help me to understand how things should work. I was a bit
surprised to see no COM tests, or at least I didn't find any
Howdy,
Debugging a problem I am having in COM (mentioned a few weeks ago), I
think I know what the problem is but not where. So I figured some COM
test would help me to understand how things should work. I was a bit
surprised to see no COM tests, or at least I didn't find any in the ole*
direct
(I sent a version of this to wine-users originally and Ivan said to send
it over here to wine-devel)
On windows XP, with the latest patches/service packs, I got the errors
below.
Since these were popups and/or crashes, I'm assuming they need to be
reported manually.
0. Small issue: The winra
Alexandre,
I've noticed that you applied a modified version of my patch, which tries to
fix a potential double free of the "temp" variable in dlls/advapi32/crypt.c's
CryptAcquireContextA function. However, I think that the modified version
does not fix the problem. Here is a code snippet from t
On Mon, 2 Aug 2004, Ivan Leo Puoti wrote:
> Not sure if I ever forwarded this.
>
> Ivan.
>
> Is it possible to advertise on www.winehq.com? If so, how could we go
> about it?
[...]
> Cheeze Ltd
> www.cheeze.com
I had a look at their web site and it does not look like a company I
would personally
Jeroen Janssen wrote:
As far as I see it I have two options (to run this outprocess
client/server program):
1) use the available proxy/stub code
2) use the typelib marshaller if a typelib is registered
And maybe a 3rd option: use native ole/rpcrt/etc dlls?
---
Jeroen
Not sure if I ever forwarded this.
Ivan.--- Begin Message ---
Is it possible to advertise on www.winehq.com? If so,
how could we go about it?
Best regards,
Vic
Vic Synott
Account Director
Cheeze
Ltd
www.cheeze.com
Tel: 01473 236892
Fax: 01473 236902
Mob: 07775 9208
Hello,
Filip Navara wrote:
Can you try the attached patch please?
The patch improves the situation a lot! Even Save List works now!
Thanks!
Before:
http://www.physik.fu-berlin.de/~tburnus/wine/diamond_list_wine.png
Afterwards:
http://www.physik.fu-berlin.de/~tburnus/wine/diamond_list_wine2.png
The
James Hawkins wrote:
+PWSTR keyname;
- keyname = CRYPT_Alloc(strlen(KEYSTR) + strlen(pProvName) +1);
+keyname = CRYPT_Alloc((strlenW(KEYSTR) + strlenW(pProvName) + 1) *
sizeof(WCHAR));
if (keyname)
{
- strcpy(keyname, KEYSTR);
- str
Fabian Cenedese wrote:
Someone sent me a debug version of a Windows dll and a map file. I'm
not a Windows programmer, and I'm not sure how to use the map fiile.
Look on the microsoft site for crashfinder (it's from a MS Journal article).
It reads the mapfile(s), you can enter an address and
"James Hawkins" <[EMAIL PROTECTED]> wrote:
> Full rewrite. If you have any questions, I'll be happy to answer them.
>
> Changelog
> * clean up cross-call functions
> - strcpy(keyname, KEYSTR);
> - strcpy(keyname + strlen(KEYSTR), pProvName);
> + strcpyW(keyname, KEYSTR);
> + strcpyW(key
>Someone sent me a debug version of a Windows dll and a map file. I'm
>not a Windows programmer, and I'm not sure how to use the map fiile.
Look on the microsoft site for crashfinder (it's from a MS Journal article).
It reads the mapfile(s), you can enter an address and it returns you the
m
27 matches
Mail list logo
