Re: wave tests patch

2004-07-20 Thread Francois Gouget
Francois Gouget wrote: [...] Anyway, assuming that we need to round up I propose to modify the implementation as in the attached patch. The advantage is that it does not rely on ceil(). In fact it doesn't even use floating point arithmetic so we cannot get any rounding error. The code that perfo

Re: Fix winmm's check_position() tests

2004-07-20 Thread Francois Gouget
Robert Reif wrote: I would just revert the patch and recalculate duration based on the fragment size. You need to keep the double because of integer overflow in the MS calculation Well, it won't overflow for the tones we play because they just last a few seconds. But it will start overflowing wh

Re: help with building with winelib on Mac os x

2004-07-20 Thread Jeff Cooper
Thank you, I know.. I email both lists.. hoping someone one the wine list might have an idea.. On Jul 20, 2004, at 2:55 PM, Mike Hearn wrote: On Tue, 20 Jul 2004 13:48:17 -0700, Jeff Cooper wrote: I am trying to build a "Hello World" app with winelib on Mac os x You need to talk to the Darwine

Re: help with building with winelib on Mac os x

2004-07-20 Thread Mike Hearn
On Tue, 20 Jul 2004 13:48:17 -0700, Jeff Cooper wrote: > I am trying to build a "Hello World" app with winelib on Mac os x You need to talk to the Darwine guys. They are the ones porting Wine to MacOS.

help with building with winelib on Mac os x

2004-07-20 Thread Jeff Cooper
I am trying to build a "Hello World" app with winelib on Mac os x I have done so by mimicking how winemine is built or modifying the winemine make file to work with the hello world app. This uses GCC to build correct?.. I then try winemaker to create a make file, and when trying to build with

Re: winetest timeout question

2004-07-20 Thread Ferenc Wagner
Robert Reif <[EMAIL PROTECTED]> writes: > Has anyone considered changing the timeout logic to be reset > every time something is printed? This would allow long tests > that periodically output something to run more than 2 minutes. > Timeout would only occur 2 minutes after the last output. Yes,

Re: Fix crash in dsound test

2004-07-20 Thread Ferenc Wagner
Francois Gouget <[EMAIL PROTECTED]> writes: > On Mon, 19 Jul 2004, Ferenc Wagner wrote: > >> maybe winetest should explicitly reset >> WINETEST_INTERACTIVE and the other variables... > > It should probably do so. But maybe it could also have an > option to explicitly let you run a specific test in

Re: wave tests patch

2004-07-20 Thread Francois Gouget
Robert Reif wrote: Notify when position format not supported. Test that position is 0 at start. Good patch. I was worried that tracing all waveGetPosition() failures would clober the output but after that's what one wants when tracing is enabled. Plus it uncovers interesting results: wave.c:584:

Re: winetest timeout question

2004-07-20 Thread Francois Gouget
Robert Reif wrote: I would like to change the wave tests to always play and record so all code paths can be exercised. A normal run for a single sound card takes over 2 minutes so the test times out before test completion. Actually there's a way to make the tests run faster. They take long becaus

bind() test fails

2004-07-20 Thread James Hawkins
Hi, I ran the winsock tests and the only failure i received was from bind: sock.c:660: Test failed: bind() failed error: 10048 I checked msdn and error 10048 is WSAEADDRINUSE. The code for the test of this part is: rc = bind(s2, (struct sockaddr*)&saddr, sizeof(saddr)); ok(rc==SOCKET_ERROR, "bi

Re: Don't crash on NULL data in RegSetValueEx

2004-07-20 Thread Andreas Mohr
Hi, On Tue, Jul 20, 2004 at 03:25:57PM +0100, Mike Hearn wrote: > I tested this on Win98. The platform SDK installer does this. Ah, right, my uncommitted patch from April 14. > +if (!data) return ERROR_INVALID_PARAMETER; > + > if (!is_version_nt()) /* win95 */ > { Are you sure this

Re: Fix winmm's check_position() tests

2004-07-20 Thread Andreas Mohr
Hi, On Tue, Jul 20, 2004 at 02:19:22AM +0200, Francois Gouget wrote: > Sometimes in the VMware virtual machines I do get 96000 instead of 96001 > for the 96kHz tests. But that does not seem systematic. Maybe that's the > pcm conversion bug you mentioned? > > So do you have any idea why we are g