Re: Do we still need wineinstall?

2004-06-14 Thread Dimitrie O. Paun
On Sun, Jun 13, 2004 at 09:23:53PM +0100, Mike Hearn wrote: > So - do we still need it? I don't think so. You have my vote to nuke it :) (getting rid of it is on the 0.9 TODO BTW) -- Dimi.

Re: winetest: move to resources (take n) (resend)

2004-06-14 Thread Alexandre Julliard
Ferenc Wagner <[EMAIL PROTECTED]> writes: > This is a resend to elicit some feedback on your objections > against this patch. What did I miss again? It's much better this time. The only thing I would suggest changing is that the build info text formatting should be done in the code, not in the m

Re: [USER] 'Fix' SetWindowsHookEx

2004-06-14 Thread Alexandre Julliard
Lionel Ulmer <[EMAIL PROTECTED]> writes: > Anyway, what I know is that the application explicitely puts the NULL > parameter, so it's not a bug upstream. So either it's something that worked > on Windows95 and not anymore (as the application is quite old) or a problem > in Wine. > > I will try to

Re: [USER] 'Fix' SetWindowsHookEx

2004-06-14 Thread Lionel Ulmer
On Mon, Jun 14, 2004 at 12:58:55PM -0700, Alexandre Julliard wrote: > This doesn't look right, it doesn't make sense to create a system-wide > hook without an instance, since in that case there is no way to call > the function in other processes. This requires more investigation to > find out exact

Re: [USER] 'Fix' SetWindowsHookEx

2004-06-14 Thread Alexandre Julliard
Lionel Ulmer <[EMAIL PROTECTED]> writes: > I have actually no idea what exactly is what Windows is doing there, but > this attached patch seems to do the trick. I have no idea if it's correct > though (as I do not know if what GetModuleHandle returns is really the same > thing as what SetWindowsHo

Re: Create DIALOGINFO On Demand When Calling DIALOG_get_info

2004-06-14 Thread Alexandre Julliard
Robert Shearman <[EMAIL PROTECTED]> writes: > This patch fixes bug 2210: > http://bugs.winehq.org/show_bug.cgi?id=2210 > This patch differs slightly from the one posted to wine-devel, as it > includes some checks for NULL return from DIALOG_get_info. I don't think you want to create the dialog in

Re: wine/include ddeml.h

2004-06-14 Thread André Johansen
* Alexandre Julliard (Mon, 14 Jun 2004 11:58:02 -0500) wrote: | Dmitry Timoshkov <[EMAIL PROTECTED]> | Fix CBR_BLOCK definition. | | Patch: http://cvs.winehq.org/patch.py?id=12591 | | Old revision New revision Changes Path | 1.29 1.30 +1 -1 wine/include/

Re: wine/dlls/user/dde client.c

2004-06-14 Thread Ivan
This patch http://www.winehq.com/hypermail/wine-cvs/2004/06/0085.html breaks the build on Mandrake 10.0 using gcc 3.3.2 and make 3.8, with the following error: dde/server.c: In function `WDML_ServerHandleRequest': dde/server.c:580: error: pointers are not permitted as case values make[2]: *** [dde

Re: revised winmm GetDevCaps better pointer check patch

2004-06-14 Thread Alexandre Julliard
Robert Reif <[EMAIL PROTECTED]> writes: > +/* Use the first version for strict compatibility with Microsoft */ > +/* #define WINMM_IsBadWritePtr(x,y) IsBadWritePtr((x), (y)) */ > +#define WINMM_IsBadWritePtr(x,y) ((x)==NULL) This is very confusing, if we don't check the pointer we shouldn't have

Re: General serial communications issues

2004-06-14 Thread Eric Pouech
James Courtier-Dutton a écrit : The serial port problem has now been fixed. It is not in the CVS yet, but the patches attached to previous emails in this thread, when applied to the current CVS, make serial comms work. I hope this gets all your "serial fiscal printers" working with the latest wi

Re: Fix 3 bugs in locale handling

2004-06-14 Thread Alexandre Julliard
Dmitry Timoshkov <[EMAIL PROTECTED]> writes: > 1. If the locale has changed current code never refreshes win.ini > and registry values due to the following test done in GetLocaleInfoW: > > /* first check for overrides in the registry */ > > if (!(lcflags & LOCALE_NOUSEROVERRIDE) && lcid ==

Re: SHELL32:RunFileDlg

2004-06-14 Thread Alexandre Julliard
Filip Navara <[EMAIL PROTECTED]> writes: > +if (!(hRes = FindResourceW(shell32_hInstance, L"SHELL_RUN_DLG", > (LPWSTR)RT_DIALOG))) You cannot use wide char string constants in Wine. -- Alexandre Julliard [EMAIL PROTECTED]

Re: Fix Private Profile Functions for .INI in Current Directory

2004-06-14 Thread Alexandre Julliard
Robert Shearman <[EMAIL PROTECTED]> writes: > As per MSDN (1), if a relative path to a file is passed in to the > {Get,Write}PrivateProfile* functions then the current directory is tried > first, and then if that fails the Windows directory is used (for both > the opening and creating cases). I d

Re: Do we still need wineinstall?

2004-06-14 Thread Ivan
> So - do we still need it? Can we use the registry (BTW then will winecfg be working?) to set up all the stuff we can do in the config file? Stuff such as winver, UseDGA, UseXVidMode, Managed or desktop more, and DllOverrides? If we can, IMHO wineinstall can go. Ivan.

text input focus problem

2004-06-14 Thread Richard Gobeille
Recently I upgraded a piece of software on my system called Synergy.  This software allows one keyboard and mouse to control input on two or more machines via a network connection -- not dissimilar to VNC, except that only the keyboard and mouse input is forwarded, nothing with video, et cetera