Re: Blizzard Updater Problem

2004-06-06 Thread Erich Hoover
I've actually seen the old thread but my problem appeared to be different, I applied the patch and recompiled with no success (I believe I did it appropriately, it manually requested the filenames).  Here is the requested bt output: [EMAIL PROTECTED] Diablo II]$ setarch i386 wine BNupdate.exe

Re: Blizzard Updater Problem

2004-06-06 Thread Saulius Krasuckas
On Sun, 6 Jun 2004, Robert Shearman wrote: > On Sun, 2004-06-06 at 16:14, Saulius Krasuckas wrote: > > For me reversing [2] patch worked out fine. > > > > [1] http://bugs.winehq.org/show_bug.cgi?id=2210 > > [2] http://cvs.winehq.org/patch.py?id=12071 > > Does the attached patch work for you? > >

Re: winmm GetDevCaps better pointer check patch

2004-06-06 Thread Robert Reif
Robert Shearman wrote: On Sun, 2004-06-06 at 19:26, Robert Reif wrote: Not a real program but Microsoft's API checking programs do try non NULL bad pointers and expect an error return rather than a program crash. Are you saying checking a good pointer can cause problems? No, checking a bad

Re: winmm GetDevCaps better pointer check patch

2004-06-06 Thread Robert Shearman
On Sun, 2004-06-06 at 19:26, Robert Reif wrote: > Not a real program but Microsoft's API checking programs do > try non NULL bad pointers and expect an error return rather > than a program crash. > > Are you saying checking a good pointer can cause problems? No, checking a bad pointer can cause p

Re: Blizzard Updater Problem

2004-06-06 Thread Robert Shearman
On Sun, 2004-06-06 at 16:14, Saulius Krasuckas wrote: > On Sun, 6 Jun 2004, Robert Shearman wrote: > > Erich Hoover wrote: > > > I haven't been able to get the blizzard updater to run on recent > > > versions of wine (I've downloaded from CVS to make sure there isn't a > > > fix). I'm not sure i

Re: winmm GetDevCaps better pointer check patch

2004-06-06 Thread Robert Shearman
On Sun, 2004-06-06 at 17:27, Robert Reif wrote: > Do better check on pointers to memory to be written to. ... > +if (IsBadWritePtr(lpCaps, uSize)) ... Does a program depend on these checks? We should only put them in w

RE: Blizzard Updater Problem

2004-06-06 Thread Saulius Krasuckas
On Sun, 6 Jun 2004, Robert Shearman wrote: > Erich Hoover wrote: > > I haven't been able to get the blizzard updater to run on recent > > versions of wine (I've downloaded from CVS to make sure there isn't a > > fix). I'm not sure if this is something wrong with my setup or a bug > > with wine

Re: Versioning and internal APIs

2004-06-06 Thread Paul Davis
>Finally, apparently Paul has had to duplicate a fair amount of Wine code >inside his libfst (library for loading Cubase VST plugins) because the >relevant functions are declared static in Wine. Paul, could you post a >list of exactly what you use? actually, a "fair amount" is an overstatement. it

Versioning and internal APIs

2004-06-06 Thread Mike Hearn
Hi Alexandre, Paul Davis of Ardour has raised a good point: currently despite the fact that the symbols in libwine are versioned, we change them at will and don't change the symbol version, for instance in the patch that made environ passed through to wine_init from main to hack around the general

Re: [winemenubuilder] shell:SHELL32_DllCanUnloadNow (void): stub, WinMain failed

2004-06-06 Thread Luca Capello
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Robert, on 06/06/2004 03:39 PM, Robert Shearman wrote: > Have you tried giving winemenubuilder a Windows path instead of a > Unix path? > And, yes, it isn't very informative when things go wrong. I had already tried, but I forgot to mention it... I

Re: fix for launching unix executables

2004-06-06 Thread Eric Pouech
How did it break then? Alexandre runs the test suites before checking in any patch. I read the patch too fast. It was about pure Unix apps, not winelib apps. Andi is right, there's no test right now for that. A+

Re: [winemenubuilder] shell:SHELL32_DllCanUnloadNow (void): stub, WinMain failed

2004-06-06 Thread Robert Shearman
Luca Capello wrote: > [EMAIL PROTECTED]:~/cvs/wine$ ./wine winemenubuilder \ > /home/luca/.wine/fake_windows/TreeView.lnk > WinMain > next_token > Process_Link > fixme:shell:SHELL32_DllCanUnloadNow (void): stub > err:menubuilder:WinMain failed to build menu item for \ > /home/luca/.wine

Re: [winemenubuilder] shell:SHELL32_DllCanUnloadNow (void): stub, WinMain failed

2004-06-06 Thread Luca Capello
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello, on 06/06/2004 12:03 PM, Mike Hearn wrote: > On Sat, 05 Jun 2004 16:45:23 +0200, Luca Capello wrote: >> Is this a 'wine' bug or a problem with my configuration? > I think it's a Wine bug. wineshelllink is just out of date ... keeping the > menu

Re: [winemenubuilder] shell:SHELL32_DllCanUnloadNow (void): stub, WinMain failed

2004-06-06 Thread Mike Hearn
On Sat, 05 Jun 2004 16:45:23 +0200, Luca Capello wrote: > Is this a 'wine' bug or a problem with my configuration? I think it's a Wine bug. wineshelllink is just out of date ... keeping the menu code working in the face of the change to the new menu system is a *lot* of work. thanks -mike

Re: fix for launching unix executables

2004-06-06 Thread Mike Hearn
On Sat, 05 Jun 2004 13:45:20 +0200, Eric Pouech wrote: > we do. without the patch, running the test suite would fail. There are > also some tests which launch child processes (and child process are > winelib apps). How did it break then? Alexandre runs the test suites before checking in any patc

RE: Blizzard Updater Problem

2004-06-06 Thread Robert Shearman
Erich Hoover wrote: > > I haven't been able to get the blizzard updater to run on recent > versions of wine (I've downloaded from CVS to make sure there isn't a > fix). I'm not sure if this is something wrong with my setup or a bug > with wine (i recently reinstalled my system with Fedora Core