focused code review

2004-05-27 Thread Glen Kaukola
Hi, So one project suggested on the website is to do a focused code review. In particular it talks about getting rid of inefficient uses of strcat. But that leaves me wondering what exactly constitutes an inefficient use of strcat? If anyone could provide an example I'd appreciate it. Thank

[Fwd: winetest: copy and submit manually]

2004-05-27 Thread Robert Reif
oops, wrong list. --- Begin Message --- How does one manually submit a test result that is to big to send automatically --- End Message ---

RE: FW: Edit Paste operation does not behave same as MS Windows

2004-05-27 Thread Krishna Murthy
Title: RE: FW: Edit Paste operation does not behave same as MS Windows This means it is sufficient to return FALSE in EDIT_MakeFit if the honor limit is not set and size exceeds the buffer limit? static BOOL EDIT_MakeFit(EDITSTATE *es, UINT size, BOOL honor_limit) {     HLOCAL hNew32W;

Re: FW: Edit Paste operation does not behave same as MS Windows

2004-05-27 Thread Alexandre Julliard
Krishna Murthy <[EMAIL PROTECTED]> writes: > Actually the logic truncates the data which exceeded the buffer. If the > honor limit is set and the size exceeded, the EDIT_MakeFit will return TRUE. > The following code after the EDIT_MakeFit will try to take limit to the > buffer size. > > + /*

RE: FW: Edit Paste operation does not behave same as MS Windows

2004-05-27 Thread Krishna Murthy
Title: RE: FW: Edit Paste operation does not behave same as MS Windows Actually the logic truncates the data which exceeded the buffer. If the honor limit is set and the size exceeded, the EDIT_MakeFit will return TRUE. The following code after the EDIT_MakeFit will try to take limit to the bu

Re: FW: Edit Paste operation does not behave same as MS Windows

2004-05-27 Thread Alexandre Julliard
Krishna Murthy <[EMAIL PROTECTED]> writes: > - Change log Entry: > EDIT_MakeFit should return TRUE when the honor_limit is set and paste buffer > exceeds the limit. Also EDIT_EM_ReplaceSel should compute size which could > fit in the edit control by truncating the extra characters to behave simila

Re: Repaint the whole nonclient window area on SetWindowPos(SWP_FRAMECHANGED)

2004-05-27 Thread Alexandre Julliard
Dmitry Timoshkov <[EMAIL PROTECTED]> writes: > SetWindowPos(SWP_FRAMECHANGED) causes the whole nonclient window area > to be repainted. > > Also, according to the tests Windows always repaints windows before > SetWindowPos has finished. > > This patch reduces number of message test failures from 5

Re: Add a test for accessing classes from another thread

2004-05-27 Thread Alexandre Julliard
Dmitry Timoshkov <[EMAIL PROTECTED]> writes: > somebody on the ReactOS mailing list mentioned that Windows stores class > information in the per thread list, not a per process or per module list. > That would effecively meant that accessing classes or creating windows > from other threads would fa

Re: atoi and undefined usage

2004-05-27 Thread Mike Hearn
On Thu, 27 May 2004 22:02:58 +0200, André Johansen wrote: > Should Wine care about such undefined behaviour? Currently, it seems > Wine uses the GNU libc implementation, giving a different result than > when running in Windows. Yes, if software depends on it we care ... > (In my case, an IP add

Re: Crash and corrupted registry

2004-05-27 Thread Christian Costa
Steven Edwards wrote: Hello, really bad shape. I use reiserfs on a Mandrake 2.4.21-0.13mdk kernel. It seems to happend on files that are open when the crash (freeze + reboot) occurs. Do you have the LSB package installed in your Mandrake? Yes, it is installed! There are two bugs in Mandra

Re: Crash and corrupted registry

2004-05-27 Thread Christian Costa
Alexandre Julliard wrote: Christian Costa <[EMAIL PROTECTED]> writes: This seems to be more a filesytem issue then because the file is in a really bad shape. I use reiserfs on a Mandrake 2.4.21-0.13mdk kernel. It seems to happend on files that are open when the crash (freeze + reboot) occurs.

atoi and undefined usage

2004-05-27 Thread André Johansen
The atoi() function has undefined usage when trying to convert numbers outside the range of int. When parsing numbers >= 2^31, GNU libc seems to truncate the number to 2^31-1; however, with MSVC, such a number would wrap, and when cast to an unsigned integer, numbers within an unsigned int are pre

Re: test for GetAcceptLanguagesA

2004-05-27 Thread Martin Fuchs
On 27.05.2004 04:09:34 Alexandre Julliard wrote: > Stefan Leichter <[EMAIL PROTECTED]> writes: > > before removing the acsii calls from GetAcceptLanguagesW, i like to see > the > > results of the attached tests. This will hopefuly save me some work when > > rewriting the function. The tests pas

Re: having problem in understanding debug channels

2004-05-27 Thread Mike Hearn
On Thu, 27 May 2004 08:48:18 +0100, zeeshaan umer wrote: > " invalid debug channel specification ' ZEE_DEFAULT_DEBUG_CHANNEL( );' " You use it like this: WINE_DEFAULT_DEBUG_CHANNEL( whatever ); TRACE("foo\n"); will print: trace:whatever:some_func foo thanks -mike

Re: Additional downloads for winehq

2004-05-27 Thread Duane Clark
Ivan wrote: ... and the link to the dcom95 download page is just too long. It's http://www.microsoft.com/downloads/details.aspx?familyid=d7a4de78-81a9-4db7-beb6-84ff99342172&displaylang=en and we want to keep the error log short. You could use: http://tinyurl.com/ which I used to turn the above UR

having problem in understanding debug channels

2004-05-27 Thread zeeshaan umer
hi, its zee here, i am a student and i have just came to know about wine 2-3 weeks ago. i have started studying it for exploration purpose. its quite a great effort of u people. really it is    nways the problem i m having is that i m not clearly understanding debug channels. i actually was

Re: Re: test for GetAcceptLanguagesA

2004-05-27 Thread Pouech Eric DMI AEI CAEN
> Its not a fault of the tests that they fail on wine, its a fault of > wine. For my understanding the test are created to show that either the > behaviour of wine is correct (when the test succeeds) or that something > left to do one wine (when a test fails)!? check out the todo_wine construct in

Re: test for GetAcceptLanguagesA

2004-05-27 Thread Mike Hearn
On Thu, 27 May 2004 12:17:15 +0200, Stefan Leichter wrote: > Its not a fault of the tests that they fail on wine, its a fault of > wine. For my understanding the test are created to show that either the > behaviour of wine is correct (when the test succeeds) or that something > left to do one wi

Re: test for GetAcceptLanguagesA

2004-05-27 Thread Dmitry Timoshkov
"Stefan Leichter" <[EMAIL PROTECTED]> wrote: > Its not a fault of the tests that they fail on wine, its a fault of > wine. For my understanding the test are created to show that either the > behaviour of wine is correct (when the test succeeds) or that something > left to do one wine (when a te

Re: test for GetAcceptLanguagesA

2004-05-27 Thread Stefan Leichter
Alexandre Julliard wrote: Stefan Leichter <[EMAIL PROTECTED]> writes: before removing the acsii calls from GetAcceptLanguagesW, i like to see the results of the attached tests. This will hopefuly save me some work when rewriting the function. The tests passes on my Win2k system. But they

[Janitorial]: Missing inversion im Bit manipulation

2004-05-27 Thread Uwe Bonnes
Changelog: wine/dlls/winmm/winmm.c: Add obvious missing inversion -- Uwe Bonnes[EMAIL PROTECTED] Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt - Tel. 06151 162516 Fax. 06151 164321 -- Index: wine/dlls/winmm/winmm.c ===