RE: Handling dialog messages for non-template based dialogs

2004-04-15 Thread Santosh Siddheshwar
This test fails with WINE even after I create the DIALOGINFO structure the first time it enters DefDlgProc. Not sure why this test should work on Windows. Basically at the stage where you are setting DM_SETDEFID there are no child windows on the dialog. Then what does DM_SETDEFID and DM_GETDEFID do

Re: Wine fixes

2004-04-15 Thread Dimitrie O. Paun
On April 16, 2004 12:16 am, Dimitrie O. Paun wrote: > IMO should just nuke some of these useless includes. > How can we test that they are really needed? Oops, sorry folks, this message was meant for the AbiWord guys! :) -- Dimi.

Re: abnt2 keyboard patch

2004-04-15 Thread Dmitry Timoshkov
"Rafael аvila de EspМndola" <[EMAIL PROTECTED]> wrote: > > 1. You are using 'keysym == 0x2C' for comma, but what happens if NumLock > > is on, and you press comma on the main keyboard, not on the keypad? > > Shouldn't X11 send XK_KP_xxx event in that case (something like > XK_KP_Decimal)? > The fi

Re: dlls/kernel/console.c::SetConsoleCtrlHandler() cleanup/fixup

2004-04-15 Thread Dimitrie O. Paun
On April 15, 2004 7:54 pm, Alexandre Julliard wrote: > Error codes should not be based on suggestions, what you should do is > write a small test program under Windows to find out the real codes. Hopefully, this sort of thing will be easier once we have the testing framework in place. For example,

Re: dlls/kernel/console.c::SetConsoleCtrlHandler() cleanup/fixup

2004-04-15 Thread Dimitrie O. Paun
On April 15, 2004 11:18 am, Peter Riocreux wrote: >   * This doesn't yet matter, since these handlers are not yet called...! > + * > + * Peter Riocreux ([EMAIL PROTECTED]) 2004-04-15 > + *   Added error checking and now uses SetLastError() >   */ One more thing: please don't add this sort of thing

Re: [DXDIAG2] First Implementation

2004-04-15 Thread Alexandre Julliard
Raphael <[EMAIL PROTECTED]> writes: > Yes i know that, but i only need objbase.h who doesn't include windows.h (with > ms vs headers). Yes it does, objbase.h includes rpc.h which includes windows.h. > And the GetProp #define clash doesn't exit at all on windows (not have to > include winbase/w

Re: [DXDIAG2] First Implementation

2004-04-15 Thread Raphael
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Alexandre, On Friday 16 April 2004 01:27, Alexandre Julliard wrote: > Raphael <[EMAIL PROTECTED]> writes: > > + * @TODO: fix wine headers dependencies > > + */ > > +#if !defined( _MSC_VER ) || defined( __WINE__ ) > > +# include "windef.h" > > +# in

Re: dlls/kernel/console.c::SetConsoleCtrlHandler() cleanup/fixup

2004-04-15 Thread Alexandre Julliard
Peter Riocreux <[EMAIL PROTECTED]> writes: > It gives every impression of working for me, but I have only tested it > with one application. > > Suggestions for better extended error codes appreciated. Error codes should not be based on suggestions, what you should do is write a small test program

Re: [DXDIAG2] First Implementation

2004-04-15 Thread Alexandre Julliard
Raphael <[EMAIL PROTECTED]> writes: > + * @TODO: fix wine headers dependencies > + */ > +#if !defined( _MSC_VER ) || defined( __WINE__ ) > +# include "windef.h" > +# include "winbase.h" > +# include "wingdi.h" > +# include "winuser.h" > +/** GetProp is a define by user.h */ > +# undef GetProp > +

RE: More serial access issues

2004-04-15 Thread Geoffrey Hausheer
Well, after tracing the events through wineserver, I see 'serial_queue_event' gets called, serial_get_poll_events returns 'POLLOUT', async_notify gets called (but async->thread->wait is 0, so it doesn't do anything besides setting the status to STATUS_ALERTED. The secod serial_get_poll_events retu

Re: Compiling MFC with latest CVS checkout.

2004-04-15 Thread Dimitrie O. Paun
On Thu, 15 Apr 2004, Manjunath Sripadarao wrote: > >wineg++ -v -mwindows -mno-cygwin -o mfcdb.so mfcdb.res mfcdb.dbg.o > >-lodbc32 -lole32 -loleaut32 -lwinspool -luuid > > > Thanks for the quick reply. What version of Wine are you using? I can't make sense of this. Your command line doesn't

Re: [D3D8] Add support for vertex shader (using ARB_vertex_program extension)

2004-04-15 Thread Christian Costa
Maxime Bellengà wrote: Hi Christian Are you looking for someone to test the patch on an NVIDIA card ? If you tell me how to test or the game to run, I can give you a feedback. a+ Max Hi Maxime, You can try the vertexblend, vertexshader & dolphinvs demos from the DX8 SDK. You can switch bet

Re: wine/tools wineinstall

2004-04-15 Thread Alexandre Julliard
Saulius Krasuckas <[EMAIL PROTECTED]> writes: > what about the case when ~/.wine/dosdevices exists but is empty? I don't think we need to worry about that, this shouldn't happen in normal use. > PS eghm, should it be bad for wineinstall and winecfg to share common code > for creating links in do

Re: abnt2 keyboard patch

2004-04-15 Thread Rafael Ávila de Espíndola
> I still see problems with your patch. > > 1. You are using 'keysym == 0x2C' for comma, but what happens if NumLock > is on, and you press comma on the main keyboard, not on the keypad? > Shouldn't X11 send XK_KP_xxx event in that case (something like XK_KP_Decimal)? The file /usr/include/X11/ke

Re: winegcc: use CC to compile the .spec.c file

2004-04-15 Thread Michael Stefaniuc
Alexandre Julliard wrote: "Dimitrie O. Paun" <[EMAIL PROTECTED]> writes: ChangeLog Dimitrie O. Paun <[EMAIL PROTECTED]> Always use CC to compile the .spec.c file. Doesn't compile_to_object() do this already? No; i know it because when I compile with the smatch gcc i don't get .spec.c.sm

exec-shield patch take 5

2004-04-15 Thread Mike McCormack
Hi, Here's the latest version of a patch I've written to allow wine to run without disabling exec-shield or prelinking. Mike Changes in version 5: * reserve the shared heap area as well as the PE load area * allow multiple reserve areas in libwine Changes in version 4: * set the WINEPEEXEPATH e

Re: [PATCH] Re: help fixing up SetConsoleCtrlHandler()

2004-04-15 Thread Dimitrie O. Paun
On Thu, 15 Apr 2004, Peter Riocreux wrote: > I can't see anyone relying on using something they know to be > wrong. *That* would also be madness Right. And hence our stance. > I have turned it into a trace. > > Patch below. Good. Now, for inclusion in the tree, you need to submit it to [EM

Re: [PATCH] Re: help fixing up SetConsoleCtrlHandler()

2004-04-15 Thread Peter Riocreux
"Dimitrie O. Paun" <[EMAIL PROTECTED]> writes: > On Thu, 15 Apr 2004, Peter Riocreux wrote: > >> I don't know, I just had thought that Wine was attempting to be >> bug-for-bug compatible, and assumed that part of that was honouring >> all the restrictions on usage of functions and how these varied

Re: [PATCH] Re: help fixing up SetConsoleCtrlHandler()

2004-04-15 Thread Dimitrie O. Paun
On Thu, 15 Apr 2004, Peter Riocreux wrote: > I don't know, I just had thought that Wine was attempting to be > bug-for-bug compatible, and assumed that part of that was honouring > all the restrictions on usage of functions and how these varied > between versions. We are not *that* compatible. it

Re: Compiling MFC with latest CVS checkout.

2004-04-15 Thread Manjunath Sripadarao
Dimitrie O. Paun wrote: On April 15, 2004 7:27 am, Manjunath Sripadarao wrote: Any ideas/tips. Am I even following the correct procedure ? There doesn't seem to be any document detailing this process. Any tips/instructions/suggestions would be greatly appreciated. You are on the right trac

Re: [PATCH] Re: help fixing up SetConsoleCtrlHandler()

2004-04-15 Thread Peter Riocreux
"Dimitrie O. Paun" <[EMAIL PROTECTED]> writes: > On April 15, 2004 7:58 am, Peter Riocreux wrote: >> Here is my first cut. >> >> Remember that this is my first patch, so go easy on me with he >> flamethrowers. I know the indenting isn't quite right. > > The formatting doesn't seem too bad, but the

Re: winegcc: use CC to compile the .spec.c file

2004-04-15 Thread Dimitrie O. Paun
On April 14, 2004 8:07 pm, Alexandre Julliard wrote: > Doesn't compile_to_object() do this already? It does, and that's not right. I'll have to fix this properly anyway for good -x support, don't worry about this patch. -- Dimi.

Re: Compiling MFC with latest CVS checkout.

2004-04-15 Thread Dimitrie O. Paun
On April 15, 2004 7:27 am, Manjunath Sripadarao wrote: > Any ideas/tips. Am I even following the correct procedure ? There > doesn't seem to be any document detailing this process. Any > tips/instructions/suggestions would be greatly appreciated. You are on the right track, but you've probably hit

Re: [PATCH] Re: help fixing up SetConsoleCtrlHandler()

2004-04-15 Thread Dimitrie O. Paun
On April 15, 2004 7:58 am, Peter Riocreux wrote: > Here is my first cut. > > Remember that this is my first patch, so go easy on me with he > flamethrowers. I know the indenting isn't quite right. The formatting doesn't seem too bad, but the format is wrong. Please use uniffied diff (-u): http

[PATCH] Re: help fixing up SetConsoleCtrlHandler()

2004-04-15 Thread Peter Riocreux
Here is my first cut. Remember that this is my first patch, so go easy on me with he flamethrowers. I know the indenting isn't quite right. Probably easiest to review by comparing old and new rather than looking at old and patch. Comments, especially regarding more appropriate error values to u

Re: Who's who - Blowing my own horn.

2004-04-15 Thread Kevin Koltzau
On Wednesday 14 April 2004 10:48 pm, Tony Lambregts wrote: > Blowing my own horn. ... > +Location: St. Albert, Alberta, Canada > + IRC Nick: tindalos Thats my IRC nick :)

Compiling MFC with latest CVS checkout.

2004-04-15 Thread Manjunath Sripadarao
I am trying to compile MFC with latest CVS checout, I copied the source from the windows MFC dir and also the include dir (both for MFC and the VC98 include dir). I ran winemaker --interactive . and specified the -I paths. I got a couple of makefiles. Now if I do a make I get this error. [EMAIL

RE: Handling dialog messages for non-template based dialogs

2004-04-15 Thread Santosh Siddheshwar
Actually there is WM_GETMINMAXINFO which comes before WM_NCCREATE but I dont think we should put the DIALOGINFO initialization logic there. WM_NCCREATE should be the better option. Regards Santosh Siddheshwar > -Original Message- > From: Dmitry Timoshkov [SMTP:[EMAIL PROTECTED] > Sent: Thu

Re: Handling dialog messages for non-template based dialogs

2004-04-15 Thread Dmitry Timoshkov
"Santosh Siddheshwar" <[EMAIL PROTECTED]> wrote: > OK.One place where this could be done is WM_NCCREATE which comes before > WM_CREATE. Other place (possibly better) where it might be possible to do > this is in CBTProc hook procedure. Not sure about the second option though. > Any thoughts? I'll

Re: Problem with bad generation of low-level keyboard events

2004-04-15 Thread Lionel Ulmer
> The real bug is that the thread still receives the message even though > it has timed out on the sender side. The message should be cancelled > in that case. I'll have a look at fixing that. This will fix the 'bad key-press' event bug... But it will still mean that the game will miss a keyboard