Kevin Koltzau <[EMAIL PROTECTED]> writes:
> I guess I'd probably need to define each string beforehand like
> WCHAR szString[] = {'S','T','R','I','N','G','\0'};
> and use that in the map, but before I undergo that large task I would like to verify
> thats the best way
Either that, or you can dec
"Martin Fuchs" <[EMAIL PROTECTED]> writes:
> This was no joke. If you say, you would accept such as reformating patch,
> I can easyly create one that eliminates all tab-characters, and generates
> nice and uniform indented code.
> This will make it a bit easier to create the small self-contained p
I'm trying to get some of the wine tests compiling and running under windows,
oleaut32 test specifically. I've got the project file built and everything
opens fine under visual studio 6. The only issue is that during linking of
the oleaut32 tests _IID_IFont is undefined. Oddly enough if I swi
Indentation in CopyMetaFileW is a bit inconsistent (there are some tabs
which I left since I didn't touch those lines). Should I redo my patch
to get rid of them (adds some noise to the patch), keep them in a
separate patch (limited to this very function) or leave it as is?
Also, should I change M
On Monday 12 January 2004 07:07 pm, Alexandre Julliard wrote:
> Kevin Koltzau <[EMAIL PROTECTED]> writes:
> > As far as inefficent that wasnt my concern as the data is only
> > loaded once at startup and never touched again
> > If it is an issue I will change this and resubmit
>
> Startup performan
On Tue, 13 Jan 2004 00:10:20 +, Mike Hearn wrote:
> This patch makes the halflife menu screen look a bit better, with less
> flashing. Unfortunately it also makes it feel a bit slower, but I think
> that's just an optical illusion caused by less screen activity. The
> bottleneck is elsewhere.
Kevin Koltzau <[EMAIL PROTECTED]> writes:
> As far as inefficent that wasnt my concern as the data is only
> loaded once at startup and never touched again
> If it is an issue I will change this and resubmit
Startup performance is definitely an issue. This is done for every
app, and we are alread
"Dimitrie O. Paun" <[EMAIL PROTECTED]> writes:
> Yay! (I submitted a similar patch some time ago, but you
> didn't like the {Start,End}GraphicsExposures functions.
> I still think they are decent GUI abstractions :)):
And I still disagree
> Speaking of these things, I also don't think the drive
The reason I did that was because of the large quantity of data, it was easier to
define unicode strings in resources
then it is to do in code, and I got a free method of seperating part/state data for
each class
As far as inefficent that wasnt my concern as the data is only loaded once at startu
Christian Costa <[EMAIL PROTECTED]> writes:
> Alexandre Julliard wrote:
>
>>This isn't thread-safe.
>>
> The function that uses them is a timer callback.
You are right, this doesn't matter then.
> Well, I intended, in later patches, to update the poll fds when
> opening or closing devices and th
> > There are also a number of unneeded whitespace changes that make the
> > patch larger than it should be.
>
> Yes, I tried to make some functions I had to alter a bit more readable.
> What about running a pretty printer, for example astyle
> (http://astyle.sourceforge.net/)
> on the whole code
On Mon, 12 Jan 2004, Alexandre Julliard wrote:
> Log message:
> ScrollDC doesn't need to be in the graphics driver.
Yay! (I submitted a similar patch some time ago, but you
didn't like the {Start,End}GraphicsExposures functions.
I still think they are decent GUI abstractions :)):
http:/
--- Hans Leidekker <[EMAIL PROTECTED]> wrote:
> It must be a leftover from a configure run. I suspected my own tree
> but
> but it came back after I removed it and did a cvs update.
I have seen it before and always thought it was supposed to be there.
=)
Thanks
Steven
_
Kevin Koltzau <[EMAIL PROTECTED]> writes:
> This is a ton of infrastructure for my future patches, and a full
> implementation of GetThemeDocumentationProperty which I primarilly
> used to test my INI file processing, and its now possible to set the
> current theme through the API..not that its mu
Alexandre Julliard wrote:
Christian Costa <[EMAIL PROTECTED]> writes:
+static int npfd;
+static int pfd_array_size = 0;
+static struct pollfd *pfd = NULL;
This isn't thread-safe.
The function that uses them is a timer callback.
Why don't you simply allocate the array in the
function and
Christian Costa <[EMAIL PROTECTED]> writes:
> +static int npfd;
> +static int pfd_array_size = 0;
> +static struct pollfd *pfd = NULL;
This isn't thread-safe. Why don't you simply allocate the array in the
function and free it when you are done?
--
Alexandre Julliard
[EMAIL PROTECTED]
Le lun 12/01/2004 à 02:35, Dmitry Timoshkov a écrit :
> "Vincent Beron" <[EMAIL PROTECTED]> wrote:
>
> > Changelog:
> > Get rid of a W->A crosscall (ResetDCA->ResetDCW).
>
> > -HDC WINAPI ResetDCW( HDC hdc, const DEVMODEW *devmode )
> > +HDC WINAPI ResetDCA( HDC hdc, const DEVMODEA *devmode )
> >
On Mon, Jan 12, 2004 at 09:12:54PM -0500, Hans Leidekker wrote:
>
> Hi,
>
> There's a stray file, dlls/checklink.c, in Wine CVS with these contents:
>
> int main(void)
> {
> return 0;
> }
>
> It must be a leftover from a configure run. I suspected my own tree but
> but it came back after I
Hi,
There's a stray file, dlls/checklink.c, in Wine CVS with these contents:
int main(void)
{
return 0;
}
It must be a leftover from a configure run. I suspected my own tree but
but it came back after I removed it and did a cvs update.
-Hans
On Mon, 12 Jan 2004, Steven Edwards wrote:
> http://cvs.reactos.com/cvsweb.cgi/reactos/subsys/system/regedit/
BTW, I don't know who "weiden" is (he seems to have made all the
commits), maybe he can help me with this questions. Does the
commit with this log:
updated regedit (and some minor ch
On Mon, 12 Jan 2004, Steven Edwards wrote:
> Mainly we just converted the bitmaps to icons and made
> it look more like Windows regedit. Also there are some fixes for
> writting string values.
>
> http://cvs.reactos.com/cvsweb.cgi/reactos/subsys/system/regedit/
I will try to extract stuff, thank
--- "Dimitrie O. Paun" <[EMAIL PROTECTED]> wrote:
> WineConf will a good chance to flush these things out. You guys
> should
> assemble a list of problems (as seen on your end), and we should try
> to come up with a plan that maximizes the amount of files you can
> reuse
> "as is" (keyword: "as is"
On Mon, 12 Jan 2004, Steven Edwards wrote:
> 1. They dont add much to WINE except cleaning up the TWEAK_WINELOOK
> stuff. I would have already started sending patches to remove this code
> from Winehq but I am wanting uxtheme to come along a little more so we
> can see if we can create a Win 3.1 t
--- "Dimitrie O. Paun" <[EMAIL PROTECTED]> wrote:
> There is csgrep in the tools/ module in CVS, but for that
> to work you guys need to run our commit_prep and log_accum
> in CVSROOT. If you do that, you get the wine-cvs - type
> messages for free, and can use our patch.py script to
> generate pat
On January 12, 2004 09:14 am, Steven Edwards wrote:
> There has to be a more simple way of us diffing our patches. Would any
> of the scripts you use on Crossover merging help us?
There is csgrep in the tools/ module in CVS, but for that
to work you guys need to run our commit_prep and log_accum
i
Hi,
--- Ge van Geldorp <[EMAIL PROTECTED]> wrote:
> I am more than willing to do a little bit of extra work to keep our
> trees in synch but the simple fact remains that if the only way to
> get
> something accepted into Wine is to create a new Win95 installation
> and
> see how things work there I
Hiya M8,
--- Alexandre Julliard <[EMAIL PROTECTED]> wrote:
> I know it's a pain, but the real solution for next time is to submit
> things as soon as they are done, instead of waiting a month and then
> sending a huge patch that cannot possibly be reviewed.
There has to be a more simple way of us
On 12.01.2004 01:41:45 Alexandre Julliard wrote:
> "Martin Fuchs" <[EMAIL PROTECTED]> writes:
>
> > Mhh - could you please tell me which "ugly hacks" you are speaking of?
>
> From a quick look at the patch, what I noticed is mostly the ifdefs
> and other various disabling/commenting out of parts
"Vincent Beron" <[EMAIL PROTECTED]> wrote:
> Changelog:
> Get rid of a W->A crosscall (ResetDCA->ResetDCW).
> -HDC WINAPI ResetDCW( HDC hdc, const DEVMODEW *devmode )
> +HDC WINAPI ResetDCA( HDC hdc, const DEVMODEA *devmode )
> {
> -return ResetDCA(hdc, (const DEVMODEA*)devmode); /* FIXME */
29 matches
Mail list logo
