On January 11, 2004 09:56 pm, Ge van Geldorp wrote:
> o you guys really believe that a pile of 107
> patch mails while Alexandre was unavailable would have been a better
> idea?
Absolutely. It's way better than a big huge patch. A huge patch
is meaningless for anybody reviewing, we can just put it
On January 11, 2004 03:43 pm, Vincent Béron wrote:
> Dimi, do you prefer to keep track of progress on this yourself, or
> should I send a patch for the janitorial page too?
It would be great if you'd send the update to the janitorial page.
I try to keep track, but it's so much easier if patch auth
> From: Dimitrie O. Paun
> Sent: Monday, January 05, 2004 05:33
>
> On January 2, 2004 01:12 pm, Steven Edwards wrote:
> > http://cvs.reactos.com/cvsweb.cgi/reactos/lib/user32/controls/
> > Is a good example of a place where we have been able to
> > import a large chunck of WINE user32 code witho
Well, the patch apparently helps in some cases and hurts in others, so
the only way to decide is to write a test and determine what the exact
behavior is under Windows. I agree the current behavior looks wrong,
but that doesn't mean anything when dealing with Microsoft code...
A quick foo.c shows t
> I'm afraid you'll have to do that. There's no way I can put that patch
> in as is, it's way too big and doing way too many different things. It
> also has a number of ugly hacks that will have to be cleaned up.
> Please submit small self-contained patches that do only one thing,
> with a changelo
On Monday 12 January 2004 07:22, Robert Lunnon wrote:
> There is a warning in signal_i368.c
>
> WARN( "exception outside of stack limits in thread %04lx eip %08lx esp
> %08lx stack %p-%p\n",
>GetCurrentThreadId(), EIP_sig(sigcontext),
>
>
> Can anyone tell me what this "means" i
Eric Pouech wrote:
Christian Costa a écrit :
+for (wDevID = 0; wDevID < MIDM_NumDevs; wDevID++)
+if ( (ev->source.client == MidiInDev[wDevID].addr.client) &&
(ev->source.client == MidiInDev[wDevID].addr.client) )
+break;
Why do you do twice the same test ?
A+
Indeed this is
Robert Lunnon <[EMAIL PROTECTED]> writes:
> WARN( "exception outside of stack limits in thread %04lx eip %08lx esp %08lx
> stack %p-%p\n",
>GetCurrentThreadId(), EIP_sig(sigcontext),
>
>
> Can anyone tell me what this "means" in terms of what would have to go wrong
> to gener
"Martin Fuchs" <[EMAIL PROTECTED]> writes:
> Yes, I am aware of that.
> This patch is the result of four weeks work (not only of me), spending
> most of the time with debugging, as most of those stuff is pretty
> undocumented by Microsoft. It's not possible to simply look at the
> ReactOS CVS hist
Jeremy White <[EMAIL PROTECTED]> writes:
> It's been years since I was a Stevens expert, but there was a day
> when I was, and my gut reaction to that patch was one of
> shuddering horror. In fact, I really should
> argue for the complete reversal of the patch until a regression
> test can conclu
There is a warning in signal_i368.c
WARN( "exception outside of stack limits in thread %04lx eip %08lx esp %08lx
stack %p-%p\n",
GetCurrentThreadId(), EIP_sig(sigcontext),
Can anyone tell me what this "means" in terms of what would have to go wrong
to generate this warning
Changelog:
CreateDC in wineps is Unicode now, change the spec file accordingly.
Vincent
Index: dlls/wineps/wineps.spec
===
RCS file: /home/wine/wine/dlls/wineps/wineps.spec,v
retrieving revision 1.22
diff -u -r1.22 wineps.spec
--- dll
Christian Costa a écrit :
+ for (wDevID = 0; wDevID < MIDM_NumDevs; wDevID++)
+ if ( (ev->source.client == MidiInDev[wDevID].addr.client) &&
(ev->source.client == MidiInDev[wDevID].addr.client) )
+ break;
Why do you do twice the same test ?
A+
On Sat, Jan 10, 2004 at 03:47:49PM -0500, Vincent Béron wrote:
> Maybe Jason or Lionel or Rafael can take a look at how to prevent a
> compilation problem here. I recall a push for including a set of GL
> headers with Wine to get rid of all those compilation problems...
We can't really do this saf
Marcus Meissner wrote:
On Fri, Jan 09, 2004 at 12:03:10PM +, Mike Hearn wrote:
On Thu, 08 Jan 2004 16:46:53 -0800, Alexandre Julliard wrote:
You should not use alloca in Wine, it's not portable enough.
Could we take the glib implementation of alloca and stick it into
libwine_por
> Martin, sending a bunch of patches compressed and in one message,
> makes them almost unreviewable but by the most die hards readers
> of wine-patches. It also makes it so much more difficult for
> Alexandre to split them up, match the ChangeLog, review them, etc.
> Please stick to one-(uncompres
Sorry, I forgot to include the new file "shlcpanel.c" into the shell32 patch mail.
Changelog:
- Implementation of control panel folder in shgell namespace
--
Martin Fuchs
[EMAIL PROTECTED]
shlcpanel.patch
Description: Binary data
- Original Message -
From: "Alexandre Julliard" <[EMAIL PROTECTED]>
To: "Sami Aario" <[EMAIL PROTECTED]>
Cc: <[EMAIL PROTECTED]>
Sent: Sunday, January 11, 2004 3:58 AM
Subject: Re: Build fails for current CVS update
> "Sami Aario" <[EMAIL PROTECTED]> writes:
>
> > I've determined that ve
On January 11, 2004 08:04 am, Martin Fuchs wrote:
> This patch consists of a number of changes we implemented in the ReactOS
> CVS tree in order to use Wine's shell32.dll implementation for ReactOS
> explorer. Please see the following changelog lists for the individual patch
> descriptions:
Martin
On Sun, Jan 11, 2004 at 12:36:46PM +, Mike Hearn wrote:
> > -/* The game GrandPrixLegends binds more than one time,
> > but does
> > - * not do a SO_REUSEADDR - Stevens says this is ok */
> > -TRACE( "Setting WS_SO_REUSEADDR on socket before we
Ivan Leo Murray-Smith wrote:
With this change, we can use the 6.3 version of Quicktime
to see streamed video from Wineconf...
This would break Grand Prix Legends and Nascar 2002 (Thats why the patch was
written in the first place), maybe you should contact the author of the patch, a
proper fix woul
That looks familiar. In fact, the TRACE was originally a FIXME but it
caused so much spew with so many apps I changed it. I couldn't see exactly
what needed to be fixed given the contents of the message - it seems to be
simply informing us of progress, but it's a possibility somebody knew this
wasn
22 matches
Mail list logo
