Re: kernel32: Fix lstrcmp(i)A/W to correct return values and document this behaviour

2003-10-24 Thread Dmitry Timoshkov
"Rolf Kalbermatter" <[EMAIL PROTECTED]> wrote: > int WINAPI lstrcmpA(LPCSTR str1, LPCSTR str2) > { > -int ret = CompareStringA(GetThreadLocale(), 0, str1, -1, str2, -1); > -if (ret) ret -= 2; > -return ret; > + int ret = CompareStringA(GetThreadLocale(), 0, str1, -1, str2, -1); > +

Re: Summary of translations

2003-10-24 Thread Vincent Béron
Le ven 24/10/2003 à 06:28, Dimitrie O. Paun a écrit : > On October 21, 2003 05:07 pm, Vincent Béron wrote: > [sorry for the late reply, I thought I did, but I didn't :)] > > > Would a row for each combination resource type+ID be too much? > > No, I think that's just perfect to start with. Ok, I'

Re: Translation support (wrc)

2003-10-24 Thread Vincent Béron
Le jeu 23/10/2003 à 23:55, Alexandre Julliard a écrit : > Vincent Béron <[EMAIL PROTECTED]> writes: > > > Changelog: > > Add support for comparing resources to wrc for translations. > > That's a clear case of preprocessor abuse... there has to be a better > way to do that than with a 100-line mac

Re: ClipCursor values init on start (resize missing update values)

2003-10-24 Thread Carlos Lozano
El vie, 24 de oct de 2003, a las 23:08, Carlos Lozano escribio: > > - Windows init the clipcursor values with width and height of > the screen of the primary display monitor. > (Theme Hospital mouse is now fixed) Hmmm, it is even more complex what i had thought. When the resolution mode is c

RE: FoldStringA (using W version)

2003-10-24 Thread Rolf Kalbermatter
Shachar Shemesh [mailto:[EMAIL PROTECTED] > >Well so you want to say, if I want to test strings for equality > >I do first have to call GetLastError() to check if it was an error > >or if they are really equal? > > > >This won't work as by definition a WinAPI function is usually not > >supposed to

Re: FoldStringA (using W version)

2003-10-24 Thread Shachar Shemesh
Rolf Kalbermatter wrote: Jon Griffiths [mailto:[EMAIL PROTECTED] wrote: +goto FoldStringA_exit; ^^ No allocation has been done yet, just "return 0;" would be enough! Indeed, although the above is functionally identical. Feel free to submit a patch if

RE: FoldStringA (using W version)

2003-10-24 Thread Jon Griffiths
Hi, > This won't work as by definition a WinAPI function is usually not > supposed to reset the last error if no error has occurred, so > GetLastError() may return an error even though the strings were > just simply equal. Of course it 'works': SetLastError(0); SomeCall(); if (GetLastError()) {

Re: FoldStringA (using W version)

2003-10-24 Thread Jon Griffiths
Hi, > +goto FoldStringA_exit; > ^^ > No allocation has been done yet, just "return 0;" would be > enough! Indeed, although the above is functionally identical. Feel free to submit a patch if you feel strongly about it... > Interesting idea, but I wonder how y

Re: WineHQ: PATCH to fix IPersistFile::Load() and associated functions

2003-10-24 Thread Vincent Béron
Le ven 24/10/2003 à 13:21, Subhobroto Sinha a écrit : > Hi. > > I finally produced the "official patch" after > verifying that everything is OK. > Thanks to Dimi for putting up a temporary diff for me > meanwhile ;) > > This patch has been inlined as well as attached as a > ZIP file, so suit your

IPersistFile patch

2003-10-24 Thread Ivan Leo Murray-Smith
>BTW: If I should have submitted at 'wine-patches' >rather at 'wine-devel', please let me know :=) >I really want this BUG fixed you know ;-) If you send your patch to wine-patches and it's OK for Alexandre, your patch will get into the CVS, and into the next release of wine.

WineHQ: PATCH to fix IPersistFile::Load() and associated functions

2003-10-24 Thread Subhobroto Sinha
Hi. I finally produced the "official patch" after verifying that everything is OK. Thanks to Dimi for putting up a temporary diff for me meanwhile ;) This patch has been inlined as well as attached as a ZIP file, so suit yourself. All reports regaring this patch is to be sent to with a proper s

Winesetuptk

2003-10-24 Thread Ivan Leo Murray-Smith
Rc1 had a bug that caused winesetuptk to crash when it looked for a real windows drive and didn't find one. Also, with rc2 winver is set to 98, as a lot of apps refuse to install on 95. source http://www003.portalis.it/115/download/prerelease/winesetuptk0.7rc2.tar.bz2 binary http://www003.portalis.

Re: Winesetuptk 0.7 rc1

2003-10-24 Thread Ivan Leo Murray-Smith
>My ignorance may be obvious here, but is there any reason it is 5 meg? >(I don't remember the old one being that big.) You can get a 700kb compressed binary at www003.portalis.it/115/download/prerelease/winesetuptk0.7rc1.bz2 freedback is welcome.

RE: FoldStringA (using W version)

2003-10-24 Thread Rolf Kalbermatter
Jon Griffiths [mailto:[EMAIL PROTECTED] wrote: > > +goto FoldStringA_exit; > > ^^ > > No allocation has been done yet, just "return 0;" would be > > enough! > > Indeed, although the above is functionally identical. Feel free to > submit a patch if you feel str

Bug in cxx_frame_handler

2003-10-24 Thread Robert Shearman
Hi, I believe there is a bug in cxx_frame_handler which causes an infinite loop of exceptions I believe the offending lines are 359-364. BTW, original exception was a call to NULL. Wine Trace: trace:seh:EXC_RtlRaiseException code=c005 flags=0 addr=(nil) trace:seh:EXC_RtlRaiseException info

Re: Summary of translations

2003-10-24 Thread Dimitrie O. Paun
On October 21, 2003 05:07 pm, Vincent Béron wrote: [sorry for the late reply, I thought I did, but I didn't :)] > Would a row for each combination resource type+ID be too much? No, I think that's just perfect to start with. Would be nice to have some DHTML that allows expansion and collapsing per