Re: Display detection bug

2003-09-04 Thread Lionel Ulmer
On Thu, Sep 04, 2003 at 02:23:34PM -0700, hatky wrote: > Some games are failing at detecting a 3D card or > sometimes the screen dept, have a look at bug : > > http://bugs.winehq.org/show_bug.cgi?id=1696 > > getting into another bugzila/testing prenzy, What about rather a coding / debugging fren

Re: commctrl.h cleanup

2003-09-04 Thread Dimitrie O. Paun
On September 4, 2003 08:37 pm, Alexandre Julliard wrote: > Actually I've been playing with my script for a bit, and I now have > fixed pretty much all the major issues, so you probably don't want to > work on it any more at this point. But if you have a patch for > ntstatus.h that you could send me

Re: commctrl.h cleanup

2003-09-04 Thread Alexandre Julliard
"Dimitrie O. Paun" <[EMAIL PROTECTED]> writes: > This works well for the three big ones: windef.h/winbase.h/winuser.h > For other we will include a lot on unnecessary headers. For example, > ntstatus.h is not needed in many files that include winnt.h. Yes, ntstatus.h is a bit different, and proba

Re: commctrl.h cleanup

2003-09-04 Thread Dimitrie O. Paun
On September 4, 2003 07:08 pm, Alexandre Julliard wrote: > Anyway, just to show it can be done here's the beginning of such a > script; you can do 'fix-includes windef.h winbase.h ' and it > will make sure all the files listed include windef.h before winbase.h > without making unnecessary changes.

Re: commctrl.h cleanup

2003-09-04 Thread Alexandre Julliard
"Dimitrie O. Paun" <[EMAIL PROTECTED]> writes: > I have a lot more changes (cleanup of winnt.h), do you want me to drop > them all? Fixing _all_ headers is a big task, I don't understand why > we can't do it in distinct chunks Because such large scale changes are a real pain for everybody who

Display detection bug

2003-09-04 Thread hatky
Some games are failing at detecting a 3D card or sometimes the screen dept, have a look at bug : http://bugs.winehq.org/show_bug.cgi?id=1696 getting into another bugzila/testing prenzy, hatky. __ Do you Yahoo!? Yahoo! SiteBuilder - Free, easy-to-use web site desig

Re: [dcom 1.2] Implement dispatch variant marshalling

2003-09-04 Thread Dimitrie O. Paun
On 4 Sep 2003, Mike Hearn wrote: > Another possibility is to have a wine convenience macro, similar to the > glib g_return_if_fail() macro, that works for instance: > > wine_return_if_fail_hr(CoDoSomethingCOMRelated()) > > which expands to > { >HRESULT hr = CoDoSomethingCOMRelated() >if

Re: [dcom 1.2] Implement dispatch variant marshalling

2003-09-04 Thread Dimitrie O. Paun
On 4 Sep 2003, Mike Hearn wrote: > I removed the use of asserts to check the results, and replaced them > with ERRs. > + working_mem = GlobalAlloc(0, size); > + if (!working_mem) { > +ERR("failed to get a global alloc\n"); > +return oldpos; > + } I don't think this is such a good idea

Re: [dcom 1.2] Implement dispatch variant marshalling

2003-09-04 Thread Mike Hearn
On Thu, 2003-09-04 at 20:53, Dimitrie O. Paun wrote: > I'd prefer we don't have there -- they really clutter the code, > provide a bad example to follow, and provide little, if any, > benefit. What you can do is put some strategic TRACEs that would > help someone who knows the code to identify the

Re: commctrl.h cleanup

2003-09-04 Thread Dimitrie O. Paun
On Thu, 4 Sep 2003, Alexandre Julliard wrote: > In other words we need to fix all the headers at once, and apply one > big patch that fixes all the C files that need fixing in one step. > I know it's a lot of work, that's why I suggested writing a script... I have a lot more changes (cleanup of w

RE: TreeView & WM_NOTIFY

2003-09-04 Thread Igor Grahek
I think I found the source of my problem: - Wine/windows/win.c ::CreateWindowEx if ((cs->style & (WS_CHILD|WS_POPUP)) == WS_CHILD) parent = WIN_GetFullHandle(cs->hwndParent); else owner = GetAncestor( cs->hwndParent, GA_ROOT ); --

Re: winres.h cleanup

2003-09-04 Thread Eric Pouech
[EMAIL PROTECTED] wrote: I dont see the reason for this change... The real version of winres.h from microsoft includes winresrc.h the little script I used didn't handle properly all the cases (mainly when I didn't have the file in my SDK reference...) here's an update to the list (and the shell sc

Re: commctrl.h cleanup

2003-09-04 Thread Alexandre Julliard
"Dimitrie O. Paun" <[EMAIL PROTECTED]> writes: >> I think there will still >> be a lot of changes to make, and I'd really prefer to avoid having to >> fix the same C files again and again. > > In other words? Is it OK if I fix prsht.h as well? It was a lot of > work you know... In other words we

Re: commctrl.h cleanup

2003-09-04 Thread Dimitrie O. Paun
On Thu, 4 Sep 2003, Alexandre Julliard wrote: > Looks like you have been reorganizing a bit too much, config.h and > wine/port.h should always be included before anything else. I did not realize this. We don't (or we shouldn't) test for HAVE_* in our header files (except port.h), so I was only aw

Re: commctrl.h cleanup

2003-09-04 Thread Alexandre Julliard
"Dimitrie O. Paun" <[EMAIL PROTECTED]> writes: > I know, it would be nice to have an intelligent utility to > cleanup the headers, but by the looks of it, it has to be > rather smart. This is probably one of the more difficult > cleanups, and I did it all by hand, which gave me a chance > to clean

Re: winres.h cleanup

2003-09-04 Thread Dimitrie O. Paun
On Thu, 4 Sep 2003 [EMAIL PROTECTED] wrote: > I dont see the reason for this change... > The real version of winres.h from microsoft includes winresrc.h Sorry, I don't have the MS headers, and it seemed from the list Eric sent to the list that it's not included. Alexandre, please disregard this

Re: winres.h cleanup

2003-09-04 Thread jonwil
I dont see the reason for this change... The real version of winres.h from microsoft includes winresrc.h

Re: Bugzilla down?

2003-09-04 Thread Jeremy Newman
On Wed, 2003-09-03 at 14:34, Dustin Navea wrote: > Hi guys, I just tried to access Bugzilla, and it isnt responding, checked > with a ping and a traceroute but both gave me request timed out, although > that could be because of a firewall, I just figured someone might want to > know (jeremy).. >