Re: [PATCH libinput 1/1] Fix debouncing algorithm

2017-11-14 Thread Peter Hutterer
On Tue, Nov 14, 2017 at 07:40:08PM +0100, Vicente Bergas wrote: > Hi Peter, > > (sorry, sent twice, first time I forgot to "reply-all") > > On Tue, Nov 14, 2017 at 5:22 AM, Peter Hutterer > wrote: > > ... > > >> -#define DEBOUNCE_TIME ms2us

[ANNOUNCE] libinput 1.9.2

2017-11-14 Thread Peter Hutterer
on dependencies are missing. The rest are documentation, man page and test fixes. Peter Hutterer (12): touchpad: allow for multiple paired keyboards circle.yml: add ninja dist to tests doc: quote all paths in the doxygen file test: fix the device name for the magic mo

Re: [PATCH libinput 1/1] Fix debouncing algorithm

2017-11-15 Thread Peter Hutterer
On Wed, Nov 15, 2017 at 09:31:07PM +0100, Vicente Bergas wrote: > On Wed, Nov 15, 2017 at 1:38 AM, Peter Hutterer > wrote: > > ... I'd appreciate it if you could give it a test > > though. > > > > Cheers, > >Peter > > Hi Peter, > just teste

[PATCH libinput] tools: replace the tap time measuring tool with a python one

2017-11-15 Thread Peter Hutterer
A lot easier to process data in python than in C. Signed-off-by: Peter Hutterer --- meson.build | 10 +- tools/libinput-measure-touchpad-tap | 261 + tools/libinput-measure-touchpad-tap.c | 509 -- 3 files changed, 263

Re: [PATCH libinput] tools: replace the tap time measuring tool with a python one

2017-11-16 Thread Peter Hutterer
On Thu, Nov 16, 2017 at 03:03:41PM +0800, Dima Ryazanov wrote: > Oh nice, much simpler. I have a few nitpick comments, but it looks good, > and works for me. > > Reviewed-By: Dima Ryazanov > Tested-By: Dima Ryazanov thx, much appreciated! > On Thu, Nov 16, 2017 at 1:11

Re: [PATCH libinput 1/1] Fix debouncing algorithm

2017-11-19 Thread Peter Hutterer
On Sun, Nov 19, 2017 at 08:45:16PM +0100, Vicente Bergas wrote: > On Thursday, November 16, 2017 2:29:05 AM CET, Peter Hutterer wrote: > > On Wed, Nov 15, 2017 at 09:31:07PM +0100, Vicente Bergas wrote: > > > On Wed, Nov 15, 2017 at 1:38 AM, Peter Hutterer > > > wrote:

[PATCH libinput] debounce: handle a timeout in MAYBE_SPURIOUS state

2017-11-20 Thread Peter Hutterer
we should transition to pressed state again. Reported-by: Vicente Bergas Signed-off-by: Peter Hutterer --- doc/button-debouncing-state-machine.svg | 369 +++- src/evdev-debounce.c| 4 +- 2 files changed, 121 insertions(+), 252 deletions(-) diff --

[PATCH libinput 0/2] libinput record/replay as evemu replacement

2017-11-27 Thread Peter Hutterer
Short story: I'm, planning to replace evemu. Its API is difficult to extend because it ended up as a library when really it should've only ever been a tool. Changing it requires breaking the API anyway and at that point we might as well add a new tool. shipped with libinput, because that way it's

[PATCH libinput 2/2] tools: add a libinput-replay tool

2017-11-27 Thread Peter Hutterer
. This is particularly useful on long recordings - once the bug occurs we can ctrl+c and match up the last few lines with the recordings file. This allows us to e.g. drop the rest of the file. Signed-off-by: Peter Hutterer --- circle.yml| 4 +- meson.build

[PATCH libinput 1/2] tools: add a libinput-record tool

2017-11-27 Thread Peter Hutterer
nd up as KEY_A. This protects against inadvertent information leakage * supports a --multiple option to record multiple devices simultaneously. All recordings have the same time offset, it is thus possible to reproduce bugs that depend on the interaction of more than one device. Signed-of

[ANNOUNCE] libinput 1.9.3

2017-11-27 Thread Peter Hutterer
libinput 1.9.3 is now available. The biggest change here is a new button debouncing code that makes the stuck buttons a thing of the past. If you are running 1.9 and you occasionally notice a stuck mouse button, this release will fix it. Aside from that we only have a few man page fixes. Peter

Re: [PATCH libinput] debounce: handle a timeout in MAYBE_SPURIOUS state

2017-11-28 Thread Peter Hutterer
On Tue, Nov 28, 2017 at 09:13:29PM +0100, Vicente Bergas wrote: > On Tuesday, November 21, 2017 8:10:19 AM CET, Peter Hutterer wrote: > > Sequences to trigger: > > - spurious debouncing is enabled > > - release a button in IS_DOWN state -> RELEASE_DELAYED >

Re: [RFC wayland-protocols] unstable: Add input-timestamps protocol

2017-11-29 Thread Peter Hutterer
On Wed, Nov 29, 2017 at 12:42:57PM +0200, Alexandros Frantzis wrote: > wl_pointer, wl_keyboard and wl_touch events currently use a 32-bit > timestamp with millisecond resolution. In some cases, notably latency > measurements, this resolution is too coarse to be useful. > > This protocol provides a

Re: [PATCH libinput] FreeBSD portability fixes

2017-11-30 Thread Peter Hutterer
On Thu, Nov 23, 2017 at 09:15:27PM +0300, Greg V wrote: > - some items in meson were missing a dependency on udev > - libdl does not exist on FreeBSD, dlopen is in libc > - no linux/types.h on FreeBSD > - stdarg.h included when variadic functions are used > - and other fixes > --- > include/linux/

[PATCH libinput] fallback: send key events out immediately upon receiving them

2017-12-07 Thread Peter Hutterer
sent in the order of the event codes. KEY_A sorts before KEY_LEFTSHIFT and our shift + A becomes A + shift. Fix this by treating key events as before db3b6fe5f7f8 - by sending them out as we get them. https://bugs.freedesktop.org/show_bug.cgi?id=104030 Signed-off-by: Peter Hutterer --- src/e

Re: [PATCH wayland-protocols] unstable: Add input-timestamps protocol

2017-12-07 Thread Peter Hutterer
o generic with "input event" rather than listing them but nonetheless, Reviewed-by: Peter Hutterer Cheers, Peter > --- > Makefile.am| 1 + > unstable/input-timestamps/README | 4 + > .../input-timestamps-unsta

[PATCH libinput] tablet: set the tip-up pressure threshold to 1%

2017-12-07 Thread Peter Hutterer
shold only applies to pens that don't already have a pressure offset anyway. https://bugs.freedesktop.org/show_bug.cgi?id=103086 Signed-off-by: Peter Hutterer --- src/evdev-tablet.c | 5 +++-- test/test-tablet.c | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/evdev

Re: [PATCH v2 libinput] FreeBSD portability fixes

2017-12-10 Thread Peter Hutterer
On Fri, Dec 01, 2017 at 04:59:43PM +0300, Greg V wrote: > --- > .gitignore| 1 + > include/linux/input.h | 4 > meson.build | 39 ++- > src/libinput-util.h | 4 > test/litest.c | 9 - > test/litest.h

Re: [PATCH libinput] fallback: send key events out immediately upon receiving them

2017-12-11 Thread Peter Hutterer
On Mon, Dec 11, 2017 at 02:39:01PM +, Eric Engestrom wrote: > On Friday, 2017-12-08 10:17:17 +1000, Peter Hutterer wrote: > > Commit db3b6fe5f7f8 "fallback: change to handle the state at EV_SYN time" > > introduced regressions for two types of event sequences. >

Re: [PATCH v2 libinput] FreeBSD portability fixes

2017-12-12 Thread Peter Hutterer
On Tue, Dec 12, 2017 at 03:55:10PM +, Emil Velikov wrote: > On 11 December 2017 at 04:21, Peter Hutterer wrote: > > >> - ptrace(PTRACE_CONT, NULL, NULL); > >> + ptrace(PTRACE_CONT, ppid, NULL, 0); > > > > > sp

[ANNOUNCE] libinput 1.9.4

2017-12-13 Thread Peter Hutterer
. The second source was a ordering issue inside libinput so shift+C arrived as C+shift instead in some cases. This is fixed by reverting to the previous event handling approach for key events. If you're on 1.9.3 right now, updating to 1.9.4 is highly recommended. Peter Hutterer (5): fal

Re: [RFC PATCH xserver] xwayland: avoid race condition on new keymap

2017-12-18 Thread Peter Hutterer
On Fri, Dec 15, 2017 at 04:43:47PM +0100, Olivier Fourdan wrote: > When the Wayland compositor notifies of a new keymap, for the first X11 > client using the keyboard, the last slave keyboard used might still not > be set (i.e. “lastSlave” is still NULL). > > As a result, the new keymap is not app

[PATCH libinput] test: collect test case failures and print them on each fd

2017-12-18 Thread Peter Hutterer
. This way the failures are always the last thing printed by the test suite. Signed-off-by: Peter Hutterer --- test/litest.c | 46 +++--- 1 file changed, 43 insertions(+), 3 deletions(-) diff --git a/test/litest.c b/test/litest.c index 05726726..d4874d43

[PATCH libinput] path: if the udev device is never initialized, bail

2018-01-04 Thread Peter Hutterer
2000ms should be enough, if that fails let's bail completely. Related to: https://bugs.freedesktop.org/show_bug.cgi?id=104278 Signed-off-by: Peter Hutterer --- src/path-seat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/path-seat.c b/src/path-seat.c index c16

[PATCH libinput] touchpad: don't disable the hysteresis unless a finger is down

2018-01-07 Thread Peter Hutterer
://bugs.freedesktop.org/show_bug.cgi?id=98839#c74 Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 3 ++- test/test-touchpad.c| 4 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index 52df8fd2..df0b0633 100644 --- a/src/evdev-mt

[PATCH libinput] touchpad: drop the double normalization

2018-01-09 Thread Peter Hutterer
, then (often immediately) convert back to device coordinates, albeit for equal x/y resolution. This isn't necessary, we can just convert the device coordinates to x/y-equal resolution device coordinates and pass those on. Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad-edge-scroll.c

Re: [PATCH] udev: Thinkpad T470 uses the same settings as T450

2018-01-11 Thread Peter Hutterer
On Tue, Jan 09, 2018 at 10:41:54AM +0100, Tomas Vestelind wrote: > Hi, > > The trackpoint on my T470p was very choppy when moving it, even though > the trackpad was fine. > > I applied the following (the attached patch) and it works much better > now. I'm not sure that this is the correct solutio

Re: EVoC - Project ideas & hardware requirements

2018-01-14 Thread Peter Hutterer
sorry about the delay On Mon, Dec 18, 2017 at 07:57:41AM +0100, Stefan Dvoretskii wrote: > Hello dear Wayland developers, > > I am a student thinking about participating in EVoC. I've browsed the Ideas > concerning Wayland on the official site ( > https://www.x.org/wiki/SummerOfCodeIdeas/) and fo

Re: [PATCH libinput 1/2] touchpad: make the edge-scroll edge 7mm wide

2018-01-17 Thread Peter Hutterer
e "typical bezel limits". > > > > Signed-off-by: Peter Hutterer > > --- > > src/evdev-mt-touchpad-edge-scroll.c | 25 +++-- > > 1 file changed, 3 insertions(+), 22 deletions(-) > > > > diff --git a/src/evdev-mt-touchpad-edge-scroll.c

Re: [PATCH libinput 1/2] touchpad: make the edge-scroll edge 7mm wide

2018-01-18 Thread Peter Hutterer
On Wed, Jan 17, 2018 at 01:21:52PM +0100, Alexander Karlstad wrote: > On 17. jan. 2018 13:02, Peter Hutterer wrote: > > there's no configuration option for it, it's hard-coded. 7mm should be > > enough for the average finger - why do you need to change it? > > If

[ANNOUNCE] libinput 1.9.901

2018-01-21 Thread Peter Hutterer
og is below. Greg V (2): meson.build: add missing udev dependencies and linux/input.h includes Include stdarg.h where variadic functions are used Lyude Paul (1): Correct Lyude's Copyright assignment Peter Hutterer (66): evdev: document the change-of-directions

Re: [PATCH v5 3/7] launcher-logind: only get a VT on seat0, as only seat0 supports VTs

2018-01-21 Thread Peter Hutterer
gt; + return; > > > > if (compositor->vt_switching == false) > > return; > > Reviewed-by: Pekka Paalanen > > Although I'm not quite sure whether the VT-ful seat's name is > configurable in logind or elsewhere, wonder

Re: libinput touchscreen maxTouchPoints

2018-01-24 Thread Peter Hutterer
On Wed, Jan 24, 2018 at 10:04:52AM +0100, Johannes Pointner wrote: > Hello, > > I have noticed that since we are using xf86-input-libinput all our > touchscreens (resistive and pcap) reporting a value of 15 for > maxTouchPoints. > After further looking into this I saw that xf86-input-libinput sets

Re: [PATCH xserver] xwayland: Support for BTN_STYLUS3 kernel events

2018-01-25 Thread Peter Hutterer
On Wed, Jan 24, 2018 at 10:54:53AM -0800, Jason Gerecke wrote: > On Thu, Nov 9, 2017 at 2:19 PM, Jason Gerecke wrote: > > On Tue, Nov 7, 2017 at 2:37 PM, Peter Hutterer > > wrote: > >> On Tue, Nov 07, 2017 at 11:09:44AM -0800, Jason Gerecke wrote: > >>> BT

Re: libinput touchscreen maxTouchPoints

2018-01-29 Thread Peter Hutterer
On Wed, Jan 24, 2018 at 10:47:10AM +0100, Johannes Pointner wrote: > On Wed, Jan 24, 2018 at 10:18 AM, Peter Hutterer > wrote: > > On Wed, Jan 24, 2018 at 10:04:52AM +0100, Johannes Pointner wrote: > >> Hello, > >> > >> I have noticed that since w

Re: libinput touchscreen maxTouchPoints

2018-01-30 Thread Peter Hutterer
On Tue, Jan 30, 2018 at 04:18:26PM +1000, Peter Hutterer wrote: > On Wed, Jan 24, 2018 at 10:47:10AM +0100, Johannes Pointner wrote: > > On Wed, Jan 24, 2018 at 10:18 AM, Peter Hutterer > > wrote: > > > On Wed, Jan 24, 2018 at 10:04:52AM +0100, Johannes Poin

[PATCH libinput 1/2] test: inhibit nasty keys and switches during test runs

2018-01-31 Thread Peter Hutterer
Having the system suspend or shutdown halfway through a test run is a tad annoying. So let's talk to logind and tell it to inhibit the various keys we're testing. https://bugs.freedesktop.org/show_bug.cgi?id=104720 Signed-off-by: Peter Hutterer --- meson.build | 7 ++- tes

[PATCH libinput 2/2] test: don't abort for timer offset errors during valgrind runs

2018-01-31 Thread Peter Hutterer
Too easy to trigger with the short button debouncing offsets Signed-off-by: Peter Hutterer --- test/litest.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/test/litest.c b/test/litest.c index befb486a..dcbed5c9 100644 --- a/test/litest.c +++ b/test/litest.c @@ -691,8

[PATCH libinput] evdev: add a quirk to disable debouncing on the MS Nano Transcievers

2018-01-31 Thread Peter Hutterer
histicated. https://bugs.freedesktop.org/show_bug.cgi?id=104415 Signed-off-by: Peter Hutterer --- This is missing the svg bits for the state diagram, the mailing list wouldn't like it... meson.build| 1 + src/evdev-debounce.c

[PATCH libinput] tablet: skip tablet_flush() if our current tool type is none

2018-02-01 Thread Peter Hutterer
If a tablet never sends a BTN_TOOL_foo, we never update the tool and we remain on the 'none' tool. https://bugzilla.redhat.com/show_bug.cgi?id=1535755 Signed-off-by: Peter Hutterer --- src/evdev-tablet.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff -

[PATCH libinput] tablet: don't set rotation on a tool if we don't have ABS_Z

2018-02-05 Thread Peter Hutterer
a single cause only and thus the tablet bits are accurate anyway. https://bugs.freedesktop.org/show_bug.cgi?id=104939 Signed-off-by: Peter Hutterer --- src/evdev-tablet.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/evdev-tablet.c b/src/evdev-tablet.c

[PATCH libinput] evdev: log all evdev_msg_* on one line

2018-02-05 Thread Peter Hutterer
So we don't have to have newline handling in the callers. This effectively reverts 6ab2999be90331 "test: detect linebreaks in log messages". https://bugs.freedesktop.org/show_bug.cgi?id=104957 Signed-off-by: Peter Hutterer --- src/evdev.h | 21 ++--- tes

[PATCH libinput] timer: change the timer offset warning to a client bug

2018-02-05 Thread Peter Hutterer
deserves, if I may say so). Up-, down- or side-grade it to a client bug, so the outrage can be directed elsewhere, preferably away from me. And add a section to the documentation, just in case someone actually reads this stuff. Signed-off-by: Peter Hutterer --- doc/faqs.dox | 22

[ANNOUNCE] libinput 1.9.902

2018-02-06 Thread Peter Hutterer
10 (a tablet-related crash). Otherwise, expect 1.10 very soon, you may put some champagne in the fridge in preparation for the festivities. As usual, the git shortlog is below. Peter Hutterer (9): fallback: remove unused DEBOUNCE_TIME setting test: fix udev rule for hp wmi hotkeys te

[PATCH libinput 6/8] tablet: disable BTN_TOOL_MOUSE/LENS for non-Wacom tablets

2018-02-06 Thread Peter Hutterer
neric rotation calculation that may not be correct anyway. Signed-off-by: Peter Hutterer --- src/evdev-tablet.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/evdev-tablet.c b/src/evdev-tablet.c index 0140c6f5..2480bbfe 100644 --- a/src/evdev-tablet.c +++ b/src/evdev-tablet.c @@ -2

[PATCH libinput 2/8] tablet: move the quirk disabling up within tablet_init

2018-02-06 Thread Peter Hutterer
Let's make sure all libevdev manipluations are done before we start initializing anything based on the event codes. Signed-off-by: Peter Hutterer --- src/evdev-tablet.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/evdev-tablet.c b/src/evdev-tablet.c

[PATCH libinput 1/8] test: make the mouse tool a litest feature bit

2018-02-06 Thread Peter Hutterer
Aiptek tablets have the BTN_TOOL_MOUSE|LENS bits but don't actually have a mouse, at least not in libinput (see future patches). Turns out we only have one device that really has the tool anyway, so not running the tests for the others seems sensible. Signed-off-by: Peter Hutterer ---

[PATCH libinput 0/8] Quirks and fixes for non-Wacom tablets (Aiptek)

2018-02-06 Thread Peter Hutterer
The one thing we can rely on from non-wacom tablets is that they're less inclined to follow the established evdev behaviours. The Aiptek tablet in this case doesn't send BTN_TOOL_PEN or any other tools, despite having the bits. It also doesn't care about tilt, because clearly, just pretending tilt

[PATCH libinput 3/8] tablet: don't set rotation on a tool if we don't have ABS_Z

2018-02-06 Thread Peter Hutterer
a single cause only and thus the tablet bits are accurate anyway. https://bugs.freedesktop.org/show_bug.cgi?id=104939 Signed-off-by: Peter Hutterer --- src/evdev-tablet.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/evdev-tablet.c b/src/evdev-tablet.c

[PATCH libinput 5/8] tablet: skip tablet_flush() if our current tool type is none

2018-02-06 Thread Peter Hutterer
If a tablet never sends a BTN_TOOL_foo, we never update the tool and we remain on the 'none' tool. Somewhat related to: https://bugzilla.redhat.com/show_bug.cgi?id=1535755 https://bugs.freedesktop.org/show_bug.cgi?id=104911 Signed-off-by: Peter Hutterer --- src/evdev-tab

[PATCH libinput 8/8] Add a test device for aiptek tablets

2018-02-06 Thread Peter Hutterer
This tablet advertises tilt but doesn't actually have it. Let's rule out tilt for all aiptek devices until someone complains. Recording from: https://bugzilla.redhat.com/show_bug.cgi?id=1535755 Related to: https://bugs.freedesktop.org/show_bug.cgi?id=104911 Signed-off-by: Pete

[PATCH libinput 7/8] tablet: fake a BTN_TOOL_PEN on the first event if needed

2018-02-06 Thread Peter Hutterer
E (i.e. no BTN_TOOL_* was received), we pretend that we've earlier forced a proximity-out event for this tablet. This causes the proximity-out quirk code to emulate a proximity in and we're off. Hooray. https://bugs.freedesktop.org/show_bug.cgi?id=104911 Signed-off-by: Peter Hutterer ---

[PATCH libinput 4/8] tablet: release the tablet state on device delete

2018-02-06 Thread Peter Hutterer
When the device gets deleted in a non-neutral state, we need to release all buttons, lift the tip up and send a proximity out event. https://bugs.freedesktop.org/show_bug.cgi?id=104940 Signed-off-by: Peter Hutterer --- src/evdev-tablet.c | 6 test/test-tablet.c | 101

Re: [PATCH weston 1/2] weston: remove SEGV and ABRT handlers

2018-02-07 Thread Peter Hutterer
On Wed, Feb 07, 2018 at 12:03:56PM +, Simon McVittie wrote: > On Wed, 07 Feb 2018 at 12:51:14 +0200, Pekka Paalanen wrote: > > Catching an ABRT is kind of ok, catching a SEGV is russian roulette. We > > have been quite lucky with it, but I've started hitting crashes inside > > malloc() which ca

[PATCH libinput] evdev: fail before open_restricted if the devnode doesn't exist

2018-02-09 Thread Peter Hutterer
https://bugzilla.redhat.com/show_bug.cgi?id=1536633 https://bugzilla.redhat.com/show_bug.cgi?id=1539046 https://bugzilla.redhat.com/show_bug.cgi?id=1539783 https://bugzilla.redhat.com/show_bug.cgi?id=1540662 https://bugs.freedesktop.org/show_bug.cgi?id=104278 Signed-off-by: Peter Hutterer

[ANNOUNCE] libinput 1.10.0

2018-02-12 Thread Peter Hutterer
a constantly in-proximity tool. A new threshold for proximity out fixes this. As usual, the git shortlog is below. Peter Hutterer (5): tablet: drop unnecessary switch case statements tablet: remove obsolete BTN_TOUCH case test: add a missing proximity timeout in a tip up tes

Re: [PATCH libinput] evdev: fail before open_restricted if the devnode doesn't exist

2018-02-12 Thread Peter Hutterer
On Fri, Feb 09, 2018 at 12:00:47PM -0600, Jeffrey Smith wrote: > > + if (!devnode) { > > + log_info(libinput, "%s: no device node associated\n", > > sysname); > > + return NULL; > > + } > > + > > if (udev_device_should_be_ignored(udev_device)) { > >

Re: [PATCH libinput] evdev: fail before open_restricted if the devnode doesn't exist

2018-02-12 Thread Peter Hutterer
Checking these bugs before I was about to push: On Fri, Feb 09, 2018 at 07:59:08PM +1000, Peter Hutterer wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1536633 > https://bugzilla.redhat.com/show_bug.cgi?id=1539046 > https://bugzilla.redhat.com/show_bug.cgi?id=153978

Re: [PATCH libinput] evdev: fail before open_restricted if the devnode doesn't exist

2018-02-12 Thread Peter Hutterer
On Tue, Feb 13, 2018 at 01:43:27PM +1000, Peter Hutterer wrote: > Checking these bugs before I was about to push: > > On Fri, Feb 09, 2018 at 07:59:08PM +1000, Peter Hutterer wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=1536633 > > https://bugzilla.redhat.com/sh

Re: [PATCH libinput 1/2] meson: Fix absolute libdir case in install script

2018-02-15 Thread Peter Hutterer
On Thu, Nov 30, 2017 at 09:23:38AM +0100, Quentin Glidic wrote: > From: Quentin Glidic > > If libdir is an absolute path (which means it’s outside of prefix) we > would wrongly add the prefix to it in the install script. Just pass the > correct libdir from Meson directly thanks to join_paths() ma

Re: [PATCH 0/2 libinput] [RFC] Add touchpad wobbliness detection

2018-02-19 Thread Peter Hutterer
On Sun, Feb 18, 2018 at 01:09:22PM +0300, Konstantin Kharlamov wrote: > For the purposes it seems to work fine — it's marked RFC because I see a > small oddness, and I think it's better to ask someone more > acknowledgable in libinput codebase. thanks, much appreciated. I was hoping I get to this

[PATCH libinput] touchpad: only begin fake touches when we have at least one finger down

2018-02-19 Thread Peter Hutterer
If a single-touch touchpad drops below the pressure threshold in the same frame where a fake finger is added, we begin a fake touch here. The subsequent loop ends this fake touch because real_fingers_down is 0. This causes the tapping code to have a mismatch of how many fingers are down because it

Re: [PATCH v2] touchpad: add wobbling detection

2018-02-19 Thread Peter Hutterer
On Sun, Feb 18, 2018 at 11:14:55PM +0300, Konstantin Kharlamov wrote: > The details are explained in comment in the code. That aside, I shall > mention the check is so light, that it shouldn't influence CPU > performance even a bit, and can blindly be kept always enabled. I like it! And it does wo

Re: [PATCH v2] touchpad: add wobbling detection

2018-02-20 Thread Peter Hutterer
On Tue, Feb 20, 2018 at 08:58:33PM +0300, Konstantin Kharlamov wrote: > On 20.02.2018 17:31, Konstantin Kharlamov wrote: > > On 20.02.2018 13:44, Konstantin Kharlamov wrote: > > > On 20.02.2018 09:34, Peter Hutterer wrote: > > > > On Sun, Feb 18, 2018 at 11:14:55

[PATCH libinput 2/4] touchpad: change the stylus palm arbitration to process touches

2018-02-20 Thread Peter Hutterer
Previously, on touch toggle (invoked by the tablet when a pen goes in proximity) the touchpad cleared the state and ignored any events. Since we ignore touches that we didn't see the touch begin for, this handled the cases of a touch remaining after proximity out. This code pre-dates palm detectio

[PATCH libinput 1/4] touchpad: reset the palm state to NONE on a new touch

2018-02-20 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index b3ed6d56..fdb7b452 100644 --- a/src/evdev-mt-touchpad.c +++ b/src/evdev-mt-touchpad.c @@ -271,6 +271,7 @@ tp_new_touch(struct

[PATCH libinput 4/4] touchpad: delay arbitration by 90ms after touch toggle

2018-02-20 Thread Peter Hutterer
like a tap-to-click. Fix this by delaying the 'arbitration is now off' toggle, causing any touch that starts immediately after proximity out to be detected as palm and ignored for its lifetime. https://bugs.freedesktop.org/show_bug.cgi?id=104985 Signed-off-by: Peter Hutterer --- src

[PATCH libinput 3/4] evdev: pass the time down to toggle_touch

2018-02-20 Thread Peter Hutterer
Currently unused, will be used in later patches Signed-off-by: Peter Hutterer --- src/evdev-fallback.c| 3 ++- src/evdev-mt-touchpad.c | 3 ++- src/evdev-tablet.c | 18 -- src/evdev.h | 3 ++- 4 files changed, 18 insertions(+), 9 deletions(-) diff --git

Re: [ANNOUNCE] libinput 1.10.0

2018-02-21 Thread Peter Hutterer
On Tue, Feb 20, 2018 at 12:34:35AM +0100, Aleksandar Jevremovic wrote: > Looks like this new version causes problems with acceleration on > trackpoints: > https://www.linuxquestions.org/questions/showthread.php?p=5821760#post5821760 there hasn't been any change to trackpoint acceleration code in t

[PATCH v2 libinput 2/4] tools: add a libinput-replay tool

2018-02-21 Thread Peter Hutterer
. This is particularly useful on long recordings - once the bug occurs we can ctrl+c and match up the last few lines with the recordings file. This allows us to e.g. drop the rest of the file. Signed-off-by: Peter Hutterer --- circle.yml| 4 +- meson.build

[PATCH v2 libinput 0/4] libinput record/replay as evemu replacement

2018-02-21 Thread Peter Hutterer
As said in v1: I'm, planning to replace evemu. Its API is difficult to extend because it ended up as a library when really it should've only ever been a tool. Changing it requires breaking the API anyway and at that point we might as well add a new tool. shipped with libinput, bec

[PATCH v2 libinput 1/4] tools: add a libinput-record tool

2018-02-21 Thread Peter Hutterer
swer the question of: why a printf-approach to writing out json instead of a library, it's simply that we want to be able to have real-time output of the recording. Signed-off-by: Peter Hutterer --- meson.build | 15 + tools/libinput-record.c | 898

[PATCH v2 libinput 3/4] doc: add a section to the tools page for record/replay

2018-02-21 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- doc/tools.dox | 95 +++ 1 file changed, 95 insertions(+) diff --git a/doc/tools.dox b/doc/tools.dox index a3673773..bb885f28 100644 --- a/doc/tools.dox +++ b/doc/tools.dox @@ -76,4 +76,99 @@ $ sudo

[PATCH v2 libinput 4/4] tools: add a verification tool to make sure the json format is correct

2018-02-21 Thread Peter Hutterer
--- tools/libinput-record-json-verify.py | 88 1 file changed, 88 insertions(+) create mode 100755 tools/libinput-record-json-verify.py diff --git a/tools/libinput-record-json-verify.py b/tools/libinput-record-json-verify.py new file mode 100755 index 00

[PATCH libinput] touchpad: use the fuzz value (if any) for the hysteresis margin

2018-02-21 Thread Peter Hutterer
25mm (from 0.5mm). The problem with a 0 fuzz is that the distinction between "does not have fuzz" and "too lazy to set it" is not clear. Long-term we should probably punish those that don't set it though... https://bugs.freedesktop.org/show_bug.cgi?id=105108 Signed-off-by

[PATCH libinput 2/2] touchpad: enable palm detection on tablets' touchpads

2018-02-22 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c| 18 -- src/evdev.c| 8 src/evdev.h| 1 + udev/90-libinput-model-quirks.hwdb | 4 4 files changed, 25 insertions(+), 6 deletions(-) diff --git a

[PATCH libinput 1/2] touchpad: init touch size range based on the udev property

2018-02-22 Thread Peter Hutterer
No need to hardcode Apple here, if we have a udev property for this, let's use it. Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index 62b

Re: [PATCH libinput] indentation: add .dir-locals.el for emacs

2018-02-26 Thread Peter Hutterer
On Sat, Feb 24, 2018 at 06:55:34PM +0300, Konstantin Kharlamov wrote: > It's pretty basic as compared to e.g. one of Mesa, but I don't see what > else could be needed, and if anything, it can be added later. > > Signed-off-by: Konstantin Kharlamov > --- > .dir-locals.el | 4 > 1 file change

[PATCH v3 libinput 0/4] libinput record/replay as evemu replacement

2018-02-26 Thread Peter Hutterer
TLDR: evemu replacement, see v2: https://lists.freedesktop.org/archives/wayland-devel/2018-February/037172.html This version switches from JSON to YAML which is a much saner format for a file that must be human *and* machine-readable. Changes to v2: - switched to YAML as output format - libinput-

[PATCH v3 libinput 2/4] tools: add a libinput-replay tool

2018-02-26 Thread Peter Hutterer
ccurs we can ctrl+c and match up the last few lines with the recordings file. This allows us to e.g. drop the rest of the file. Signed-off-by: Peter Hutterer --- meson.build | 9 +++ tools/libinput-replay | 190 ++ tools/lib

[PATCH v3 libinput 1/4] tools: add a libinput-record tool

2018-02-26 Thread Peter Hutterer
And to answer the question of: why a printf-approach to writing out yaml instead of a library, it's simply that we want to be able to have real-time output of the recording. Signed-off-by: Peter Hutterer --- meson.build | 15 + tools/libin

[PATCH v3 libinput 4/4] tools: add --all to libinput-record

2018-02-26 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- tools/libinput-record.c | 71 +-- tools/libinput-record.man | 8 ++ 2 files changed, 77 insertions(+), 2 deletions(-) diff --git a/tools/libinput-record.c b/tools/libinput-record.c index b0e0ba1b..3cbcd0b8

[PATCH v3 libinput 3/4] doc: add a section to the tools page for record/replay

2018-02-26 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- doc/tools.dox | 94 +++ 1 file changed, 94 insertions(+) diff --git a/doc/tools.dox b/doc/tools.dox index a3673773..eade88af 100644 --- a/doc/tools.dox +++ b/doc/tools.dox @@ -76,4 +76,98 @@ $ sudo

[PATCH libinput] touchpad: don't do speed-based thumb detection on single-touch or semi-mts

2018-02-26 Thread Peter Hutterer
Because life is too short for this https://bugs.freedesktop.org/show_bug.cgi?id=105265 Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 4 1 file changed, 4 insertions(+) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index 62ba678e..2a6cdcef 100644 --- a/src

[ANNOUNCE] libinput 1.10.1

2018-02-27 Thread Peter Hutterer
should now work as intended. And fixes for the 'libinput-debug-events' and 'libinput-list-devices' compat scripts that could lead to the wrong bindir/libdir being used. Maxin B. John (1): libinput-measure-touchpad-tap: use /usr/bin/env to invoke python3 Peter Hutterer

[PATCH libinput] tools: add the git version in the libinput-record output

2018-02-28 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- meson.build | 5 + src/libinput-git-version.h.in | 3 +++ tools/libinput-record.c | 2 ++ 3 files changed, 10 insertions(+) create mode 100644 src/libinput-git-version.h.in diff --git a/meson.build b/meson.build index 60caf997

[PATCH libinput 2/5] test: don't run the 2fg pressure test on single-touch touchpads

2018-02-28 Thread Peter Hutterer
Only the appletouch has pressure and thus executed that code path Signed-off-by: Peter Hutterer --- test/test-touchpad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test-touchpad.c b/test/test-touchpad.c index 836640b7..bf342b95 100644 --- a/test/test-touchpad.c

[PATCH libinput 4/5] touchpad: don't end below-threshold pressure touches if nfake_fingers > nslots

2018-02-28 Thread Peter Hutterer
pressure when we exceed the slot number. Exception: if all real fingers are below the pressure threshold, the fake fingers are ignored too. Related to https://bugs.freedesktop.org/show_bug.cgi?id=105258 Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 4 +++- test/test-touchpad-tap.c | 11

[PATCH libinput 5/5] touchpad: add a TOUCH_MAYBE_END state

2018-02-28 Thread Peter Hutterer
ger a release https://bugs.freedesktop.org/show_bug.cgi?id=105258 Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad-edge-scroll.c | 8 src/evdev-mt-touchpad.c | 93 + src/evdev-mt-touchpad.h | 9 ++-- test/test-touch

[PATCH libinput 3/5] touchpad: add the pressure thresholds to the debugging output

2018-02-28 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index 2a6cdcef..eaa9215a 100644 --- a/src/evdev-mt-touchpad.c +++ b/src/evdev-mt-touchpad.c @@ -3073,7 +3073,9

[PATCH libinput 1/5] test: don't run the MT pressure test on devices without MT pressure

2018-02-28 Thread Peter Hutterer
ests. Signed-off-by: Peter Hutterer --- test/test-touchpad-tap.c | 63 +--- 1 file changed, 60 insertions(+), 3 deletions(-) diff --git a/test/test-touchpad-tap.c b/test/test-touchpad-tap.c index a57677c2..948be965 100644 --- a/test/test-touchpad-tap.c +++

[PATCH v4 libinput 1/3] touchpad: move the hysteresis into its own substruct

2018-02-28 Thread Peter Hutterer
Prep work for the wobbling detection patch Signed-off-by: Peter Hutterer --- New in this series src/evdev-mt-touchpad.c | 10 +- src/evdev-mt-touchpad.h | 4 +++- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index

[PATCH v4 libinput 2/3] touchpad: remove the code for disabling hysteresis

2018-02-28 Thread Peter Hutterer
From: Konstantin Kharlamov Signed-off-by: Konstantin Kharlamov Signed-off-by: Peter Hutterer --- Changes to v3: - rebased for patch 1/3 src/evdev-mt-touchpad.c | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt

[PATCH v4 libinput 3/3] touchpad: add wobbling detection

2018-02-28 Thread Peter Hutterer
uristic. v4: * some more style fixes Signed-off-by: Konstantin Kharlamov Signed-off-by: Peter Hutterer --- Changes to v3: - more style fixes - ajudsted for patch 1/3 src/evdev-mt-touchpad.c | 58 - src/evdev-mt-touchpad.h | 2 ++ 2 files changed, 5

[PATCH libinput] Add libinput_device_touch_get_touch_count()

2018-03-02 Thread Peter Hutterer
://bugs.freedesktop.org/show_bug.cgi?id=104867 Signed-off-by: Peter Hutterer --- src/evdev.c | 22 ++ src/evdev.h | 3 +++ src/libinput.c| 6 ++ src/libinput.h| 14 ++ src/libinput.sym | 4 test/test-touch.c | 23 +++ 6

Re: [ANNOUNCE] libinput 1.10.1

2018-03-04 Thread Peter Hutterer
On Sun, Mar 04, 2018 at 02:57:18PM +0100, Jan Engelhardt wrote: > > On Wednesday 2018-02-28 01:27, Peter Hutterer wrote: > > >libinput 1.10.1 is now available. This release fixes three crashers, one > >during tapping, two on startup/resume when the device node or sea

[PATCH libinput 2/3] touchpad: enable hysteresis based on a 0 fuzz value

2018-03-04 Thread Peter Hutterer
If the fuzz is 0, assume we don't need hysteresis and use the wobble detection code instead. If the fuzz is non-zero, enable it by default. Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/evdev-mt-touchpa

[PATCH libinput 1/3] touchpad: use the fuzz value (if any) for the hysteresis margin

2018-03-04 Thread Peter Hutterer
of 0 have the hysteresis margin reduced to 0.25mm (from 0.5mm). https://bugs.freedesktop.org/show_bug.cgi?id=105108 Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/sr

[PATCH libinput 3/3] Extract and reset the abs fuzz value for the x/y axes

2018-03-04 Thread Peter Hutterer
ng around with udev rules. That too should be a minor issue. https://bugs.freedesktop.org/show_bug.cgi?id=105303 Signed-off-by: Peter Hutterer --- meson.build| 2 +- src/evdev.c| 39 +++ src/evdev.h

[ANNOUNCE] libinput 1.10.2

2018-03-06 Thread Peter Hutterer
e for disabling hysteresis touchpad: add wobbling detection Mario Di Raimondo (1): Fix Apple Magic Trackpad sensitivity Peter Hutterer (9): meson: add the 221 version to the libsystemd dependency touchpad: don't do speed-based thumb detection on single-touch or semi-mts

  1   2   3   4   5   6   7   8   9   10   >