Re: Should I always add wl_display_sync() before wl_display_dispatch_queue()?

don't know the codebase of either, but you have to be careful with handing it back and forth. In particular, take a look at wl_display_prepare_read: http://cgit.freedesktop.org/wayland/wayland/tree/src/wayland-client.c#n1078 I hope that's helpful, --Jason Ekstrand > >

[PATCH weston 10/11] compositor-wayland: Parse [output] config sections and more options

ine option. This brings the wayland backend almost up to par, in terms of functionality with the X11 backend. Signed-off-by: Jason Ekstrand --- The new version makes window title handling a little more sane. man/weston.ini.man | 4 +- src/compositor-wayla

Re: [PATCH weston 11/11] cairo-util: Rework frame button handling

In retrospect, this should probably go earlier in the series, before the second compositor-wayland patch. It doesn't actually matter, but it makes more sense there. --Jason Ekstrand On Sun, Oct 27, 2013 at 10:25 PM, Jason Ekstrand wrote: > This makes button handling more correct co

Re: [PATCH mesa v4] wayland: Add support for eglSwapInterval

On Oct 30, 2013 3:59 AM, "Tomeu Vizoso" wrote: > > On 30 October 2013 09:44, Neil Roberts wrote: > > Tomeu Vizoso writes: > > > >> What I fail to see is why a single sync should be enough, as we don't > >> know when the GPU will signal that it's done with the buffer that we > >> are waiting to b

Re: [PATCH mesa v4] wayland: Add support for eglSwapInterval

ts for that matter) are coming to the client, then I would consider that a weston bug. We should really find a way to ensure that buffers do get flushed eventually so clients don't starve(maybe once per frame). I'm open to the possibility that this is a really bad idea. However, it seems mor

[RFC weston] Add a release_type argument to weston_buffer_reference

This allows the caller to specify whether the wl_buffer.release event (if one is generated) should be sent immediately or queued for later. This only makes a difference if this weston_buffer_reference call will release the buffer. If there are other references to the buffer remaining, the argumen

Re: [PATCH 2/2] protocol: add state set functions for maximized and fullscreen.

y. Some comments below: > > On Thu, Oct 24, 2013 at 12:00 AM, Bill Spitzak wrote: > > Jason Ekstrand wrote: > > > >> At this point, I think I can propose a solution which should allow for > >> client control while still keeping the compositor in control: > &

Re: [PATCH 2/2] protocol: add state set functions for maximized and fullscreen.

On Thu, Oct 31, 2013 at 3:37 PM, Bill Spitzak wrote: > Jason Ekstrand wrote: > > Yes, in theory they could read the configuration of the compositor. >> > > I really don't want to build this kind of inconsistency into the system >> and I don't see why it&#

Re: [PATCH mesa v4] wayland: Add support for eglSwapInterval

On Thu, Oct 31, 2013 at 4:59 AM, Tomeu Vizoso wrote: > On 31 October 2013 02:54, Jason Ekstrand wrote: > > On Wed, Oct 30, 2013 at 3:59 AM, Tomeu Vizoso > wrote: > >> > >> On 30 October 2013 09:44, Neil Roberts wrote: > >> > Tomeu Vizoso writes:

[PATCH] toytoolkit: Handle the close button without upsetting state

This is a better fix than 4a7409a1 because it maintains proper state in the frame in the case where the client actually has a close handler. The other would not properly reset the frame state and didn't check the last two statusses --- clients/window.c | 19 ++- 1 file changed, 10

Re: [PATCH weston 01/11] compositor-wayland: Rename structure members and make things more consistant

On Thu, Oct 31, 2013 at 12:51 AM, Kristian Høgsberg wrote: > On Sun, Oct 27, 2013 at 10:24:53PM -0500, Jason Ekstrand wrote: > > Signed-off-by: Jason Ekstrand > > --- > > src/compositor-wayland.c | 76 > ++-- > > 1 file

Re: [PATCH 2/2] protocol: add state set functions for maximized and fullscreen.

On Fri, Nov 1, 2013 at 8:36 PM, Gregory Merchan wrote: > On Thu, Oct 31, 2013 at 8:28 PM, Jason Ekstrand > wrote: > > On Thu, Oct 31, 2013 at 3:37 PM, Bill Spitzak wrote: > >> > >> Jason Ekstrand wrote: > >> > >>> Yes, in theory

Re: [PATCH 2/2] protocol: add state set functions for maximized and fullscreen.

On Fri, Nov 1, 2013 at 8:36 PM, Gregory Merchan wrote: > On Thu, Oct 31, 2013 at 8:28 PM, Jason Ekstrand > wrote: > > On Thu, Oct 31, 2013 at 3:37 PM, Bill Spitzak wrote: > >> > >> Jason Ekstrand wrote: > >> > >>> Yes, in theory

Re: [PATCH 2/2] protocol: add state set functions for maximized and fullscreen.

On Fri, Nov 1, 2013 at 11:36 PM, Jasper St. Pierre wrote: > On Fri, Nov 1, 2013 at 11:58 PM, Jason Ekstrand wrote: > > ... snip > > >> Gregory, >> Thank you very much for your e-mail. I think that helps a lot. The lack >> of code is ok because I think Rafael is

[PATCH weston 1/6] compositor-wayland: Remove unused output handling code

Signed-off-by: Jason Ekstrand --- src/compositor-wayland.c | 48 1 file changed, 48 deletions(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index 50bcb8d..f71faa7 100644 --- a/src/compositor-wayland.c +++ b/src/compositor

[PATCH weston 5/6] compositor-wayland: Add a --scale option

Signed-off-by: Jason Ekstrand --- src/compositor-wayland.c | 16 src/compositor.c | 1 + 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index e5c6726..e688820 100644 --- a/src/compositor-wayland.c

[PATCH weston 0/6] More wayland backend fixes/features

, it will create exactly one fullscreen output. If you want more fullscreen outputs, you need to use the other method for now. Jason Ekstrand (6): compositor-wayland: Remove unused output handling code compositor-wayland: rename wayland_compositor.inputs to input_list compositor-wayland: Fix

[PATCH weston 2/6] compositor-wayland: rename wayland_compositor.inputs to input_list

Signed-off-by: Jason Ekstrand --- src/compositor-wayland.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index f71faa7..5f691a7 100644 --- a/src/compositor-wayland.c +++ b/src/compositor-wayland.c @@ -72,7 +72,7

[PATCH weston 6/6] compositor-wayland: Add fullscreen support

This adds fullscreen support to the wayland backend. You can make any output fullscreen by the shortcut CTRL+ALT+F. You can also run weston with the --fullscreen option which causes it to create a single fullscreen output. Signed-off-by: Jason Ekstrand --- src/compositor-wayland.c | 296

[PATCH weston 4/6] compositor-wayland: Move config parsing into backend_init

This cleans up the configuration and command parsing and separates it from compositor/output initialization. Signed-off-by: Jason Ekstrand --- src/compositor-wayland.c | 172 +++ 1 file changed, 98 insertions(+), 74 deletions(-) diff --git a/src

[PATCH weston 3/6] compositor-wayland: Fix cursor coordinate transforms so it works on translated outputs

Signed-off-by: Jason Ekstrand --- src/compositor-wayland.c | 4 1 file changed, 4 deletions(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index 5f691a7..181d6bb 100644 --- a/src/compositor-wayland.c +++ b/src/compositor-wayland.c @@ -862,8 +862,6

Re: [PATCH weston 5/6] compositor-wayland: Add a --scale option

On Nov 8, 2013 3:46 AM, "Pekka Paalanen" wrote: > > On Thu, 7 Nov 2013 20:13:32 -0600 > Jason Ekstrand wrote: > > > Signed-off-by: Jason Ekstrand > > --- > > src/compositor-wayland.c | 16 > > src/compositor.c | 1 + >

Re: [RFC v2] surface crop & scale protocol extension

crop&scale in the wl_subsurface protocol. It's worth noting that this same issue makes putting a video (from an external source) in a SHM subsurface frame really awkward. See also this e-mail from April: http://lists.freedesktop.org/archives/wayland-devel/2013-April/008875.html Hope it&#

[PATCH weston 7/6] Update the weston man page to include the new Wayland backend options

Signed-off-by: Jason Ekstrand --- This belongs in the Wayland backend patch series man/weston.man | 17 + 1 file changed, 17 insertions(+) diff --git a/man/weston.man b/man/weston.man index 39d854b..2ee3616 100644 --- a/man/weston.man +++ b/man/weston.man @@ -148,9 +148,26

[PATCH weston 7/7 v2] Update the weston man page to include the new Wayland backend options

Signed-off-by: Jason Ekstrand --- man/weston.man | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/man/weston.man b/man/weston.man index 39d854b..2095819 100644 --- a/man/weston.man +++ b/man/weston.man @@ -148,9 +148,27 @@ Name of the Wayland display to

Re: [PATCH weston 7/7 v2] Update the weston man page to include the new Wayland backend options

On Nov 11, 2013 3:18 AM, "Pekka Paalanen" wrote: > > On Sun, 10 Nov 2013 17:26:28 -0600 > Jason Ekstrand wrote: > > > Signed-off-by: Jason Ekstrand > > --- > > man/weston.man | 20 +++- > > 1 file changed, 19 insertions(+), 1 del

Re: [PATCH weston 7/7 v2] Update the weston man page to include the new Wayland backend options

On Mon, Nov 11, 2013 at 2:12 PM, Jason Ekstrand wrote: > > On Nov 11, 2013 3:18 AM, "Pekka Paalanen" wrote: > > > > On Sun, 10 Nov 2013 17:26:28 -0600 > > Jason Ekstrand wrote: > > > > > Signed-off-by: Jason Ekstrand > > > --- >

[PATCH] input: Fix a segfault in focus checking

Without this, weston will segfault whenever the focus is a non-client surface such as the black surface in fullscreen. --- src/input.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/input.c b/src/input.c index 6637882..b6130d6 100644 --- a/src/input.c +++ b/src/input.c

[PATCH] compositor-drm: Release the correct buffer in drm_output_release_fb

--- My knowledge of the DRM backend is rather small, so I don't know if this is really the right fix. I hit this when the the mode fails to set. See also compositor-drm.c:606 src/compositor-drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compositor-drm.c b/src/comp

Re: Thoughts about decoration information in the xdg_shell

in windows. Somewhere in here we would also need an event to let the client tell the server whether it decided to decorate or not. There's also a race in here that we need to solve, but I think we can handle that. There's my thoughts.

Re: [PATCH] client: Introduce functions to allocate and marshal proxies atomically

be able to link against older versions? I'm thinking that's probably not an issue. 3) might be good to add a note specifying that the marshalling functions will create and return exactly one proxy if the given interface is non-null and then enforce that. Hope that helps. --Jason Ekstrand

Re: Protocol documentation

one: http://people.collabora.com/~jonny/wayland/wl_surface.html#Request:attach Thanks, --Jason Ekstrand On Tue, Nov 26, 2013 at 7:25 AM, Jonny Lamb wrote: > Hi. > > I have recently been working on some Wayland protocol stuff and found > referring to the XML tiresome. Telepathy's

Re: Move wayland-drm protocol from Mesa to wayland-core

col. If we don't alter the details of wl_drm in the rename, it shouldn't be too hard to move everyone over from wl_drm to mesa_drm. Hope that's sensible/helpful. --Jason Ekstrand ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH weston 2/8] compositor: do not recompute size on pointer_set_cursor

Pekka and I already talked about this one and I think it's the right thing to do. --Jason Ekstrand Reviewed-by: Jason Ekstrand On Nov 26, 2013 11:20 AM, "Jonny Lamb" wrote: > From: Pekka Paalanen > > This removes the calls to weston_surface_buffer_width/height() from

Re: [PATCH weston 3/8] compositor: merge surface size from buffer size funcs

This one is also a good idea. Removes code duplication and keeps the surface size calculations in compositor.c where they belong. --Jason Ekstrand Reviewed-by: Jason Ekstrand On Nov 26, 2013 11:20 AM, "Jonny Lamb" wrote: > From: Pekka Paalanen > > Replace the two fu

Re: [PATCH weston 1/8] compositor: gather buffer_transform and _scale into a struct

This one is a nice cleanup. --Jason Ekstrand Kristian, I would recommend pushing the first three right away as they will help with removing weston_view.width/height. --Jason Ekstrand Reviewed-by: Jason Ekstrand On Nov 26, 2013 11:20 AM, "Jonny Lamb" wrote: > From: Pekka Paalane

[PATCH] Remove the weston_view.geometry.width/height fields

This has a couple of additional implications for the internal weston API: 1) weston_view_configure no longer exists. Use weston_view_set_position instead. 2) The weston_surface.configure callback no longer takes a width and height. If you need these, surface.width/height are set before

Re: [RFC weston] Add a release_type argument to weston_buffer_reference

ess minimum number of buffers. The proposed patch is for the second case. Since the compositor releasing buffers at strange times is a backend-specific thing, this allows the backend to say "the client probably wants this now, go ahead and post it". I hope that makes things more clear. --Ja

[PATCH] Add a weston_surface_set_size function

of weston_surface manually. Signed-off-by: Jason Ekstrand --- desktop-shell/shell.c | 9 +++-- src/compositor.c | 15 +++ src/compositor.h | 4 3 files changed, 18 insertions(+), 10 deletions(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index

Re: [PATCH weston v2] input: make sure the devices get the resource destruction signal

Yeah, this is a good idea. --Jason Ekstrand Reviewed-By: Jason Ekstrand On Dec 6, 2013 5:48 AM, "Giulio Camuffo" wrote: > The device may not have a resource for the client yet, but install > the listeners nevertheless. > Fixes https://bugs.freedesktop.org/show_bug.cgi?id

Re: [PATCH] Add a weston_surface_set_size function

that weston_surface_set_size is only for non-client surfaces and therefore has the assert. --Jason Ekstrand On Dec 9, 2013 2:16 PM, "Giulio Camuffo" wrote: > 2013/12/9 Bryce W. Harrington : > > On Wed, Dec 04, 2013 at 08:32:03PM -0600, Jason Ekstrand wrote: > >> Surfaces that

Re: [PATCH weston] compositor: add a masking mechanism to weston_layer

Giulio, Couple thoughts. First, you don't provide an implementation of the clipping in any of the renderers. Probably have to wait on the Collabora people for the RPi renderer, but we should have pixman and gl implementations of this. Second, is there any particular reason why you're using pixm

Re: Fwd: [PATCH weston] xdg-shell: Make stable

, that could be "if the app has the focus-stealing permission, show the window, otherwise blink the notification bar" or something like that. However, allowing the app to say "you need to show me now" and being able to expect that its demand will be followed to the letter

Re: [PATCH weston 2/2] compositor: add a masking mechanism to weston_layer

One comment below. Otherwise, it looks good (though I haven't tested it yet.) Also, I'd like to decide what I think about the first patch before merging. I'll get back to you Monday or Tuesday. --Jason On Wed, Jul 9, 2014 at 12:12 PM, Giulio Camuffo wrote: > this adds a mechanism to mask the

Re: [PATCH] xdg-shell: Align surface life-time rules with that of wl_shell

face is destroyed. It's possible that we could remove the destructor and tie the two lifecycles together. However, we need to be *really* careful about doing so. --Jason Ekstrand > > Signed-off-by: Sjoerd Simons > --- > desktop-shell/shell.c | 25 ++-

Re: Fwd: [PATCH weston] xdg-shell: Make stable

ds the "xdg_surface_present()" request, > then a little blinking balloon, technically similar to a panel tooltip, > will appear at the bottom of the screen for some time. > When clicked, the balloon would then make the surface appear back on the > current screen, positioned as it w

Re: [PATCH] xdg-shell: Align surface life-time rules with that of wl_shell

And whatever we choose, we should try to make it consistent with the > subsurface roles, too, so we don't have different semantics for those. > > > On Mon, Jul 21, 2014 at 2:14 PM, Sjoerd Simons < > sjoerd.sim...@collabora.co.uk> wrote: > >> On Mon, 2014-07-21

Re: [PATCH wayland v5] client: extend error handling

Sorry for not looking at it. I'm mostly ok with the API so it's fine that you pushed it. I did have a question or two though. On Mon, Jul 7, 2014 at 7:28 AM, Pekka Paalanen wrote: > From: Marek Chalupa > > When an error occurs, wl_display_get_error() does not > provide any way of getting kno

Re: [PATCH weston] xwayland: set surface_id to 0 when client resource is found

Thanks. I just pushed this (with a small fix to change the variable name from "surface" to "id"). --Jason Ekstrand On Sun, Jul 20, 2014 at 1:10 AM, Boyan Ding wrote: > Only when reading through mails today did I find I had duplicated > efforts [1], sorry. >

Re: [PATCH] doc: Fix link to wl_list_remove()

Fine with me. Pushed. --Jason Ekstrand On Thu, Jul 24, 2014 at 5:35 PM, Bryce W. Harrington < b.harring...@samsung.com> wrote: > Use function linking syntax instead of variable linking, to resolve two > warnings: > > wayland-server.h:167: warning: explicit link request to

Re: [PATCH weston] compositor: ignore unmapped sub-surfaces for view_list

Yeah, I think this looks ok. Reviewed-by: Jason Ekstrand On Mon, Jul 28, 2014 at 4:06 AM, Pekka Paalanen wrote: > From: Pekka Paalanen > > It looks like that in the great conversion introducing weston_view, one > conditional was forgotten from the code that builds the global fl

Re: [PATCH V3] Do not assume 64x64 cursor, added support for other sizes (like in AMD Kaveri, 128x128).

Couple thoughs. First, we need to also update drm_output_prepare_cursor_view to check against the size coming from GBM instead of against the hard-coded 64x64 it's currently checking against. Without changing that, we are still restricted to 64x64 regardless of the GBM checking. Other questions b

Re: [PATCH V3] Do not assume 64x64 cursor, added support for other sizes (like in AMD Kaveri, 128x128).

On Tue, Jul 29, 2014 at 12:17 AM, Michel Dänzer wrote: > On 29.07.2014 16:01, Jason Ekstrand wrote: > > Couple thoughs. First, we need to also update > > drm_output_prepare_cursor_view to check against the size coming from GBM > > instead of against the hard-coded 64x64 it

Re: [PATCH V3] Do not assume 64x64 cursor, added support for other sizes (like in AMD Kaveri, 128x128).

that we're actually taking advantage of our new-found big cursors. Thanks, --Jason Ekstrand On Tue, Jul 29, 2014 at 12:40 AM, Michel Dänzer wrote: > On 29.07.2014 16:36, Jason Ekstrand wrote: > > On Tue, Jul 29, 2014 at 12:17 AM, Michel Dänzer > <mailto:mic...@daenzer.net&

Re: RFC : xdg_surface_present() look-and-feel and implementation

reuse > an existing term. One reason is to prevent somebody else from adding a > redundant api for that term, because they did not realize "present" is the > thing they are looking for. > We also discussed the name "attention". The reason why we didn'

Re: RFC : xdg_surface_present() look-and-feel and implementation

ns when you cycle through > windows with "Mod-Tab" and choose one. > Given that it's not supposed to be directly tied to a specific compositor action, that's probably best. I just wanted to make sure you were thinking about this and had a reason. --Jason > > >

Re: [PATCH weston] animation: also change stop value when updating a fade target

I just pushed this because it fixes a bug. I really don't like the fact that we have to track this separately from spring.target. We should probably fix the animation code so we don't. --Jason Ekstrand On Tue, Jul 29, 2014 at 4:56 PM, Jonny Lamb wrote: > If we're

Re: [PATCH weston 1/2] input: Send key-repeat

Both of these look good to me. I'll get around to pushing them soon. --Jason On Mon, Aug 4, 2014 at 10:43 AM, Jasper St. Pierre wrote: > --- > src/input.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/input.c b/src/input.c > index 4aa8ca7..aaa2223 100644 > -

Re: [PATCH weston] input: send wl_keyboard.repeat_info with rate and delay info

Bump. I just pushed Jasper's simple patch before seeing Daniel's comment about this one. Did we ever figure out pekka's crash? I'd like to see this committed soon. --Jason Ekstrand On Fri, Jul 25, 2014 at 5:01 AM, Pekka Paalanen wrote: > On Wed, 16 Jul 2014 23:0

Re: [PATCH wayland 0/6] Introduce API to automatically find a good default display

Sorry for not posting to the ML, but this looked good so I pushed it. --Jason On Thu, Jul 17, 2014 at 10:54 AM, Jasper St. Pierre wrote: > This patch series introduces a new API to find an open Wayland display > so that compositors don't need to reimplement all this code. This way, > the code s

Re: wayland: new socket addition

run/user/1000/wayland-1.lock, maybe another > compositor is running >unable to lock lockfile /run/user/1000/wayland-2.lock, maybe another > compositor is running > etc. ... > > only when manually adding the socket. It's really annoying when the >

Re: [PATCH wayland] server: Don't expose wl_display as a global

I think this is ok. To my knowledge, no one is re-binding wl_display or even relying on that global being exposed. --Jason On Thu, Aug 7, 2014 at 6:55 AM, Jasper St. Pierre wrote: > The idea here was that once upon a time, clients could rebind wl_display > to a higher version, so we offered th

Re: [PATCH weston 2/4] Don't bother destroying resources after sending an error

I squished in a little note for/from myself as to why this is OK. I pushed this one and the other 3 --Jason On Thu, Aug 7, 2014 at 1:43 PM, Jasper St. Pierre wrote: > An error makes the client exit, which cleans up the resources anyway. > --- > desktop-shell/input-panel.c | 1 - > desktop-she

Re: Undefined behavior

ever, the client shouldn't expect anything in particular. It could, for instance, result in no cursor. > Obviously, no valid program should ever try to reuse a cursor surface as > an xdg_surface. > Yeah, feel free to kill the client fo

Re: Undefined behavior

On Fri, Aug 15, 2014 at 12:18 AM, Pekka Paalanen wrote: > On Thu, 14 Aug 2014 11:31:27 -0700 > Jason Ekstrand wrote: > > > On Tue, Aug 12, 2014 at 1:34 PM, Jasper St. Pierre < > jstpie...@mecheye.net> > > wrote: > > > > > In the xdg-shell thread

Re: [PATCH wayland] client: add a public function to make a roundtrip on a custom queue

On Tue, Aug 19, 2014 at 3:58 AM, Pekka Paalanen wrote: > On Wed, 16 Jul 2014 11:13:06 +0300 > Giulio Camuffo wrote: > > > 2014-07-15 20:39 GMT+03:00 Daniel Stone : > > > Hi, > > > > > > > > > On Tuesday, July 15, 2014, Giulio Camuffo >

Re: [PATCH weston] configure.ac: use libinput by default

Reviewed-by: Jason Ekstrand On Tue, Aug 19, 2014 at 3:13 AM, Pekka Paalanen wrote: > From: Pekka Paalanen > > Libinput is stabilizing soon, so let's flip the default switch now. The > old input code will still be carried as an option for a while. > > Cc: Peter Hutt

Re: [PATCH wayland v2] protocol: define the concept of wl_surface role

Pekka, I have one nitpick below. However, if we can't find a good solution, I'm ok with pushing as-is. Reviewed-by: Jason Ekstrand On Tue, Aug 19, 2014 at 1:41 AM, Pekka Paalanen wrote: > On Tue, 19 Aug 2014 10:29:21 +0300 > Pekka Paalanen wrote: > > > From: Pekka

Re: [PATCH wayland v2] protocol: define the concept of wl_surface role

On Wed, Aug 20, 2014 at 12:52 PM, Bill Spitzak wrote: > > > On 08/20/2014 03:06 AM, Pekka Paalanen wrote: > >> On Tue, 19 Aug 2014 13:04:54 -0700 >> Bill Spitzak wrote: >> > > Destroying the last protocol object for the role does not remove the >>> role, correct? The client can recreate a new p

Re: [PATCH wayland v4 1/5] protocol: define the concept of wl_surface role

LGTM Reviewed-by: Jason Ekstrand On Thu, Aug 21, 2014 at 2:52 AM, Pekka Paalanen wrote: > From: Pekka Paalanen > > Define what a role is, and what restrictions there are. > > A change to existing behaviour is that a role cannot be changed at all > once set. However, this is

Re: [PATCH wayland v4 1/5] protocol: define the concept of wl_surface role

That applies to the whole series, BTW On Thu, Aug 21, 2014 at 9:03 AM, Jason Ekstrand wrote: > LGTM > Reviewed-by: Jason Ekstrand > > > On Thu, Aug 21, 2014 at 2:52 AM, Pekka Paalanen > wrote: > >> From: Pekka Paalanen >> >> Define what a role is, a

Re: [PATCH wayland] server: Don't expose wl_display as a global

On Thu, Aug 21, 2014 at 4:00 AM, Pekka Paalanen wrote: > On Thu, 7 Aug 2014 09:55:49 -0400 > "Jasper St. Pierre" wrote: > > > The idea here was that once upon a time, clients could rebind wl_display > > to a higher version, so we offered the ability to rebind it > > here. However, this is parti

Re: [PATCH wayland] protocol: Add a surface_has_existing_role error

As I mentioned on IRC, I don't really like adding and using an enum value without bumping protocol version. However, the only time we ever use it is to kill the client so the worst thing that can happen is that the client doesn't report the error correctly. I think I'm ok w

Re: Wayland and Weston 1.6 alpha snapshot (1.5.91)

we don't make any changes to xdg_shell between 1.6 and 1.7, the universe will break again at 1.7. This is because we'll pull the experimental_version request which changes the order of things. Do we have a plan for how to keep this from going too badly? --Jason Ekstrand

Re: [PATCH weston] xdg-shell: Make stable

Just a couple quick comments below. I can't fin where this goes, so I'm putting it here: Why are we having compositors send an initial configure event again? Given that we have a serial, tiling compositors can just send a configure and wait until the client responds to the event. Non-tiling com

Re: Wayland and Weston 1.6 alpha snapshot (1.5.91)

On Aug 26, 2014 4:32 AM, "Pekka Paalanen" wrote: > > On Tue, 26 Aug 2014 10:36:58 +0100 > Daniel Stone wrote: > > > Hi, > > > > On 23 August 2014 15:38, Pekka Paalanen wrote: > > > > > On Fri, 22 Aug 2014 10:51:19 -0700 > > > Jason

Re: [PATCH weston] xdg-shell: Make stable

On Aug 26, 2014 1:01 AM, "Giulio Camuffo" wrote: > > 2014-08-26 10:24 GMT+03:00 Pekka Paalanen : > > On Mon, 25 Aug 2014 21:51:57 -0700 > > Jason Ekstrand wrote: > > > >> Just a couple quick comments below. > >> > >> I can'

Re: [PATCH weston] xdg-shell: Make stable

7:50:47 +0300 > >> > Giulio Camuffo wrote: > >> > > >> >> 2014-08-26 17:39 GMT+03:00 Jason Ekstrand : > >> >> > > >> >> > On Aug 26, 2014 1:01 AM, "Giulio Camuffo" > wrote: > >> >

Re: [PATCH weston] shell: quit weston, if weston-desktop-shell dies early

Really, do we need a whole 30 seconds? You can easily do enough interaction to crash something in 30 seconds. Other than that, this looks fine. Reviewed-by: Jason Ekstrand On Thu, Aug 28, 2014 at 1:48 AM, Pekka Paalanen wrote: > From: Pekka Paalanen > > If weston-desktop-shell

Re: [PATCH weston] xdg-shell: Make stable

his needs to be explicitly stated to be double-buffered with commit. I think popups look OK but I don't have much experience there. --Jason Ekstrand ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mail

Re: [PATCH] pixman-backend: add support for zooming

eper changes to Weston: https://github.com/jekstrand/weston/commits/wip/transforms --Jason Ekstrand On Aug 29, 2014 7:56 AM, "Derek Foreman" wrote: > Currently if you try to zoom with mod+scrollwheel the pixman > backend will stop rendering anything at all and will continuously

Re: Self introduction

il with a bunch of bugs. Pick one and try to squash it! If you're feeling more adventurous, I've got a project or two that I wouldn't mind someone picking up. (I haven't had time lately for much weston hacking.) --Jason Ekstrand ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH] pixman-backend: add support for zooming

On Aug 29, 2014 6:25 PM, "Derek Foreman" wrote: > > On 29/08/14 06:42 PM, Jason Ekstrand wrote: > > Derek, > > I haven't had a chance to look that hard at or play with this patch yet. > > Hopefully I can look at it before too long. One quick question though

Re: [PATCH] pixman-backend: add support for zooming

On Mon, Sep 1, 2014 at 2:37 AM, Pekka Paalanen wrote: > On Fri, 29 Aug 2014 23:35:37 -0700 > Jason Ekstrand wrote: > > > On Aug 29, 2014 6:25 PM, "Derek Foreman" wrote: > > > > > > On 29/08/14 06:42 PM, Jason Ekstrand wrote: > > > > Derek,

Re: [PATCH] pixman-backend: add support for zooming

On Mon, Sep 1, 2014 at 8:33 AM, Derek Foreman wrote: > On 01/09/14 04:52 AM, Jason Ekstrand wrote: > > On Mon, Sep 1, 2014 at 2:37 AM, Pekka Paalanen > wrote: > > > >> On Fri, 29 Aug 2014 23:35:37 -0700 > >> Jason Ekstrand wrote: > >> > >&

Re: [PATCH 3/3] client: cancel read in wl_display_read_events() when last_error is set

I took a look at it too and it looks good to me --Jason On Thu, Sep 11, 2014 at 1:46 AM, Pekka Paalanen wrote: > On Wed, 10 Sep 2014 12:47:14 +0200 > Marek Chalupa wrote: > > > Calling wl_display_read_events() after an error should be equivalent > > to wl_display_cancel_read(), so that display

Re: [PATCH weston 1/3] Introduce pointer lock interface

On Thu, Sep 18, 2014 at 2:26 AM, Pekka Paalanen wrote: > On Wed, 17 Sep 2014 22:35:40 +0200 > Jonas Ådahl wrote: > > > On Wed, Sep 17, 2014 at 11:16:06PM +0300, Giulio Camuffo wrote: > > > 2014-09-17 23:11 GMT+03:00 Jonas Ådahl : > > > > On Wed, Sep 17, 2014 at 10:56:13PM +0300, Giulio Camuffo w

Re: [PATCH weston 1/3] Introduce pointer lock interface

> > > > > > On Thu, Sep 18, 2014 at 10:43:47AM -0700, Jason Ekstrand wrote: > > > > > On Thu, Sep 18, 2014 at 2:26 AM, Pekka Paalanen < > ppaala...@gmail.com> > > > wrote: > > > > > > > > > > > On Wed, 17 Sep 201

Re: [PATCH weston 1/3] Introduce pointer lock interface

On Sat, Sep 20, 2014 at 12:58 AM, Pekka Paalanen wrote: > On Fri, 19 Sep 2014 12:46:20 -0700 > Jason Ekstrand wrote: > > > On Fri, Sep 19, 2014 at 11:20 AM, Jonas Ådahl wrote: > > > > > On Fri, Sep 19, 2014 at 11:00:21AM -0600, Jasper St. Pierre wrote: > >

Re: [PATCH weston 1/3] Introduce pointer lock interface

> > > > On Fri, 19 Sep 2014 08:33:13 +0200 > > > > Jonas Ådahl wrote: > > > > > > > > > On Thu, Sep 18, 2014 at 10:43:47AM -0700, Jason Ekstrand wrote: > > > > > > On Thu, Sep 18, 2014 at 2:26 AM, Pekka Paalanen < > ppaala...@g

Re: [PATCH V2] wayland.xml: add "enum", "bitfield" and "is_bitfield" attributes

On Mon, Sep 22, 2014 at 9:30 AM, Nils Chr. Brause wrote: > On Mon, Sep 22, 2014 at 11:21 AM, Pekka Paalanen > wrote: > > > > On Wed, 3 Sep 2014 19:44:04 +0200 > > "Nils Chr. Brause" wrote: > > > > > This replaces "[PATCH wayland] Add "enum" attribute to "arg" elements". > > > Previous concers h

Re: [PATCH weston 1/3] Introduce pointer lock interface

On Sun, Sep 21, 2014 at 11:43 PM, Pekka Paalanen wrote: > On Sat, 20 Sep 2014 11:43:22 -0700 > Jason Ekstrand wrote: > > > On Sat, Sep 20, 2014 at 1:29 AM, Pekka Paalanen > wrote: > > > > > On Fri, 19 Sep 2014 20:20:53 +0200 > > > Jonas Ådahl wrote: &

Re: [PATCH V2] wayland.xml: add "enum", "bitfield" and "is_bitfield" attributes

On Mon, Sep 22, 2014 at 12:48 PM, Jasper St. Pierre wrote: > > > On Mon, Sep 22, 2014 at 12:27 PM, Jason Ekstrand > wrote: > >> >> >> On Mon, Sep 22, 2014 at 9:30 AM, Nils Chr. Brause < >> nilschrbra...@gmail.com> wrote: >> >>>

Re: [PATCH weston 1/3] Introduce pointer lock interface

On Mon, Sep 22, 2014 at 12:52 PM, Jonas Ådahl wrote: > On Mon, Sep 22, 2014 at 11:31:27AM -0700, Jason Ekstrand wrote: > > On Sun, Sep 21, 2014 at 11:43 PM, Pekka Paalanen > > wrote: > > > > > On Sat, 20 Sep 2014 11:43:22 -0700 > > > Jason Ekstrand wrote

Re: [PATCH V2] wayland.xml: add "enum", "bitfield" and "is_bitfield" attributes

On Tue, Sep 23, 2014 at 8:17 AM, Nils Chr. Brause wrote: > On Tue, Sep 23, 2014 at 8:35 AM, Pekka Paalanen > wrote: > > On Tue, 23 Sep 2014 13:59:39 +0800 > > Boyan Ding wrote: > > > >> On Mon, 2014-09-22 at 11:27 -0700, Jason Ekstrand wrote: > >> >

Re: [PATCH weston 1/3] Introduce pointer lock interface

Hi Matthieu, Could you please provide more explanation on what use-cases you are considering and why the current proposal fails to accomplish them? All I was able to get from your post was the example of a TV remote. It's all well and good to completely disagree with the proposed approach, but wi

Re: [PATCH weston 1/3] Introduce pointer lock interface

Bill, That's an interesting idea, but there are a few problems (which may be solvable). I do kind of like the way it completely sidesteps the acceleration issue. On Tue, Sep 23, 2014 at 12:43 PM, Bill Spitzak wrote: > In any case this all sounds excessively complicated. I think this will > work

Re: [PATCH weston 1/3] Introduce pointer lock interface

oposal can do that Jonas' one can't do ? > => The only thing I can find is the case where a seat doesn't have a > wl_pointer but have relative events. For all the rest, Jonas' proposal > seems to work. > => My proposition seems simpler to me. Less dependencies b

Re: xdg shell status and gaps

On Sep 25, 2014 3:04 PM, "Jasper St. Pierre" wrote: > > > > On Thu, Sep 25, 2014 at 3:58 PM, Bill Spitzak wrote: >> >> On 09/25/2014 01:57 PM, Jasper St. Pierre wrote: >> >>> https://github.com/magcius/weston/commit/c1e5a846f4f57400bca1262111f9793e451c5b49 >> >> >> That patch has nothing to do wi

Re: xdg shell status and gaps

On Fri, Sep 26, 2014 at 7:38 AM, Jasper St. Pierre wrote: > > > On Fri, Sep 26, 2014 at 4:07 AM, Carlos Garnacho > wrote: > >> Hey, >> >> On Thu, Sep 25, 2014 at 7:30 PM, Matthias Clasen < >> matthias.cla...@gmail.com> wrote: >> >>> On Thu, Sep 25, 2014 at 10:32 AM, Jasper St. Pierre >>> wrote:

<    2   3   4   5   6   7   8   >