Re: [PATCH weston] compositor-rdp: Correct mouse scrolling direction

Le 09/02/2018 à 17:14, Jason Gerecke a écrit : > The direction of scrolling in the RDP compositor appears to be inverted. > When using Weston directly in X, sending X11 button 4 cuases window > contents to scroll up and button 4 to be reported to xwayland clients. > Conversely, when using Weston th

Re: [PATCH weston] compositor-rdp: Correct mouse scrolling direction

Le 21/02/2018 à 11:09, Hardening a écrit : > Le 09/02/2018 à 17:14, Jason Gerecke a écrit : >> The direction of scrolling in the RDP compositor appears to be inverted. >> When using Weston directly in X, sending X11 button 4 cuases window >> contents to scroll up and butto

Re: [PATCH 2/3] gl-renderer: read PIXMAN_x8r8g8b8 as GL_BGRA_EXT

Le 06/07/2017 à 12:06, Olivier Blin a écrit : > This is needed by the RDP backend, which uses PIXMAN_x8r8g8b8 for its > shadow buffers. > --- > libweston/gl-renderer.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libweston/gl-renderer.c b/libweston/gl-renderer.c > index da29b072..b8b1

Re: [PATCH 3/3] rdp-backend.so: OpenGL hardware acceleration

Le 06/07/2017 à 12:06, Olivier Blin a écrit : > From: DRC > > --- > compositor/main.c | 23 +++- > configure.ac | 4 +- > libweston/compositor-rdp.c | 314 > +++-- > libweston/compositor-rdp.h | 24 > 4 files changed, 352 i

Re: [PATCH weston] compositor-rdp: fix compilation with freerdp 2.0.0-rc2

Le 22/05/2018 à 16:12, Pekka Paalanen a écrit : > On Fri, 11 May 2018 11:47:47 +0200 > Luca Weiss wrote: > >> See >> https://github.com/FreeRDP/FreeRDP/commit/1f7d33a2f22a372c124ce985a394619e186e06b9 >> for the upstream change. >> >> Signed-off-by: Luca Weiss >> --- >> libweston/compositor-rd

Re: [PATCH] rdp-compositor: fix compilation against last FreeRDP 2.0

Le 25/05/2018 à 16:17, Pekka Paalanen a écrit : > On Thu, 24 May 2018 14:55:20 +0200 > David Fort wrote: > >> The SURFACE_BITS_COMMAND struct has changed and some members have been moved >> in the >> bmp field. >> --- >> configure.ac | 5 ++- [...] >> > > Hi, > > with freerd

Re: Remote display with 3D acceleration using Wayland/Weston

Le 24/02/2017 à 00:51, DRC a écrit : > On 12/15/16 3:01 AM, Pekka Paalanen wrote: >> The current RDP-backed is written to set up and use only the Pixman >> renderer. Pixman renderer is a software renderer, and will not >> initialize EGL in the compositor. Therefore no support for hardware >> accele

Re: [PATCH 1/3] compositor-rdp: fix leak of frame bitmap in raw mode

Le 06/07/2017 à 12:06, Olivier Blin a écrit : > In rdp_peer_refresh_raw(), cmd->bitmapData was reallocated, but never freed. > > The cmd content (actually peer->update->surface_bits_command) was > re-initialized to zero at the beginning of the function, losing the > pointer to the previously alloc

Re: [PATCH] Fix API troubles with FreeRDP 2.0

Le 25/09/2017 à 10:49, Pekka Paalanen a écrit : > On Fri, 22 Sep 2017 11:17:41 +0200 > David Fort wrote: > >> With FreeRDP 2.0 the crypto needs to be initialized or we fail as soon as we >> try to >> compute a md5. The API also changed for the suppress output callback. >> --- >> libweston/compo

Re: [PATCH weston 05/21] libweston: weston_output_init(..., +name)

Le 22/09/2017 à 16:31, Pekka Paalanen a écrit : > From: Pekka Paalanen > > Add 'name' argument to weston_output_init(). This is much more obvious > than the assert inside weston_output_init() to ensure the caller has set > a field in weston_output first. > > Now weston_output_init() will strdup(

Re: Wayland/weston, Qt and RDP connection...

o services. And it doesn’t start: Hi, sorry very late reply, but if the goal is to export a Qt app through RDP, you may be interested by qfreerdp_platform (https://github.com/hardening/qfreerdp_platform). This a QPA (Qt Platform Abstraction module) that expose the screen and inputs through

Re: [PATCH] clients: Fix compositor version check for WL_SURFACE_DAMAGE_BUFFER_SINCE_VERSION

Le 20/12/2015 13:41, Chris Michael a écrit : > Signed-off-by: Chris Michael > --- > clients/simple-damage.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/clients/simple-damage.c b/clients/simple-damage.c > index 37a81f5..24c67cc 100644 > --- a/clients/simple-damage.c

wayalnd client wants to know the keyboard layout

Hello, I have worked on having the FreeRDP client have a decent wayland support. On the graphical part everything is quite straight forward anyway, I'm hitting some troubles with keyboard support (someone could say as usual when you code something around keyboard). In X11, xfreerdp queries X abou

Re: [PATCH wayland] scanner: Print filename on DTD validation error

Le 25/01/2016 10:28, Jonas Ådahl a écrit : > Don't just print prefix the errors with "protocol", but the actual file > name, if wayland-scanner was passed with the filename of the protocol > file. If wayland-scanner is reading from stdin, errors will be prefixed > with "" instead of "protocol". >

Re: [PATCH weston] input: Implement wl_seat.release

Le 13/03/2016 17:49, Quentin Glidic a écrit : > From: Quentin Glidic > > Avoid a crash because listener is NULL. > > Signed-off-by: Quentin Glidic > --- > src/input.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/src/input.c b/src/input.c > index 8c106dd..5d13b08 100644 > --

Re: [PATCH wayland 2/3] server: move include directives before extern "C" wrapper

Le 17/04/2016 13:29, Emil Velikov a écrit : > Analogous to previous commit but for the server(-core) header. > > Signed-off-by: Emil Velikov > --- > src/wayland-server-core.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/wayland-server-core.h b/src/wayland

Re: [PATCH 1/5] rdp: allow to compile against FreeRDP 2.0

Le 22/04/2016 15:19, David Fort a écrit : > FreeRDP 2.0 is about to be released, this allows to compile against this > version. > > Signed-off-by: David Fort > --- > configure.ac | 8 +++- > src/compositor-rdp.c | 23 --- > 2 files changed, 23 insertions(+), 8 d

Re: [PATCH 3/5] rdp: fix presentation for the RDP compositor

Le 22/04/2016 15:55, Pekka Paalanen a écrit : > On Fri, 22 Apr 2016 15:19:04 +0200 > David Fort wrote: > >> Set an update delay that is a multiple of the output frequency, or we may do >> incorrect weston_output_finish_frame calls. >> --- >> src/compositor-rdp.c | 2 +- >> 1 file changed, 1 inse

Re: [PATCH 5/5] desktop shell: resize background and panel when an output switches mode

Le 22/04/2016 16:18, Pekka Paalanen a écrit : > On Fri, 22 Apr 2016 15:19:06 +0200 > David Fort wrote: > >> When an output permanently switches mode, the desktop shell must be notified >> so >> that the misc components can resize to the new size of the output. This >> patch also >> fixes the co

Re: [PATCH v1] refactor configuration API of rdp-backend

Le 22/04/2016 17:05, Benoit Gschwind a écrit : > Implement a "well" defined API to configure the rdp backend. > Following according to discution about libweston API. > --- > v1: > - Fix the patch log > v0: > - Nothing particular. > > Signed-off-by: Benoit Gschwind > > Makefile.am |

Re: [PATCH 1/5] rdp: allow to compile against FreeRDP 2.0

Le 23/04/2016 11:50, Quentin Glidic a écrit : > On 22/04/2016 15:19, David Fort wrote: >> FreeRDP 2.0 is about to be released, this allows to compile against >> this version. >> >> Signed-off-by: David Fort >> --- >> configure.ac | 8 +++- >> src/compositor-rdp.c | 23 +++

Re: [PATCH 1/6] rdp: allow to compile against FreeRDP 2.0

Le 01/05/2016 23:32, David Fort a écrit : > FreeRDP 2.0 is about to be released, this allows to compile against this > version. > The detection is adjusted to prefer FreeRDP 2 against version 1.x. > > Signed-off-by: David Fort > --- > configure.ac | 5 - > src/compositor-rdp.c | 23

Re: [GSoC] Some questions about wayland clients with no outputs present

Le 03/05/2016 09:52, Pekka Paalanen a écrit : > On Mon, 2 May 2016 17:33:14 -0700 > Bryce Harrington wrote: > >> On Mon, May 02, 2016 at 12:49:04PM +0200, Armin Krezović wrote: >>> On 30.04.2016 22:14, Bryce Harrington wrote: On Sat, Apr 30, 2016 at 05:20:09PM +0200, Armin Krezović wrote:

Re: [ANNOUNCE] wayland 1.10.91

Le 11/05/2016 21:11, Bryce Harrington a écrit : > On Fri, May 06, 2016 at 02:17:23PM +0300, Pekka Paalanen wrote: >> On Wed, 4 May 2016 11:46:23 -0700 >> Bryce Harrington wrote: >> >>> On Wed, May 04, 2016 at 12:55:16AM -0700, Bryce Harrington wrote: Here's the alpha for the upcoming 1.11 rel

Re: [PATCH 2/6] rdp: don't release the seat until it is safe

Le 20/05/2016 00:51, Bryce Harrington a écrit : > On Tue, Apr 26, 2016 at 11:34:04PM +0200, David Fort wrote: >> Releasing a seat is not safe, so let's just announce it without keyboard >> and mouse until this is fixed. Without this patch we just can't reconnect on >> the RDP compositor as it crash

Re: [PATCH] rdp: don't release the seat until it is safe v2

Le 20/05/2016 11:58, Sam Spilsbury a écrit : > On Fri, May 20, 2016 at 5:33 PM, David Fort wrote: >> Releasing a seat is not safe, so let's just announce it without keyboard >> and mouse until this is fixed. Without this patch we just can't reconnect on >> the RDP compositor as it crashes. >> >> v

Re: [PATCH 0/6] RDP compositor needs love v2

Le 26/04/2016 23:34, David Fort a écrit : > Compared to the first version: > * compilation with FreeRDP 2.0 is now prefered; > * trivial patch using constant instead of hard coded value has its own commit; > * I have splitted the output resized patch so that the shell and the core > weston > part

Re: [PATCH wayland] shm: add getters for the fd and offset

Le 01/07/2015 10:25, Giulio Camuffo a écrit : > This allows to share the buffer data by mmapping the fd again. > --- > src/wayland-server-core.h | 6 ++ > src/wayland-shm.c | 16 +++- > 2 files changed, 21 insertions(+), 1 deletion(-) > Reviewed-by: David FORT > diff -

Re: [PATCH wayland 3/3] shm: wl_shm_buffer_get_data() requires a valid pool.

Le 01/07/2015 12:52, Marek Chalupa a écrit : > > > On Wed, Jul 1, 2015 at 11:25 AM, Marek Chalupa > wrote: > > > > On Fri, Jun 26, 2015 at 6:35 PM, Derek Foreman > mailto:der...@osg.samsung.com>> wrote: > > There's no situation where a shm buffer w

Re: [PATCH weston] compositor-rdp: free() can handle NULL pointers

Le 01/08/2015 16:02, Dawid Gajownik a écrit : > There's no need to check if a pointer exists before passing it to free(). > free() can handle NULL pointers. > > Signed-off-by: Dawid Gajownik Reviewed-By: David FORT > --- > src/compositor-rdp.c | 9 +++-- > 1 file changed, 3 insertions(+),

Re: [PATCH weston v3] compositor-rdp: rdp_destroy() double free error #91457

Le 05/08/2015 22:20, Derek Foreman a écrit : > On 05/08/15 03:21 PM, Dawid Gajownik wrote: >> When something goes wrong during weston initialization, >> weston_compositor_destroy() is executed. It destroys the backend and >> then frees compositor memory. Unfortunately RDP backend is not correctly >

Re: [PATCH weston] RDP compositor: make the seat dynamic and don't destroy it on removal

Le 25/09/2015 11:31, Pekka Paalanen a écrit : > On Thu, 24 Sep 2015 23:40:26 +0200 > David FORT wrote: > >> This patch makes the seat dynamic and leak it on purpose during seat removal >> to >> prevent the ghost object case. >> --- >> src/compositor-rdp.c | 39 +++---

Re: [PATCH weston] RDP compositor: make the seat dynamic and don't destroy it on removal

Le 25/09/2015 19:15, Derek Foreman a écrit : > On 25/09/15 08:19 AM, Hardening wrote: >> Le 25/09/2015 11:31, Pekka Paalanen a écrit : >>> On Thu, 24 Sep 2015 23:40:26 +0200 >>> David FORT wrote: >>> >>>> This patch makes the seat dynamic and

Re: [PATCH 3/3] Add a release request on wl_seat

Le 24/09/2015 01:59, Jonas Ådahl a écrit : > On Wed, Sep 23, 2015 at 11:17:33AM -0500, Derek Foreman wrote: >> On 25/02/15 08:03 AM, David FORT wrote: >>> This is required if we want to correctly remove a wl_seat server-side. >>> --- >>> protocol/wayland.xml | 6 ++ >>> 1 file changed, 6 inser

Re: [PATCH] wayland: add release request on wl_seat

Le 29/09/2015 09:58, Jonas Ådahl a écrit : > On Tue, Sep 29, 2015 at 09:43:01AM +0200, David FORT wrote: >> This is required if we want to correctly remove a wl_seat compositor-side. A >> wl_seat is announced as a global object, then it is bound by the client. When >> the compositor wants to remove

Re: [PATCH wayland v2] scanner: Close input resource when done to prevent leak

Le 02/10/2015 03:13, Bryce Harrington a écrit : > Addresses this error reported by Denis Denisov: > > [src/scanner.c:1415]: (error) Resource leak: input > > Signed-off-by: Bryce Harrington > > v2: Also close input for other exit points in main. > Signed-off-by: Bryce Harrington Reviewed-by:

Re: [PATCH 4/4] compositor-rdp: Add missing '\n' in weston_log usage

Le 01/10/2015 16:51, Chris Michael a écrit : > Signed-off-by: Chris Michael > --- > src/compositor-rdp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/compositor-rdp.c b/src/compositor-rdp.c > index c221eb9..7272f41 100644 > --- a/src/compositor-rdp.c > +++ b/src/c

Re: [PATCH] weston-input: Reformat weston_log line to add missing space between words

Le 07/10/2015 18:33, Derek Foreman a écrit : > On 07/10/15 10:59 AM, Chris Michael wrote: >> Signed-off-by: Chris Michael > > Reviewed-by: Derek Foreman > >> --- >> src/input.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/input.c b/src/input.c >> index e230c8

Re: [PATCH wayland] scanner: Generate 'since' macros for requests as well

Le 08/10/2015 05:10, Jonas Ådahl a écrit : > We already generate WL_[INTERFACE]_[REQUEST]_SINCE_VERSION macros for > events in the server protocol headers. Lets do the same for requests in > the client protocol headers as well. > > Signed-off-by: Jonas Ådahl > --- > src/scanner.c | 1 + > 1 file

Re: [PATCH] weston: release keyboard/touch/pointer objects

Le 08/10/2015 05:14, Jonas Ådahl a écrit : > On Tue, Oct 06, 2015 at 10:59:32AM +0200, David FORT wrote: >> This patch adds the missing calls to release when the seat has capabilities >> changes. It also fixes a missing release of the touch object. >> --- >> clients/window.c | 23 +

Re: [PATCH weston] clients: track seat_version per seat, not per display

Le 14/10/2015 16:39, Derek Foreman a écrit : > Apparently it's possible for a compositor to advertise seats with > different versions on the same connection, so this makes us more robust > against that dubious behaviour. > > This also tracks the seat version we requested instead of the advertised

Re: [weston] xkbcommon library is not optional.

Le 16/10/2015 03:28, Bryce Harrington a écrit : > On Tue, Oct 13, 2015 at 01:59:13PM +0200, Joaquim Duran wrote: >> Hello, >> >> When configuring the Weston project, it is possible to disable (don't >> include) the library libxkbcommon. To compile Weston successfully, >> even if the option --disabl

Re: [weston] xkbcommon library is not optional.

> > Joaquim Duran > Don't get me wrong, I'm not saying it's not useful. I'm saying that probably nobody's using it as otherwise it doesn't compile. > 2015-10-16 10:27 GMT+02:00 Hardening : >> Le 16/10/2015 03:28, Bryce Harrington a écrit : >&

Re: [RFC] weston: implement inert objects for keyboard/pointer/touch

Le 16/10/2015 11:53, David FORT a écrit : > This patch implements inert objects for wl_keyboard, wl_pointer and wl_touch. > The target case is when the server has just send a capability event about a > disappearing object, and the client binds the corresponding object. We bind an > inert object: an

Re: [RFC] weston: implement inert objects for keyboard/pointer/touch

Le 16/10/2015 11:53, David FORT a écrit : > This patch implements inert objects for wl_keyboard, wl_pointer and wl_touch. > The target case is when the server has just send a capability event about a > disappearing object, and the client binds the corresponding object. We bind an > inert object: an

Re: [PATCH] weston: implement inert objects for keyboard/pointer/touch

Le 20/10/2015 10:24, Bryce Harrington a écrit : > On Mon, Oct 19, 2015 at 03:47:19PM +0200, David FORT wrote: >> This patch implements inert objects for wl_keyboard, wl_pointer and wl_touch. >> The target case is when the server has just send a capability event about a >> disappearing object, and t

Re: [PATCH] weston: implement inert objects for keyboard/pointer/touch

Le 20/10/2015 17:12, Bryce Harrington a écrit : > On Tue, Oct 20, 2015 at 10:39:51AM +0200, Hardening wrote: >> Le 20/10/2015 10:24, Bryce Harrington a écrit : >>> On Mon, Oct 19, 2015 at 03:47:19PM +0200, David FORT wrote: >>>> This patch implements inert objects f

Re: [PATCH weston 03/10] Use presentation timing protocol from wayland-protocols

Le 04/11/2015 09:49, Jonas Ådahl a écrit : > Signed-off-by: Jonas Ådahl > --- > Makefile.am | 21 ++- > clients/presentation-shm.c | 65 +- > clients/weston-info.c| 19 +-- > protocol/presentation_timing.xml | 274 > --

Re: [PATCH weston 03/10] Use presentation timing protocol from wayland-protocols

Le 04/11/2015 09:49, Jonas Ådahl a écrit : > Signed-off-by: Jonas Ådahl > --- > Makefile.am | 21 ++- > clients/presentation-shm.c | 65 +- > clients/weston-info.c| 19 +-- > protocol/presentation_timing.xml | 274 > --

Re: Process for implementing a double buffer on Wayland

Le 25/11/2015 17:18, Daniel Stone a écrit : > Hi Mike, > > On 25 November 2015 at 16:06, Mike Johnson wrote: >> I've created 2 buffers of the same size (800x600 pixels). So I want the >> input buffer to get filled off-screen, while the output buffer will show the >> content on-screen. >> >> Firs

Re: [PATCH weston] compositor-fbdev: Drop intermediate shadow buffer

Le 05/12/2015 02:20, Derek Foreman a écrit : > From: Sjoerd Simons > > Currently the fbdev compositor has its own shadow buffer when rendering > with pixman, causing the following copies to occur: > > [pixman shadow buffer] -> [fbdev shadow buffer] -> [fbdev hardware] > > As the pixman render a

Re: [PATCH v4] xwm: let the shells decide the position of X windows

Le 11/12/2015 19:57, Giulio Camuffo a écrit : > The xwm used to automatically send to Xwayland the position of X windows > when that changed, using the x,y of the primary view of the surface. > This works fine for the desktop shell but less so for others. > This patch adds a 'send_position' vfunc t

Re: [PATCH] Fix compilation with FreeRdp 1.1 and master

On 10/12/2013 00:42, Kristian Høgsberg wrote: On Mon, Dec 09, 2013 at 10:16:39PM +0100, Hardening wrote: The API to use remoteFx encoding has changed between master and stable 1.1 branch. This patch fixes compilation for both. Please note that the freerdp/version.h file is generated in the very

Re: [PATCH] Fix compilation with FreeRdp 1.1 and master

On 10/12/2013 09:25, Hardening wrote: On 10/12/2013 00:42, Kristian Høgsberg wrote: On Mon, Dec 09, 2013 at 10:16:39PM +0100, Hardening wrote: The API to use remoteFx encoding has changed between master and stable 1.1 branch. This patch fixes compilation for both. Please note that the freerdp

[PATCH 1/1] Add a FreeRds backend, take 3

0..19b68c3 --- /dev/null +++ b/src/compositor-freerds.c @@ -0,0 +1,1057 @@ +/** + * Copyright © 2013 Hardening + * + * Permission to use, copy, modify, distribute, and sell this software and + * its documentation for any purpose is hereby granted without fee, provided + * that the above copyright n

[PATCH] Release pointer and keyboard with the seat

This patch fixes seat releasing during a RDP disconnection. It does not fully fix https://bugs.freedesktop.org/show_bug.cgi?id=66830, but makes things better. --- src/compositor-rdp.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/compositor-rdp.c b/src/compositor-rdp.

Re: [PATCH] Release pointer and keyboard with the seat

Le 22/12/2013 22:50, Kristian Høgsberg a écrit : On Sat, Dec 21, 2013 at 11:19:11PM +0100, Hardening wrote: This patch fixes seat releasing during a RDP disconnection. It does not fully fix https://bugs.freedesktop.org/show_bug.cgi?id=66830, but makes things better. Thanks, applied. What&#

Re: [PATCH 1/1] Add a FreeRds backend, take 3

Le 22/12/2013 23:52, Mariusz Ceier a écrit : Hello, I have installed freerdp with freerds and pysession-manager. Applied this patch in weston, and configured weston as static content provider for pysession-manager (both as greeter and desktop). Here, I have some results after testing: 1) Whe

[PATCH] Add a FreeRds backend, take 4

* Copyright © 2013 Hardening + * + * Permission to use, copy, modify, distribute, and sell this software and + * its documentation for any purpose is hereby granted without fee, provided + * that the above copyright notice appear in all copies and that both that + * copyright notice and this permissi

[PATCH] Add a FreeRds backend, take 5

sitor-freerds.c b/src/compositor-freerds.c new file mode 100644 index 000..aa733f7 --- /dev/null +++ b/src/compositor-freerds.c @@ -0,0 +1,1206 @@ +/** + * Copyright © 2013 Hardening + * + * Permission to use, copy, modify, distribute, and sell this software and + * its documentation for any purpo

[PATCH] Fix compilation with FreeRdp 1.1 and master v2

The API to use remoteFx encoding has changed between master and stable 1.1 branch. This patch should fix compilation for both. This new version adds checks for the freerdp/version.h file --- configure.ac | 5 + src/compositor-rdp.c | 12 2 files changed, 17 insertions(+)

[PATCH] Add a FreeRds backend, take 6

w file mode 100644 index 000..7e23f10 --- /dev/null +++ b/src/compositor-freerds.c @@ -0,0 +1,1206 @@ +/** + * Copyright © 2013 Hardening + * + * Permission to use, copy, modify, distribute, and sell this software and + * its documentation for any purpose is hereby granted without fee, provided + *

[PATCH] FreeRds backend, weston 1.5 rebased

tic_la_LDFLAGS = -module -avoid-version diff --git a/src/compositor-freerds.c b/src/compositor-freerds.c new file mode 100644 index 000..7e23f10 --- /dev/null +++ b/src/compositor-freerds.c @@ -0,0 +1,1206 @@ +/** + * Copyright © 2013 Hardening + * + * Permission to use, copy, modify, distrib

[PATCH] FreeRds backend, simplifications and improvements

file mode 100644 index 000..d78b42c --- /dev/null +++ b/src/compositor-freerds.c @@ -0,0 +1,1237 @@ +/** + * Copyright © 2013 Hardening + * + * Permission to use, copy, modify, distribute, and sell this software and + * its documentation for any purpose is hereby granted without fee, provided + * th

[PATCH] FreeRds backend, simplifications and improvements take 2

bcm_host} diff --git a/src/compositor-freerds.c b/src/compositor-freerds.c new file mode 100644 index 000..d78b42c --- /dev/null +++ b/src/compositor-freerds.c @@ -0,0 +1,1237 @@ +/** + * Copyright © 2013 Hardening + * + * Permission to use, copy, modify, distribute, and sell this software and +

Re: [PATCH 0/6] Add weston randr protocol

Le 27/02/2014 04:27, Quanxian Wang a écrit : These patches will provide weston randr protocol, its implementation and randr application. The idea is from xrandr provided by xserver. *Dynamic* mode setting is the main objective of this protocol. Remember, it is one shot operation. For example, if

Re: [PATCH] FreeRds backend, simplifications and improvements take 2

Le 26/02/2014 19:14, Mariusz Ceier a écrit : Hi, I did some basic testing of this version, and it seems to be as stable as x11-backend :) Issues that still aren't resolved: - when trying to enter polish letter they send either ^C or characters from different keymap(?), depending on client us

Re: [PATCH 1/6] Add weston randr protocol

Le 05/03/2014 03:07, Wang, Quanxian a écrit : Hi, All With the first version of randr protol, I got many useful idea and comments. Thanks. Before I send the email, I have make it happen in real world but need more deep testing. Here are new changes and idea for that protocol based on the ide

Re: [PATCH 1/6] Add weston randr protocol

Le 05/03/2014 11:04, Pekka Paalanen a écrit : On Wed, 5 Mar 2014 09:40:32 + "Wang, Quanxian" wrote: Just mention one thing Pq: But RandR is a disaster if random applications use it! Windows and icons squashed into top-left corner, dialogs too large to fit on the screen after the random ap

[PATCH] Add error handling for wl_cursors

This patch adds some error management in wayland cursors --- cursor/wayland-cursor.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/cursor/wayland-cursor.c b/cursor/wayland-cursor.c index b16f530..dba3b51 100644 --- a/cursor/wayland-cursor.c +++ b/cursor/

[PATCH] Check return value of wl_cursor functions

This patch adds checks for themes and cursors returned by wl_cursor functions. --- clients/simple-egl.c | 10 ++ clients/window.c | 4 src/compositor-wayland.c | 7 ++- 3 files changed, 20 insertions(+), 1 deletion(-) diff --git a/clients/simple-egl.c b/clients/simp

[PATCH] Make RDP backend supports arbitrary modes

This patch removes the extra modes parameter for the RDP compositor. And make it support any mode that is requested (be aware that RDP client may not support all possible modes, especially odd resolution). This is definitely useful for the fullscreen shell. --- src/compositor-rdp.c | 105 +

Re: [PATCH] compositor: Use weston_log rather than perror for error messages

Le 18/03/2014 20:34, Bryce W. Harrington a écrit : weston_log() seems to be the standard elsewhere in the codebase for errors. These are the only two instances where perror() is used instead, and their error messages aren't that informative anyway. Signed-off-by: Bryce Harrington --- src/com

[PATCH] Make RDP backend supports arbitrary modes v2

This patch removes the extra modes parameter for the RDP compositor. And make it support any mode that is requested (be aware that RDP client may not support all possible modes, especially odd resolution). This new version fixes remarks done by Jason Ekstrand. It also fixes some missing spaces bet

Re: [PATCH] compositor: Use weston_log rather than perror for error messages

Le 22/03/2014 12:21, Pekka Paalanen a écrit : On Fri, 21 Mar 2014 05:54:02 + "Bryce W. Harrington" wrote: weston_log() seems to be the standard elsewhere in the codebase for errors. These are the only two instances where perror() is used instead, and their error messages aren't that infor

[PATCH] Add an option to disable client initiated resizes

This patch adds an option to the RDP compositor to disable desktop resizes initiated by RDP peer. The current behaviour is that if an incoming RDP peer suggests a resolution that is not the current one, a mode_switch() is done and the desktop is resized to that new resolution. This new flag allows

Re: [PATCH] Add an option to disable client initiated resizes

Le 03/04/2014 02:08, Bill Spitzak a écrit : Hardening wrote: +if (!settings->DesktopResize) { +/* peer does not support desktop resize */ +weston_log("%s: client doesn't support resizing, closing connection\n", __FUNCTION__); +

[PATCH v2] Add an option to disable client initiated resizes

This patch adds an option to the RDP compositor to disable desktop resizes initiated by RDP peer. The current behaviour is that if an incoming RDP peer suggests a resolution that is not the current one, a mode_switch() is done and the desktop is resized to that new resolution. This new flag allows

Re: [PATCH V3 4/7] Add new mode function in drm backend

) + return NULL; + memset(modeinfo, 0x0, sizeof(*modeinfo)); Hardening: you should use zmalloc here + + modeinfo->type = DRM_MODE_TYPE_USERDEF; + modeinfo->hskew = 0; + modeinfo->vrefresh = 0; + modeinfo->hdisplay = hdisplay; [...] +

Re: [PATCH V3 0/7] Add weston randr protocol

Le 08/04/2014 07:03, Quanxian Wang a écrit : Important Changes compared with V2: 1) Provide 2 methods to mode match for mode setting and mode delete. a) Exact mode number match Client selects the mode number according to query information. [...] 5) Add above and below move action o

Re: [PATCH V3 5/7] weston:Add the weston randr protocol implementation

; 1<modenum.modi_time; + *results |= result<< + (WRANDR_TYPE_OOP_MODENUM * 2); + } + + if (request->flags & 1<mode->modi_time > time) { + time = request->mode->modi_time; +

Re: [PATCH libinput 1/9] evdev: Dynamically allocate slot array

Le 09/04/2014 21:02, Jonas Ådahl a écrit : Don't have a hard coded (previously 16) slot array size; instead allocate dynamically depending what slots are assigned. There is still a hard coded max though, to protect from invalid input, but its changed to 60. Signed-off-by: Jonas Ådahl --- src/

[PATCH] Check malloc result

This patch checks malloc was successfull and release resources if it wasn't. --- src/screen-share.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/src/screen-share.c b/src/screen-share.c index 5de20be..d3e3f05 100644 --- a/src/screen-share.c +++ b/src/screen

[PATCH 0/2] Keyboard oriented patch

The RDP compositor could became more popular with the fullscreen shell, so this serie brings enhancements for keyboard. The first patch adds the management of more RDP keyboard layouts. The second one simplifies scan code computation by using existing FreeRDP functions. Hardening (2): Add

[PATCH 2/2] Use FreeRDP buildin functions to get scancodes

This patch make use of the functions available in FreeRDP to retrieve the scancode to inject. --- src/compositor-rdp.c | 24 ++-- 1 file changed, 6 insertions(+), 18 deletions(-) diff --git a/src/compositor-rdp.c b/src/compositor-rdp.c index 437954f..b749129 100644 --- a/src/c

[PATCH 1/2] Add more keyboards for the RDP compositor

This patch complements the table that contains matches between RDP and xkb keyboard layouts. We now handle variants too. --- src/compositor-rdp.c | 132 ++- 1 file changed, 120 insertions(+), 12 deletions(-) diff --git a/src/compositor-rdp.c b/src/c

Re: [PATCH 1/2] Add more keyboards for the RDP compositor

On 04/11/2014 01:52 AM, Hardening wrote: This patch complements the table that contains matches between RDP and xkb keyboard layouts. We now handle variants too. --- src/compositor-rdp.c | 132 ++- 1 file changed, 120 insertions(+), 12 deletion

Re: [PATCH wayland] connection: Don't write past the end of the connection buffer

Le 17/04/2014 17:20, Ander Conselvan de Oliveira a écrit : From: Ander Conselvan de Oliveira If a message was too big to fit in the connection buffer, the code in wl_buffer_put would just write past the end of it. I haven't seen any real world use case that would trigger this bug, but it was p

Re: [PATCH] event: Cheking for NULL before dereferencing the pointer.

Le 09/05/2014 08:43, Srivardhan Hebbar a écrit : Checking for NULL before dereferencing the wl_event_source pointer so as to avoid crash. Signed-off-by: Srivardhan Hebbar --- src/event-loop.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/event-loop.c b/src/

Re: [PATCH] event: Cheking for NULL before dereferencing the pointer.

Le 09/05/2014 12:20, Pekka Paalanen a écrit : On Fri, 09 May 2014 15:21:51 +0530 Srivardhan wrote: -Original Message- From: Pekka Paalanen [mailto:ppaala...@gmail.com] Sent: Friday, May 09, 2014 3:09 PM To: Srivardhan Cc: 'Hardening'; wayland-devel@lists.freedesktop.org S

[PATCH 1/2] Set to NULL event source after a call to wl_event_source_remove

This patch sets to NULL event sources after a call to wl_event_source_remove() has been made. --- src/clipboard.c | 3 ++- src/compositor-drm.c | 3 +++ src/compositor-rpi.c | 1 + src/compositor-x11.c | 2 ++ src/compositor.c | 6 +- src/evdev-touchpad.c | 1 + src/evdev.c |

[PATCH 2/2] Handle OOM with signal events

This patch handles the case where a signal event source can not be created. --- src/compositor.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index 6ad3387..047df8a 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -4197,

Re: [PATCH V2] event: assert wl_event_source pointer is NULL.

Le 12/05/2014 07:56, Srivardhan Hebbar a écrit : Signed-off-by: Srivardhan Hebbar --- src/event-loop.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/event-loop.c b/src/event-loop.c index 9790cde..57e3fed 100644 --- a/src/event-loop.c +++ b/src/event-loop.c @@

Re: Wayland and Weston 1.5.0 is released

of the key contributors. Either people that have their corner of weston that they maintain (for example Pekka and the Raspberry Pi backend or Hardening and the RDP backend) or contributors who have been part of the project for a while and understands the code base well - or both. Hi, congratul

Re: [PATCH] protocol: remove redundant 'the' in description

Le 23/05/2014 09:14, Pekka Paalanen a écrit : On Fri, 23 May 2014 03:04:29 -0400 "Jasper St. Pierre" wrote: On Fri, May 23, 2014 at 2:49 AM, Pekka Paalanen wrote: [...] This is obviously correct. Can I push this, or shall we reserve the right to push to libwayland for Kristian only, ev

[PATCH 2/2] Use FreeRDP buildin functions to get scancodes

This patch make use of the functions available in FreeRDP to retrieve the scancode to inject. --- src/compositor-rdp.c | 24 ++-- 1 file changed, 6 insertions(+), 18 deletions(-) diff --git a/src/compositor-rdp.c b/src/compositor-rdp.c index 437954f..b749129 100644 --- a/src/c

[PATCH 0/2] RDP Keyboard

ese at the last sending, so if nobody's against I will commit them. Hardening (2): Add more keyboards for the RDP compositor Use FreeRDP buildin functions to get scancodes src/compositor-rdp.c | 156 +-- 1 file changed, 126 insertions(+

[PATCH 1/2] Add more keyboards for the RDP compositor

This patch complements the table that contains matches between RDP and xkb keyboard layouts. We now handle variants too. --- src/compositor-rdp.c | 132 ++- 1 file changed, 120 insertions(+), 12 deletions(-) diff --git a/src/compositor-rdp.c b/src/c

Re: [PATCH 0/2] RDP Keyboard

Le 26/05/2014 17:22, Hardening a écrit : > I'm resending this serie of patches that are related to keyboard with the RDP > compositor. The first one make weston support more RDP keyboard (RDP to Xkb > convertion). The second make use of buildin FreeRDP functions instead of >

Re: [PATCH] weston: Fix memleak issue in compositor.c

Le 27/05/2014 11:00, Srivardhan Hebbar a écrit : > This fix is upon "Hardening " patch. [PATCH 2/2] Handle > OOM with signal events. > LGTM Reviewed-by: Hardening > Signed-off-by: Srivardhan Hebbar > --- > src/compositor.c | 23 +-- >

  1   2   >