Hi,
On 30-09-2019 10:33, Sean Young wrote:
On Mon, Sep 30, 2019 at 11:34:04AM +1000, Peter Hutterer wrote:
On Sun, Sep 29, 2019 at 08:17:38PM +0100, Sean Young wrote:
When using IR receivers using libinput, key events get dropped if a new
rc keymap is loaded and the key was not in the old keym
Hi,
On 01-10-2019 10:39, Sean Young wrote:
Hi Hans,
On Mon, Sep 30, 2019 at 01:29:59PM +0200, Hans de Goede wrote:
On 30-09-2019 10:33, Sean Young wrote:
On Mon, Sep 30, 2019 at 11:34:04AM +1000, Peter Hutterer wrote:
On Sun, Sep 29, 2019 at 08:17:38PM +0100, Sean Young wrote:
Any thoughts
Hi Sean,
On 02-10-2019 11:33, Sean Young wrote:
Hi,
On Tue, Oct 01, 2019 at 03:32:52PM +0200, Hans de Goede wrote:
On 01-10-2019 10:39, Sean Young wrote:
On Mon, Sep 30, 2019 at 01:29:59PM +0200, Hans de Goede wrote:
So can you please explain your specific use-case here?
Simply loading a
Hi,
On 6/25/20 11:40 AM, Simon Ser wrote:
On Thursday, June 25, 2020 11:01 AM, Brad Robinson
wrote:
As a toolkit developer coming from Windows/OSX this is fairly
shocking. I'm aware of the decoration protocol, but given it's not
supported (and by the sound of it never will be) on some of the
As discussed already several times in the past:
https://www.x.org/wiki/Events/XDC2014/XDC2014GoedeBacklight/
https://lore.kernel.org/all/4b17ba08-39f3-57dd-5aad-d37d844b0...@linux.intel.com/
The current userspace API for brightness control offered by
/sys/class/backlight devices has various iss
Hi Simon,
On 4/7/22 18:51, Simon Ser wrote:
> Very nice plan! Big +1 for the overall approach.
Thanks.
> On Thursday, April 7th, 2022 at 17:38, Hans de Goede
> wrote:
>
>> The drm_connector brightness properties
>> ===
>>
&g
Hi Daniel,
On 4/8/22 10:07, Daniel Vetter wrote:
> On Thu, Apr 07, 2022 at 05:05:52PM -0400, Alex Deucher wrote:
>> On Thu, Apr 7, 2022 at 1:43 PM Hans de Goede wrote:
>>>
>>> Hi Simon,
>>>
>>> On 4/7/22 18:51, Simon Ser wrote:
>>>> Very n
Hi,
On 4/8/22 11:58, Hans de Goede wrote:
> Hi Daniel,
>
> On 4/8/22 10:07, Daniel Vetter wrote:
>> On Thu, Apr 07, 2022 at 05:05:52PM -0400, Alex Deucher wrote:
>>> On Thu, Apr 7, 2022 at 1:43 PM Hans de Goede wrote:
>>>>
>>>> Hi Simon,
>&g
Hi,
On 4/8/22 11:58, Hans de Goede wrote:
> Hi Daniel,
>
> On 4/8/22 10:07, Daniel Vetter wrote:
>> On Thu, Apr 07, 2022 at 05:05:52PM -0400, Alex Deucher wrote:
>>> On Thu, Apr 7, 2022 at 1:43 PM Hans de Goede wrote:
>>>>
>>>> Hi Simon,
>&g
Hi,
On 4/8/22 12:16, Simon Ser wrote:
> Would it be an option to only support the KMS prop for Good devices,
> and continue using the suboptimal existing sysfs API for Bad devices?
>
> (I'm just throwing ideas around to see what sticks, feel free to ignore.)
Currently suid-root or pkexec helpers
Hi,
On 4/8/22 16:08, Alex Deucher wrote:
> On Fri, Apr 8, 2022 at 4:07 AM Daniel Vetter wrote:
>>
>> On Thu, Apr 07, 2022 at 05:05:52PM -0400, Alex Deucher wrote:
>>> On Thu, Apr 7, 2022 at 1:43 PM Hans de Goede wrote:
>>>>
>>>> Hi Simon,
>&g
Hi Simon,
On 4/8/22 10:22, Simon Ser wrote:
> Hi Hans,
>
> Thanks for your details replies!
>
> On Thursday, April 7th, 2022 at 19:43, Hans de Goede
> wrote:
>
>>> On Thursday, April 7th, 2022 at 17:38, Hans de Goede
>>> wrote:
>>&
Hi,
On 4/8/22 17:11, Alex Deucher wrote:
> On Fri, Apr 8, 2022 at 10:56 AM Hans de Goede wrote:
>>
>> Hi,
>>
>> On 4/8/22 16:08, Alex Deucher wrote:
>>> On Fri, Apr 8, 2022 at 4:07 AM Daniel Vetter wrote:
>>>>
>>>> On Thu, Apr 07, 202
Hi,
On 4/7/22 20:58, Carsten Haitzler wrote:
> On Thu, 7 Apr 2022 17:38:59 +0200 Hans de Goede said:
>
> Below you covered our usual /sys/class/backlight device friends... what about
> DDC monitor controls? These function similarly but just remotely control a
> screen via I2C
Hi Simon,
On 4/8/22 10:22, Simon Ser wrote:
> Hi Hans,
>
> Thanks for your details replies!
>
> On Thursday, April 7th, 2022 at 19:43, Hans de Goede
> wrote:
>
>>> On Thursday, April 7th, 2022 at 17:38, Hans de Goede
>>> wrote:
>>&
Hi Pekka,
On 4/11/22 13:34, Pekka Paalanen wrote:
> On Mon, 11 Apr 2022 12:18:30 +0200
> Hans de Goede wrote:
>
>> Hi,
>>
>> On 4/8/22 17:11, Alex Deucher wrote:
>>> On Fri, Apr 8, 2022 at 10:56 AM Hans de Goede wrote:
>>>>
>
> ...
>
Hi,
On 4/13/22 10:32, Daniel Vetter wrote:
> On Fri, Apr 08, 2022 at 12:26:24PM +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 4/8/22 12:16, Simon Ser wrote:
>>> Would it be an option to only support the KMS prop for Good devices,
>>> and continue using th
Hi All,
As discussed in the "[RFC] drm/kms: control display brightness through
drm_connector properties" thread, step 1 of the plan is to stop
registering multiple /sys/class/backlight devs for a single display.
On x86 there can be multiple firmware + direct-hw-access methods
for controlling the
gt;>>>> On Mon, Apr 11, 2022 at 6:18 AM Hans de Goede wrote:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> On 4/8/22 17:11, Alex Deucher wrote:
>>>>>>> On Fri, Apr 8, 2022 at 10:56 AM Hans de Goede
>>
Hi,
On 4/14/22 15:10, Jani Nikula wrote:
> On Thu, 07 Apr 2022, Hans de Goede wrote:
>> As discussed already several times in the past:
>> https://www.x.org/wiki/Events/XDC2014/XDC2014GoedeBacklight/
>>
>> https://lore.kernel.org/all/4b17ba08-39f3-57dd-5aad-d
Hi,
On 5/18/22 16:23, Jani Nikula wrote:
> On Wed, 18 May 2022, Hans de Goede wrote:
>> So how about: display_brightness or panel_brightness ?
>
> This is a prime opportunity to look at all the existing properties, and
> come up with a new combination of capitalization
Hi,
On 6/3/22 17:22, Simon Ser wrote:
> On Friday, June 3rd, 2022 at 17:17, Zack Rusin wrote:
>
>>
>>> On Jun 3, 2022, at 10:56 AM, Simon Ser wrote:
>>> ⚠ External Email
>>>
>>> On Friday, June 3rd, 2022 at 16:38, Zack Rusin wrote:
>>>
> On Jun 3, 2022, at 10:32 AM, Simon Ser wrote:
>
Hi,
On 6/10/22 14:53, Simon Ser wrote:
> On Friday, June 10th, 2022 at 14:36, Gerd Hoffmann wrote:
>
>> Hi,
>>
As Pekka mentionned, I'd also like to have a conversation of how far we
want to
push virtualized driver features. I think KMS support is a good feature to
have
>>>
Hi,
On 19-01-17 03:34, Peter Hutterer wrote:
We were just switching type here without actual normalization, the filter code
is in device units as of bdd4264d6150f4a6248eec7.
Signed-off-by: Peter Hutterer
Series looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
src
h-set looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
src/evdev-mt-touchpad.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c
index f437c2d..ca00c40 100644
--- a/src/evdev-mt-touchpad.c
+++ b/src/evdev-mt-touch
Hi,
On 08-02-17 01:17, Peter Hutterer wrote:
42 and 58 were within the middle button already, 40/60 are more accurate
values.
https://bugs.freedesktop.org/show_bug.cgi?id=99212
Signed-off-by: Peter Hutterer
Looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
src/evdev-mt
Hi,
First of all patches 1-9 and 11 looks good to me and are:
Reviewed-by: Hans de Goede
I've some remarks inline on this one.
On 30-01-17 01:58, Peter Hutterer wrote:
Don't rely on BTN_TOUCH for "finger down", the value for that is hardcoded in
the kernel and not a
ff-by: Peter Hutterer
Series looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
src/evdev-lid.c | 28 +---
src/evdev-mt-touchpad-tap.c | 22 --
src/evdev-mt-touchpad.c | 14 ++
src/evdev-mt-touchpad.h
Hi,
On 09-02-17 23:55, Peter Hutterer wrote:
On Thu, Feb 09, 2017 at 05:25:36PM +0100, Hans de Goede wrote:
Hi,
First of all patches 1-9 and 11 looks good to me and are:
Reviewed-by: Hans de Goede
thx, fwiw, I already pushed these, so fixups will come as a separate patch.
I've
Hi,
Series looks good, but patch 1/2 introduces
tp_is_tpkb_combo_below() and patch 2/2 then moves it around
to avoid doing a forward declaration, it would be better IMHO
if patch 1/2 simply defined it in the place where 2/2 puts it.
With that fixed:
Reviewed-by: Hans de Goede
Regards,
Hans
--show-keycodes switch to show it.
The few times we actually need the keycodes, we can run the switch in the
debugging tool.
This does not affect keys outside of the main block on the keyboard (F-keys,
multimedia keys).
Signed-off-by: Peter Hutterer
Patch looks good to me:
Reviewed-by: Hans de
-by: Hans de Goede
Regards,
Hans
---
src/evdev-tablet-pad.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/evdev-tablet-pad.c b/src/evdev-tablet-pad.c
index bed43b6..6be53b5 100644
--- a/src/evdev-tablet-pad.c
+++ b/src/evdev-tablet-pad.c
@@ -542,6 +542,11 @@ pad_init_buttons
Hi,
On 14-02-17 02:58, Peter Hutterer wrote:
makes it easier to filter out debugging messages
Signed-off-by: Peter Hutterer
---
Sorry, used the wrong patch, v1 was an earlier version.
v2 looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
tools/shared.c | 18
With these fixes, a long click
now sends button events if there never were any scroll events generated.
Series looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
changes look good to me, as for how the new accel feels / works,
I trust you've good reasons for these changes:
Acked-by: Hans de Goede
Regards,
Hans
---
This is the first time I'm quite happy with the touchpad acceleration.
src/filter.c | 37 ++
Hi,
On 24-02-17 05:41, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer
Patch series looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
src/evdev-tablet-pad-leds.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/evdev-tablet-pad-leds.c b/src/evdev-tablet-pad
Hi,
On 24-02-17 07:15, Peter Hutterer wrote:
Brings some consistency to the log output, making it easier to grep for a
specific device's output, etc.
Patch series looks good to me:
Acked-by: Hans de Goede
Regards,
Hans
___
wayland-devel ma
horizontal edge scroll area. Reduce the minimum size to 40mm
instead, that's closer to where it starts to get a bit iffy.
https://bugzilla.redhat.com/show_bug.cgi?id=141
Signed-off-by: Peter Hutterer
Patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
src/evd
=99976
Signed-off-by: Peter Hutterer
Patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
src/evdev-mt-touchpad-buttons.c | 2 +-
test/test-touchpad-buttons.c| 32
2 files changed, 33 insertions(+), 1 deletion(-)
diff --git a/src
Hi,
On 07-03-17 04:22, Peter Hutterer wrote:
https://bugs.freedesktop.org/show_bug.cgi?id=99975
Signed-off-by: Peter Hutterer
Patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
src/evdev-mt-touchpad.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions
.high = 24;
tp->pressure.low = 10;
+ } else if (device->model_flags & EVDEV_MODEL_CYAPA) {
+ tp->pressure.high = 8;
+ tp->pressure.low = 6;
updated locally to 10/8 at the tester's request
LGTM:
Reviewed-by:
ven in the software button. We can revisit this if we see
tap detection failures in the future.
https://bugzilla.redhat.com/show_bug.cgi?id=1415796
Signed-off-by: Peter Hutterer
Sounds reasonable to me and the code changes look good:
Reviewed-by: Hans de Goede
Regards,
Hans
---
src/evdev-mt-
vent being event_delta_smooth_value us apart.
Theoritically a very still finger may send the exact same coordinates
and pressure twice, but even if this happens that is not a problem because
a still finger generates coordinates changes below the hyst treshold so
we ignore it anyways.
Signed-off-by: Han
Bluetooth wreaks havoc with the timestamp of the input events coming
from the touchpad, enable timestamp smoothing support to counter this.
Signed-off-by: Hans de Goede
---
src/evdev-mt-touchpad.c | 4 +++-
src/filter.c| 6 +-
src/filter.h| 4 +++-
tools/ptraccel
Hi,
On 10-07-17 07:11, Peter Hutterer wrote:
From: Hans de Goede
Some devices, specifically some bluetooth touchpads generate quite
unreliable timestamps for their events. The problem seems to be that
(some of) these touchpads sample at aprox 90 Hz, but the bluetooth stack
only communicates
e
gestures working reliably than both unreliably.
Signed-off-by: Peter Hutterer
I agree this is the best way to handle this:
Acked-by: Hans de Goede
Regards,
Hans
---
src/evdev-mt-touchpad-gestures.c | 7 +-
test/test-gestures.c | 211 ---
Hi,
On 19-09-17 18:41, Matt Porter wrote:
The Chalkboard Electronics HID Touchscreen is classified as
a tablet device by systemd udev because it has BTN_TOOL_PEN
support. It also reports a resolution of 0 for both X and Y
axes in absinfo. This causes libinput to reject it as an
invalid tablet de
Hi,
On 21-09-17 16:00, Matt Porter wrote:
On Thu, Sep 21, 2017 at 10:59:08AM +0200, Hans de Goede wrote:
Hi,
On 19-09-17 18:41, Matt Porter wrote:
The Chalkboard Electronics HID Touchscreen is classified as
a tablet device by systemd udev because it has BTN_TOOL_PEN
support. It also reports
Hi,
On 25-09-17 08:08, Peter Hutterer wrote:
On Sat, Sep 23, 2017 at 09:57:37AM +0200, Klaus Rudolph wrote:
With X11 ( before wayland ) I can set up my touchscreen with:
xinput --list
find my device: "Advanced Silicon S.A. CoolTouch(TM) System"
and can simply set the props I need with:
ully and
slowly. This is likely going to take multiple years and then some ...
Regards,
Hans
>
> On Thu, Apr 7, 2022 at 10:39 AM Hans de Goede <mailto:hdego...@redhat.com>> wrote:
>
> As discussed already several times in the past:
> https://www.x.org/wiki/Eve
s.
As such just having a kernel cmdline parameter to hide/unhide
it might be good enough.
Regards,
Hans
>
> On Thu, Aug 25, 2022 at 3:27 AM Hans de Goede <mailto:hdego...@redhat.com>> wrote:
>
> Hi Yusuf,
>
> On 8/24/22 04:18, Yusuf Khan wrote:
> &
Hi all,
Here is v2 of my "drm/kms: control display brightness through drm_connector
properties" RFC:
Changes from version 1:
- Drop bl_brightness_0_is_min_brightness from list of new connector
properties.
- Clearly define that 0 is always min-brightness when setting the brightness
through th
Hi All,
I will be at Plumbers Dublin next week and I was wondering if
anyone interested in this wants to get together for a quick
discussion / birds of a feather session about this?
I have just posted version 2 of the RFC:
https://lore.kernel.org/dri-devel/b61d3eeb-6213-afac-2e70-7b9791c86...@red
Hi,
On 9/9/22 15:39, Simon Ser wrote:
> On Friday, September 9th, 2022 at 12:12, Hans de Goede
> wrote:
>
>> Phase 3: Deprecate /sys/class/backlight uAPI
>>
>>
>> Once most userspace has moved over to using the new
Hi All,
On 9/9/22 12:23, Hans de Goede wrote:
> Hi All,
>
> I will be at Plumbers Dublin next week and I was wondering if
> anyone interested in this wants to get together for a quick
> discussion / birds of a feather session about this?
>
> I have just posted version
Hi All,
Juerd (in the Cc) reported the following problem to me at our local hackerspace.
During a big hacker event in the Netherlands this summer (MCH) the logistics
team used custom barcodes to keep track of inventory. These custom barcodes
contain a # symbol.
They noticed that with the USB-key
Hi,
On 9/12/22 23:20, Peter wrote:
> Hi all,
>
>
> Op maandag 12 september 2022 om 15:14:09 +0200 schreef Juerd Waalboer
> :
>> Hans de Goede skribis 2022-09-12 7:16 (+0200):
>>> During a big hacker event in the Netherlands this summer (MCH) the logistics
>>
Hi,
On 9/13/22 12:28, Carlos Garnacho wrote:
> Hi!,
>
> On Tue, Sep 13, 2022 at 11:36 AM Hans de Goede wrote:
>>
>> Hi,
>>
>> On 9/12/22 23:20, Peter wrote:
>>> Hi all,
>>>
>>>
>>> Op maandag 12 september 2022 om 15:14:09 +020
Hi,
On 9/28/22 12:04, Jani Nikula wrote:
> On Fri, 09 Sep 2022, Hans de Goede wrote:
>> Hi all,
>>
>> Here is v2 of my "drm/kms: control display brightness through drm_connector
>> properties" RFC:
>>
>> Changes from version 1:
>> -
Hi,
On 9/28/22 12:57, Ville Syrjälä wrote:
> On Wed, Sep 28, 2022 at 01:04:01PM +0300, Jani Nikula wrote:
>> On Fri, 09 Sep 2022, Hans de Goede wrote:
>>> Hi all,
>>>
>>> Here is v2 of my "drm/kms: control display brightness through drm_connector
Hi,
On 9/30/22 18:17, Sebastian Wick wrote:
> On Fri, Sep 30, 2022 at 5:27 PM Pekka Paalanen wrote:
>>
>> On Fri, 30 Sep 2022 17:44:17 +0300
>> Ville Syrjälä wrote:
>>
>>> On Fri, Sep 30, 2022 at 04:20:29PM +0200, Sebastian Wick wrote:
On Fri, Sep 30, 2022 at 9:40 AM Pekka Paalanen wrote:
Hi,
On 10/3/22 12:32, Pekka Paalanen wrote:
> On Mon, 3 Oct 2022 11:44:56 +0200
> Hans de Goede wrote:
>
>> One example mentioned here is that laptops with Intel integrated
>> graphics may have some "perceived brightness" mapping table
>> in their Video BIOS
Hi Mariano,
On 6/19/24 5:15 PM, Mariano wrote:
> Hi everybody
>
> MGRX is a small 2D graphics C library derived from the GRX library. GRX was
> originaly written by Csaba Biegl for DJ Delorie's DOS port of the GCC
> compiler.
>
> MGRX supports DOS, Win32, Linux framebuffer, Linux KMS/DRM, Linu
to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
doc/tablet-support.dox | 4 +++-
src/libinput.c | 6 ++
src/libinput.h | 24 ++--
src/libinput.sym | 1 +
test/tablet.c | 25 +
5 files changed, 53 insertions(
Hi,
On 12/21/2015 02:46 AM, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer
Looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
src/evdev-tablet.c | 4
test/tablet.c | 38 ++
2 files changed, 42 insertions(+)
diff
Hi,
On 12/21/2015 06:56 AM, Peter Hutterer wrote:
Only the wheel has a discrete value, no need to keep arrays for a single
value.
Signed-off-by: Peter Hutterer
Entire series looks good to me and is:
Reviewed-by: Hans de Goede
Regards,
Hans
---
src/evdev-tablet.c | 6
Hi,
On 03-01-16 23:36, Peter Hutterer wrote:
A fake MT device may have ABS_MT_POSITION_X but not Y. In this case we don't
care, because we don't handle those axes anyway.
http://bugs.freedesktop.org/show_bug.cgi?id=93474
Signed-off-by: Peter Hutterer
---
src/evdev.c
Hi,
On 04-01-16 02:20, Peter Hutterer wrote:
This is a first draft to gather some comments, it's not hooked up to
anything yet and really just to get the main intention across.
Things up for comments and discussion:
Unlike buttons, we only expose switches we understand, hence enum
libinput_swit
-by: Peter Hutterer
Patch code looks good to me:
Reviewed-by: Hans de Goede
I do worry a bit if this will not break dwt on older macbooks
though. Maybe we need to also check the bus type in this block:
> + /* For Apple touchpads, always use its internal keyboard */
> + if (ven
Hi,
On 08-01-16 01:51, Peter Hutterer wrote:
A fake MT device may have ABS_MT_POSITION_X but not Y. In this case we don't
care, because we don't handle those axes anyway.
http://bugs.freedesktop.org/show_bug.cgi?id=93474
Signed-off-by: Peter Hutterer
Looks good to me:
Reviewed-b
axis and the BTN_TOOL_* events.
https://bugs.freedesktop.org/show_bug.cgi?id=93583
This kernel patch is required:
https://lkml.org/lkml/2016/1/11/171
Signed-off-by: Peter Hutterer
Patch looks good to me:
Reviewed-by: Hans de Goede
About Benjamin's patch:
https://lkml.org/lkml/2016/1/1
Hi,
On 19-01-16 01:01, Peter Hutterer wrote:
Synaptics, Elantech and Alps semi-mt devices all have issues with reporting
correct MT data, even the bounding box which semi-mt devices are supposed to
report is wrong.
Synaptics devices have massive jumps with two fingers down. Elantech devices
may
Hi,
On 22-01-16 03:06, Peter Hutterer wrote:
If the touch hasn't updated, the distance hasn't changed so there is no need
to unhover.
Signed-off-by: Peter Hutterer
Series looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
src/evdev-mt-touchpad.c | 3 +++
1 fi
Hi,
On 22-01-16 03:06, Peter Hutterer wrote:
On Wed, Jan 20, 2016 at 11:31:42AM +0100, Hans de Goede wrote:
Hi,
Then we can also revert:
http://cgit.freedesktop.org/wayland/libinput/commit/?id=0d40aefe
Making tp_gesture_get_active_touches() look only at real touches
again as intended
Hi,
On 25-01-16 04:03, Peter Hutterer wrote:
The first/second variables are only needed for pinch, so we can skip them
here.
Signed-off-by: Peter Hutterer
Patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
src/evdev-mt-touchpad-gestures.c | 10 --
1 file
Hi,
On 25-01-16 04:04, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer
Patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
src/evdev-mt-touchpad-gestures.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/src/evdev-mt
Hi,
On 25-01-16 04:03, Peter Hutterer wrote:
On Fri, Jan 22, 2016 at 11:15:55AM +0100, Hans de Goede wrote:
Hi,
On 22-01-16 03:06, Peter Hutterer wrote:
On Wed, Jan 20, 2016 at 11:31:42AM +0100, Hans de Goede wrote:
Hi,
Then we can also revert:
http://cgit.freedesktop.org/wayland
accordingly, for
now disable the button codes.
https://bugs.freedesktop.org/show_bug.cgi?id=92127
Signed-off-by: Peter Hutterer
Patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
src/evdev.c| 36 +
src/evdev.h
: Hans de Goede
Regards,
Hans
---
test/gestures.c | 60 +
1 file changed, 60 insertions(+)
diff --git a/test/gestures.c b/test/gestures.c
index 3f7ee83..c814911 100644
--- a/test/gestures.c
+++ b/test/gestures.c
@@ -1153,6 +1153,63
Hi,
On 01-02-16 07:43, Peter Hutterer wrote:
On Mon, Feb 01, 2016 at 12:38:13PM +1000, Peter Hutterer wrote:
Some older touchpad devices jitter a fair bit when a finger is resting on the
touchpad. That's why the hysteresis was introduced in the synaptics driver
back in 2011. However, the defaul
motion are too good to ignore
Ok, lets say how this one plays out:
Reviewed-by: Hans de Goede
Regards,
Hans
src/evdev-mt-touchpad.c| 23 ++-
src/evdev.c| 1 +
src/evdev.h| 1 +
udev/90-libinput-mo
obviously wrong. For now, give priority to serio keyboards, and
override existing dwt pairings with the new keyboard.
https://bugs.freedesktop.org/show_bug.cgi?id=93983
Signed-off-by: Peter Hutterer
Patch looks good to me: Reviewed-by: Hans de Goede
Regards.
Hans
---
src/evdev-mt-touchpad.c
. This is a corner case and likely hard to trigger by a real user.
https://bugs.freedesktop.org/show_bug.cgi?id=93984
Signed-off-by: Peter Hutterer
Patch looks good to me: Reviewed-by: Hans de Goede
Regards.
Hans
---
src/evdev-mt-touchpad.c | 18 +-
src/evdev-mt-touchpad.h | 1
Hutterer
Looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
src/evdev-mt-touchpad.c | 9 ---
test/touchpad.c | 68 +
2 files changed, 73 insertions(+), 4 deletions(-)
diff --git a/src/evdev-mt-touchpad.c b/src/evdev
, EFL/Enlightenment)
Mike Blumenkrantz (Samsung, EFL/Enlightenment)
Andrew Williams (EFL/Enlightenment)
Olivier Fourdan (Red Hat, graphics team)
Benjamin Tissoires (Red Hat, graphics team)
Hans de Goede (Red Hat, graphics team)
Discussed:
-Menu position stuff, basically:
https://bugzilla.gnome.org
.
Expected side-effect: earlier versions of ALPS touchpads now lose their
(erroneous) size assignment.
Signed-off-by: Peter Hutterer
Both patches look good to me and are:
Reviewed-by: Hans de Goede
Thanks & Regards,
Hans
---
udev/90-libinput-model-quirks.hwdb | 4 ++--
udev/libi
NG_PROXIMITY))
delta.x = value - tablet->axes.point.x;
tablet->axes.point.x = value;
+
}
point.x = tablet->axes.point.x;
This seems like an extra empty line accidentally got added. Otherwise this
patch looks good to me:
Reviewed-by: Ha
bug.cgi?id=93947
Signed-off-by: Peter Hutterer
Patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
src/evdev-mt-touchpad.c | 11 +++-
src/evdev-mt-touchpad.h | 1 -
test/touchpad.c | 72 ++---
3 files c
Hi,
On 17-02-16 01:11, Peter Hutterer wrote:
https://bugs.freedesktop.org/show_bug.cgi?id=94097
Signed-off-by: Peter Hutterer
Patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
src/evdev-mt-touchpad.c | 27 +++
1 file changed, 19
Sorry for being a bit slow on reviewing this one, this
seems to be a good solution to me (I consider false positives unlikely):
Reviewed-by: Hans de Goede
Regards,
Hans
---
src/evdev-mt-touchpad-gestures.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a
Looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
src/evdev-mt-touchpad-gestures.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/evdev-mt-touchpad-gestures.c b/src/evdev-mt-touchpad-gestures.c
index dc8d606..3c8f5a7 100644
--- a/src/evdev-mt-touchpad-gestures.c
+++
vrThinkPadX1Carbon3rd:*
+ LIBINPUT_MODEL_LENOVO_T450_TOUCHPAD=1
+
##
# Synaptics
##
Otherwise this patch looks good to me and is:
Reviewed-by: Hans de Goede
Regards,
Hans
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel
https://bugs.freedesktop.org/show_bug.cgi?id=94733
Signed-off-by: Peter Hutterer
Patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
src/evdev-mt-touchpad-buttons.c | 23 ---
test/trackpoint.c | 132
2 files ch
dirty)
continue;
+ if (t->pressure_delta < -7)
+ tp_motion_history_reset(t);
+
Do you really want to do this on all touchpads and not just on t440 / t450
and friends ?
Otherwise this series looks good and is:
Reviewed-by: Hans de Goede
Rega
only refer to the middle button area now.
https://bugs.freedesktop.org/show_bug.cgi?id=94755
Signed-off-by: Peter Hutterer
Patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
doc/clickpad-softbuttons.dox| 14 +-
doc/svg/software-buttons.svg| 30
Hi,
On 11-04-16 01:32, Peter Hutterer wrote:
Supposed to be [-1, 1] but we only generated [0, 1]
Reported-by: Carlos Garnacho
Signed-off-by: Peter Hutterer
Patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
src/evdev-tablet.c | 2 +-
test/tablet.c | 10
Signed-off-by: Peter Hutterer
Patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
src/evdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/evdev.c b/src/evdev.c
index 6bb8986..9be4a96 100644
--- a/src/evdev.c
+++ b/src/evdev.c
@@ -505,11
Hi,
On 11-04-16 05:54, Peter Hutterer wrote:
The state of button scrolling should determine whether we filter the event,
not the hardware button state.
Signed-off-by: Peter Hutterer
---
src/evdev.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/evdev.c b/sr
Hi,
On 11-04-16 05:54, Peter Hutterer wrote:
https://bugs.freedesktop.org/show_bug.cgi?id=94856
Signed-off-by: Peter Hutterer
Patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
src/evdev.c| 107 -
src
down emulation should not engage. Test for this.
Signed-off-by: Peter Hutterer
Patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
test/pointer.c | 57 +
1 file changed, 57 insertions(+)
diff --git a/test/pointe
1 - 100 of 779 matches
Mail list logo
