On Tuesday, 2017-12-05 13:47:06 +, Daniel Stone wrote:
> Hi Eric,
>
> On 8 June 2017 at 22:20, Eric Engestrom wrote:
> > On Wednesday, 2017-05-24 21:23:14 +0100, Eric Engestrom wrote:
> >> This field is populated with chars, compared to chars and printed as
> >&
On Friday, 2017-12-08 10:17:17 +1000, Peter Hutterer wrote:
> Commit db3b6fe5f7f8 "fallback: change to handle the state at EV_SYN time"
> introduced regressions for two types of event sequences.
>
> One is a kernel bug - some devices/drivers like the asus-wireless send a key
> press + release with
On February 15, 2018 6:55:14 PM UTC, Emil Velikov
wrote:
> From: Emil Velikov
>
> Based on a similar patch (in Mesa) by Eric Engestrom.
>
> Cc: Eric Engestrom
Reviewed-by: Eric Engestrom
> Signed-off-by: Emil Velikov
> ---
> egl/wayland-egl-symbols-check |
On Friday, 2018-02-23 17:31:53 +, Emil Velikov wrote:
> From: Emil Velikov
>
> Inspired by Heiko Becker and Eric's work in libdrm and Mesa
> respectively.
>
> Cc: Eric Engestrom
> Signed-off-by: Emil Velikov
Reviewed-by: Eric Engestrom
I haven't really
ar 2018 14:30:27 +
> >> > Emil Velikov wrote:
> >> >
> >> >> From: Emil Velikov
> >> >>
> >> >> Based on a similar patch (in Mesa) by Eric Engestrom.
> >> >>
> >> >> v2: Rebase on top of $NM patch
&
On Monday, 2018-03-19 12:11:50 +, Eric Engestrom wrote:
> On Monday, 2018-03-19 11:43:08 +, Emil Velikov wrote:
> > On 19 March 2018 at 09:56, Pekka Paalanen wrote:
> > > On Fri, 16 Mar 2018 16:18:57 +
> > > Emil Velikov wrote:
> > >
> > &g
On Monday, 2018-03-19 15:13:14 +, Daniel Stone wrote:
> The previous rewrite of the wayland-egl ABI checker introduced checks
> for removed symbols as well as added symbols, but broke some failure
> conditions. Add an explict return-code variable set in failure paths,
> rather than chaining or
On Monday, 2018-03-19 16:10:57 +, Daniel Stone wrote:
> Hi,
>
> On 19 March 2018 at 16:08, Eric Engestrom wrote:
> > On Monday, 2018-03-19 15:13:14 +, Daniel Stone wrote:
> >> +if ! test -f "$LIB"; then
> >> + echo "Test binary \&qu
On Monday, 2018-03-19 17:45:19 +0100, Guido Günther wrote:
> Use stride instead of width for buffer calculation.
>
> Signed-off-by: Guido Günther
> ---
> clients/simple-dmabuf-drm.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/clients/simple-dmabuf-drm.c b/clie
On Monday, 2018-03-19 17:45:20 +0100, Guido Günther wrote:
> Signed-off-by: Guido Günther
It is indeed :)
Reviewed-by: Eric Engestrom
> ---
> clients/simple-dmabuf-drm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/clients/simple-dmab
Upstream SDL supports Wayland since v2.0.4 (June 2015):
https://forums.libsdl.org/viewtopic.php?t=11294
Just set SDL_VIDEODRIVER=wayland and SDL will do the right thing :)
Signed-off-by: Eric Engestrom
---
TODO | 3 ---
1 file changed, 3 deletions(-)
diff --git a/TODO b/TODO
index
butors of projects that follow X.Org's
> purpose as enacted in its bylaws. Other projects can continue to be
> hosted on fd.o but won't receive X.Org membership for the mere reason
> of
> being hosted on fd.o.
With my member hat on, I think this is the best choice.
Acked
nction is specific to 4 char codes, I think its name should
reflect this.
> +{
> + int i;
> +
> + assert(len >= 5);
> +
> + for (i = 0; i < 4; i++)
> + str[i] = bits2graph(format, i * 8);
> + str[i] = '\0';
> +}
> +
>
er_size = 32;
> window.frame_sync = 1;
> + window.delay = 0;
>
> for (i = 1; i < argc; i++) {
> - if (strcmp("-f", argv[i]) == 0)
> + if (strcmp("-d", argv[i]) == 0 && i+1 < argc)
> +
On Tuesday, 2017-02-21 16:14:27 +, Emil Velikov wrote:
> From: Emil Velikov
>
> With next commit we'll make wayland-util a shared library (for reasons
> mentioned in the commit). As such we need to make sure that the private
> symbols are somewhere that they can be used internally. Otherwise
eleration in Xwayland (glamor being used by default).
>
> Add an environment variable XWAYLAND_NO_GLAMOR t odiable glamor support
"to disable"
The change itself looks good to me.
Reviewed-by: Eric Engestrom
As to whether it's a good idea to allow this, I'd say it
h, and you can drop the quotes :)
I think allowing to leave out tests is reasonable. I tested it a bit
too, to make sure it doesn't break `make check` or `make distcheck`, so
with the above fix, you can have my:
Reviewed-by: Eric Engestrom
T
Signed-off-by: Eric Engestrom
---
tests/connection-test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/connection-test.c b/tests/connection-test.c
index 8be6c38..157e1bc 100644
--- a/tests/connection-test.c
+++ b/tests/connection-test.c
@@ -603,8 +603,8
On Thursday, 2017-03-23 11:59:22 -0500, Derek Foreman wrote:
> posix_fallocate() can return EINTR and need to be restarted - I've hit
> this when running weston-terminal under gdb.
>
> Signed-off-by: Derek Foreman
Both patches are:
Reviewed-by: Eric Engestrom
...and now I&#x
On Wednesday, 2017-04-26 12:20:39 +1000, Peter Hutterer wrote:
> With autotools, we replace the @top_srcdir@ during configure and then run teh
> resulting scripts.
>
> With meson, it's easier to just pass top-srcdir it in as argument.
>
> Signed-off-by: Peter Hutterer
> ---
> test/symbols-leak-
Reviewed-by: Eric Engestrom
On 2 May 2017 01:01:32 BST, Peter Hutterer wrote:
>With autotools, we replace the @top_srcdir@ during configure and then
>run
>the resulting scripts.
>
>With meson, it's easier to just pass top-srcdir it in as argument.
>
>Signed-off-by: Pet
2, len) != 0)
> + continue;
> +
> + if (options[k].type == WESTON_OPTION_BOOLEAN)
> + continue;
Am I understanding this right, that you're skipping this here because it
is already be handled by long_option()?
I think this is actuall
On Wednesday, 2017-05-10 13:48:00 +1000, Peter Hutterer wrote:
> Signed-off-by: Peter Hutterer
This series is
Reviewed-by: Eric Engestrom
> ---
> src/evdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/evdev.c b/src/evdev.c
> index d24a
Signed-off-by: Eric Engestrom
---
src/evdev.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/src/evdev.c b/src/evdev.c
index a2be6fc..7895644 100644
--- a/src/evdev.c
+++ b/src/evdev.c
@@ -50,6 +50,8 @@
#define DEFAULT_WHEEL_CLICK_ANGLE 15
#define
Rewrite
foo(); while(...) { foo(); }
into
do { foo(); } while(...);
to avoid duplication and make the flow easier to read and understand.
Signed-off-by: Eric Engestrom
---
src/libinput.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/libinput.c b/src
On Wednesday, 2017-05-10 17:25:04 +0200, Jan Engelhardt wrote:
>
> On Wednesday 2017-05-10 17:20, Dima Ryazanov wrote:
> > +#define ARRAY_SIZE(a) (sizeof(a)/sizeof(a)[0])
> >
> >
> >I'm guessing this works, but "sizeof(a)[0]" looks very unintuitive to me. I
> >think "sizeof(a[0])" is
> >the
On Wednesday, 2017-05-17 09:02:32 +1000, Peter Hutterer wrote:
> Signed-off-by: Peter Hutterer
> ---
> meson.build | 7 +++--
> tools/Makefile.am | 8 --
> tools/libinput-debug-events.c | 15 +--
> tools/libinput-tool.c | 8 ++
> tools/libi
This field is populated with chars, compared to chars and printed as
a char. It should probably be a char.
Signed-off-by: Eric Engestrom
---
shared/config-parser.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/shared/config-parser.h b/shared/config-parser.h
index f18d2c0b
These are already used as bools by all callers, let's make that official.
Signed-off-by: Eric Engestrom
---
shared/option-parser.c | 39 ---
1 file changed, 20 insertions(+), 19 deletions(-)
diff --git a/shared/option-parser.c b/shared/option-parser.c
test.rules"
> + "/80-libinput-device-groups-litest-XX.rules"
>
> static int jobs = 8;
> static int in_debugger = -1;
> @@ -1125,17 +1125,20 @@ litest_copy_file(const char *dest, const char *src,
> const char *header)
> {
> int in
On Wednesday, 2017-05-24 21:23:14 +0100, Eric Engestrom wrote:
> This field is populated with chars, compared to chars and printed as
> a char. It should probably be a char.
>
> Signed-off-by: Eric Engestrom
Humble ping?
I don't have commit access either, so you'll ha
On Tuesday, 2017-06-20 12:26:24 +1000, Peter Hutterer wrote:
> All the other config options have a simple true/false as well.
>
> Signed-off-by: Peter Hutterer
All 3 patches are:
Reviewed-by: Eric Engestrom
> ---
> meson.build | 2 +-
> meson_options.txt | 2 +-
>
gt; sudo restorecon /usr/lib64/libinput.so.*
> +
> +
> +Pick whichever one is your libdir.
You don't need this note if you give that command instead :)
$> sudo restorecon /usr/lib*/libinput.so.*
Reviewed-by: Eric Engestrom
> +
> +This issue is tracked in https://github.com/me
https://www.archlinux.org/news/deprecation-of-abs/
Signed-off-by: Eric Engestrom
---
doc/building.dox | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/doc/building.dox b/doc/building.dox
index 5ce2146..355c535 100644
--- a/doc/building.dox
+++ b/doc/building.dox
@@ -124,10 +1
On 21 June 2017 00:43:10 BST, Peter Hutterer wrote:
>Signed-off-by: Peter Hutterer
>---
>A temporary workaround until the meson bit is fixed.
Reviewed-by: Eric Engestrom
> meson.build | 6 ++
> src/Makefile.am | 2 +-
configuration : man_config,
Well, it's a shame install_man() doesn't have a `configuration:`
argument :(
> +install : true,
> + install_dir : join_paths(get_option('mandir'), 'man1')
Took me a minute to find t
On Friday, 2017-06-30 16:21:39 +0100, Eric Engestrom wrote:
> On Thursday, 2017-06-29 10:01:10 +1000, Peter Hutterer wrote:
> > Signed-off-by: Peter Hutterer
> > ---
> > configure.ac | 1 +
> > meson.build
weston_check_egl_extension() returns a bool, not a pointer.
Signed-off-by: Eric Engestrom
---
clients/nested.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/clients/nested.c b/clients/nested.c
index 173076a6..e9070e9b 100644
--- a/clients/nested.c
+++ b/clients/nested.c
On Monday, 2017-09-11 13:52:28 +0100, Eric Engestrom wrote:
> weston_check_egl_extension() returns a bool, not a pointer.
>
> Signed-off-by: Eric Engestrom
Fixes: ce5b614c80b4dfe8e899 "clients/nested: use weston_check_egl_extension
over strstr&quo
On Monday, 2017-09-11 16:08:53 +0100, Emil Velikov wrote:
> On 11 September 2017 at 15:40, Eric Engestrom
> wrote:
> > On Monday, 2017-09-11 13:52:28 +0100, Eric Engestrom wrote:
> >> weston_check_egl_extension() returns a bool, not a pointer.
> >>
> Nicely sp
On Friday, 2017-09-15 11:17:29 -0400, Drew DeVault wrote:
> On 2017-09-15 6:06 PM, Pekka Paalanen wrote:
> > Indeed, 2 and 4 bit formats are also missing, but 8 and 16 bit ones are
> > already defined unless you meant some new variation.
>
> The 8 and 16 bit ones, so far as I can tell, are 8/16 b
Hello everyone,
For many years now, we have maintained mirrors of numerous FDo projects
on GitHub, under the following organisations:
https://github.com/freedesktop
https://github.com/mesa3d
https://github.com/wayland-project
A bit over a month ago, a new security feature in git started preventin
Signed-off-by: Eric Engestrom
---
tools/zunitc/src/zuc_base_logger.c | 6 --
tools/zunitc/src/zunitc_impl.c | 11 ---
2 files changed, 17 deletions(-)
diff --git a/tools/zunitc/src/zuc_base_logger.c
b/tools/zunitc/src/zuc_base_logger.c
index 1beb60d..cdbd9ea 100644
--- a/tools
Signed-off-by: Eric Engestrom
---
tools/zunitc/inc/zunitc/zunitc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/zunitc/inc/zunitc/zunitc.h b/tools/zunitc/inc/zunitc/zunitc.h
index 0fa78e3..6ac6f39 100644
--- a/tools/zunitc/inc/zunitc/zunitc.h
+++ b/tools/zunitc/inc
Signed-off-by: Eric Engestrom
---
clients/flower.c | 2 +-
clients/scaler.c | 2 +-
clients/smoke.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/clients/flower.c b/clients/flower.c
index aafc63c..34287fd 100644
--- a/clients/flower.c
+++ b/clients/flower.c
@@ -110,7
Signed-off-by: Eric Engestrom
---
doc/t440-support.dox | 2 +-
src/evdev-tablet.c | 2 +-
src/evdev.c | 2 +-
src/filter.c | 2 +-
src/libinput.h | 8
5 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/doc/t440-support.dox b/doc/t440-support.dox
Signed-off-by: Eric Engestrom
---
src/wayland-client.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/wayland-client.c b/src/wayland-client.c
index 297c7a5..33033e7 100644
--- a/src/wayland-client.c
+++ b/src/wayland-client.c
@@ -1587,7 +1587,7 @@ wl_display_poll
Signed-off-by: Eric Engestrom
---
xwayland/selection.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xwayland/selection.c b/xwayland/selection.c
index 6f5328d..bd5e28a 100644
--- a/xwayland/selection.c
+++ b/xwayland/selection.c
@@ -117,7 +117,7
Signed-off-by: Eric Engestrom
---
protocol/wayland.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/protocol/wayland.xml b/protocol/wayland.xml
index 8739cd3..12a6efd 100644
--- a/protocol/wayland.xml
+++ b/protocol/wayland.xml
@@ -2038,7 +2038,7 @@
The timestamp
return;
> }
>
> first, the object is already NULL, second, the assignment has no effect
> since we return from the function right away
>
> Signed-off-by: Marek Chalupa
Either way, it's
Reviewed-by: Eric Engestrom
_
Signed-off-by: Eric Engestrom
---
src/wayland-server.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/wayland-server.c b/src/wayland-server.c
index ae9365f..f745e62 100644
--- a/src/wayland-server.c
+++ b/src/wayland-server.c
@@ -1308,7 +1308,7
Signed-off-by: Eric Engestrom
---
tests/test-runner.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/test-runner.c b/tests/test-runner.c
index 742b4f0..4aa6667 100644
--- a/tests/test-runner.c
+++ b/tests/test-runner.c
@@ -205,7 +205,7 @@ run_test(const struct test *t
Signed-off-by: Eric Engestrom
---
src/wayland-client.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/wayland-client.c b/src/wayland-client.c
index 7af806c..03c087a 100644
--- a/src/wayland-client.c
+++ b/src/wayland-client.c
@@ -581,7 +581,7
Signed-off-by: Eric Engestrom
---
src/wayland-util.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/wayland-util.h b/src/wayland-util.h
index cc1999d..8da156c 100644
--- a/src/wayland-util.h
+++ b/src/wayland-util.h
@@ -300,7 +300,7 @@ union wl_argument {
* A
Signed-off-by: Eric Engestrom
---
doc/Contributing | 10 +-
doc/publican/sources/Protocol.xml | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/Contributing b/doc/Contributing
index 65565dc..c790a07 100644
--- a/doc/Contributing
+++ b/doc
On Thu, Jun 30, 2016 at 12:22:10PM +1000, Peter Hutterer wrote:
> Increase the mm move threshold for 3 and 4 finger gestures to 2 and 3 mm,
> respectively. In multi-finger gestures it's common to have minor movement
> while all fingers are being put down or before the conscious movement starts.
> T
On Thu, Jun 30, 2016 at 02:10:24PM +0100, Eric Engestrom wrote:
> The threshold now becomes 0 for 1 finger, which I assume was not the
Sorry for the noise, I just realized this code only applies to >2
fingers, so you can just ignore my previous m
callback will be called to start
>* the Xwayland process.
>*
"an X socket", maybe?
Either way, your changes are good:
Reviewed-by: Eric Engestrom
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel
On Wed, Jul 06, 2016 at 03:30:54PM -0700, Bryce Harrington wrote:
> Signed-off-by: Bryce Harrington
Reviewed-by: Eric Engestrom
> ---
> libweston/linux-dmabuf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libweston/linux-dmabuf.c b/libwes
On Wed, Jul 06, 2016 at 03:18:46PM -0700, Bryce Harrington wrote:
> Signed-off-by: Bryce Harrington
Reviewed-by: Eric Engestrom
> ---
> compositor/xwayland.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/compositor/xwayland.c b/compositor/xwayland
On Wed, Jul 06, 2016 at 03:14:20PM -0700, Bryce Harrington wrote:
> Signed-off-by: Bryce Harrington
Indeed, this is needed for XSERVER_PATH
Reviewed-by: Eric Engestrom
> ---
> compositor/xwayland.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/compositor/xwayl
On Thu, Jul 07, 2016 at 10:56:12AM -0700, Bryce Harrington wrote:
> Signed-off-by: Bryce Harrington
This is the last of it, right? ^^
Reviewed-by: Eric Engestrom
> ---
> unstable/input-method/input-method-unstable-v1.xml | 2 +-
> unstable/text-input/text-input-unstable-v1.xml
lue = strtol(entry->value, &end, 0);
> - if (*end != '\0') {
> + if (errno != 0 || end == entry->value || *end != '\0') {
Isn't the empty string case already covered by `*end != '\0'` ?
Either way, the duplicate test wouldn't hurt, s
On Fri, Jul 08, 2016 at 10:26:43AM +0100, Eric Engestrom wrote:
> On Thu, Jul 07, 2016 at 02:08:28PM -0700, Bryce Harrington wrote:
> > + errno = 0;
> > *value = strtol(entry->value, &end, 0);
> > - if (*end != '\0') {
> > + if (errn
gt; than either of these limits, so the change is believed to have no impact
> in practice.
>
> Also add a test case for negative numbers that catches this error
> condition.
>
> Signed-off-by: Bryce Harrington
Looks good to me.
Reviewed-by: Eric Engestrom
_
On Mon, Jul 11, 2016 at 05:02:44PM -0700, Bryce Harrington wrote:
> Improve error checking for situations like RDP_FD=42foo, or where the
> provided number is out of range.
>
> Suggestion by Yong Bakos.
>
> Signed-off-by: Bryce Harrington
Reviewed-by: Eric Engestrom
goto invalid;
}
/* ... */
invalid:
*color = default_color;
errno = EINVAL;
return -1;
Additionally, I agree with Quentin, since you made a special function
for colors, we might as well have it support more color formats,
On Thu, Jul 14, 2016 at 11:30:39AM -0700, Bryce Harrington wrote:
> On Thu, Jul 14, 2016 at 01:35:09PM +0100, Eric Engestrom wrote:
> > On Wed, Jul 13, 2016 at 07:01:28PM -0700, Bryce Harrington wrote:
> > > Previously weston_config_section_get_uint was serving dual purpose for
On Fri, Jul 15, 2016 at 10:13:03AM +0100, Eric Engestrom wrote:
> On Thu, Jul 14, 2016 at 11:30:39AM -0700, Bryce Harrington wrote:
> > On Thu, Jul 14, 2016 at 01:35:09PM +0100, Eric Engestrom wrote:
> > > On Wed, Jul 13, 2016 at 07:01:28PM -0700, Bryce Harrington wrote:
On Sat, Jul 16, 2016 at 11:32:49PM +0300, Jussi Kukkonen wrote:
> This fixes build on musl.
>
> Signed-off-by: Jussi Kukkonen
Reviewed-by: Eric Engestrom
> ---
> shared/xalloc.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/shared/xalloc.h b/shared/
On Mon, Jul 18, 2016 at 09:53:20AM +0100, Eric Engestrom wrote:
> On Sat, Jul 16, 2016 at 11:32:49PM +0300, Jussi Kukkonen wrote:
> > This fixes build on musl.
> >
> > Signed-off-by: Jussi Kukkonen
>
> Reviewed-by: Eric Engestrom
Actually, a quick grep tells me 9
Bakos
Matches my grep.
Reviewed-by: Eric Engestrom
> ---
> cursor/cursor-data.h | 2 ++
> cursor/wayland-cursor.c | 1 +
> src/event-loop.c | 1 +
> src/scanner.c | 1 +
> src/wayland-client-core.h | 1 +
> src/wayland-private.h | 1 +
>
t_dwt_triggered(tp, t, time))
> goto out;
>
> - if (tp_palm_detect_trackpoint(tp, t, time))
> + if (tp_palm_detect_trackpoint_triggered(tp, t, time))
> goto out;
>
> if (t->palm.state == PALM_EDGE) {
> --
> 2.7.4
I fe
result is stored in *value; otherwise *value is
> > + * unchanged and errno is set appropriately.
> > + *
> > + * \return true if number parsed successfully, false on error
>
> "if the number". IMO you should squash the safe_strtoint() tests into this
> patc
list_length)
> +{
> + struct wl_list list;
> + struct element e;
> +
> + wl_list_init(&list);
> + assert(wl_list_length(&list) == 0);
> + wl_list_insert(&list, &e.link);
> + assert(wl_list_length(&list) == 1);
What about a second insert
On Thu, Sep 01, 2016 at 09:53:36AM +1000, Peter Hutterer wrote:
> Signed-off-by: Peter Hutterer
> ---
> Mostly sending this out for any hints on how to deal with this in Arch or
> other distributions not listed here. Let me know and I'll add it to the
> list.
The Arch way would be to install the
On Thu, Sep 01, 2016 at 11:18:12AM +0100, Eric Engestrom wrote:
> On Thu, Sep 01, 2016 at 09:53:36AM +1000, Peter Hutterer wrote:
> > Signed-off-by: Peter Hutterer
> > ---
> > Mostly sending this out for any hints on how to deal with this in Arch or
> > other distributi
132,7 +135,14 @@ print_event_header(struct libinput_event *ev)
> break;
> }
>
> - printf("%-7s%-16s ", libinput_device_get_sysname(dev), type);
> + prefix = (last_device != dev) ? '-' : ' ';
Nit: that line would be even shorter withi
This makes it clear that it's not meant to be dereferenced.
CC: Peter Hutterer
Signed-off-by: Eric Engestrom
---
tools/event-debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/event-debug.c b/tools/event-debug.c
index 0e95611..5cd5915 100644
--- a/tools/
On Sat, Sep 10, 2016 at 10:55:21PM +0200, Armin Krezović wrote:
> clang doesn't support gnu_print attribute, so just
> leave it out when clang is used.
>
> Signed-off-by: Armin Krezović
> ---
> clients/stacking.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/clients/stacking.c b/
On Thu, Sep 15, 2016 at 07:55:54AM +1000, Peter Hutterer wrote:
> On Wed, Sep 14, 2016 at 05:48:26PM +0100, Eric Engestrom wrote:
> > On Thu, Sep 08, 2016 at 03:55:47PM +1000, Peter Hutterer wrote:
> > > diff --git a/tools/event-debug.c b/tools/event-debug.c
> > > in
y)
> {
> free(array->data);
> + array->data = NULL;
If we add
array->size = 0;
array->alloc = 0;
we can then remove this comment from patch #1, right?
\note Leaves the array in an invalid state.
The series is good anyway, so it is:
Rev
On Mon, Sep 19, 2016 at 11:59:03AM +0100, Eric Engestrom wrote:
> On Fri, Sep 16, 2016 at 03:37:37PM -0700, Yong Bakos wrote:
> > From: Yong Bakos
> >
> > Explicitly set the data member to NULL during wl_array_release, preventing
> > the
> > dangling pointer
On Tue, Sep 27, 2016 at 12:35:55PM +0200, Armin Krezović wrote:
> This patch fixes a compiler warning when building with
> clang, since it doesn't support gnu_printf attribute.
>
> v2:
>
> - Switch to WL_PRINTF per suggestion from Eric Engestrom.
>
> Signed-off-by:
On Tue, Sep 27, 2016 at 01:03:48PM -0500, Yong Bakos wrote:
> From: Yong Bakos
>
> Explicitly set the data member to an invalid memory address during
> wl_array_release, such that re-using a freed wl_array without re-initializing
> causes a crash. In addition, this pointer assignment makes wl_arr
Reviewed-by: Eric Engestrom
(BTW patchwork doesn't understand "the series is", does it? Or does it
have to be a specific keyword?)
Cheers,
Eric
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.or
sh` stops on:
[...]
checking for library containing pam_open_session... no
configure: error: weston-launch requires pam
The code looks good though (with one nit-pick), so even if I couldn't
test it, it is:
Reviewed-by: Eric Engestrom
> ---
> libweston/weston-launch.c | 20 +++
On Fri, Sep 30, 2016 at 11:36:24AM +0100, Murray Calavera wrote:
> On 30 September 2016 at 11:10, Eric Engestrom
> wrote:
>
> > On Thu, Sep 29, 2016 at 09:26:16PM +0100, Murray Calavera wrote:
> > > error.h is a gnu extension and not available in other
> > > po
On Fri, Sep 30, 2016 at 02:07:38PM +0200, Armin Krezović wrote:
> On 30.09.2016 13:59, Eric Engestrom wrote:
> > On Fri, Sep 30, 2016 at 11:36:24AM +0100, Murray Calavera wrote:
> >> On 30 September 2016 at 11:10, Eric Engestrom
> >> wrote:
> >>
> >&
> Signed-off-by: Tomohito Esaki
Reviewed-by: Eric Engestrom
> ---
> libweston/compositor-drm.c | 31 ---
> 1 file changed, 16 insertions(+), 15 deletions(-)
>
> diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c
> index 8319d7c.
On Fri, Sep 30, 2016 at 06:28:52PM +0900, Tomohito Esaki wrote:
> This implementations bypasses gbm and passes the dmabuf handles directly
> to libdrm for composition.
>
> Signed-off-by: Tomohito Esaki
> ---
> libweston/compositor-drm.c | 125
> ++---
> 1
the zwp_input_method protocol,
> and with no mechanism to load system or user-specified compose keys.
>
> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=53648
> Signed-off-by: Bryce Harrington
> Reviewed-by: Daniel Stone
>
> Signed-off-by: Bryce Harrington
Reviewed-
Test for all the possible lengths (up to 8), specifying which are
expected to be valid and how they should be interpreted.
Sprinkle some `#` and `0x` around randomly to make sure those work at
any length too.
Signed-off-by: Eric Engestrom
---
tests/config-parser-test.c | 160
Valid colours start with an optional '0x' or '#', followed by:
- AARRGGBB
- RRGGBB
- A R G B
-R G B
- XYXYXY
- XXXXXX
Signed-off-by: Eric Engestrom
---
I just stumbled back on this discussion from a few months ago, and
decided to give it a go.
Once again, I apo
r.y1 / gs->hsub[j],
> + (r.x2 - r.x1) / gs->vsub[j],
> + (r.y2 - r.y1) / gs->vsub[j],
I think you got your horizontal and vertical subsampling crossed here.
Unless I'm
On Friday, 2016-10-21 12:30:07 +0200, Quentin Glidic wrote:
> Hi,
>
> On 20/10/2016 00:08, Eric Engestrom wrote:
> > Valid colours start with an optional '0x' or '#', followed by:
> > - AARRGGBB
> > - RRGGBB
> > - A R G B
> > -R
Supported colour formats are:
- (0x)(AA)RRGGBB
- #RGB(A)
- #RRGGBB(AA)
Cc: Bryce Harrington
Cc: Quentin Glidic
Signed-off-by: Eric Engestrom
---
v2: reduce the number of formats supported
read #-prefixed values the same way CSS would
---
shared/config-parser.c | 54
Add tests for all the supported colour formats
Cc: Bryce Harrington
Cc: Quentin Glidic
Signed-off-by: Eric Engestrom
---
v2: reduce the number of formats supported
read #-prefixed values the same way CSS would
---
tests/config-parser-test.c | 96
har *format, va_list args)
+/* You can also add the attribute here if you prefer */
{
(Obviously, the same suggestion applies to all the functions in this patch.)
Patches 2 & 3 look good to me:
Reviewed-by: Eric Engestrom
> const char *prefix;
>
> diff --git a/test/lite
to get the entrypoint when you found an
extension, how about `swap_buffers_with_damage_ext_to_entrypoint`?
Rather long I'll concede, but explicit.
You can also drop the middle bit: `swap_damage_ext_to_entrypoint`
With an appropriate name here (and the other patch), the series is:
Reviewed-by: Eric
1 - 100 of 105 matches
Mail list logo
