[PATCH wayland-protocols] text-input: Add v3 of the text-input protocol

2018-03-11 Thread Carlos Garnacho
both directions. - There is no event to send keysyms. The handling ought to be by all means identical to wl_keyboard's, compositors might just use that interface. Signed-off-by: Carlos Garnacho --- Hey, Belatedly, here's my proposed v3 of the text-input protocol, a rename of what is i

Re: [PATCHv2] text-input: Add v3 of the text-input protocol

2018-04-11 Thread Carlos Garnacho
st for clients. > - There is no event to send keysyms. Compositors can use wl_keyboard > interface instead. > > Reviewed-by: Drew DeVault > --- > > Hi, > > This patch follows the original proposal by Carlos Garnacho. It's the > result of my work on behalf

Re: [wayland-protocols] text-input: Add v3 of the text-input protocol

2018-04-11 Thread Carlos Garnacho
:20:53 PDT Dorota Czaplejewicz wrote: >> > > On Sun, 11 Mar 2018 20:30:14 +0100 >> > > >> > > Carlos Garnacho wrote: >> > > > This new protocol description is a vast simplification over v2, >> > > > highlights >> > > > a

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-07-17 Thread Carlos Garnacho
tors can use wl_keyboard >> > interface instead. >> > - All state is double-buffered, with specified state. >> > - Use Unicode codepoints to measure strings. >> > >> > Signed-off-by: Dorota Czaplejewicz >> > Signed-off-by: Carlos Garnacho

Re: [PATCH v10 wayland_protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Carlos Garnacho
Hey, With the serial number behavior cleared out, this all reads great to me. Can't be part and judge though :), so no R-b label. Cheers, Carlos On Mon, Jul 30, 2018 at 4:14 PM, Dorota Czaplejewicz wrote: > From: Carlos Garnacho > > This new protocol description is an e

Re: [PATCH wayland-protocols] unstable: add xdg-primary-selection protocol

2018-08-16 Thread Carlos Garnacho
Hi!, Thanks Simon for moving this forward. FTR this looks good to me. Had some chat with Jonas on IRC about the suitability of xdg vs wp prefixes, but I personally think your choice is fine. Either way, this is Acked-by: Carlos Garnacho On Sun, Jul 8, 2018 at 9:14 PM, Simon Ser wrote: > T

Re: [PATCH wayland-protocols] unstable: add xdg-primary-selection protocol

2018-08-16 Thread Carlos Garnacho
On Thu, Aug 16, 2018 at 4:46 PM, Jonas Ådahl wrote: > On Thu, Aug 16, 2018 at 04:25:06PM +0200, Carlos Garnacho wrote: >> Hi!, >> >> Thanks Simon for moving this forward. FTR this looks good to me. Had >> some chat with Jonas on IRC about the suitability of xdg vs wp &g

Re: [PATCH wayland-protocols v2] unstable: add primary-selection protocol

2018-10-10 Thread Carlos Garnacho
ata_offer, if any, upon receiving this event. > + > + interface="zwp_primary_selection_offer_v1" allow-null="true"/> > + > + > + > + > +Destroy the primary selection device. > + > + > + > + > + > + > + A wp_primary_selection_offer represents an offer to transfer the > contents > + of the primary selection clipboard to the client. Similar to > + wl_data_offer, the offer also describes the mime types that the > source > + will transferthat the > This is in the original protocol, so definitely more my fault than yours, but would be nice not to drag this further :). I guess the original intention was: "...describes the mime types that the data can be converted to..." Besides that, the patch is Reviewed-by: Carlos Garnacho Cheers, Carlos ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: RFC libinput high-resolution wheel scrolling

2019-01-25 Thread Carlos Garnacho
Hi!, I surely missed the gitlab ping, hope this makes up for it :). On Fri, Jan 25, 2019 at 6:28 AM Peter Hutterer wrote: > > I'm sending this here to get some more exposure. The kernel will get > high-resolution scroll wheels with the 5.0 release. The details are in the > blog post linked below

[RFC PATCH wayland-protocols] presentation: New protocol for presenting surfaces to the user

2019-10-16 Thread Carlos Garnacho
immediately switching focus to a surface makes sense. - Window raising/activation: allowing existing clients to request focus in a controlled manner. Signed-off-by: Carlos Garnacho --- Makefile.am | 1 + unstable/presentation/README | 5

Re: [RFC PATCH wayland-protocols] presentation: New protocol for presenting surfaces to the user

2019-10-17 Thread Carlos Garnacho
Hey :), On Wed, Oct 16, 2019 at 10:54 AM Olivier Fourdan wrote: > The name itself, “presentation” might be confusing considering we > already have a “presentation-time” protocol. > Right... I'm open to naming suggestions. Struggled a bit there, other single word that I could come up with are "a

Re: [RFC PATCH wayland-protocols] presentation: New protocol for presenting surfaces to the user

2019-10-17 Thread Carlos Garnacho
Hi Dorota! On Wed, Oct 16, 2019 at 11:16 AM Dorota Czaplejewicz < dorota.czaplejew...@puri.sm> wrote: > On Wed, 16 Oct 2019 10:43:00 +0200 > Carlos Garnacho wrote: > > > This protocol takes over 3 different, but interrelated aspects of > > DE/client interaction:

Re: [RFC PATCH wayland-protocols] presentation: New protocol for presenting surfaces to the user

2019-10-17 Thread Carlos Garnacho
Hi Pekka, Thank you for your comments! On Wed, Oct 16, 2019 at 11:31 AM Pekka Paalanen wrote: > On Wed, 16 Oct 2019 10:54:08 +0200 > Olivier Fourdan wrote: > > > Hey Carlos, > > > > On Wed, Oct 16, 2019 at 10:43 AM Carlos Garnacho > wrote: > > > >

Re: Keyboard issues w/Orca screen reader

2021-02-24 Thread Carlos Garnacho
Hi Mike!, On Wed, Feb 24, 2021 at 11:03 PM Mike Gorse wrote: > > As part of the GNOME project, we have Orca. It is a screen reader that reads > what an application is displaying out loud, or sends it to a Braille display. > It allows a blind user to interact with GNOME. There are currently severa

Re: accessibility: implementation of zoom/invert on Wayland?

2021-07-01 Thread Carlos Garnacho
Hi Patrick, On Thu, Jul 1, 2021 at 11:11 PM Patrick Pelletier wrote: > > Hi, > > I'm new to Wayland and only have a fairly basic understanding of how the > different parts fit together. I'm trying to find out more about how the > following two accessibility features (for visually impaired users)

[PATCH weston v5 1/4] compositor: Implement zwp_pointer_gesture_[pinch|swipe]_v1 interfaces

2017-01-27 Thread Carlos Garnacho
pdate to use standalone XML. Signed-off-by: Carlos Garnacho --- Makefile.am | 4 +- libweston/compositor.c | 2 + libweston/compositor.h | 12 +++ libweston/input.c | 216 +++- libweston/libinput-device

[PATCH weston v5 2/4] clients: Request the wl_pointer_gesture_swipe/pinch interfaces

2017-01-27 Thread Carlos Garnacho
. Signed-off-by: Carlos Garnacho Reviewed-by: Jonas Ådahl Reviewed-by: Bryce Harrington --- Makefile.am | 6 +- clients/window.c | 230 ++- clients/window.h | 54 + 3 files changed, 288 insertions(+), 2 deletions(-) diff

[PATCH weston v5 4/4] clients: Add pointer pinch gesture support to weston-image

2017-01-27 Thread Carlos Garnacho
It will allow zooming in/out the loaded image. Signed-off-by: Carlos Garnacho Reviewed-by: Jonas Ådahl --- clients/image.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/clients/image.c b/clients/image.c index db9ccd6..5057d0a 100644 --- a/clients

[PATCH weston v5 3/4] clients: Add pointer gesture support to weston-eventdemo

2017-01-27 Thread Carlos Garnacho
Just print the output, as with the other events. Signed-off-by: Carlos Garnacho Reviewed-by: Jonas Ådahl Reviewed-by: Bryce Harrington --- clients/eventdemo.c | 108 +++- 1 file changed, 107 insertions(+), 1 deletion(-) diff --git a/clients

[PATCH wayland v4] protocol: Define further the behavior of input on the presence of grabs

2017-01-27 Thread Carlos Garnacho
touch interface can cope with such input redirection situations on individual touchpoints. Signed-off-by: Carlos Garnacho Reviewed-by: Peter Hutterer --- Changes since v3: Applied wording improvements from Yong Bakos, added the clarification suggested by Daniel, and made wl_touch.leave part of

[PATCH] tests: Fix "new ID" type handling in argument_from_va_list test

2017-02-23 Thread Carlos Garnacho
New IDs are internally dealt with as objects, however this test expected to deal with 'n' as the uint32_t type that's just seen through the wire. We should give it an object instead, and expect an object from it. https://bugs.freedesktop.org/show_bug.cgi?id=99899 Signed-off-by:

Re: Wrong (non modified) key under Wayland when multiple events combined in single SYN_REPORT

2022-09-13 Thread Carlos Garnacho
Hi!, On Tue, Sep 13, 2022 at 11:36 AM Hans de Goede wrote: > > Hi, > > On 9/12/22 23:20, Peter wrote: > > Hi all, > > > > > > Op maandag 12 september 2022 om 15:14:09 +0200 schreef Juerd Waalboer > > : > >> Hans de Goede skribis 2022-09-12 7:16 (+0200): > >>> During a big hacker event in the Ne

Re: Difficulties with Wayland D&D protocol - D&D source persistence

2022-10-24 Thread Carlos Garnacho
Hi Martin, On Mon, Oct 24, 2022 at 11:43 AM Martin Stransky wrote: > > Hi folks, > > I'd like to point out how Wayland D&D protocol limits real life > applications. > > Main limitation is a requirement that D&D source window has to be kept > opened and D&D is cancelled otherwise. > > That's espe

Re: How does "move cursor one word to the right" work in zwp_text_input_unstable_v3?

2022-12-17 Thread Carlos Garnacho
Hi Filip, On Sat, Dec 17, 2022 at 12:09 PM Filip Filmar wrote: > > Hi folks! > > I am exploring the features of the v3 text input API as seen at > https://wayland.app/protocols/text-input-unstable-v3. > > I am curious, how does this API then implement operations such as "move > cursor one word

Wayland Governance Meeting - Oct 30 / Nov 01

2023-10-19 Thread Carlos Garnacho
Hi, I would like to propose a meeting about the color management protocol [1] after next week (it's late to schedule for next, plus there's people still likely at XDC). After talking with GIMP maintainers, I think this topic might welcome some higher bandwidth place to discuss. The doodle is at [2

Re: Wayland Governance Meeting - Oct 30 / Nov 01

2023-10-24 Thread Carlos Garnacho
Hi Pekka, (this time on list) On Fri, Oct 20, 2023 at 12:44 PM Pekka Paalanen wrote: > > On Thu, 19 Oct 2023 23:58:18 +0200 > Carlos Garnacho wrote: > > > Hi, > > > > I would like to propose a meeting about the color management protocol > > [1] after next

Re: Wayland Governance Meeting - Oct 30 / Nov 01

2023-10-25 Thread Carlos Garnacho
Hi, On Thu, Oct 19, 2023 at 11:58 PM Carlos Garnacho wrote: > > Hi, > > I would like to propose a meeting about the color management protocol > [1] after next week (it's late to schedule for next, plus there's > people still likely at XDC). After talking with GIMP

Re: Wayland Governance Meeting - Oct 30 / Nov 01

2023-11-01 Thread Carlos Garnacho
Hi, On Thu, Oct 19, 2023 at 11:58 PM Carlos Garnacho wrote: > > Hi, > > I would like to propose a meeting about the color management protocol > [1] after next week (it's late to schedule for next, plus there's > people still likely at XDC). After talking with GIMP

Governance Meeting Announcement: Text-Input (Was: Call for proposals for the next governance meeting)

2024-05-07 Thread Carlos Garnacho
Hi!, On Wed, Apr 17, 2024 at 2:37 PM Vlad Zahorodnii wrote: > > Hello, > > The Wayland Governance Meeting is semi-regular meeting to drive > discussion on wayland-protocols forward. > > We are looking for the proposals for the next meeting as well as people > who can lead/drive the discussion. If

Re: Governance Meeting Announcement: Text-Input (Was: Call for proposals for the next governance meeting)

2024-05-11 Thread Carlos Garnacho
On Tue, May 7, 2024 at 1:40 PM Carlos Garnacho wrote: > > Hi!, > > On Wed, Apr 17, 2024 at 2:37 PM Vlad Zahorodnii > wrote: > > > > Hello, > > > > The Wayland Governance Meeting is semi-regular meeting to drive > > discussion on wayland-prot

Re: Governance Meeting Announcement: Text-Input (Was: Call for proposals for the next governance meeting)

2024-05-13 Thread Carlos Garnacho
Hi!, On Sun, May 12, 2024 at 2:18 AM Carlos Garnacho wrote: > > On Tue, May 7, 2024 at 1:40 PM Carlos Garnacho wrote: > > > > Hi!, > > > > On Wed, Apr 17, 2024 at 2:37 PM Vlad Zahorodnii > > wrote: > > > > > > Hello, > > > > &

Governance Meeting Announcement: Text Input (2)

2024-06-25 Thread Carlos Garnacho
Hi all, It was agreed in the last meeting around the text-input protocol to do some follow ups to discuss remaining issues and possible further improvements. I would like to call a second meeting, a poll is now at https://nuudel.digitalcourage.de/kgL4lA5qDUb5ssSa (NB: times in CEST) to decide on a

Re: Governance Meeting Announcement: Text Input (2)

2024-06-28 Thread Carlos Garnacho
Hi Aleix! On Fri, Jun 28, 2024 at 3:33 PM wrote: > > Hi, > Sorry for sending this e-mail this late in the process, it seems like this > mailing list has kicked my personal e-mail account. > > > I'd like to participate in this call as I've been involved in this topic for > Plasma for quite a whi

Re: Governance Meeting Announcement: Text Input (2)

2024-06-30 Thread Carlos Garnacho
Hi all, On Tue, Jun 25, 2024 at 11:56 PM Carlos Garnacho wrote: > > Hi all, > > It was agreed in the last meeting around the text-input protocol to do > some follow ups to discuss remaining issues and possible further > improvements. I would like to call a second meeting

Re: Governance Meeting Announcement: Text Input (2)

2024-07-02 Thread Carlos Garnacho
Hey all, On Sun, Jun 30, 2024 at 7:58 PM Carlos Garnacho wrote: > > Hi all, > > On Tue, Jun 25, 2024 at 11:56 PM Carlos Garnacho wrote: > > > > Hi all, > > > > It was agreed in the last meeting around the text-input protocol to do > > some follow up

[PATCH weston 2/5] data-device: Implement DnD actions

2015-12-21 Thread Carlos Garnacho
e v1: - Updated to v2 of DnD actions protocol changes, implement wl_data_offer.source_actions. - Fixed coding style issues. Signed-off-by: Carlos Garnacho Reviewed-by: Michael Catanzaro --- clients/dnd.c | 32 ++--- clients/window.c | 25 + src/compositor.h

[PATCH weston 5/5] dnd: Turn into a full blown example

2015-12-21 Thread Carlos Garnacho
- Remove unneeded include. Remove extra newlines. Other minor code fixes. Signed-off-by: Carlos Garnacho Reviewed-by: Jonas Ådahl --- clients/dnd.c | 92 --- 1 file changed, 69 insertions(+), 23 deletions(-) diff --git a/clients/dn

[PATCH weston/wayland 0/7] drag-and-drop progress notification and actions

2015-12-21 Thread Carlos Garnacho
Hey, I'm resending again the whole batch again. I applied all suggestions from Jonas, in the end I liked his idea to have data source notification triggered explicitly by a wl_data_offer request, so I added the .finish request to wayland 1/2, and added the implementation on weston 1/5. The rest o

[PATCH wayland 2/2] protocol: Add DnD actions

2015-12-21 Thread Carlos Garnacho
moment. Changes since v1: - Added wl_data_offer.source_actions to let know of the actions offered by a data source. - Renamed wl_data_source.finished to "drag_finished" for clarity - Improved wording as suggested by Bryce Signed-off-by: Carlos Garnacho Reviewed-by: Michael Cat

[PATCH wayland 1/2] protocol: Improve data source notification around DnD progress

2015-12-21 Thread Carlos Garnacho
since v2: - Minor rewording. Changes since v1: - Renamed events to have a common "dnd" namespace. Made dnd_performed to happen invariably, data_device.cancelled may still happen afterwards. Signed-off-by: Carlos Garnacho Reviewed-by: Michael Catanzaro Reviewed-by: Jonas Ådahl

[PATCH weston 1/5] data-device: Implement DnD progress notification

2015-12-21 Thread Carlos Garnacho
es vs tabs fixes. Fixed resource versioning. Changes since v1: - Updated to protocol v2. Signed-off-by: Carlos Garnacho Reviewed-by: Michael Catanzaro --- clients/dnd.c | 39 +++--- clients/window.c | 3 ++- src/compositor.h | 2 ++ src/data-dev

[PATCH weston 3/5] client: Add DnD cursors to the managed cursors list

2015-12-21 Thread Carlos Garnacho
That way we'll be able to set the corresponding pointer surface to a current DnD operation. Signed-off-by: Carlos Garnacho Reviewed-by: Jonas Ådahl --- clients/window.c | 16 clients/window.h | 3 +++ 2 files changed, 19 insertions(+) diff --git a/clients/window.c b/cl

[PATCH weston 4/5] data-device: Implement compositor-chosen actions

2015-12-21 Thread Carlos Garnacho
of weston_drag. The mapping has been made similar to what GTK+/QT usually do, the shift key defaults to "move" and ctrl defaults to "copy". Changes since v1: - Handle the keyboard grab being cancelled. Initialize new wl_data_source fields. Signed-off-by: Carlo

Re: [PATCH wayland 2/2] protocol: Add DnD actions

2015-12-22 Thread Carlos Garnacho
Hey!, On Tue, Dec 22, 2015 at 4:12 AM, Jonas Ådahl wrote: > On Tue, Dec 22, 2015 at 02:33:33AM +0100, Carlos Garnacho wrote: >> These 2 requests have been added: >> >> - wl_data_source.set_actions: Notifies the compositor of the available >>

Re: [PATCH wayland 1/2] protocol: Improve data source notification around DnD progress

2015-12-22 Thread Carlos Garnacho
Hey!, On Tue, Dec 22, 2015 at 3:26 AM, Jonas Ådahl wrote: > On Tue, Dec 22, 2015 at 02:33:32AM +0100, Carlos Garnacho wrote: >> Currently, there's no means for the DnD origin to know whether the >> destination is actually finished with the DnD transaction, short of >&g

Re: [PATCH weston 2/5] data-device: Implement DnD actions

2015-12-22 Thread Carlos Garnacho
Hey!, On Tue, Dec 22, 2015 at 5:25 AM, Jonas Ådahl wrote: > On Tue, Dec 22, 2015 at 02:33:28AM +0100, Carlos Garnacho wrote: >> The policy in weston in order to determine the chosen DnD action is >> deliberately simple, and is probably the minimals that any compositor >>

Re: [PATCH wayland 1/2] protocol: Improve data source notification around DnD progress

2015-12-22 Thread Carlos Garnacho
Hey, On Tue, Dec 22, 2015 at 2:55 PM, Jonas Ådahl wrote: > On Tue, Dec 22, 2015 at 01:33:08PM +0100, Carlos Garnacho wrote: >> Hey!, >> >> On Tue, Dec 22, 2015 at 3:26 AM, Jonas Ådahl wrote: >> > On Tue, Dec 22, 2015 at 02:33:32AM +0100, Carlos Garnacho wrote: >

Re: [PATCH wayland 2/2] protocol: Add DnD actions

2015-12-22 Thread Carlos Garnacho
Hey, On Tue, Dec 22, 2015 at 1:36 PM, Jonas Ådahl wrote: > On Tue, Dec 22, 2015 at 12:20:35PM +0100, Carlos Garnacho wrote: >> Hey!, >> >> On Tue, Dec 22, 2015 at 4:12 AM, Jonas Ådahl wrote: >> > On Tue, Dec 22, 2015 at 02:33:33AM +0100, Carlos Garnacho wrote: &g

Re: [PATCH wayland 1/2] protocol: Improve data source notification around DnD progress

2015-12-23 Thread Carlos Garnacho
Hey, On Wed, Dec 23, 2015 at 3:07 AM, Jonas Ådahl wrote: > On Tue, Dec 22, 2015 at 04:46:37PM +0100, Carlos Garnacho wrote: >> Hey, >> >> On Tue, Dec 22, 2015 at 2:55 PM, Jonas Ådahl wrote: >> > On Tue, Dec 22, 2015 at 01:33:08PM +0100, Carlos Garnacho wrote: >&

Re: [PATCH wayland 1/2] protocol: Improve data source notification around DnD progress

2015-12-23 Thread Carlos Garnacho
change this > patch introduces. > > On Tue, Dec 22, 2015 at 02:33:32AM +0100, Carlos Garnacho wrote: >> Currently, there's no means for the DnD origin to know whether the >> destination is actually finished with the DnD transaction, short of >> finalizing it afte

[PATCH wayland 1/2] protocol: Improve data source notification around DnD progress

2015-12-23 Thread Carlos Garnacho
ariably, data_device.cancelled may still happen afterwards. Signed-off-by: Carlos Garnacho Reviewed-by: Michael Catanzaro Reviewed-by: Jonas Ådahl Reviewed-by: Mike Blumenkrantz --- protocol/wayland.xml | 87 1 file changed, 81 insertions(+)

[PATCH wayland 2/2] protocol: Add DnD actions

2015-12-23 Thread Carlos Garnacho
a data source. - Renamed wl_data_source.finished to "drag_finished" for clarity - Improved wording as suggested by Bryce Signed-off-by: Carlos Garnacho Reviewed-by: Michael Catanzaro Reviewed-by: Mike Blumenkrantz --- protocol/wayland.xml | 164 ++- 1

[PATCH weston 1/5] data-device: Implement DnD progress notification

2015-12-23 Thread Carlos Garnacho
n < 3 drag destinations. Changes since v2: - Handle wl_data_offer.finish. Fixed commit log inconsistencies. Added version checks. Spaces vs tabs fixes. Fixed resource versioning. Changes since v1: - Updated to protocol v2. Signed-off-by: Carlos Garnacho Reviewed-by: Mich

[PATCH weston 3/5] client: Add DnD cursors to the managed cursors list

2015-12-23 Thread Carlos Garnacho
That way we'll be able to set the corresponding pointer surface to a current DnD operation. Signed-off-by: Carlos Garnacho Reviewed-by: Jonas Ådahl --- clients/window.c | 16 clients/window.h | 3 +++ 2 files changed, 19 insertions(+) diff --git a/clients/window.c b/cl

[PATCH weston 2/5] data-device: Implement DnD actions

2015-12-23 Thread Carlos Garnacho
dates the dnd surface like data_source.target events do. Changes since v2: - Split from DnD progress notification changes. Changes since v1: - Updated to v2 of DnD actions protocol changes, implement wl_data_offer.source_actions. - Fixed coding style issues. Signed-off-by: Carlos

[PATCH weston 5/5] dnd: Turn into a full blown example

2015-12-23 Thread Carlos Garnacho
- Remove unneeded include. Remove extra newlines. Other minor code fixes. Signed-off-by: Carlos Garnacho Reviewed-by: Jonas Ådahl --- clients/dnd.c | 92 --- 1 file changed, 69 insertions(+), 23 deletions(-) diff --git a/clients/dn

[PATCH weston 4/5] data-device: Implement compositor-chosen actions

2015-12-23 Thread Carlos Garnacho
le the keyboard grab being cancelled. Initialize new wl_data_source fields. Signed-off-by: Carlos Garnacho Reviewed-by: Jonas Ådahl --- src/compositor.h | 1 + src/data-device.c | 75 +++ 2 files changed, 76 insertions(+) diff --git a/sr

[PATCH wayland v8 1/2] protocol: Improve data source notification around DnD progress

2015-12-23 Thread Carlos Garnacho
ata_offer.accept and wl_data_source.cancelled. Changes since v2: - Minor rewording. Changes since v1: - Renamed events to have a common "dnd" namespace. Made dnd_performed to happen invariably, data_device.cancelled may still happen afterwards. Signed-off-by: Carlos Garnacho

[PATCH wayland v8 2/2] protocol: Add DnD actions

2015-12-23 Thread Carlos Garnacho
Changes since v1: - Added wl_data_offer.source_actions to let know of the actions offered by a data source. - Renamed wl_data_source.finished to "drag_finished" for clarity - Improved wording as suggested by Bryce Signed-off-by: Carlos Garnacho Reviewed-by: Michael Catanzaro Reviewed-by: Mike Blumenkran

[PATCH weston v5 1/5] data-device: Implement DnD progress notification

2015-12-23 Thread Carlos Garnacho
d to protocol v2. Signed-off-by: Carlos Garnacho Reviewed-by: Michael Catanzaro --- clients/dnd.c | 39 - clients/window.c | 3 +- src/compositor.h | 3 ++ src/data-device.c | 102 +- 4 files changed, 129 inse

[PATCH weston v7 2/5] data-device: Implement DnD actions

2015-12-23 Thread Carlos Garnacho
f DnD actions protocol changes, implement wl_data_offer.source_actions. - Fixed coding style issues. Signed-off-by: Carlos Garnacho Reviewed-by: Michael Catanzaro --- clients/dnd.c | 32 ++--- clients/window.c | 25 +++ src/compositor.h |

Re: [PATCH wayland 1/2] protocol: Improve data source notification around DnD progress

2016-01-11 Thread Carlos Garnacho
Hi Pekka!, On Tue, Jan 5, 2016 at 9:50 AM, Pekka Paalanen wrote: > On Wed, 23 Dec 2015 12:31:16 +0100 > Carlos Garnacho wrote: > >> Hey, >> >> On Wed, Dec 23, 2015 at 5:47 AM, Jonas Ådahl wrote: >> > Hi again, >> > >> > I was reading

[PATCH wayland v9 2/2] protocol: Add DnD actions

2016-01-13 Thread Carlos Garnacho
ished" for clarity - Improved wording as suggested by Bryce Signed-off-by: Carlos Garnacho Reviewed-by: Michael Catanzaro Reviewed-by: Mike Blumenkrantz Reviewed-by: Jonas Ådahl --- protocol/wayland.xml | 194 ++- 1 file changed, 193 insert

Re: [PATCH wayland v8 2/2] protocol: Add DnD actions

2016-01-13 Thread Carlos Garnacho
Hey Jonas, On Mon, Jan 11, 2016 at 9:12 AM, Jonas Ådahl wrote: > On Thu, Dec 24, 2015 at 03:21:11AM +0100, Carlos Garnacho wrote: >> These 2 requests have been added: >> >> - wl_data_source.set_actions: Notifies the compositor of the available >>

Re: [PATCH wayland 2/2] protocol: Add DnD actions

2016-01-13 Thread Carlos Garnacho
Hi Michal, On Mon, Jan 11, 2016 at 11:34 AM, Michal Suchanek wrote: > On 24 December 2015 at 01:58, Carlos Garnacho wrote: > >> @@ -757,6 +883,40 @@ >> >> >> >> + >> + >> + >> + >> + >>

[PATCH wayland v10 2/2] protocol: Add DnD actions

2016-01-13 Thread Carlos Garnacho
e moment. Changes since v1: - Added wl_data_offer.source_actions to let know of the actions offered by a data source. - Renamed wl_data_source.finished to "drag_finished" for clarity - Improved wording as suggested by Bryce Signed-off-by: Carlos Garnacho Reviewed-by: Michael Catanzaro Revie

[PATCH weston v6 1/5] data-device: Implement DnD progress notification

2016-01-14 Thread Carlos Garnacho
es. Added version checks. Spaces vs tabs fixes. Fixed resource versioning. Changes since v1: - Updated to protocol v2. Signed-off-by: Carlos Garnacho Reviewed-by: Michael Catanzaro --- clients/dnd.c | 39 +++- clients/window.c | 3 +- src/compositor.h | 3 ++ src/

[PATCH weston v7 2/5] data-device: Implement DnD actions

2016-01-14 Thread Carlos Garnacho
urce_actions. - Fixed coding style issues. Signed-off-by: Carlos Garnacho Reviewed-by: Michael Catanzaro --- clients/dnd.c | 32 +-- clients/window.c | 25 src/compositor.h | 5 ++ src/data-device.c | 169 -- 4

Re: [PATCH weston v7 2/5] data-device: Implement DnD actions

2016-01-15 Thread Carlos Garnacho
Hey Jonas, On Fri, Jan 15, 2016 at 7:10 AM, Jonas Ådahl wrote: > On Thu, Jan 14, 2016 at 11:46:34PM +0100, Carlos Garnacho wrote: >> The policy in weston in order to determine the chosen DnD action is >> deliberately simple, and is probably the minimals that any compositor >

Re: [PATCH weston v6 1/5] data-device: Implement DnD progress notification

2016-01-15 Thread Carlos Garnacho
Hey Jonas, On Fri, Jan 15, 2016 at 6:32 AM, Jonas Ådahl wrote: > On Thu, Jan 14, 2016 at 11:43:39PM +0100, Carlos Garnacho wrote: >> Weston now sends wl_data_source.dnd_drop_performed and .dnd_finished in >> order to notify about the different phases of DnD. >> >>

[PATCH wayland 1/2] protocol: Improve data source notification around DnD progress

2016-01-15 Thread Carlos Garnacho
ata_offer.accept and wl_data_source.cancelled. Changes since v2: - Minor rewording. Changes since v1: - Renamed events to have a common "dnd" namespace. Made dnd_performed to happen invariably, data_device.cancelled may still happen afterwards. Signed-off-by: Carlos Garnacho

[PATCH wayland 2/2] protocol: Add DnD actions

2016-01-15 Thread Carlos Garnacho
rity - Improved wording as suggested by Bryce Signed-off-by: Carlos Garnacho Reviewed-by: Michael Catanzaro Reviewed-by: Mike Blumenkrantz Reviewed-by: Jonas Ådahl --- protocol/wayland.xml | 205 ++- 1 file changed, 204 insertions(+), 1 del

[PATCH weston 3/5] client: Add DnD cursors to the managed cursors list

2016-01-15 Thread Carlos Garnacho
That way we'll be able to set the corresponding pointer surface to a current DnD operation. Signed-off-by: Carlos Garnacho Reviewed-by: Jonas Ådahl --- clients/window.c | 16 clients/window.h | 3 +++ 2 files changed, 19 insertions(+) diff --git a/clients/window.c b/cl

[PATCH weston 1/5] data-device: Implement DnD progress notification

2016-01-15 Thread Carlos Garnacho
nges since v2: - Handle wl_data_offer.finish. Fixed commit log inconsistencies. Added version checks. Spaces vs tabs fixes. Fixed resource versioning. Changes since v1: - Updated to protocol v2. Signed-off-by: Carlos Garnacho Reviewed-by: Michael Catanzaro Reviewed-by: Jonas Ådahl ---

[PATCH weston 4/5] data-device: Implement compositor-chosen actions

2016-01-15 Thread Carlos Garnacho
le the keyboard grab being cancelled. Initialize new wl_data_source fields. Signed-off-by: Carlos Garnacho Reviewed-by: Jonas Ådahl --- src/compositor.h | 1 + src/data-device.c | 76 +++ 2 files changed, 77 insertions(+) diff --git a/sr

[PATCH weston 2/5] data-device: Implement DnD actions

2016-01-15 Thread Carlos Garnacho
2: - Split from DnD progress notification changes. Changes since v1: - Updated to v2 of DnD actions protocol changes, implement wl_data_offer.source_actions. - Fixed coding style issues. Signed-off-by: Carlos Garnacho Reviewed-by: Michael Catanzaro --- clients/dnd.c | 36 +++

[PATCH weston 5/5] dnd: Turn into a full blown example

2016-01-15 Thread Carlos Garnacho
v2: - Updated to behave alright-ish with version < 3. Changes since v1: - Remove unneeded include. Remove extra newlines. Other minor code fixes. Signed-off-by: Carlos Garnacho Reviewed-by: Jonas Ådahl --- clients/dnd.c | 106 ++ 1

Re: [PATCH weston 3/5] client: Add DnD cursors to the managed cursors list

2016-01-15 Thread Carlos Garnacho
Hey Bryce :), On Sat, Jan 16, 2016 at 12:13 AM, Bryce Harrington wrote: > On Fri, Jan 15, 2016 at 09:14:25PM +0100, Carlos Garnacho wrote: >> That way we'll be able to set the corresponding pointer surface to >> a current DnD operation. >> >> Signed-off-by: Carlos

Re: [PATCH wayland 2/2] protocol: Add DnD actions

2016-01-16 Thread Carlos Garnacho
Hi Jonas! On Sat, Jan 16, 2016 at 9:37 AM, Jonas Ådahl wrote: > On Fri, Jan 15, 2016 at 02:49:33PM -0800, Bryce Harrington wrote: >> On Fri, Jan 15, 2016 at 09:11:40PM +0100, Carlos Garnacho wrote: >> > These 2 requests have been added: >> > >> > - wl_d

Re: [PATCH wayland] protocol: Add note about per version requirements to wl_data_device_manager

2016-01-18 Thread Carlos Garnacho
ted we should add a note about the per version requirements > (wl_data_source.set_actions, wl_data_offer.accept and wl_data_offer.finish > during DND), see here is such a paragraph. Oh indeed. Makes sense to mention this in wl_data_device_manager docs, Reviewed-by: Carl

[PATCH weston v9] data-device: Implement DnD actions

2016-01-18 Thread Carlos Garnacho
- Fixed coding style issues. Signed-off-by: Carlos Garnacho Reviewed-by: Michael Catanzaro Reviewed-by: Jonas Ådahl --- clients/dnd.c | 36 +-- clients/window.c | 34 ++ clients/window.h | 3 + src/compositor.h |

[PATCH weston 1/3] clipboard: zalloc the clipboard_source

2016-02-01 Thread Carlos Garnacho
The wrapped weston_data_source struct has new fields which were left uninitialized, so its access is unreliable. Signed-off-by: Carlos Garnacho --- src/clipboard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/clipboard.c b/src/clipboard.c index da7dbb6..54a578f 100644

[PATCH weston 2/3] xwayland: zalloc the x11_data_sources

2016-02-01 Thread Carlos Garnacho
this patch. Signed-off-by: Carlos Garnacho --- xwayland/dnd.c | 2 +- xwayland/selection.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xwayland/dnd.c b/xwayland/dnd.c index a036b30..f17e4cd 100644 --- a/xwayland/dnd.c +++ b/xwayland/dnd.c @@ -162,7 +162,7

[PATCH weston 3/3] data-device: Check harder for selection/non-wayland sources

2016-02-01 Thread Carlos Garnacho
We're not always dealing with weston_data_sources that have a wl_resource, or data_sources that belong to drag-and-drop. Check harder for these on the drag-and-drop code paths triggered from common code. Signed-off-by: Carlos Garnacho --- src/data-device.c | 8 ++-- 1 file chang

Re: [RFC wayland-protocols V3] Add Primary Selection Protocol Version 1

2016-02-04 Thread Carlos Garnacho
Hi!, Chiming in late... On Thu, Jan 7, 2016 at 3:50 AM, Lyude wrote: > Signed-off-by: Lyude > --- > > Notes: > Changes since V2 > * Bunch of grammatical/wording fixes from whot > * Addition of wp_primary_selection_offer::end_offers, for marking the end >

Re: [PATCH weston] xwm: Don't clear the selection if it has no text type available

2016-02-04 Thread Carlos Garnacho
es the first offer. > > That seems better than a livelock though. Maybe we can grab all available > offers when cloning the selection instead of just the first (but that should > be done in addition to this patch, I think, because we could have an app that > doesn't offer text at a

Re: [PATCH libinput] test: add tablet test for out-of-bounds motion coordinates

2016-02-11 Thread Carlos Garnacho
Hey :), On Thu, Feb 11, 2016 at 8:31 AM, Peter Hutterer wrote: > The newer Cintiqs have a minimum value of 400/400 advertised by the kernel but > the actual sensor goes past the 0/0 origin. Test this, make sure that a value > outside the boundaries generates negative mm values. > > Signed-off-by:

[PATCH wayland-protocols] xdg-shell: Add startup notification

2016-02-11 Thread Carlos Garnacho
ceive startup IDs that are guaranteed to be unique, whereas in X11 this is a best effort of the launcher client. Some notes have also been added about focus stealing prevention, although that's mostly up for compositors to implement. Signed-off-by: Carlos Garnacho --- I've got no full

Re: [PATCH weston v2 1/5] protocol: Add _wl_pointer_gestures (swipe/pinch) protocol

2016-02-18 Thread Carlos Garnacho
Hey Daniel :), I see Jonas replied, I'll try to give some more detail. On Thu, Feb 18, 2016 at 11:03 AM, Daniel Stone wrote: > Hi, > > On 31 July 2015 at 14:53, Carlos Garnacho wrote: >> On Wed, Jul 29, 2015 at 4:52 AM, Jonas Ådahl wrote: >>> On Thu, Jul 23, 201

[RFC wayland-protocols v4] Add Primary Selection Protocol Version 1

2016-02-19 Thread Carlos Garnacho
Signed-off-by: Carlos Garnacho --- After having talked with Lyude, I'll be trying to move this ahead. Changes since v3: - Added a rather verbose protocol description, including a high-level overview of the workings. - Made event emission 1:1 with wayland core

Re: [RFC wayland-protocols v4] Add Primary Selection Protocol Version 1

2016-02-22 Thread Carlos Garnacho
Hey Jonas, On Mon, Feb 22, 2016 at 8:53 AM, Jonas Ådahl wrote: > On Sat, Feb 20, 2016 at 01:31:59AM +0100, Carlos Garnacho wrote: >> From: Lyude >> >> This primary selection is similar in spirit to the eponimous >> in X11, allowing a quick "select text + middle c

Re: [RFC wayland-protocols v4] Add Primary Selection Protocol Version 1

2016-02-22 Thread Carlos Garnacho
Hi Michal, On Mon, Feb 22, 2016 at 2:25 PM, Michal Suchanek wrote: > Hello, > > On 20 February 2016 at 01:31, Carlos Garnacho wrote: > >> + >> + >> +This protocol provides the ability to have a primary selection device to >> +match that of the X

Re: [RFC wayland-protocols v4] Add Primary Selection Protocol Version 1

2016-02-22 Thread Carlos Garnacho
Hi Michal, On Mon, Feb 22, 2016 at 4:53 PM, Michal Suchanek wrote: > On 22 February 2016 at 15:57, Carlos Garnacho wrote: >> Hi Michal, >> >> On Mon, Feb 22, 2016 at 2:25 PM, Michal Suchanek wrote: >>> Hello, >>> >>> On 2

[PATCH weston] xwayland: Create the drag-and-drop window in weston_wm_dnd_init

2016-02-22 Thread Carlos Garnacho
ake drag-and-drop target hidden. This allows drag-and-drop to work between X11 clients in Xwayland, and avoids a crash with (currently unhandled) wl_resource-less data sources. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=94218 Signed-off-by: Carlos Garnacho --- I'm sending this patch

Re: [PATCH wayland-protocols] xdg-shell: Add startup notification

2016-02-26 Thread Carlos Garnacho
Hey :), On Mon, Feb 15, 2016 at 9:59 AM, Jonas Ådahl wrote: > On Thu, Feb 11, 2016 at 01:52:36PM +0100, Carlos Garnacho wrote: >> The xdg_launcher interface is added for the launcher, it's used >> to notify of the startup ID to be transmitted to the launchee, >> pl

Re: [PATCH wayland-protocols] xdg-shell: Add startup notification

2016-02-26 Thread Carlos Garnacho
Hey :), On Fri, Feb 26, 2016 at 1:54 PM, Pekka Paalanen wrote: > On Mon, 15 Feb 2016 16:59:02 +0800 > Jonas Ådahl wrote: > >> On Thu, Feb 11, 2016 at 01:52:36PM +0100, Carlos Garnacho wrote: >> > The xdg_launcher interface is added for the launcher, it's used >&g

Re: [PATCH v7 wayland-protocols] Add the tablet protocol

2016-03-31 Thread Carlos Garnacho
Hey :), On Thu, Mar 31, 2016 at 9:32 AM, Peter Hutterer wrote: > sorry about the delay, this one slipped through > > On Fri, Mar 11, 2016 at 04:12:55PM -0800, Jason Gerecke wrote: >> On 03/08/2016 10:10 PM, Peter Hutterer wrote: >> > Signed-off-by: Peter Hutterer >> > Reviewed-by: Daniel Stone

Re: [PATCH libinput] tablet: fix the airbrush slider range

2016-04-11 Thread Carlos Garnacho
Hey!, On Mon, Apr 11, 2016 at 1:32 AM, Peter Hutterer wrote: > Supposed to be [-1, 1] but we only generated [0, 1] > > Reported-by: Carlos Garnacho > Signed-off-by: Peter Hutterer Also: Tested-by: Carlos Garnacho Thanks :), Carlos ___

Re: [PATCH v2 libinput 1/5] tablet: move the libwacom check for left-handed-ness into a helper function

2016-04-15 Thread Carlos Garnacho
Hey!, On Mon, Apr 11, 2016 at 5:15 AM, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > Changes since v1: > - new in this version > > src/evdev-tablet.c | 38 +- > src/evdev.c| 52 > sr

Re: [PATCH v2 libinput 0/5] Add tablet pad support

2016-04-15 Thread Carlos Garnacho
vent_tablet_pad_get_button() to the more explicitly named > libinput_event_tablet_pad_get_button_number(). Just to drive the point home. The whole series look great to me, just the small glitch I pointed out in 1/5. Other than that, the whole series is: Revi

  1   2   3   >