Re: [RFC PATCH v2 04/17] drm/vkms: Add kunit tests for VKMS LUT handling

2023-10-24 Thread Arthur Grillo
> Cc: Uma Shankar > Cc: Naseer Ahmed > Cc: Christopher Braga > Cc: Abhinav Kumar > Cc: Arthur Grillo > Cc: Hector Martin > Cc: Liviu Dudau > Cc: Sasha McIntosh > --- > drivers/gpu/drm/vkms/Kconfig | 5 ++ > drivers/gpu/drm/vkms/Makefile

Re: [RFC PATCH v3 04/23] drm/vkms: Add kunit tests for VKMS LUT handling

2023-11-09 Thread Arthur Grillo
ff-by: Harry Wentland > Cc: Arthur Grillo > --- > drivers/gpu/drm/vkms/Kconfig | 5 ++ > drivers/gpu/drm/vkms/tests/.kunitconfig | 4 ++ > drivers/gpu/drm/vkms/tests/vkms_color_tests.c | 62 +++ > drivers/gpu/drm/vkms/vkms_compos

Re: [RFC PATCH v3 05/23] drm/vkms: Avoid reading beyond LUT array

2023-11-10 Thread Arthur Grillo
gt; - Drop bits from commit description that didn't contribute >anything of value > > Signed-off-by: Harry Wentland > Cc: Arthur Grillo LGTM Reviewed-by: Arthur Grillo Best Regards, ~Arthur Grillo > --- > drivers/gpu/drm/vkms/vkms_composer.c | 14 ++ >

Re: [RFC PATCH v3 04/23] drm/vkms: Add kunit tests for VKMS LUT handling

2023-11-10 Thread Arthur Grillo
On 09/11/23 19:05, Arthur Grillo wrote: > > > On 08/11/23 13:36, Harry Wentland wrote: >> Debugging LUT math is much easier when we can unit test >> it. Add kunit functionality to VKMS and add tests for >> - get_lut_index >> - lerp_u16 >> >>

Re: [RFC PATCH v4 06/42] drm/vkms: Add kunit tests for VKMS LUT handling

2024-02-27 Thread Arthur Grillo
v3: > - Use include way of testing static functions (Arthur) > > Signed-off-by: Harry Wentland > Cc: Arthur Grillo > --- > drivers/gpu/drm/vkms/Kconfig | 5 + > drivers/gpu/drm/vkms/tests/.kunitconfig | 4 + > drivers/gpu/drm/vkms/tests/vkms_color_