[PATCH weston 00/12] libweston: Use struct timespec for time values

2017-11-16 Thread Alexandros Frantzis
the codebase. In order to limit the scope of each commit, some commits include temporary time value conversions to accommodate existing internal APIs. These temporary conversions are later removed as the internal APIs are also changed to used struct timespec. Alexandros Frantzis (12): shared: Add

[PATCH weston 01/12] shared: Add timespec_is_zero helper

2017-11-16 Thread Alexandros Frantzis
Add a helper function to check if a struct timespec is zero. This helper will be used in the upcoming commits to transition the Weston codebase to struct timespec. Signed-off-by: Alexandros Frantzis --- shared/timespec-util.h | 12 tests/timespec-test.c | 11 +++ 2 files

[PATCH weston 05/12] libweston: Use struct timespec for motion events

2017-11-16 Thread Alexandros Frantzis
Change code related to motion events to use struct timespec to represent time. This commit is part of a larger effort to transition the Weston codebase to struct timespec. Signed-off-by: Alexandros Frantzis --- compositor/screen-share.c | 6 +- desktop-shell/exposay.c| 3

[PATCH weston 04/12] libweston: Use struct timespec for the output presentation timestamp

2017-11-16 Thread Alexandros Frantzis
Store the output presentation timestamp as struct timespec. This commit is part of a larger effort to transition the Weston codebase to struct timespec. Signed-off-by: Alexandros Frantzis --- libweston/compositor.c| 12 ++-- libweston/compositor.h| 2 +- libweston

[PATCH weston 02/12] shared: Add helpers to convert between various time units and timespec

2017-11-16 Thread Alexandros Frantzis
Add helper functions to make it easy and less error-prone to convert between values in various time units (nsec, usec, msec) and struct timespec. These helpers are going to be used in the upcoming commits to transition the Weston codebase to struct timespec. Signed-off-by: Alexandros Frantzis

[PATCH weston 03/12] libweston: Use struct timespec for animations

2017-11-16 Thread Alexandros Frantzis
Change code related to animations to use struct timespec to represent time. This commit is part of a larger effort to transition the Weston codebase to struct timespec. Signed-off-by: Alexandros Frantzis --- desktop-shell/shell.c | 26 ++ desktop-shell/shell.h | 2

[PATCH weston 08/12] libweston: Use struct timespec for key events

2017-11-16 Thread Alexandros Frantzis
Change code related to key events to use struct timespec to represent time. This commit is part of a larger effort to transition the Weston codebase to struct timespec. Signed-off-by: Alexandros Frantzis --- compositor/screen-share.c | 8 --- compositor/text-backend.c | 13

[PATCH weston 10/12] libweston: Use struct timespec for touch up events

2017-11-16 Thread Alexandros Frantzis
Change code related to touch up events to use struct timespec to represent time. This commit is part of a larger effort to transition the Weston codebase to struct timespec. Signed-off-by: Alexandros Frantzis --- desktop-shell/shell.c | 3 ++- ivi-shell/hmi-controller.c | 3

[PATCH weston 07/12] libweston: Use struct timespec for axis events

2017-11-16 Thread Alexandros Frantzis
Change code related to axis events to use struct timespec to represent time. This commit is part of a larger effort to transition the Weston codebase to struct timespec. Signed-off-by: Alexandros Frantzis --- compositor/screen-share.c | 5 - desktop-shell/exposay.c| 3

[PATCH weston 06/12] libweston: Use struct timespec for button events

2017-11-16 Thread Alexandros Frantzis
Change code related to button events to use struct timespec to represent time. This commit is part of a larger effort to transition the Weston codebase to struct timespec. Signed-off-by: Alexandros Frantzis --- compositor/screen-share.c | 5 - desktop-shell/exposay.c| 4

[PATCH weston 09/12] libweston: Use struct timespec for touch down events

2017-11-16 Thread Alexandros Frantzis
Change code related to touch down events to use struct timespec to represent time. This commit is part of a larger effort to transition the Weston codebase to struct timespec. Signed-off-by: Alexandros Frantzis --- desktop-shell/shell.c | 8 +--- ivi-shell/hmi-controller.c

[PATCH weston 12/12] libweston: Use struct timespec for compositor time

2017-11-16 Thread Alexandros Frantzis
of a larger effort to transition the Weston codebase to struct timespec. Signed-off-by: Alexandros Frantzis --- compositor/text-backend.c | 11 +++ desktop-shell/shell.c | 8 desktop-shell/shell.h | 2 +- libweston/compositor-rdp.c | 10 +- libweston/compo

[PATCH weston 11/12] libweston: Use struct timespec for touch motion events

2017-11-16 Thread Alexandros Frantzis
Change code related to touch motion events to use struct timespec to represent time. This commit is part of a larger effort to transition the Weston codebase to struct timespec. Signed-off-by: Alexandros Frantzis --- desktop-shell/shell.c | 5 +++-- ivi-shell/hmi-controller.c | 5

[PATCH weston] ivi-shell: Fix incorrect use of logical instead of bitwise operator

2017-11-17 Thread Alexandros Frantzis
Fix the code to use the correct bitwise AND operator '&', instead of the currently used logical AND operator '&&', to check the value of a bit flag in a bit mask. This problem was reported as a warning when building with clang. --- ivi-shell/ivi-layout.c | 2 +- 1 file changed, 1 insertion(+), 1

[RFC wayland] protocol: Add high-resolution wl_touch timestamp event

2017-11-21 Thread Alexandros Frantzis
Signed-off-by: Alexandros Frantzis --- protocol/wayland.xml | 27 +++ 1 file changed, 23 insertions(+), 4 deletions(-) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index aabc7ae..b01811e 100644 --- a/protocol/wayland.xml +++ b/protocol/wayland.xml @@

Re: [RFC wayland] protocol: Add high-resolution wl_touch timestamp event

2017-11-21 Thread Alexandros Frantzis
On Tue, Nov 21, 2017 at 10:52:00PM +0800, Jonas Ådahl wrote: > On Tue, Nov 21, 2017 at 03:45:48PM +0200, Alexandros Frantzis wrote: > > wl_touch events currently use a 32-bit timestamp with millisecond > > resolution. In some cases, notably latency measurements, this resolution &g

Re: [PATCH weston 05/12] libweston: Use struct timespec for motion events

2017-11-24 Thread Alexandros Frantzis
On Fri, Nov 24, 2017 at 03:29:11PM +0200, Pekka Paalanen wrote: > On Thu, 16 Nov 2017 18:20:54 +0200 > Alexandros Frantzis wrote: > > > Change code related to motion events to use struct timespec to represent > > time. > > > > This commit is part of a large

[PATCH weston v2 05/12] libweston: Use struct timespec for motion events

2017-11-24 Thread Alexandros Frantzis
Change code related to motion events to use struct timespec to represent time. This commit is part of a larger effort to transition the Weston codebase to struct timespec. Signed-off-by: Alexandros Frantzis --- Changes in v2: - Fix handle_pointer_motion_absolute to use the event time in

[PATCH weston v2 01/12] shared: Add timespec_is_zero helper

2017-11-27 Thread Alexandros Frantzis
Add a helper function to check if a struct timespec is zero. This helper will be used in the upcoming commits to transition the Weston codebase to struct timespec. Signed-off-by: Alexandros Frantzis --- Changes in v2: - Use designated initializers to initialize members of struct timespec in

Re: [PATCH weston 01/12] shared: Add timespec_is_zero helper

2017-11-27 Thread Alexandros Frantzis
On Mon, Nov 27, 2017 at 10:20:35AM +0200, Pekka Paalanen wrote: > On Fri, 24 Nov 2017 18:36:43 + > Emil Velikov wrote: > > > Hi Alexandros, > > > > On 16 November 2017 at 16:20, Alexandros Frantzis > > wrote: > > > >

[RFC wayland-protocols] unstable: Add input-timestamps protocol

2017-11-29 Thread Alexandros Frantzis
ed, but supporting pointer and keyboard event timestamps will be similar. Signed-off-by: Alexandros Frantzis --- Makefile.am| 1 + unstable/input-timestamps/README | 4 + .../input-timestamps-unstable-v1.xml | 132 +

Re: [RFC wayland] protocol: Add high-resolution wl_touch timestamp event

2017-11-29 Thread Alexandros Frantzis
On Wed, Nov 29, 2017 at 09:26:07AM +0200, Pekka Paalanen wrote: > On Tue, 28 Nov 2017 14:16:32 + > Daniel Stone wrote: > > > Hi, > > > > On 24 November 2017 at 11:59, Pekka Paalanen wrote: > > > On Tue, 21 Nov 2017 15:45:48 +0200 > > > Alex

Re: [RFC wayland-protocols] unstable: Add input-timestamps protocol

2017-11-30 Thread Alexandros Frantzis
On Thu, Nov 30, 2017 at 04:08:06PM +1000, Peter Hutterer wrote: > On Wed, Nov 29, 2017 at 12:42:57PM +0200, Alexandros Frantzis wrote: > > wl_pointer, wl_keyboard and wl_touch events currently use a 32-bit > > timestamp with millisecond resolution. In some cases, notably latency &

[PATCH weston] tests: Fix integer overflows on 32-bit systems

2017-12-01 Thread Alexandros Frantzis
Ensure that the integer type used in expressions involving multiplication with NSEC_PER_SEC is large enough to avoid overflows on 32-bit systems. In the expressions fixed by this patch a 64-bit type (long long) is required. Signed-off-by: Alexandros Frantzis --- tests/timespec-test.c | 4

[PATCH weston 1/8] shared: Add timespec_normalize helper

2017-12-04 Thread Alexandros Frantzis
tv_sec_hi, tv_sec_lo, tv_sec_nsec triplets, and will be used in upcoming commits. Signed-off-by: Alexandros Frantzis --- shared/timespec-util.h | 28 ++ tests/timespec-test.c | 65 ++ 2 files changed, 93 insertions(+) diff --git a

[PATCH weston 0/8] tests: Add input event timestamp tests

2017-12-04 Thread Alexandros Frantzis
. Patches (3) and (4) reorganize the pointer tests to make it easier to add new test cases. Patches (5) to (8) add tests for input events with a focus on verifying event timestamps. Alexandros Frantzis (8): shared: Add timespec_normalize helper shared: Add helpers to convert between protocol

[PATCH weston 4/8] tests: Use separate test cases for pointer motion and button tests

2017-12-04 Thread Alexandros Frantzis
Split pointer motion and pointer button tests so that each test case is more focused and self-contained. Signed-off-by: Alexandros Frantzis --- tests/pointer-test.c | 36 +--- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/tests/pointer-test.c b

[PATCH weston 5/8] tests: Add checks for pointer motion and button event timestamps

2017-12-04 Thread Alexandros Frantzis
Enhance the existing pointer motion and button event tests to additionally verify the event timestamps. This requires updating the weston-test protocol to support passing motion and button event timestamps. Signed-off-by: Alexandros Frantzis --- protocol/weston-test.xml | 6

[PATCH weston 3/8] tests: Move wl_pointer tests to their own file

2017-12-04 Thread Alexandros Frantzis
Move wl_pointer tests from event-test.c to their own pointer-test.c file. This move makes the test organization clearer and more consistent, and will make addition of further pointer tests easier. Signed-off-by: Alexandros Frantzis --- Makefile.am | 8 +- tests/button-test.c | 61

[PATCH weston 2/8] shared: Add helpers to convert between protocol data and timespec

2017-12-04 Thread Alexandros Frantzis
Add helpers to safely convert between struct timespec values and tv_sec_hi, tv_sec_lo, tv_nsec triplets used for sending high-resolution timestamp data over the wayland protocol. Replace existing conversion code with the helper functions. Signed-off-by: Alexandros Frantzis --- clients

[PATCH weston 7/8] tests: Add test for keyboard key event timestamps

2017-12-04 Thread Alexandros Frantzis
Add test to verify that the server correctly sets the timestamps of keyboard key events. This requires updating the weston-test protocol to support passing key event timestamps. Signed-off-by: Alexandros Frantzis --- protocol/weston-test.xml | 3 ++ tests/keyboard-test.c

[PATCH weston 6/8] tests: Add test for pointer axis events

2017-12-04 Thread Alexandros Frantzis
Add test to verify the server correctly emits pointer axis events. This requires updating the weston-test protocol with a new request for pointer axis events. Signed-off-by: Alexandros Frantzis --- protocol/weston-test.xml | 7 +++ tests/pointer-test.c | 28

[PATCH weston 8/8] tests: Add test for touch event timestamps

2017-12-04 Thread Alexandros Frantzis
Add test to verify that the server correctly sets the timestamps of touch events. This requires updating the weston-test protocol with a new request for touch events. Signed-off-by: Alexandros Frantzis --- Makefile.am | 7 +++- protocol/weston-test.xml | 9

[PATCH wayland-protocols] unstable: Add input-timestamps protocol

2017-12-05 Thread Alexandros Frantzis
eceive and associate it with the next supported input event that arrives. Signed-off-by: Alexandros Frantzis --- Makefile.am| 1 + unstable/input-timestamps/README | 4 + .../input-timestamps-unstable-v1.xml

Re: [PATCH wayland-protocols] unstable: Add input-timestamps protocol

2017-12-05 Thread Alexandros Frantzis
On Tue, Dec 05, 2017 at 06:07:02PM +0200, Alexandros Frantzis wrote: > wl_pointer, wl_keyboard and wl_touch events currently use a 32-bit > timestamp with millisecond resolution. In some cases, notably latency > measurements, this resolution is too coarse to be useful. > > This pr

Re: [PATCH weston 1/8] shared: Add timespec_normalize helper

2017-12-12 Thread Alexandros Frantzis
On Tue, Dec 12, 2017 at 11:50:49AM +0200, Pekka Paalanen wrote: > On Mon, 4 Dec 2017 15:34:01 +0200 > Alexandros Frantzis wrote: > > > Add a helper function to normalize struct timespec values so that the > > nanoseconds part is less than 1 second and has the same sign as

Re: [PATCH weston 2/8] shared: Add helpers to convert between protocol data and timespec

2017-12-12 Thread Alexandros Frantzis
On Tue, Dec 12, 2017 at 12:09:59PM +0200, Pekka Paalanen wrote: > On Mon, 4 Dec 2017 15:34:02 +0200 > Alexandros Frantzis wrote: > > > Add helpers to safely convert between struct timespec values and > > tv_sec_hi, tv_sec_lo, tv_nsec triplets used for sending high-resoluti

Re: [PATCH weston 1/8] shared: Add timespec_normalize helper

2017-12-12 Thread Alexandros Frantzis
On Tue, Dec 12, 2017 at 12:55:27PM +0200, Pekka Paalanen wrote: > On Tue, 12 Dec 2017 12:36:39 +0200 > Alexandros Frantzis wrote: > > > On Tue, Dec 12, 2017 at 11:50:49AM +0200, Pekka Paalanen wrote: > > > On Mon, 4 Dec 2017 15:34:01 +0200 > > > Alexandros Fran

Re: [PATCH weston 5/8] tests: Add checks for pointer motion and button event timestamps

2017-12-12 Thread Alexandros Frantzis
On Tue, Dec 12, 2017 at 02:13:26PM +0200, Pekka Paalanen wrote: > On Mon, 4 Dec 2017 15:34:05 +0200 > Alexandros Frantzis wrote: > > > Enhance the existing pointer motion and button event tests to > > additionally verify the event timestamps. This requires updating the >

Re: [PATCH weston 2/8] shared: Add helpers to convert between protocol data and timespec

2017-12-12 Thread Alexandros Frantzis
On Tue, Dec 12, 2017 at 03:09:56PM +0200, Pekka Paalanen wrote: > On Tue, 12 Dec 2017 14:43:11 +0200 > Alexandros Frantzis wrote: > > > On Tue, Dec 12, 2017 at 12:09:59PM +0200, Pekka Paalanen wrote: > > > On Mon, 4 Dec 2017 15:34:02 +0200 > > > Alexandros Fran

[PATCH weston v2 3/6] tests: Add checks for pointer motion and button event timestamps

2017-12-13 Thread Alexandros Frantzis
Enhance the existing pointer motion and button event tests to additionally verify the event timestamps. This requires updating the weston-test protocol to support passing motion and button event timestamps. Signed-off-by: Alexandros Frantzis --- Changes in v2: - Add unit suffix "mse

[PATCH weston v2 0/6] tests: Add input event timestamp tests

2017-12-13 Thread Alexandros Frantzis
timespec functions already produce normalized representations. We can reintroduce it if required, e.g., if we need to normalize timespecs from untrusted sources. Patch-specific changes are listed in each individual patch. Alexandros Frantzis (6): shared: Add timespec_from_proto helper function

[PATCH weston v2 1/6] shared: Add timespec_from_proto helper function

2017-12-13 Thread Alexandros Frantzis
Add helper function to convert tv_sec_hi, tv_sec_lo, tv_nsec triplets, used for sending high-resolution timestamp data over the wayland protocol, to struct timespec values. Replace existing conversion code with the helper function. Signed-off-by: Alexandros Frantzis --- Changes in v2: - New

[PATCH weston v2 4/6] tests: Add test for pointer axis events

2017-12-13 Thread Alexandros Frantzis
Add test to verify the server correctly emits pointer axis events. This requires updating the weston-test protocol with a new request for pointer axis events. Signed-off-by: Alexandros Frantzis --- Changes in v2: - Add unit suffix "msec" to variables that hold event time. proto

[PATCH weston v2 2/6] shared: Add timespec_to_proto helper function

2017-12-13 Thread Alexandros Frantzis
Add helper function to convert from struct timespec values to tv_sec_hi, tv_sec_lo, tv_nsec triplets used for sending high-resolution timestamp data over the wayland protocol. Replace existing conversion code with the helper function. Signed-off-by: Alexandros Frantzis --- Changes in v2: - New

[PATCH weston v2 5/6] tests: Add test for keyboard key event timestamps

2017-12-13 Thread Alexandros Frantzis
performs a roundtrip internally. To account for this, the client_roundtrip() function is now directly called in the loop only when it is still required, i.e., when deactivating the surface. Signed-off-by: Alexandros Frantzis --- Changes in v2: - Add unit suffix "msec" to variables

[PATCH weston v2 6/6] tests: Add test for touch event timestamps

2017-12-13 Thread Alexandros Frantzis
Add test to verify that the server correctly sets the timestamps of touch events. This requires updating the weston-test protocol with a new request for touch events. Signed-off-by: Alexandros Frantzis --- Changes in v2: - Add unit suffix "msec" to variables that hold event time. M

Re: [PATCH wayland-protocols] unstable: Add input-timestamps protocol

2017-12-13 Thread Alexandros Frantzis
On Mon, Dec 11, 2017 at 03:25:28PM +0200, Pekka Paalanen wrote: > On Tue, 5 Dec 2017 18:07:02 +0200 > Alexandros Frantzis wrote: > > > wl_pointer, wl_keyboard and wl_touch events currently use a 32-bit > > timestamp with millisecond resolution. In some cases, notably lat

[PATCH weston v3] tests: Add test for pointer axis events

2017-12-18 Thread Alexandros Frantzis
Add test to verify the server correctly emits pointer axis events. This requires updating the weston-test protocol with a new request for pointer axis events. Signed-off-by: Alexandros Frantzis --- Changes in v3: - Use uint32_t, not double, for event time variables. Changes in v2: - Add

Re: [PATCH weston v2 4/6] tests: Add test for pointer axis events

2017-12-18 Thread Alexandros Frantzis
On Mon, Dec 18, 2017 at 11:53:24AM +0200, Pekka Paalanen wrote: > On Wed, 13 Dec 2017 13:27:56 +0200 > Alexandros Frantzis wrote: > > > Add test to verify the server correctly emits pointer axis events. This > > requires updating the weston-test protocol with a new request

Re: [PATCH wayland-protocols] unstable: Add input-timestamps protocol

2017-12-18 Thread Alexandros Frantzis
On Mon, Dec 18, 2017 at 12:50:30PM +0200, Pekka Paalanen wrote: > On Wed, 13 Dec 2017 16:48:28 +0200 > Alexandros Frantzis wrote: > > > On Mon, Dec 11, 2017 at 03:25:28PM +0200, Pekka Paalanen wrote: > > > On Tue, 5 Dec 2017 18:07:02 +0200 > >

[PATCH wayland-protocols v2] unstable: Add input-timestamps protocol

2017-12-18 Thread Alexandros Frantzis
eceive and associate it with the next supported input event that arrives. Signed-off-by: Alexandros Frantzis Reviewed-by: Pekka Paalanen Acked-by: Jonas Ådahl --- Changes in v2: - Add '...carrying a timestamp...' to better describe the set of subsequent input events in the timesta

Re: [PATCH wayland-protocols v2] unstable: Add input-timestamps protocol

2017-12-19 Thread Alexandros Frantzis
On Tue, Dec 19, 2017 at 10:15:06AM +0200, Pekka Paalanen wrote: > On Mon, 18 Dec 2017 14:55:00 +0200 > Alexandros Frantzis wrote: > > > wl_pointer, wl_keyboard and wl_touch events currently use a 32-bit > > timestamp with millisecond resolution. In some cases, notably lat

[PATCH weston 0/6] libweston: Support input_timestamps_unstable_v1

2017-12-20 Thread Alexandros Frantzis
://lists.freedesktop.org/archives/wayland-devel/2017-December/036320.html Alexandros Frantzis (6): shared: Add timespec_eq helper function tests: Introduce input timestamps helper libweston: Introduce input-timestamps support libweston: Implement keyboard timestamps for

[PATCH weston 3/6] libweston: Introduce input-timestamps support code

2017-12-20 Thread Alexandros Frantzis
-off-by: Alexandros Frantzis --- Makefile.am | 4 +- libweston/input.c | 115 ++ 2 files changed, 118 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 0b616c11..823e9845 100644 --- a/Makefile.am +++ b/Makefile.am

[PATCH weston 5/6] libweston: Implement pointer timestamps for input_timestamps_unstable_v1

2017-12-20 Thread Alexandros Frantzis
Implement the zwp_input_timestamps_v1.get_pointer_timestamps request to subscribe to timestamp events for wl_pointer resources. Signed-off-by: Alexandros Frantzis --- libweston/compositor.h | 2 ++ libweston/input.c | 50 +- tests/pointer-test.c | 66

[PATCH weston 4/6] libweston: Implement keyboard timestamps for input_timestamps_unstable_v1

2017-12-20 Thread Alexandros Frantzis
Implement the zwp_input_timestamps_v1.get_keyboard_timestamps request to subscribe to timestamp events for wl_keyboard resources. Signed-off-by: Alexandros Frantzis --- libweston/compositor.h | 2 ++ libweston/input.c | 38 +++--- tests/keyboard-test.c

[PATCH weston 6/6] libweston: Implement touch timestamps for input_timestamps_unstable_v1

2017-12-20 Thread Alexandros Frantzis
Implement the zwp_input_timestamps_v1.get_touch_timestamps request to subscribe to timestamp events for wl_touch resources. Signed-off-by: Alexandros Frantzis --- libweston/compositor.h | 2 ++ libweston/input.c | 53 +++--- tests/touch-test.c

[PATCH weston 2/6] tests: Introduce input timestamps helper

2017-12-20 Thread Alexandros Frantzis
Introduce helper test code to implement the client side of the input_timestamps_unstable_v1 protocol. This helper will be used in upcoming commits to test the server side implementation of the protocol in libweston. Signed-off-by: Alexandros Frantzis --- Makefile.am | 16

[PATCH weston 1/6] shared: Add timespec_eq helper function

2017-12-20 Thread Alexandros Frantzis
Add a helper function to check if two struct timespec values are equal. This helper function will be used in upcoming commits that implement the input_timestamps_unstable_v1 protocol. Signed-off-by: Alexandros Frantzis --- shared/timespec-util.h | 13 + tests/timespec-test.c | 12

Re: [PATCH wayland-protocols v2] unstable: Add input-timestamps protocol

2017-12-20 Thread Alexandros Frantzis
On Tue, Dec 19, 2017 at 01:06:11PM +0200, Alexandros Frantzis wrote: > On Tue, Dec 19, 2017 at 10:15:06AM +0200, Pekka Paalanen wrote: > > On Mon, 18 Dec 2017 14:55:00 +0200 > > Alexandros Frantzis wrote: > > > > > wl_pointer, wl_keyboard and wl_touch

[PATCH weston 4/8] libweston: Make weston_seat release safe

2018-01-26 Thread Alexandros Frantzis
this NULL user data case where required. Signed-off-by: Alexandros Frantzis --- libweston/input.c | 45 +++-- 1 file changed, 35 insertions(+), 10 deletions(-) diff --git a/libweston/input.c b/libweston/input.c index 48bcc55c..e4daa56b 100644 --- a

[PATCH weston 2/8] libweston: Make weston_keyboard destruction safe

2018-01-26 Thread Alexandros Frantzis
destruction, so other code can check whether the resource is inert. Signed-off-by: Alexandros Frantzis --- libweston/input.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/libweston/input.c b/libweston/input.c index 01f0d568..96cabf25 100644 --- a

[PATCH weston 3/8] libweston: Make weston_touch destruction safe

2018-01-26 Thread Alexandros Frantzis
other code can check whether the resource is inert. Signed-off-by: Alexandros Frantzis --- libweston/input.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/libweston/input.c b/libweston/input.c index 96cabf25..48bcc55c 100644 --- a/libweston/input.c +++ b

[PATCH weston 1/8] libweston: Make weston_pointer destruction safe

2018-01-26 Thread Alexandros Frantzis
become inert. The clean-up involves, among other things, unsetting the destroyed weston_pointer object from the user data of pointer resources, and handling this NULL user data case where required. Signed-off-by: Alexandros Frantzis --- libweston/input.c | 41

[PATCH weston 5/8] tests: Support setting the test client input dynamically

2018-01-26 Thread Alexandros Frantzis
oming commits. This commit changes the code to check for the test seat and set up the input object while handling the wl_seat information events. Signed-off-by: Alexandros Frantzis --- tests/weston-test-client-helper.c | 78 ++- tests/weston-test-client-hel

[PATCH weston 0/8] libweston: Make input object destruction safe

2018-01-26 Thread Alexandros Frantzis
but I will investigate further and hopefully we can remove this workaround. 2. Even without some of the fixes in the patches 1-4, the test may seem to pass. However, running with a memory debugger reveals a different story, since without the fixes we encounter various memory errors. Alexandros F

[PATCH weston 8/8] tests: Add test for seat destruction and creation

2018-01-26 Thread Alexandros Frantzis
d-off-by: Alexandros Frantzis --- Makefile.am | 5 + tests/devices-seat-test.c | 53 +++ 2 files changed, 58 insertions(+) create mode 100644 tests/devices-seat-test.c diff --git a/Makefile.am b/Makefile.am index e224d606..f0370973 1

[PATCH weston 6/8] tests: Support weston_test request for adding a test seat

2018-01-26 Thread Alexandros Frantzis
ry to create multiple test seats or try to remove an already removed test seat. Signed-off-by: Alexandros Frantzis --- tests/weston-test.c | 32 +--- 1 file changed, 25 insertions(+), 7 deletions(-) diff --git a/tests/weston-test.c b/tests/weston-test.c index 80b

[PATCH weston 7/8] tests: Handle removal of seat global in test clients

2018-01-26 Thread Alexandros Frantzis
accordingly. This update will be used by upcoming tests to check that seat removal and re-addition is working properly. Signed-off-by: Alexandros Frantzis --- tests/weston-test-client-helper.c | 71 +-- tests/weston-test-client-helper.h | 1 + 2 files changed, 70

Re: [PATCH weston 6/6] libweston: Implement touch timestamps for input_timestamps_unstable_v1

2018-01-26 Thread Alexandros Frantzis
On Fri, Jan 19, 2018 at 12:18:38PM +0200, Pekka Paalanen wrote: > On Wed, 20 Dec 2017 16:18:01 +0200 > Alexandros Frantzis wrote: > > > Implement the zwp_input_timestamps_v1.get_touch_timestamps request to > > subscribe to timestamp events for wl_touch resources. &

Re: [PATCH weston 4/8] libweston: Make weston_seat release safe

2018-01-31 Thread Alexandros Frantzis
On Wed, Jan 31, 2018 at 03:21:07PM +0200, Pekka Paalanen wrote: > On Fri, 26 Jan 2018 18:47:58 +0200 > Alexandros Frantzis wrote: > > > Ensure the server can safely handle client requests for wl_seat resource > > that have become inert due to weston_seat object r

Re: [PATCH weston 5/8] tests: Support setting the test client input dynamically

2018-01-31 Thread Alexandros Frantzis
On Wed, Jan 31, 2018 at 04:25:15PM +0200, Pekka Paalanen wrote: > On Fri, 26 Jan 2018 18:47:59 +0200 > Alexandros Frantzis wrote: > > > The current test client code waits for all wl_seat globals to arrive > > before checking them and deciding which one is the test seat glob

Re: [PATCH weston 5/8] tests: Support setting the test client input dynamically

2018-02-01 Thread Alexandros Frantzis
On Thu, Feb 01, 2018 at 12:00:44PM +0200, Pekka Paalanen wrote: > On Wed, 31 Jan 2018 17:14:49 +0200 > Alexandros Frantzis wrote: > > > On Wed, Jan 31, 2018 at 04:25:15PM +0200, Pekka Paalanen wrote: > > > On Fri, 26 Jan 2018 18:47:59 +0200 > > > Alexandros Fran

Re: [PATCH weston 8/8] tests: Add test for seat destruction and creation

2018-02-01 Thread Alexandros Frantzis
On Thu, Feb 01, 2018 at 12:46:13PM +0200, Pekka Paalanen wrote: > On Fri, 26 Jan 2018 18:48:02 +0200 > Alexandros Frantzis wrote: > > > Add a test to check that we can destroy and create the test seat. Since > > after test seat destruction the test client releases any

Re: [PATCH weston 5/8] tests: Support setting the test client input dynamically

2018-02-01 Thread Alexandros Frantzis
On Thu, Feb 01, 2018 at 12:20:44PM +0200, Pekka Paalanen wrote: > On Fri, 26 Jan 2018 18:47:59 +0200 > Alexandros Frantzis wrote: > > > The current test client code waits for all wl_seat globals to arrive > > before checking them and deciding which one is the test seat glob

Re: [PATCH weston 5/8] tests: Support setting the test client input dynamically

2018-02-01 Thread Alexandros Frantzis
On Thu, Feb 01, 2018 at 02:09:32PM +0200, Pekka Paalanen wrote: > On Thu, 1 Feb 2018 13:30:25 +0200 > Alexandros Frantzis wrote: > > > On Thu, Feb 01, 2018 at 12:20:44PM +0200, Pekka Paalanen wrote: > > > On Fri, 26 Jan 2018 18:47:59 +0200 > > > Alexandros Fran

[PATCH weston v2 6/7] tests: Run devices tests using the test desktop shell

2018-02-08 Thread Alexandros Frantzis
afely add tests which add/remove such globals in upcoming commits. Signed-off-by: Alexandros Frantzis --- Changes in v2: - New in v2. tests/devices-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/devices-test.c b/tests/devices-test.c index ce1cea3b..a6ec6eaf 100644 --- a/

[PATCH weston v2 3/7] libweston: Make weston_seat release safe

2018-02-08 Thread Alexandros Frantzis
] xdg_toplevel.show_window_menu [FIXED] xdg_toplevel.move [FIXED] xdg_toplevel.resize [FIXED] xdg_popup.grab == xdg_shell_unstable_v5 == [FIXED] xdg_shell.get_xdg_popup [FIXED] xdg_surface.show_window_menu [FIXED] xdg_surface.move [FIXED] xdg_surface.resize Signed-off-by: Alexandros Frantzis

[PATCH weston v2 0/7] libweston: Make input object destruction safe

2018-02-08 Thread Alexandros Frantzis
ed by this race. More detailed changes introduced in v2 are provided in each patch. Alexandros Frantzis (7): libweston: Support NULL weston_pointer in init_pointer_constraint libweston: Make weston_pointer destruction safe libweston: Make weston_seat release safe tests: Handle removal of

[PATCH weston v2 1/7] libweston: Support NULL weston_pointer in init_pointer_constraint

2018-02-08 Thread Alexandros Frantzis
: Alexandros Frantzis --- Changes in v2: - New patch libweston/input.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/libweston/input.c b/libweston/input.c index 96cded47..390698c7 100644 --- a/libweston/input.c +++ b/libweston/input.c @@ -3572,7 +3572,7

[PATCH weston v2 5/7] tests: Support setting the test client input dynamically

2018-02-08 Thread Alexandros Frantzis
was previously the case. Signed-off-by: Alexandros Frantzis --- Changes in v2: - Add explicit test for seat names. - Don't destroy input objects for non-test seats unconditionally. - Simplify devices handling in seat name handler. tests/devices-test.c | 10 ++

[PATCH weston v2 4/7] tests: Handle removal of seat global in test clients

2018-02-08 Thread Alexandros Frantzis
accordingly. This update will be used by upcoming tests to check that seat removal and re-addition is working properly. Signed-off-by: Alexandros Frantzis --- Changes in v2: - Simplify input_destroy, no need to check for validity of wl_* objects. tests/weston-test-client-helper.c | 83

[PATCH weston v2 2/7] libweston: Make weston_pointer destruction safe

2018-02-08 Thread Alexandros Frantzis
weston_pointer (e.g. in init_pointer_constraint), so there is no need for additional updates there. Signed-off-by: Alexandros Frantzis --- Changes in v2: - Removed NULL check before calling init_pointer_constraint, since init_pointer_constraint now handles this case. - Handle NULL weston_pointer in

[PATCH weston v2 7/7] tests: Add test for seat destruction and creation

2018-02-08 Thread Alexandros Frantzis
Add a test to check that we can destroy and create the test seat. Since after test seat destruction the test client releases any associated input resources, this test also checks that libweston properly handles release requests for inert input resources. Signed-off-by: Alexandros Frantzis

[PATCH weston] libweston-desktop/xdg-shell-v5: Drop xdg-shell v5 support

2018-02-13 Thread Alexandros Frantzis
d-off-by: Alexandros Frantzis --- Makefile.am | 6 +- libweston-desktop/internal.h | 3 - libweston-desktop/libweston-desktop.c | 10 - libweston-desktop/xdg-shell-v5.c | 911 -- 4 files changed, 1 insertion(+), 929 dele

[PATCH weston v3 3/7] libweston: Make weston_seat release safe

2018-02-14 Thread Alexandros Frantzis
] xdg_toplevel.show_window_menu [FIXED] xdg_toplevel.move [FIXED] xdg_toplevel.resize [FIXED] xdg_popup.grab == xdg_shell_unstable_v5 == [FIXED] xdg_shell.get_xdg_popup [FIXED] xdg_surface.show_window_menu [FIXED] xdg_surface.move [FIXED] xdg_surface.resize Signed-off-by: Alexandros Frantzis

[PATCH weston v4 3/7] libweston: Make weston_seat release safe

2018-02-15 Thread Alexandros Frantzis
] xdg_toplevel.show_window_menu [FIXED] xdg_toplevel.move [FIXED] xdg_toplevel.resize [FIXED] xdg_popup.grab == xdg_shell_unstable_v5 == [FIXED] xdg_shell.get_xdg_popup [FIXED] xdg_surface.show_window_menu [FIXED] xdg_surface.move [FIXED] xdg_surface.resize Signed-off-by: Alexandros Frantzis

[PATCH weston v2 0/6] libweston: Support input_timestamps_unstable_v1

2018-02-16 Thread Alexandros Frantzis
/archives/wayland-devel/2017-December/036320.html Alexandros Frantzis (6): shared: Add timespec_eq helper function tests: Introduce input timestamps helper libweston: Introduce input-timestamps support libweston: Implement keyboard timestamps for input_timestamps_unstable_v1 libweston

[PATCH weston v2 2/6] tests: Introduce input timestamps helper

2018-02-16 Thread Alexandros Frantzis
wayland-protocols, so this commit updates the version dependency in configure.ac accordingly. Signed-off-by: Alexandros Frantzis Reviewed-by: Pekka Paalanen --- Changes in v2: - Update wayland-protocols version dependency to 1.13. Makefile.am | 16 ++-- configure.ac

[PATCH weston v2 4/6] libweston: Implement keyboard timestamps for input_timestamps_unstable_v1

2018-02-16 Thread Alexandros Frantzis
useful in the implementation of the remaining zwp_input_timestamps_manager_v1 requests. Signed-off-by: Alexandros Frantzis --- Changes in v2: - Merge helper functions from v1 3/6 commit in this one to avoid warnings in 3/6 commit. - Remove the head of timestamps_list in

[PATCH weston v2 1/6] shared: Add timespec_eq helper function

2018-02-16 Thread Alexandros Frantzis
Add a helper function to check if two struct timespec values are equal. This helper function will be used in upcoming commits that implement the input_timestamps_unstable_v1 protocol. Signed-off-by: Alexandros Frantzis Reviewed-by: Pekka Paalanen --- Changes in v2: - No changes. shared

[PATCH weston v2 3/6] libweston: Introduce input-timestamps support

2018-02-16 Thread Alexandros Frantzis
foundation for timestamp subscriptions for keyboard/pointer/touch to be added cleanly in upcoming commits. Signed-off-by: Alexandros Frantzis --- Changes in v2: - Move unused helper functions to next patch to avoid warnings, keep only zwp_input_timestamps_manager_v1 code in this patch

[PATCH weston v2 5/6] libweston: Implement pointer timestamps for input_timestamps_unstable_v1

2018-02-16 Thread Alexandros Frantzis
Implement the zwp_input_timestamps_manager_v1.get_pointer_timestamps request to subscribe to timestamp events for wl_pointer resources. Ensure that the request handling code can gracefully handle inert pointer resources. Signed-off-by: Alexandros Frantzis --- Changes in v2: - Remove the head of

[PATCH weston v2 6/6] libweston: Implement touch timestamps for input_timestamps_unstable_v1

2018-02-16 Thread Alexandros Frantzis
Implement the zwp_input_timestamps_manager_v1.get_touch_timestamps request to subscribe to timestamp events for wl_touch resources. Ensure that the request handling code can gracefully handle inert touch resources. Signed-off-by: Alexandros Frantzis --- Changes in v2: - Remove the head of

Re: [PATCH weston v2 6/6] libweston: Implement touch timestamps for input_timestamps_unstable_v1

2018-02-16 Thread Alexandros Frantzis
On Fri, Feb 16, 2018 at 06:44:19PM +0200, Alexandros Frantzis wrote: > Implement the zwp_input_timestamps_manager_v1.get_touch_timestamps > request to subscribe to timestamp events for wl_touch resources. Ensure > that the request handling code can gracefully handle inert touch &g

[PATCH weston v3 4/6] libweston: Implement keyboard timestamps for input_timestamps_unstable_v1

2018-02-20 Thread Alexandros Frantzis
useful in the implementation of the remaining zwp_input_timestamps_manager_v1 requests. Signed-off-by: Alexandros Frantzis --- Changes in v3: - In keyboard_timestamps_stop_after_client_releases_wl_keyboard test check for changes to keyboard->input_timestamp instead of keybo

[PATCH weston v3 5/6] libweston: Implement pointer timestamps for input_timestamps_unstable_v1

2018-02-20 Thread Alexandros Frantzis
Implement the zwp_input_timestamps_manager_v1.get_pointer_timestamps request to subscribe to timestamp events for wl_pointer resources. Ensure that the request handling code can gracefully handle inert pointer resources. Signed-off-by: Alexandros Frantzis --- Changes in v3: - In

[PATCH weston v3 6/6] libweston: Implement touch timestamps for input_timestamps_unstable_v1

2018-02-20 Thread Alexandros Frantzis
Implement the zwp_input_timestamps_manager_v1.get_touch_timestamps request to subscribe to timestamp events for wl_touch resources. Ensure that the request handling code can gracefully handle inert touch resources. Signed-off-by: Alexandros Frantzis --- Changes in v3: - In

Re: [RFC,wayland-protocols] Add alpha-compositing protocol

2018-09-10 Thread Alexandros Frantzis
On Fri, Sep 07, 2018 at 04:02:24PM +0200, Gary Bisson wrote: > Hi Alexandros, All, > > On Tue, Aug 08, 2017 at 05:24:58PM +0300, Alexandros Frantzis wrote: > > This protocol specifies a set of interfaces used to control the alpha > > compositing and blending of surface co

  1   2   >