Re: [PATCH V9 32/43] drm/amd/display: Add support for BT.709 and BT.2020 TFs

2025-05-12 Thread Melissa Wen
On 04/29, Alex Hung wrote: > From: Harry Wentland > > This adds support for the BT.709/BT.2020 transfer functions > on all current 1D curve plane colorops, i.e., on DEGAM, SHAPER, > and BLND blocks. > > With this change the following IGT subtests pass: > kms_colorop --run plane-XR30-XR30-bt2020_

Re: [PATCH V9 36/43] drm/colorop: Add mutliplier type

2025-05-12 Thread Melissa Wen
On 29/04/2025 22:11, Alex Hung wrote: Typo in the commit msg: mutliplier -> multiplier This introduces a new drm_colorop_type: DRM_COLOROP_MULTIPLIER. It's a simple multiplier to all pixel values. The value is specified via a S31.32 fixed point provided via the "MULTIPLIER" property. Review

Re: [PATCH V9 22/43] drm/colorop: define a new macro for_each_new_colorop_in_state

2025-05-12 Thread Melissa Wen
On 04/29, Alex Hung wrote: > Create a new macro for_each_new_colorop_in_state to access new > drm_colorop_state updated from uapi. > > Reviewed-by: Simon Ser > Signed-off-by: Alex Hung > Reviewed-by: Daniel Stone > --- > include/drm/drm_atomic.h | 20 > 1 file changed, 20

Re: [PATCH V9 24/43] drm/amd/display: Add bypass COLOR PIPELINE

2025-05-12 Thread Melissa Wen
On 04/29, Alex Hung wrote: > From: Harry Wentland > > Add the default Bypass pipeline and ensure it passes the > kms_colorop test plane-XR30-XR30-bypass. > > Signed-off-by: Alex Hung > Signed-off-by: Harry Wentland > Reviewed-by: Daniel Stone > --- > .../amd/display/amdgpu_dm/amdgpu_dm_plane

Re: [PATCH V9 26/43] drm/amd/display: Add support for sRGB EOTF in DEGAM block

2025-05-12 Thread Melissa Wen
On 04/29, Alex Hung wrote: > Expose one 1D curve colorop with support for > DRM_COLOROP_1D_CURVE_SRGB_EOTF and program HW to perform > the sRGB transform when the colorop is not in bypass. > > With this change the following IGT test passes: > kms_colorop --run plane-XR30-XR30-srgb_eotf > > The co

Re: [PATCH V9 42/43] drm/amd/display: add 3D LUT colorop

2025-05-12 Thread Melissa Wen
On 04/29, Alex Hung wrote: > This adds support for a 3D LUT. > > The color pipeline now consists of the following colorops: > 1. 1D curve colorop > 2. Multiplier > 3. 3x4 CTM > 4. 1D curve colorop > 5. 1D LUT > 6. 3D LUT > 7. 1D curve colorop > 8. 1D LUT > > Signed-off-by: Alex Hung > Reviewed-b

Re: [PATCH V8 40/43] drm/colorop: Add 3D LUT support to color pipeline

2025-05-12 Thread Alex Hung
On 4/25/25 07:50, Leandro Ribeiro wrote: On 3/26/25 20:47, Alex Hung wrote: It is to be used to enable HDR by allowing userpace to create and pass 3D LUTs to kernel and hardware. new drm_colorop_type: DRM_COLOROP_3D_LUT. Signed-off-by: Alex Hung --- v8: - Fix typo in subject (Simon Ser

Re: [PATCH V9 42/43] drm/amd/display: add 3D LUT colorop

2025-05-12 Thread Alex Hung
On 5/12/25 18:52, Melissa Wen wrote: On 04/29, Alex Hung wrote: This adds support for a 3D LUT. The color pipeline now consists of the following colorops: 1. 1D curve colorop 2. Multiplier 3. 3x4 CTM 4. 1D curve colorop 5. 1D LUT 6. 3D LUT 7. 1D curve colorop 8. 1D LUT Signed-off-by: Alex H