Re: [V7 02/45] drm/vkms: Round fixp2int conversion in lerp_u16

2025-02-25 Thread Louis Chauvet
Le 20/12/2024 à 05:33, Alex Hung a écrit : From: Harry Wentland fixp2int always rounds down, fixp2int_ceil rounds up. We need the new fixp2int_round. Signed-off-by: Alex Hung Signed-off-by: Harry Wentland Reviewed-by: Louis Chauvet Hi, Can I extract this patch from the series and appl

Re: [V7 03/45] drm/vkms: Add kunit tests for VKMS LUT handling

2025-02-25 Thread Louis Chauvet
Le 20/12/2024 à 05:33, Alex Hung a écrit : From: Harry Wentland Debugging LUT math is much easier when we can unit test it. Add kunit functionality to VKMS and add tests for - get_lut_index - lerp_u16 Reviewed-by: Louis Chauvet Signed-off-by: Alex Hung Signed-off-by: Harry Wentland C

Re: [V7 01/45] drm: Add helper for conversion from signed-magnitude

2025-02-25 Thread Louis Chauvet
Le 24/02/2025 à 19:50, Alex Hung a écrit : On 2/24/25 09:07, Louis Chauvet wrote: Le 20/12/2024 à 05:33, Alex Hung a écrit : From: Harry Wentland CTM values are defined as signed-magnitude values. Add a helper that converts from CTM signed-magnitude fixed point value to the twos-comple

Re: [V7 05/45] drm/colorop: Introduce new drm_colorop mode object

2025-02-25 Thread Louis Chauvet
Le 20/12/2024 à 05:33, Alex Hung a écrit : From: Harry Wentland This patches introduces a new drm_colorop mode object. This object represents color transformations and can be used to define color pipelines. We also introduce the drm_colorop_state here, as well as various helpers and state t

Re: [V7 06/45] drm/colorop: Add TYPE property

2025-02-25 Thread Louis Chauvet
Le 20/12/2024 à 05:33, Alex Hung a écrit : From: Harry Wentland Add a read-only TYPE property. The TYPE specifies the colorop type, such as enumerated curve, 1D LUT, CTM, 3D LUT, PWL LUT, etc. For now we're only introducing an enumerated 1D LUT type to illustrate the concept. Signed-off-by

Re: [V7 07/45] drm/colorop: Add 1D Curve subtype

2025-02-25 Thread Louis Chauvet
Le 20/12/2024 à 05:33, Alex Hung a écrit : From: Harry Wentland Add a new drm_colorop with DRM_COLOROP_1D_CURVE with two subtypes: DRM_COLOROP_1D_CURVE_SRGB_EOTF and DRM_COLOROP_1D_CURVE_SRGB_INV_EOTF. Signed-off-by: Harry Wentland Co-developed-by: Alex Hung Signed-off-by: Alex Hung ---

Re: [V7 09/45] drm/colorop: Add BYPASS property

2025-02-25 Thread Louis Chauvet
Le 20/12/2024 à 05:33, Alex Hung a écrit : From: Harry Wentland We want to be able to bypass each colorop at all times. Introduce a new BYPASS boolean property for this. Signed-off-by: Alex Hung Signed-off-by: Harry Wentland Reviewed-by: Louis Chauvet -- Louis Chauvet, Bootlin Embedde

Re: [V7 10/45] drm/colorop: Add NEXT property

2025-02-25 Thread Louis Chauvet
Le 20/12/2024 à 05:33, Alex Hung a écrit : From: Harry Wentland We'll construct color pipelines out of drm_colorop by chaining them via the NEXT pointer. NEXT will point to the next drm_colorop in the pipeline, or by 0 if we're at the end of the pipeline. Signed-off-by: Alex Hung Signed-of

Re: [V7 02/45] drm/vkms: Round fixp2int conversion in lerp_u16

2025-02-25 Thread Louis Chauvet
Le 25/02/2025 à 12:28, Simon Ser a écrit : On Tuesday, February 25th, 2025 at 10:37, Louis Chauvet wrote: Can I extract this patch from the series and apply it on drm-misc-next? That sounds completely fine by me, and TBH it sounds like it could even be drm-misc-fixes material? Probably

Re: [V7 15/45] drm/vkms: Add kunit tests for linear and sRGB LUTs

2025-02-25 Thread Louis Chauvet
Le 20/12/2024 à 05:33, Alex Hung a écrit : From: Harry Wentland Two tests are added to VKMS LUT handling: - linear - inv_srgb Reviewed-by: Louis Chauvet Signed-off-by: Alex Hung Signed-off-by: Harry Wentland --- v7: - Fix checkpatch warnings (Louis Chauvet) - Adde a commit messages

Re: [V7 14/45] drm/vkms: Add enumerated 1D curve colorop

2025-02-25 Thread Louis Chauvet
Le 20/12/2024 à 05:33, Alex Hung a écrit : From: Harry Wentland This patch introduces a VKMS color pipeline that includes two drm_colorops for named transfer functions. For now the only ones supported are sRGB EOTF, sRGB Inverse EOTF, and a Linear TF. We will expand this in the future but I don

Re: [V7 02/45] drm/vkms: Round fixp2int conversion in lerp_u16

2025-02-25 Thread Harry Wentland
On 2025-02-25 09:05, Louis Chauvet wrote: > > > Le 25/02/2025 à 12:28, Simon Ser a écrit : >> On Tuesday, February 25th, 2025 at 10:37, Louis Chauvet >> wrote: >> >>> Can I extract this patch from the series and apply it on drm-misc-next? >> >> That sounds completely fine by me, and TBH it soun

Re: [V7 03/45] drm/vkms: Add kunit tests for VKMS LUT handling

2025-02-25 Thread Harry Wentland
On 2025-02-25 04:51, Louis Chauvet wrote: > > > Le 20/12/2024 à 05:33, Alex Hung a écrit : >> From: Harry Wentland >> >> Debugging LUT math is much easier when we can unit test >> it. Add kunit functionality to VKMS and add tests for >>   - get_lut_index >>   - lerp_u16 >> >> Reviewed-by: Lou

Re: [V7 02/45] drm/vkms: Round fixp2int conversion in lerp_u16

2025-02-25 Thread Simon Ser
On Tuesday, February 25th, 2025 at 15:43, Harry Wentland wrote: > > > We need to be a bit careful when merging patches from the same series > > > via multiple trees. Maybe we'll merge the colorop stuff via the amd > > > tree? I don't remember the rules around trees, and I don't know if it > > >

Re: [V7 02/45] drm/vkms: Round fixp2int conversion in lerp_u16

2025-02-25 Thread Louis Chauvet
Le 25/02/2025 à 15:45, Simon Ser a écrit : On Tuesday, February 25th, 2025 at 15:43, Harry Wentland wrote: We need to be a bit careful when merging patches from the same series via multiple trees. Maybe we'll merge the colorop stuff via the amd tree? I don't remember the rules around trees

Re: [V7 16/45] drm/colorop: Add 3x4 CTM type

2025-02-25 Thread Louis Chauvet
Le 20/12/2024 à 05:33, Alex Hung a écrit : From: Harry Wentland This type is used to support a 3x4 matrix in colorops. A 3x4 matrix uses the last column as a "bias" column. Some HW exposes support for 3x4. The calculation looks like: out matrixin |R| |0 1 2 3 | | R | |G|

Re: [V7 18/45] drm/vkms: add 3x4 matrix in color pipeline

2025-02-25 Thread Louis Chauvet
Le 20/12/2024 à 05:33, Alex Hung a écrit : From: Harry Wentland We add two 3x4 matrices into the VKMS color pipeline. The reason we're adding matrices is so that we can test that application of a matrix and its inverse yields an output equal to the input image. One complication with the mat

Re: [V7 02/45] drm/vkms: Round fixp2int conversion in lerp_u16

2025-02-25 Thread Simon Ser
On Tuesday, February 25th, 2025 at 10:37, Louis Chauvet wrote: > Can I extract this patch from the series and apply it on drm-misc-next? That sounds completely fine by me, and TBH it sounds like it could even be drm-misc-fixes material? We need to be a bit careful when merging patches from the