Re: [V7 31/45] drm/colorop: add BT2020/BT709 OETF and Inverse OETF

2025-01-15 Thread Simon Ser
> The BT.709 and BT.2020 OETFs are the same, the only difference > being that the BT.2020 variant is defined with more precision > for 10 and 12-bit per color encodings. Just to make sure, the spec defines this precision, correct? It's not an AMD-specific thing? > Both are used as encoding functi

Re: [V7 29/45] drm/colorop: Add PQ 125 EOTF and its inverse

2025-01-15 Thread Simon Ser
Is this 125 magic number something we can expect other hardware to implement as well? Could AMD use the HDR multiplier or another block to behave as if the multiplier didn't exist? Note, I am no HDR expert. Maybe others have a better idea whether this makes sense or not.

Re: [V7 33/45] drm/colorop: Add 1D Curve Custom LUT type

2025-01-15 Thread Simon Ser
> diff --git a/drivers/gpu/drm/drm_atomic_uapi.c > b/drivers/gpu/drm/drm_atomic_uapi.c > index a3e1fcad47ad..4744c12e429d 100644 > --- a/drivers/gpu/drm/drm_atomic_uapi.c > +++ b/drivers/gpu/drm/drm_atomic_uapi.c > @@ -701,6 +701,9 @@ static int drm_atomic_color_set_data_property(struct > drm_col

Re: [V7 33/45] drm/colorop: Add 1D Curve Custom LUT type

2025-01-15 Thread Simon Ser
> + prop = drm_property_create_range(dev, DRM_MODE_PROP_IMMUTABLE, "SIZE", Ah, I forgot something: I think this needs to be DRM_MODE_PROP_ATOMIC?

Re: [V7 36/45] drm/colorop: Add mutliplier type

2025-01-15 Thread Simon Ser
Reviewed-by: Simon Ser