Re: [RFC PATCH v3 01/23] drm: Don't treat 0 as -1 in drm_fixp2int_ceil

2023-12-08 Thread Melissa Wen
On 12/06, Melissa Wen wrote: > On 11/08, Harry Wentland wrote: > > Unit testing this in VKMS shows that passing 0 into > > this function returns -1, which is highly counter- > > intuitive. Fix it by checking whether the input is > > >= 0 instead of > 0. > > > Nice finding. Thanks! > > Could you a

Re: [RFC PATCH v3 06/23] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2023-12-08 Thread Pekka Paalanen
On Wed, 8 Nov 2023 11:36:25 -0500 Harry Wentland wrote: > v3: > - Describe DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE (Sebastian) > - Ask for clear documentation of colorop behavior (Sebastian) > > v2: > - Update colorop visualizations to match reality (Sebastian, Alex Hung) > - Updated wording (Pe

Re: [RFC PATCH v3 07/23] drm/colorop: Introduce new drm_colorop mode object

2023-12-08 Thread Pekka Paalanen
On Wed, 8 Nov 2023 11:36:26 -0500 Harry Wentland wrote: > This patches introduces a new drm_colorop mode object. This > object represents color transformations and can be used to > define color pipelines. > > We also introduce the drm_colorop_state here, as well as > various helpers and state tr

Re: [RFC PATCH v3 08/23] drm/colorop: Add TYPE property

2023-12-08 Thread Pekka Paalanen
On Wed, 8 Nov 2023 11:36:27 -0500 Harry Wentland wrote: > Add a read-only TYPE property. The TYPE specifies the colorop > type, such as enumerated curve, 1D LUT, CTM, 3D LUT, PWL LUT, > etc. > > v3: > - Make TYPE a range property > - Move enum drm_colorop_type to uapi header > - Fix drm_get_c

Re: [RFC PATCH v3 06/23] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2023-12-08 Thread Pekka Paalanen
On Wed, 8 Nov 2023 11:36:25 -0500 Harry Wentland wrote: > v3: > - Describe DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE (Sebastian) > - Ask for clear documentation of colorop behavior (Sebastian) > > v2: > - Update colorop visualizations to match reality (Sebastian, Alex Hung) > - Updated wording (Pe

Re: [RFC PATCH v3 09/23] drm/color: Add 1D Curve subtype

2023-12-08 Thread Pekka Paalanen
On Wed, 8 Nov 2023 11:36:28 -0500 Harry Wentland wrote: > Signed-off-by: Harry Wentland > --- > drivers/gpu/drm/drm_atomic_uapi.c | 18 ++ > drivers/gpu/drm/drm_colorop.c | 39 +++ > include/drm/drm_colorop.h | 20 > 3 files c

Re: [RFC PATCH v3 13/23] drm/plane: Add COLOR PIPELINE property

2023-12-08 Thread Pekka Paalanen
On Wed, 8 Nov 2023 11:36:32 -0500 Harry Wentland wrote: > We're adding a new enum COLOR PIPELINE property. This > property will have entries for each COLOR PIPELINE by > referencing the DRM object ID of the first drm_colorop > of the pipeline. 0 disables the entire COLOR PIPELINE. I didn't find

Re: what are the protocol rules about uniqueness of event and request names?

2023-12-08 Thread Sebastian Wick
On Fri, Dec 8, 2023 at 12:44 AM jleivent wrote: > > On Thu, 7 Dec 2023 22:06:07 + > David Edmundson wrote: > > > The generated C code be full of conflicts. The > > MY_PROTOCOL_REQUESTEVENT_SINCE_VERSION define for a start. > > > > I think it might compile in C, but other generators exist that

Re: [RFC PATCH v3 15/23] drm/vkms: Add enumerated 1D curve colorop

2023-12-08 Thread Pekka Paalanen
On Wed, 8 Nov 2023 11:36:34 -0500 Harry Wentland wrote: > This patch introduces a VKMS color pipeline that includes two > drm_colorops for named transfer functions. For now the only ones > supported are sRGB EOTF, sRGB Inverse EOTF, and a Linear TF. > We will expand this in the future but I don't

Re: [RFC PATCH v3 17/23] drm/colorop: Introduce DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE

2023-12-08 Thread Pekka Paalanen
On Wed, 8 Nov 2023 11:36:36 -0500 Harry Wentland wrote: > With the introduction of the pre-blending color pipeline we > can no longer have color operations that don't have a clear > position in the color pipeline. We deprecate all existing > plane properties. For upstream drivers those are: > -

Re: [RFC PATCH v3 18/23] drm/colorop: Add 3x4 CTM type

2023-12-08 Thread Pekka Paalanen
On Wed, 8 Nov 2023 11:36:37 -0500 Harry Wentland wrote: > This type is used to support a 3x4 matrix in colorops. A 3x4 > matrix uses the last column as a "bias" column. Some HW exposes > support for 3x4. The calculation looks like: > > out matrixin > |R| |0 1 2 3 | | R | > |G| =

Re: [RFC PATCH v3 20/23] drm/vkms: Use s32 for internal color pipeline precision

2023-12-08 Thread Pekka Paalanen
On Wed, 8 Nov 2023 11:36:39 -0500 Harry Wentland wrote: > Certain operations require us to preserve values below 0.0 and > above 1.0 (0x0 and 0x respectively in 16 bpc unorm). One > such operation is a BT709 encoding operation followed by its > decoding operation, or the reverse. > > We'll u

Re: [RFC PATCH v3 21/23] drm/vkms: add 3x4 matrix in color pipeline

2023-12-08 Thread Pekka Paalanen
On Wed, 8 Nov 2023 11:36:40 -0500 Harry Wentland wrote: > We add two 3x4 matrices into the VKMS color pipeline. The reason > we're adding matrices is so that we can test that application > of a matrix and its inverse yields an output equal to the input > image. Would it not be better to mimic wh

Re: [RFC PATCH v3 23/23] drm/vkms: Add tests for CTM handling

2023-12-08 Thread Pekka Paalanen
On Wed, 8 Nov 2023 11:36:42 -0500 Harry Wentland wrote: > A whole slew of tests for CTM handling that greatly helped in > debugging the CTM code. The extent of tests might seem a bit > silly but they're fast and might someday help save someone > else's day when debugging this. To be honest, this

Re: what are the protocol rules about uniqueness of event and request names?

2023-12-08 Thread jleivent
On Fri, 8 Dec 2023 12:54:35 +0100 Sebastian Wick wrote: > ... > I think a more useful thing to do would be to add this restriction (an > interface cannot have an event and a request with the same name) to > the documentation and to wayland-scanner. > Also: an event and request with the same name