Re: [PATCH RFC v5 02/10] drm: Introduce solid fill DRM plane property

2023-08-28 Thread Jessica Zhang
On 8/8/2023 3:57 PM, Jessica Zhang wrote: On 8/7/2023 6:07 PM, Dmitry Baryshkov wrote: On 8 August 2023 00:41:07 GMT+03:00, Jessica Zhang wrote: On 8/4/2023 6:27 AM, Dmitry Baryshkov wrote: On Fri, 28 Jul 2023 at 20:03, Jessica Zhang wrote: Document and add support for solid_fill

[PATCH RFC v6 07/10] drm/atomic: Loosen FB atomic checks

2023-08-28 Thread Jessica Zhang
Loosen the requirements for atomic and legacy commit so that, in cases where pixel_source != FB, the commit can still go through. This includes adding framebuffer NULL checks in other areas to account for FB being NULL when non-FB pixel sources are enabled. To disable a plane, the pixel_source mu

[PATCH RFC v6 02/10] drm: Introduce solid fill DRM plane property

2023-08-28 Thread Jessica Zhang
Document and add support for solid_fill property to drm_plane. In addition, add support for setting and getting the values for solid_fill. To enable solid fill planes, userspace must assign a property blob to the "solid_fill" plane property containing the following information: struct drm_mode_so

[PATCH RFC v6 03/10] drm: Add solid fill pixel source

2023-08-28 Thread Jessica Zhang
Add "SOLID_FILL" as a valid pixel source. If the pixel_source property is set to "SOLID_FILL", it will display data from the drm_plane "solid_fill" blob property. Reviewed-by: Dmitry Baryshkov Signed-off-by: Jessica Zhang --- drivers/gpu/drm/drm_blend.c | 10 +- include/drm/drm_plane.h

[PATCH RFC v6 04/10] drm/atomic: Add pixel source to plane state dump

2023-08-28 Thread Jessica Zhang
Add pixel source to the atomic plane state dump Signed-off-by: Jessica Zhang --- drivers/gpu/drm/drm_atomic.c| 1 + drivers/gpu/drm/drm_blend.c | 1 + drivers/gpu/drm/drm_crtc_internal.h | 1 + 3 files changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/

[PATCH RFC v6 06/10] drm/atomic: Move framebuffer checks to helper

2023-08-28 Thread Jessica Zhang
Currently framebuffer checks happen directly in drm_atomic_plane_check(). Move these checks into their own helper method. Reviewed-by: Dmitry Baryshkov Signed-off-by: Jessica Zhang --- drivers/gpu/drm/drm_atomic.c | 130 --- 1 file changed, 73 insertions(

[PATCH RFC v6 01/10] drm: Introduce pixel_source DRM plane property

2023-08-28 Thread Jessica Zhang
Add support for pixel_source property to drm_plane and related documentation. In addition, force pixel_source to DRM_PLANE_PIXEL_SOURCE_FB in DRM_IOCTL_MODE_SETPLANE as to not break legacy userspace. This enum property will allow user to specify a pixel source for the plane. Possible pixel sources

[PATCH RFC v6 10/10] drm/msm/dpu: Add solid fill and pixel source properties

2023-08-28 Thread Jessica Zhang
Add solid_fill and pixel_source properties to DPU plane Reviewed-by: Dmitry Baryshkov Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_p

[PATCH RFC v6 05/10] drm/atomic: Add solid fill data to plane state dump

2023-08-28 Thread Jessica Zhang
Add solid_fill property data to the atomic plane state dump. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/drm_atomic.c | 4 drivers/gpu/drm/drm_plane.c | 8 include/drm/drm_plane.h | 3 +++ 3 files changed, 15 insertions(+) diff --git a/drivers/gpu/drm/drm_atomic.c b/dri

[PATCH RFC v6 00/10] Support for Solid Fill Planes

2023-08-28 Thread Jessica Zhang
Some drivers support hardware that have optimizations for solid fill planes. This series aims to expose these capabilities to userspace as some compositors have a solid fill flag (ex. SOLID_COLOR in the Android hardware composer HAL) that can be set by apps like the Android Gears app. In order to

[PATCH RFC v6 08/10] drm/msm/dpu: Allow NULL FBs in atomic commit

2023-08-28 Thread Jessica Zhang
Since solid fill planes allow for a NULL framebuffer in a valid commit, add NULL framebuffer checks to atomic commit calls within DPU. Reviewed-by: Dmitry Baryshkov Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 9 ++- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c

[PATCH RFC v6 09/10] drm/msm/dpu: Use DRM solid_fill property

2023-08-28 Thread Jessica Zhang
Drop DPU_PLANE_COLOR_FILL_FLAG and check the DRM solid_fill property to determine if the plane is solid fill. In addition drop the DPU plane color_fill field as we can now use drm_plane_state.solid_fill instead, and pass in drm_plane_state.alpha to _dpu_plane_color_fill_pipe() to allow userspace to

Re: [PATCH RFC v5 02/10] drm: Introduce solid fill DRM plane property

2023-08-28 Thread Dmitry Baryshkov
On Tue, 29 Aug 2023 at 02:45, Jessica Zhang wrote: > > > > On 8/8/2023 3:57 PM, Jessica Zhang wrote: > > > > > > On 8/7/2023 6:07 PM, Dmitry Baryshkov wrote: > >> > >> > >> On 8 August 2023 00:41:07 GMT+03:00, Jessica Zhang > >> wrote: > >>> > >>> > >>> On 8/4/2023 6:27 AM, Dmitry Baryshkov wrote