Re: [RFC PATCH 0/3] Support for Solid Fill Planes

2023-06-29 Thread Pekka Paalanen
On Wed, 28 Jun 2023 09:40:21 -0700 Jessica Zhang wrote: > On 6/28/2023 12:34 AM, Pekka Paalanen wrote: > > On Tue, 27 Jun 2023 15:10:19 -0700 > > Abhinav Kumar wrote: > > > >> On 6/27/2023 2:59 PM, Dmitry Baryshkov wrote: > >>> On 28/06/2023 00:27, Jessica Zhang wrote: > > > >>>

Re: [RFC PATCH 0/3] Support for Solid Fill Planes

2023-06-29 Thread Jessica Zhang
On 6/27/2023 3:10 PM, Abhinav Kumar wrote: On 6/27/2023 2:59 PM, Dmitry Baryshkov wrote: On 28/06/2023 00:27, Jessica Zhang wrote: On 6/27/2023 12:58 AM, Pekka Paalanen wrote: On Mon, 26 Jun 2023 16:02:50 -0700 Jessica Zhang wrote: On 11/7/2022 11:37 AM, Ville Syrjälä wrote: On Fri,

Re: [Freedreno] [RFC PATCH 0/3] Support for Solid Fill Planes

2023-06-29 Thread Jessica Zhang
On 6/29/2023 12:29 AM, Pekka Paalanen wrote: On Wed, 28 Jun 2023 09:40:21 -0700 Jessica Zhang wrote: On 6/28/2023 12:34 AM, Pekka Paalanen wrote: On Tue, 27 Jun 2023 15:10:19 -0700 Abhinav Kumar wrote: On 6/27/2023 2:59 PM, Dmitry Baryshkov wrote: On 28/06/2023 00:27, Jessica Zhang

[PATCH RFC v4 3/7] drm/atomic: Move framebuffer checks to helper

2023-06-29 Thread Jessica Zhang
Currently framebuffer checks happen directly in drm_atomic_plane_check(). Move these checks into their own helper method. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/drm_atomic.c | 130 --- 1 file changed, 74 insertions(+), 56 deletions(-) diff --git

[PATCH RFC v4 2/7] drm: Introduce pixel_source DRM plane property

2023-06-29 Thread Jessica Zhang
Add support for pixel_source property to drm_plane and related documentation. This enum property will allow user to specify a pixel source for the plane. Possible pixel sources will be defined in the drm_plane_pixel_source enum. The current possible pixel sources are DRM_PLANE_PIXEL_SOURCE_FB and

[PATCH RFC v4 1/7] drm: Introduce solid fill DRM plane property

2023-06-29 Thread Jessica Zhang
Document and add support for solid_fill property to drm_plane. In addition, add support for setting and getting the values for solid_fill. To enable solid fill planes, userspace must assign a property blob to the "solid_fill" plane property containing the following information: struct drm_solid_f

[PATCH RFC v4 0/7] Support for Solid Fill Planes

2023-06-29 Thread Jessica Zhang
Some drivers support hardware that have optimizations for solid fill planes. This series aims to expose these capabilities to userspace as some compositors have a solid fill flag (ex. SOLID_COLOR in the Android hardware composer HAL) that can be set by apps like the Android Gears app. In order to

[PATCH RFC v4 7/7] drm/msm/dpu: Use DRM solid_fill property

2023-06-29 Thread Jessica Zhang
Drop DPU_PLANE_COLOR_FILL_FLAG and check the DRM solid_fill property to determine if the plane is solid fill. In addition drop the DPU plane color_fill field as we can now use drm_plane_state.solid_fill instead, and pass in drm_plane_state.alpha to _dpu_plane_color_fill_pipe() to allow userspace to

[PATCH RFC v4 5/7] drm/msm/dpu: Add solid fill and pixel source properties

2023-06-29 Thread Jessica Zhang
Add solid_fill and pixel_source properties to DPU plane Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c index c2aaaded07ed..5f09

[PATCH RFC v4 6/7] drm/msm/dpu: Allow NULL FBs in atomic commit

2023-06-29 Thread Jessica Zhang
Since solid fill planes allow for a NULL framebuffer in a valid commit, add NULL framebuffer checks to atomic commit calls within DPU. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 9 ++- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 45 +++--

[PATCH RFC v4 4/7] drm/atomic: Loosen FB atomic checks

2023-06-29 Thread Jessica Zhang
Loosen the requirements for atomic and legacy commit so that, in cases where solid fill planes is enabled but no FB is set, the commit can still go through. This includes adding framebuffer NULL checks in other areas to account for FB being NULL when solid fill is enabled. Signed-off-by: Jessica

Re: [PATCH RFC v4 2/7] drm: Introduce pixel_source DRM plane property

2023-06-29 Thread Dmitry Baryshkov
On 30/06/2023 03:25, Jessica Zhang wrote: Add support for pixel_source property to drm_plane and related documentation. This enum property will allow user to specify a pixel source for the plane. Possible pixel sources will be defined in the drm_plane_pixel_source enum. The current possible pix

Re: [PATCH RFC v4 3/7] drm/atomic: Move framebuffer checks to helper

2023-06-29 Thread Dmitry Baryshkov
On 30/06/2023 03:25, Jessica Zhang wrote: Currently framebuffer checks happen directly in drm_atomic_plane_check(). Move these checks into their own helper method. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/drm_atomic.c | 130 --- 1 file changed,

Re: [PATCH RFC v4 4/7] drm/atomic: Loosen FB atomic checks

2023-06-29 Thread Dmitry Baryshkov
On 30/06/2023 03:25, Jessica Zhang wrote: Loosen the requirements for atomic and legacy commit so that, in cases where solid fill planes is enabled but no FB is set, the commit can still go through. This includes adding framebuffer NULL checks in other areas to account for FB being NULL when sol

Re: [PATCH RFC v4 5/7] drm/msm/dpu: Add solid fill and pixel source properties

2023-06-29 Thread Dmitry Baryshkov
On 30/06/2023 03:25, Jessica Zhang wrote: Add solid_fill and pixel_source properties to DPU plane Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 2 ++ 1 file changed, 2 insertions(+) This should be the last commit. Otherwise: Reviewed-by: Dmitry Baryshkov

Re: [PATCH RFC v4 6/7] drm/msm/dpu: Allow NULL FBs in atomic commit

2023-06-29 Thread Dmitry Baryshkov
On 30/06/2023 03:25, Jessica Zhang wrote: Since solid fill planes allow for a NULL framebuffer in a valid commit, add NULL framebuffer checks to atomic commit calls within DPU. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 9 ++- drivers/gpu/drm/msm/disp/d

Re: [PATCH RFC v4 7/7] drm/msm/dpu: Use DRM solid_fill property

2023-06-29 Thread Dmitry Baryshkov
On 30/06/2023 03:25, Jessica Zhang wrote: Drop DPU_PLANE_COLOR_FILL_FLAG and check the DRM solid_fill property to determine if the plane is solid fill. In addition drop the DPU plane color_fill field as we can now use drm_plane_state.solid_fill instead, and pass in drm_plane_state.alpha to _dpu_p