Re: wl_surface.attach with NULL wl_buffer behaviour

2015-09-02 Thread Pekka Paalanen
On Wed, 2 Sep 2015 13:38:50 -0500 Prabhu S wrote: > With the below change in simple-shm.c, weston+fbdev backend will be stuck > and other compositors may work. It depends on compositor implementation and > the actual behavior supposed to be is not clearly defined. I'm still trying > to identify f

Re: wl_surface.attach with NULL wl_buffer behaviour

2015-09-02 Thread Jasper St. Pierre
Destroying the xdg_surface is absolutely OK. I'm not sure why the Qt people consider it wrong. On Wed, Sep 2, 2015 at 11:38 AM, Prabhu S wrote: > With the below change in simple-shm.c, weston+fbdev backend will be stuck > and other compositors may work. It depends on compositor implementation and

Re: wl_surface.attach with NULL wl_buffer behaviour

2015-09-02 Thread Prabhu S
With the below change in simple-shm.c, weston+fbdev backend will be stuck and other compositors may work. It depends on compositor implementation and the actual behavior supposed to be is not clearly defined. I'm still trying to identify fix in weston, it looks like state information is overwritten

Re: wl_surface.attach with NULL wl_buffer behaviour

2015-08-24 Thread Pekka Paalanen
On Fri, 21 Aug 2015 19:04:11 -0500 Prabhu S wrote: > Below is the case where I'm getting stuck with the actual test case. > Wondering why there is no callback wl_callb...@25.done or > wl_buffer@29.release > The EGL implementation depends on these callback/buffer release. You will not get wl_call

Re: wl_surface.attach with NULL wl_buffer behaviour

2015-08-24 Thread Pekka Paalanen
On Fri, 21 Aug 2015 10:16:09 -0700 "Jasper St. Pierre" wrote: > We need to fix that documentation, then, along with fixing Weston. > mutter will give you an error with this event stream, since attaching > a NULL buffer for an xdg_surface is invalid. This applies only to xdg_surface, and perhaps

Re: wl_surface.attach with NULL wl_buffer behaviour

2015-08-21 Thread Prabhu S
Below is the case where I'm getting stuck with the actual test case. Wondering why there is no callback wl_callb...@25.done or wl_buffer@29.release The EGL implementation depends on these callback/buffer release. Also noticed if the valid buffer is attached immediately after null buffer, everything

Re: wl_surface.attach with NULL wl_buffer behaviour

2015-08-21 Thread Jasper St. Pierre
We need to fix that documentation, then, along with fixing Weston. mutter will give you an error with this event stream, since attaching a NULL buffer for an xdg_surface is invalid. This behavior is one of the reasons why I removed this ability from xdg_surface and instead made it an error -- the

wl_surface.attach with NULL wl_buffer behaviour

2015-08-21 Thread Prabhu S
Hi, Based on the wayland protocol specification for wl_surface::attach >>If wl_surface.attach is sent with a NULL wl_buffer, the following wl_surface.commit will remove the surface content. Wondering if wl_surface_attach called with wl_buffer=NULL, will there be any wl_buffer release event or fram