Re: weston crash in destroy_shell_surface

2014-01-22 Thread Jason Ekstrand
Yeah, this is probably better. --Jason Ekstrand Reviewed-By: Jason Ekstrand On Jan 21, 2014 9:02 AM, "Neil Roberts" wrote: > It looks like the rest of the code assumes that shsurf->children_link > is always a consistent list. For example, shell_surface_set_parent > resets children_link to the e

Re: weston crash in destroy_shell_surface

2014-01-21 Thread Neil Roberts
It looks like the rest of the code assumes that shsurf->children_link is always a consistent list. For example, shell_surface_set_parent resets children_link to the empty list after it unlinks a child from its parent. The destroy_shell_surface code just calls wl_list_remove which leaves the list no

weston crash in destroy_shell_surface

2014-01-21 Thread Dima Ryazanov
I haven't figured out how to fix the crash, but wanted to bring it up before the 1.4 release. It's pretty easy to reproduce it: 1. Open weston-terminal (or maybe another client) 2. Right-click the titlebar 3. Click "close" As far as I can tell, the problem is these lines in destroy_shell_surface