idate
signal is encountered.
However, I'm having a bit of an issue where destroying the TopLevel
gtk4-layer-shell window throws a segfault in `wl_event_queue_release`.
Oddly enough, the segfault occurs due to what seems like a corrupt
pointer to the name field in proxy->object.interface-&g
This sounds like a bug in GDK… Maybe report it to them?
Hello All,
I have a pythno3 app that uses PyGobject to create a button.
I can reproduce a segfault by using a stylus to press and drag across that
button.
When I use my finger, no segfault.
When programmed to do nothing, I can see that the button flickers; indicating
intermittent contact
On Thu, Aug 31, 2017 at 10:23:00AM +0200, Olivier Fourdan wrote:
> Xwayland would crash in some circumstances while trying to issue a
> pointer locking when the cursor is hidden when there is no seat focus
> window set.
>
> The crash signature looks like:
>
> #0 zwp_pointer_constraints_v1_lock_
Xwayland would crash in some circumstances while trying to issue a
pointer locking when the cursor is hidden when there is no seat focus
window set.
The crash signature looks like:
#0 zwp_pointer_constraints_v1_lock_pointer ()
#1 xwl_pointer_warp_emulator_lock () at xwayland-input.c:2584
#2
Hi Munakata-san,
On 24 November 2016 at 10:05, Ryo Munakata wrote:
> Signed-off-by: Ryo Munakata
> ---
> libweston/compositor-x11.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libweston/compositor-x11.c b/libweston/compositor-x11.c
> index de64e49..34ef854 100644
Signed-off-by: Ryo Munakata
---
libweston/compositor-x11.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libweston/compositor-x11.c b/libweston/compositor-x11.c
index de64e49..34ef854 100644
--- a/libweston/compositor-x11.c
+++ b/libweston/compositor-x11.c
@@ -917,8 +917,9
On Fri, 26 Feb 2016 11:57:51 +0200
Pekka Paalanen wrote:
> On Mon, 22 Feb 2016 13:22:05 -0800
> Bryce Harrington wrote:
>
> > On Mon, Feb 22, 2016 at 02:34:57PM +0100, Marek Chalupa wrote:
> > > Hi,
> > >
> > > can confirm the segfault, tested it (w
On Mon, 22 Feb 2016 13:22:05 -0800
Bryce Harrington wrote:
> On Mon, Feb 22, 2016 at 02:34:57PM +0100, Marek Chalupa wrote:
> > Hi,
> >
> > can confirm the segfault, tested it (will send the test I used for
> > it as a follow-up). The only API change problem could b
On Mon, Feb 22, 2016 at 02:34:57PM +0100, Marek Chalupa wrote:
> Hi,
>
> can confirm the segfault, tested it (will send the test I used for
> it as a follow-up). The only API change problem could be in
> returning
> NULL as the interface - if the user does not check for it, he/
Hi,
can confirm the segfault, tested it (will send the test I used for it as
a follow-up). The only API change problem could be in returning
NULL as the interface - if the user does not check for it, he/she
dereferences NULL. But I don't think anybody (except us in tests) is
error() documentation is updated to handle
the situation. For when the proxy was NULL, the object id 0 and
interface NULL is written.
Signed-off-by: Jonas Ådahl
---
This is technically an API change, but I see no less breaking change.
Considering that clients would segfault before ever reaching here without
Null-check on "*value" is currently done in
_eglGetSyncAttrib, which is after eglGetSyncAttribKHR
attempts to copy data at 'value' to 'attrib'. Segfault
is enevitable if value==NULL in this case. Therefore,
null-check should be moved to beginning of
eglGetSyncA
gned-off-by: Pekka Paalanen
> >
> > ---
> > Hi John,
> >
> > a good find! I adjusted this patch a bit. If you can give a Tested-by
> > for the v2, I can push this.
>
> Sure. I re-built with your v2 and ran on RPi2. It runs fine, no segfault.
>
> Tes
e latter is set by weston_output_init()
> which gets called later than rpi_flippipe_init().
>
> Signed-off-by: Pekka Paalanen
>
> ---
> Hi John,
>
> a good find! I adjusted this patch a bit. If you can give a Tested-by
> for the v2, I can push this.
Sure. I re-bui
On Sat, 5 Sep 2015 15:01:39 +0100
John Sadler wrote:
> This commit works-around a serious issue when running with the RPi backend.
> When an EGL client shuts down and destroys it's EGL window, Weston dies with
> a segmentation fault in the above function (because `buffer` is now NULL).
>
> The
From: John Sadler
When running with the RPi backend, Weston now segfaults at startup on the
line:
flippipe->clk_id = output->base.compositor->presentation_clock;
in `rpi_flippipe_init()`.
This is because `output->base.compositor` is NULL. This problem did not
exist on 1.8.0, and it looks l
This commit works-around a serious issue when running with the RPi backend.
When an EGL client shuts down and destroys it's EGL window, Weston dies with
a segmentation fault in the above function (because `buffer` is now NULL).
The addition of a simple NULL check avoids the problem.
This is a min
When running with the RPi backend, Weston now segfaults at startup on the
line:
flippipe->clk_id = output->base.compositor->presentation_clock;
in `rpi_flippipe_init()`.
This is because `output->base.compositor` is NULL. This problem did not
exist on 1.8.0, and it looks like it may have been
ken
linked list resulting in a segfault.
On 22/08/14 05:47 PM, Eoff, Ullysses A wrote:
> Does this fix https://bugs.freedesktop.org/show_bug.cgi?id=82957 ?
>
>
> U. Artie
>
>> -Original Message-
>> From: wayland-devel [mailto:wayland-devel-boun...@lists.freed
: wayland-devel@lists.freedesktop.org
> Cc: Derek Foreman
> Subject: [PATCH] desktop-shell: No longer segfault on cleanup
>
> When desktop-shell's sigchld handler attempts to re-launch
> weston-desktop-shell it also registers a destroy notifier.
>
> This destroy notifier may still be on anot
lback.
So, when the cleanup callback is run before the destroy notifications are
emitted, the list will become corrupted, causing a segfault when the
notifications are emit.
Since the destroy notifier just sets a pointer to NULL - which will happen
in the cleanup handler anyway - I've simply r
On Thu, 26 Jun 2014 10:19:32 +0800
Boyan Ding wrote:
> Commit 9aa8ce69 forgot to set shsurf->fullscreen_output in
> fullscreen_binding(), causing segfault when fullscreening using key
> bindings. This patch fixes that.
>
> https://bugs.freedesktop.org/show_bug.cgi?id=798
Commit 9aa8ce69 forgot to set shsurf->fullscreen_output in
fullscreen_binding(), causing segfault when fullscreening using key
bindings. This patch fixes that.
https://bugs.freedesktop.org/show_bug.cgi?id=79828
Signed-off-by: Boyan Ding
---
desktop-shell/shell.c | 1 +
1 file changed
Commit 9aa8ce69 'shell: Don't use the helper methods in
> > xdg_shell
> > implementations' forgot to set shsurf->fullscreen_optput in
> > fullscreen_binding(), causing weston to segfault when
> > fullscreen
> > wi
e69 'shell: Don't use the helper methods in
> xdg_shell
> implementations' forgot to set shsurf->fullscreen_optput in
> fullscreen_binding(), causing weston to segfault when
> fullscreen
> with the mo
Yes we should fix this. I have one question below.
On Sat, Jun 7, 2014 at 2:40 AM, Boyan Ding wrote:
> Commit 9aa8ce69 'shell: Don't use the helper methods in xdg_shell
> implementations' forgot to set shsurf->fullscreen_optput in
> fullscreen_binding(), caus
Commit 9aa8ce69 'shell: Don't use the helper methods in xdg_shell
implementations' forgot to set shsurf->fullscreen_optput in
fullscreen_binding(), causing weston to segfault when fullscreen
with the mod + shift + f binding. This patch fixed that issue.
---
desktop-shell/she
On Fri, Apr 04, 2014 at 05:41:24PM -0500, Bryan Cain wrote:
> The shell_destroy_shell_surface function only set the backing resource to
> NULL, leaving an unusable surface in the popup_grab list until the surface's
> fading animation finished and it could be freed. This caused a seg
The shell_destroy_shell_surface function only set the backing resource to
NULL, leaving an unusable surface in the popup_grab list until the surface's
fading animation finished and it could be freed. This caused a segfault if
the shell tried to forcibly break the grab during that time interva
Without this, weston will segfault whenever the focus is a non-client
surface such as the black surface in fullscreen.
---
src/input.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/input.c b/src/input.c
index 6637882..b6130d6 100644
--- a/src/input.c
+++ b/src
On Sun, Oct 27, 2013 at 09:32:54PM -0500, Jason Ekstrand wrote:
> Without this commit, the client will segmentation fault due to accessing
> the frame after everything has been destroyed.
>
> ---
> clients/window.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Yup, I hit this a couple
Without this commit, the client will segmentation fault due to accessing
the frame after everything has been destroyed.
---
clients/window.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/clients/window.c b/clients/window.c
index 331569a..be61a53 100644
--- a/clients/window.c
On Fri, Jun 28, 2013 at 06:59:44PM +0900, Daiki Ueno wrote:
>
> ---
> clients/editor.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks, committed.
Kristian
> diff --git a/clients/editor.c b/clients/editor.c
> index d4e4e92..3fb645b 100644
> --- a/clients/editor.c
> +++ b/cli
---
clients/editor.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/clients/editor.c b/clients/editor.c
index d4e4e92..3fb645b 100644
--- a/clients/editor.c
+++ b/clients/editor.c
@@ -380,11 +380,11 @@ text_input_keysym(void *data,
text_entry_commit_and_re
On Sat, Sep 01, 2012 at 04:03:05PM +0200, Philipp Brüschweiler wrote:
> Also fixes the off-by-one in toytoolkit that exposed the issue.
Thanks, applied.
> ---
> clients/window.c | 2 +-
> src/shell.c | 4
> 2 Dateien geändert, 5 Zeilen hinzugefügt(+), 1 Zeile entfernt(-)
>
> diff --gi
Also fixes the off-by-one in toytoolkit that exposed the issue.
---
clients/window.c | 2 +-
src/shell.c | 4
2 Dateien geändert, 5 Zeilen hinzugefügt(+), 1 Zeile entfernt(-)
diff --git a/clients/window.c b/clients/window.c
index 472aabf..4ddbd2f 100644
--- a/clients/window.c
+++ b/clie
On Wed, Aug 29, 2012 at 10:53:36AM +0200, Philipp Brüschweiler wrote:
> Instead draw a fallback icon and proceed as normal.
>
> https://bugs.freedesktop.org/show_bug.cgi?id=53860
>
> v2: coding style fixes
> v3: memory leak, draw icon instead of relying on external files
Nice, committed.
Kristi
On Wed, 29 Aug 2012 10:53:36 +0200
Philipp Brüschweiler wrote:
> Instead draw a fallback icon and proceed as normal.
>
> https://bugs.freedesktop.org/show_bug.cgi?id=53860
>
> v2: coding style fixes
> v3: memory leak, draw icon instead of relying on external files
> ---
> clients/desktop-shell
Instead draw a fallback icon and proceed as normal.
https://bugs.freedesktop.org/show_bug.cgi?id=53860
v2: coding style fixes
v3: memory leak, draw icon instead of relying on external files
---
clients/desktop-shell.c | 36 +++-
1 Datei geändert, 35 Zeilen hinzuge
con,
> const char *path)
>
> launcher = malloc(sizeof *launcher);
> memset(launcher, 0, sizeof *launcher);
> - launcher->icon = cairo_image_surface_create_from_png(icon);
> + launcher->icon = load_icon_or_fallback(icon);
> launcher->path = st
Instead load a fallback icon and proceed as normal.
https://bugs.freedesktop.org/show_bug.cgi?id=53860
v2: coding style fixes
---
clients/desktop-shell.c | 20 +++-
1 Datei geändert, 19 Zeilen hinzugefügt(+), 1 Zeile entfernt(-)
diff --git a/clients/desktop-shell.c b/clients/des
Hi Philipp,
I happened across your patch and wanted to comment about the styling. (see
below)
On Tue, Aug 28, 2012 at 11:10 AM, Philipp Brüschweiler wrote:
> Instead load a fallback icon and proceed as normal.
>
> https://bugs.freedesktop.org/show_bug.cgi?id=53860
> ---
> clients/desktop-shell.
Instead load a fallback icon and proceed as normal.
https://bugs.freedesktop.org/show_bug.cgi?id=53860
---
clients/desktop-shell.c | 19 ++-
1 Datei geändert, 18 Zeilen hinzugefügt(+), 1 Zeile entfernt(-)
diff --git a/clients/desktop-shell.c b/clients/desktop-shell.c
index dc87e7
On Mon, Aug 13, 2012 at 09:27:27PM +0200, Philipp Brüschweiler wrote:
Oops, yes, that looks better.
Kristian
> ---
> src/shell.c | 7 ++-
> 1 Datei geändert, 6 Zeilen hinzugefügt(+), 1 Zeile entfernt(-)
>
> diff --git a/src/shell.c b/src/shell.c
> index 51480ce..4d6bc4f 100644
> --- a/src/
---
src/shell.c | 7 ++-
1 Datei geändert, 6 Zeilen hinzugefügt(+), 1 Zeile entfernt(-)
diff --git a/src/shell.c b/src/shell.c
index 51480ce..4d6bc4f 100644
--- a/src/shell.c
+++ b/src/shell.c
@@ -3271,12 +3271,17 @@ static void
force_kill_binding(struct wl_seat *seat, uint32_t time, uint32_
This fixes https://bugs.freedesktop.org/show_bug.cgi?id=50487
Cheers,
Philipp
On Mon, Aug 13, 2012 at 8:04 PM, Philipp Brüschweiler wrote:
> Some cursor themes don't include a "grabbing" icon, causing a segfault.
> This patch fixes this by just reverting to the st
Some cursor themes don't include a "grabbing" icon, causing a segfault.
This patch fixes this by just reverting to the stardard cursor instead.
---
clients/dnd.c | 7 +++
1 Datei geändert, 7 Zeilen hinzugefügt(+)
diff --git a/clients/dnd.c b/clients/dnd.c
index 6f55e95..44c15
On Mon, Aug 06, 2012 at 07:45:43PM -0700, juan.j.z...@linux.intel.com wrote:
> From: Juan Zhao
>
> don't create a window when the file doesn't exist
> to fix the bug
> https://bugs.freedesktop.org/show_bug.cgi?id=52450
Thanks, committed. I changed the header to say
From: Juan Zhao
don't create a window when the file doesn't exist
to fix the bug
https://bugs.freedesktop.org/show_bug.cgi?id=52450
---
clients/image.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/clients/image.c b/clients/image.c
index 711f0d8..c289d76 100644
--- a/clients/image.c
ubject: [PATCH] evas/wayland_egl: Fix segfault when doing alpha setting in
elementary.
From: Alex Wu
The current wayland_egl engine uses a global singleton EGLContext
object to render context. All Evas_GL_Wl_Window objects, which
wraps EGLSurface, share this object, so we have no chance to
differenti
put, segfault occurs.
In this patch, I give every Evas_GL_Wl_Window object a EGLContext object
and all these EGLContext objects share the same shader program objects.
A new global EGLContext object "share_context" added, which is
responsible for keeping the shared objects alive. e.g. s
solved by using EGL_SOFTWARE=1
driver bug I think
2012/7/13 microcai :
> hard debug shows it sigfaut at
>
> EGLBoolean EGLAPIENTRY
> eglQueryWaylandBufferWL(EGLDisplay dpy,struct wl_buffer *buffer,
> EGLint attribute, EGLint *value)
> {
>_EGLDisplay *disp = _eglLockDis
hard debug shows it sigfaut at
EGLBoolean EGLAPIENTRY
eglQueryWaylandBufferWL(EGLDisplay dpy,struct wl_buffer *buffer,
EGLint attribute, EGLint *value)
{
_EGLDisplay *disp = _eglLockDisplay(dpy);
_EGLDriver *drv;
EGLBoolean ret;
_EGL_CHECK_DISPLAY(disp, EGL_FAL
the backtrace is:
(gdb) backtrace
#0 0x in ?? ()
#1 0x779b6653 in eglQueryWaylandBufferWL () from
/usr/lib64/libEGL.so.1
#2 0x00408a7a in weston_surface_attach (surface=0x8c8680,
buffer=0x8937c0) at compositor.c:778
#3 0x0040a79c in surface_attach (clien
- don't leak fd in shm_pool_destroy()
- return NULL from wl_cursor_theme_load() if pool fails
Tha last one fixes a segfault, when shm_pool_create() has failed.
Signed-off-by: Pekka Paalanen
---
cursor/wayland-cursor.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff
If we can't find a cursor for whatever reason, don't crash the client in
pointer_surface_frame_callback.
Signed-off-by: Daniel Stone
---
clients/window.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/clients/window.c b/clients/window.c
index 436f862..36caeb3 100644
I'm not sure the best way to go about reporting this but I've filed the
following bug report against mesa:
https://bugs.freedesktop.org/show_bug.cgi?id=44919
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/m
On Mon, Oct 24, 2011 at 10:34 AM, Pekka Paalanen wrote:
> Without this fix, the dnd demo would make the demo compositor crash in
> shell.c:drag_offer() because resource->data is NULL.
>
> Initialise resource->data in shell_create_drag().
Right, thanks.
Kristian
> Signed-off-by: Pekka Paalanen
Without this fix, the dnd demo would make the demo compositor crash in
shell.c:drag_offer() because resource->data is NULL.
Initialise resource->data in shell_create_drag().
Signed-off-by: Pekka Paalanen
---
compositor/shell.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --g
I think it fixes your segfault only because "output" points to list head
(i guess your external connector is the first enumerated by drm),
and ((struct wlsc_output *)list_head)->current is fortunately NULL.
I've attached a patch which adresses both points.
Formal note: Part of waylan
This fixes a problem for me on a laptop with an external video port that
doesn't have a monitor plugged into it all the time.
0001-Check-for-null-output-before-trying-to-grab-its-widt.patch
Description: Binary data
___
wayland-devel mailing list
wayland
On Mon, Jul 18, 2011 at 2:00 AM, Casey Dahlin wrote:
Ok, yup. I changed it to just abort(), since it means that the server
sent invalid data.
Kristian
> ---
> wayland/wayland-client.c | 5 +
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/wayland/wayland-client.c b/
---
wayland/wayland-client.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/wayland/wayland-client.c b/wayland/wayland-client.c
index ce27a90..d1ed25a 100644
--- a/wayland/wayland-client.c
+++ b/wayland/wayland-client.c
@@ -521,6 +521,11 @@ handle_event(struct wl_disp
64 matches
Mail list logo
