Re: minor fixes in event-loop.c

2011-03-14 Thread Kristian Høgsberg
t; So maybe just closing the fds is the cleanest solution, given that only >> library code can manage them and won't copy them. >> Regards, >> Iskren >> On Sun, Mar 13, 2011 at 9:33 PM, Iskren Chernev >> wrote: >>> >>> Reply-To-All :) >>> &g

Re: minor fixes in event-loop.c

2011-03-14 Thread Iskren Chernev
them. > > Regards, > Iskren > > On Sun, Mar 13, 2011 at 9:33 PM, Iskren Chernev < > iskren.cher...@gmail.com> wrote: > >> Reply-To-All :) >> >> >> -- Forwarded message -- >> From: Iskren Chernev < iskren.cher...@gmail.com >

Re: minor fixes in event-loop.c

2011-03-13 Thread Kristian Høgsberg
ybe just closing the fds is the cleanest solution, given that only > library code can manage them and won't copy them. > > Regards, > Iskren > > On Sun, Mar 13, 2011 at 9:33 PM, Iskren Chernev > wrote: > Reply-To-All :) > > > -- Forwarded message ----

Re: minor fixes in event-loop.c

2011-03-13 Thread Iskren Chernev
sage -- > From: Iskren Chernev > Date: 2011/3/13 > Subject: Re: minor fixes in event-loop.c > To: Kristian Høgsberg > > > I fixed the "close fd" ones, but its not perfect: > -- in what order should we do the epoll_ctl, close and free? > -- what should we do

Fwd: minor fixes in event-loop.c

2011-03-13 Thread Iskren Chernev
Reply-To-All :) -- Forwarded message -- From: Iskren Chernev Date: 2011/3/13 Subject: Re: minor fixes in event-loop.c To: Kristian Høgsberg I fixed the "close fd" ones, but its not perfect: -- in what order should we do the epoll_ctl, close and free? -- what shoul

Re: minor fixes in event-loop.c

2011-03-13 Thread Kristian Høgsberg
On Sun, Mar 13, 2011 at 11:24 AM, Iskren Chernev wrote: > Some patches for event-loop.c -- the signal & timer fds were never closed. > In the future do you prefer patches standalone or archived? Looks like more good patches. Patches 1 and 4 close the fd before passing it to epoll_ctl(), and I do

minor fixes in event-loop.c

2011-03-13 Thread Iskren Chernev
Some patches for event-loop.c -- the signal & timer fds were never closed. In the future do you prefer patches standalone or archived? Regards, Iskren From 4313eca27b083b18dc01f127ca927fc0849fe0ee Mon Sep 17 00:00:00 2001 From: Iskren Chernev Date: Sun, 13 Mar 2011 16:54:07 +0200 Subject: [PATCH